)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"4e5e97b543cfd44c3c0123ce00e076e6d1e0532d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"36f73250_a519fa79","updated":"2022-06-11 09:06:20.000000000","message":"Thanks for your patch. Few comments below ...","commit_id":"c74601fdb9cc8af003eb4f1f450375542991fb6a"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b4c636e5ab6db5266da5f48e2046bd891f096828","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"d5a1b591_61b8f7a6","updated":"2022-06-15 09:27:28.000000000","message":"Still some minor fixes, then would be ready to go!\nThanks","commit_id":"4faa697a0ff3319d815350ce5528e125454696ec"},{"author":{"_account_id":1001997,"name":"FORGETTE Benoit ","email":"benoit.forgette@ci-yow.com","username":"Mrbenoit624"},"change_message_id":"08842fe6e34213a7050f3f4c796a62d14a75f989","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"41556a4c_b7325bc9","in_reply_to":"d5a1b591_61b8f7a6","updated":"2022-08-11 09:54:53.000000000","message":"Thank you for your time","commit_id":"4faa697a0ff3319d815350ce5528e125454696ec"},{"author":{"_account_id":1001997,"name":"FORGETTE Benoit ","email":"benoit.forgette@ci-yow.com","username":"Mrbenoit624"},"change_message_id":"08842fe6e34213a7050f3f4c796a62d14a75f989","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"21c6fb54_a8a6f4d8","updated":"2022-08-11 09:54:53.000000000","message":"Is there a problem on this patch or it is ok for you.\nthank you in advance","commit_id":"0263198517a476daf1cdd13b2ea2aa775214ca9c"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"79172aedba13d14c97a4fecea382ef92becdcd12","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"f5c2f3f4_f282e5e5","updated":"2022-08-11 13:12:03.000000000","message":"Sorry, I missed your update.\nIt\u0027s ok for me, thanks for the effort.\nI will merge it in 1 week if nobody have other concerns","commit_id":"0263198517a476daf1cdd13b2ea2aa775214ca9c"}],"src/server/gdb_server.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"4e5e97b543cfd44c3c0123ce00e076e6d1e0532d","unresolved":true,"context_lines":[{"line_number":3041,"context_line":"\t\t}"},{"line_number":3042,"context_line":""},{"line_number":3043,"context_line":""},{"line_number":3044,"context_line":"\t\tif (endp) {"},{"line_number":3045,"context_line":"\t\t\tpacket_size -\u003d endp - parse;"},{"line_number":3046,"context_line":"\t\t\tparse \u003d endp;"},{"line_number":3047,"context_line":"\t\t}"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"c1d5cf49_1a4fa084","line":3044,"updated":"2022-06-11 09:06:20.000000000","message":"no, this \u0027if (endp) {...}\u0027 should be inside the above \u0027if (parse[0] \u003d\u003d \u0027:\u0027) {...}\u0027, as it\u0027s relevant to that case only.","commit_id":"c74601fdb9cc8af003eb4f1f450375542991fb6a"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b4c636e5ab6db5266da5f48e2046bd891f096828","unresolved":false,"context_lines":[{"line_number":3041,"context_line":"\t\t}"},{"line_number":3042,"context_line":""},{"line_number":3043,"context_line":""},{"line_number":3044,"context_line":"\t\tif (endp) {"},{"line_number":3045,"context_line":"\t\t\tpacket_size -\u003d endp - parse;"},{"line_number":3046,"context_line":"\t\t\tparse \u003d endp;"},{"line_number":3047,"context_line":"\t\t}"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"75767c34_ede58dbe","line":3044,"in_reply_to":"c1d5cf49_1a4fa084","updated":"2022-06-15 09:27:28.000000000","message":"Done","commit_id":"c74601fdb9cc8af003eb4f1f450375542991fb6a"},{"author":{"_account_id":1001997,"name":"FORGETTE Benoit ","email":"benoit.forgette@ci-yow.com","username":"Mrbenoit624"},"change_message_id":"08842fe6e34213a7050f3f4c796a62d14a75f989","unresolved":false,"context_lines":[{"line_number":3041,"context_line":"\t\t}"},{"line_number":3042,"context_line":""},{"line_number":3043,"context_line":""},{"line_number":3044,"context_line":"\t\tif (endp) {"},{"line_number":3045,"context_line":"\t\t\tpacket_size -\u003d endp - parse;"},{"line_number":3046,"context_line":"\t\t\tparse \u003d endp;"},{"line_number":3047,"context_line":"\t\t}"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"fb03b4f2_b29948e1","line":3044,"in_reply_to":"c1d5cf49_1a4fa084","updated":"2022-08-11 09:54:53.000000000","message":"Done","commit_id":"c74601fdb9cc8af003eb4f1f450375542991fb6a"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"4e5e97b543cfd44c3c0123ce00e076e6d1e0532d","unresolved":true,"context_lines":[{"line_number":3072,"context_line":"\t\t\t\t\tint64_t tid;"},{"line_number":3073,"context_line":"\t\t\t\t\tparse +\u003d 1;"},{"line_number":3074,"context_line":""},{"line_number":3075,"context_line":"\t\t\t\t\ttid \u003d strtoll(parse, \u0026endp, 16);"},{"line_number":3076,"context_line":"\t\t\t\t\tif (tid \u003d\u003d thread_id) {"},{"line_number":3077,"context_line":"\t\t\t\t\t\t/*"},{"line_number":3078,"context_line":"\t\t\t\t\t\t * Special case: only step a single thread (core),"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"9c5cd3cb_442832b4","line":3075,"updated":"2022-06-11 09:06:20.000000000","message":"here endp is returned but its value is never used. Use:\ntid \u003d strtoll(parse, NULL, 16);\nWith this change \u0027endp\u0027 does not need to be initialized and is a local variable in the above \u0027if (endp) {...}\u0027","commit_id":"c74601fdb9cc8af003eb4f1f450375542991fb6a"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"dd0142681244bb1fd48c12331a79653a2ca5e384","unresolved":false,"context_lines":[{"line_number":3072,"context_line":"\t\t\t\t\tint64_t tid;"},{"line_number":3073,"context_line":"\t\t\t\t\tparse +\u003d 1;"},{"line_number":3074,"context_line":""},{"line_number":3075,"context_line":"\t\t\t\t\ttid \u003d strtoll(parse, \u0026endp, 16);"},{"line_number":3076,"context_line":"\t\t\t\t\tif (tid \u003d\u003d thread_id) {"},{"line_number":3077,"context_line":"\t\t\t\t\t\t/*"},{"line_number":3078,"context_line":"\t\t\t\t\t\t * Special case: only step a single thread (core),"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"4c275408_5c024686","line":3075,"in_reply_to":"9c5cd3cb_442832b4","updated":"2022-06-13 22:31:43.000000000","message":"Done","commit_id":"c74601fdb9cc8af003eb4f1f450375542991fb6a"},{"author":{"_account_id":1001997,"name":"FORGETTE Benoit ","email":"benoit.forgette@ci-yow.com","username":"Mrbenoit624"},"change_message_id":"08842fe6e34213a7050f3f4c796a62d14a75f989","unresolved":false,"context_lines":[{"line_number":3072,"context_line":"\t\t\t\t\tint64_t tid;"},{"line_number":3073,"context_line":"\t\t\t\t\tparse +\u003d 1;"},{"line_number":3074,"context_line":""},{"line_number":3075,"context_line":"\t\t\t\t\ttid \u003d strtoll(parse, \u0026endp, 16);"},{"line_number":3076,"context_line":"\t\t\t\t\tif (tid \u003d\u003d thread_id) {"},{"line_number":3077,"context_line":"\t\t\t\t\t\t/*"},{"line_number":3078,"context_line":"\t\t\t\t\t\t * Special case: only step a single thread (core),"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"ba6dbfc3_3ce8e5e3","line":3075,"in_reply_to":"9c5cd3cb_442832b4","updated":"2022-08-11 09:54:53.000000000","message":"Done","commit_id":"c74601fdb9cc8af003eb4f1f450375542991fb6a"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"4e5e97b543cfd44c3c0123ce00e076e6d1e0532d","unresolved":true,"context_lines":[{"line_number":3110,"context_line":"\t\t\tLOG_DEBUG(\"fake step thread %\"PRIx64, thread_id);"},{"line_number":3111,"context_line":""},{"line_number":3112,"context_line":"\t\t\tsig_reply_len \u003d snprintf(sig_reply, sizeof(sig_reply),"},{"line_number":3113,"context_line":"\t\t\t\t\t\t\t\t\t\t \"T05thread:%016\"PRIx64\";\", thread_id);"},{"line_number":3114,"context_line":""},{"line_number":3115,"context_line":"\t\t\tgdb_put_packet(connection, sig_reply, sig_reply_len);"},{"line_number":3116,"context_line":"\t\t\tgdb_connection-\u003eoutput_flag \u003d GDB_OUTPUT_NO;"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"db863fc5_d96a30c8","line":3113,"updated":"2022-06-11 09:06:20.000000000","message":"remove one TAB of indentation here too, so \"T05..\" get aligned with above sig_reply,","commit_id":"c74601fdb9cc8af003eb4f1f450375542991fb6a"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b4c636e5ab6db5266da5f48e2046bd891f096828","unresolved":false,"context_lines":[{"line_number":3110,"context_line":"\t\t\tLOG_DEBUG(\"fake step thread %\"PRIx64, thread_id);"},{"line_number":3111,"context_line":""},{"line_number":3112,"context_line":"\t\t\tsig_reply_len \u003d snprintf(sig_reply, sizeof(sig_reply),"},{"line_number":3113,"context_line":"\t\t\t\t\t\t\t\t\t\t \"T05thread:%016\"PRIx64\";\", thread_id);"},{"line_number":3114,"context_line":""},{"line_number":3115,"context_line":"\t\t\tgdb_put_packet(connection, sig_reply, sig_reply_len);"},{"line_number":3116,"context_line":"\t\t\tgdb_connection-\u003eoutput_flag \u003d GDB_OUTPUT_NO;"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"a09945ce_7970cd2d","line":3113,"in_reply_to":"a549ca98_2f75dd17","updated":"2022-06-15 09:27:28.000000000","message":"Done","commit_id":"c74601fdb9cc8af003eb4f1f450375542991fb6a"},{"author":{"_account_id":1001997,"name":"FORGETTE Benoit ","email":"benoit.forgette@ci-yow.com","username":"Mrbenoit624"},"change_message_id":"08842fe6e34213a7050f3f4c796a62d14a75f989","unresolved":false,"context_lines":[{"line_number":3110,"context_line":"\t\t\tLOG_DEBUG(\"fake step thread %\"PRIx64, thread_id);"},{"line_number":3111,"context_line":""},{"line_number":3112,"context_line":"\t\t\tsig_reply_len \u003d snprintf(sig_reply, sizeof(sig_reply),"},{"line_number":3113,"context_line":"\t\t\t\t\t\t\t\t\t\t \"T05thread:%016\"PRIx64\";\", thread_id);"},{"line_number":3114,"context_line":""},{"line_number":3115,"context_line":"\t\t\tgdb_put_packet(connection, sig_reply, sig_reply_len);"},{"line_number":3116,"context_line":"\t\t\tgdb_connection-\u003eoutput_flag \u003d GDB_OUTPUT_NO;"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"1f0bd0e5_13f1027f","line":3113,"in_reply_to":"db863fc5_d96a30c8","updated":"2022-08-11 09:54:53.000000000","message":"Done","commit_id":"c74601fdb9cc8af003eb4f1f450375542991fb6a"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"dd0142681244bb1fd48c12331a79653a2ca5e384","unresolved":true,"context_lines":[{"line_number":3110,"context_line":"\t\t\tLOG_DEBUG(\"fake step thread %\"PRIx64, thread_id);"},{"line_number":3111,"context_line":""},{"line_number":3112,"context_line":"\t\t\tsig_reply_len \u003d snprintf(sig_reply, sizeof(sig_reply),"},{"line_number":3113,"context_line":"\t\t\t\t\t\t\t\t\t\t \"T05thread:%016\"PRIx64\";\", thread_id);"},{"line_number":3114,"context_line":""},{"line_number":3115,"context_line":"\t\t\tgdb_put_packet(connection, sig_reply, sig_reply_len);"},{"line_number":3116,"context_line":"\t\t\tgdb_connection-\u003eoutput_flag \u003d GDB_OUTPUT_NO;"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"a549ca98_2f75dd17","line":3113,"in_reply_to":"db863fc5_d96a30c8","updated":"2022-06-13 22:31:43.000000000","message":"removed too many TABs. The initial code has 10 TABs, should be 9 TABs. But now there are only 5 TABs...","commit_id":"c74601fdb9cc8af003eb4f1f450375542991fb6a"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"4e5e97b543cfd44c3c0123ce00e076e6d1e0532d","unresolved":true,"context_lines":[{"line_number":3146,"context_line":"\t\t\tgdb_connection-\u003eoutput_flag \u003d GDB_OUTPUT_NO;"},{"line_number":3147,"context_line":"\t\t} else"},{"line_number":3148,"context_line":"\t\t\tgdb_connection-\u003efrontend_state \u003d TARGET_RUNNING;"},{"line_number":3149,"context_line":"\treturn true;"},{"line_number":3150,"context_line":"\t}"},{"line_number":3151,"context_line":""},{"line_number":3152,"context_line":"\treturn false;"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"91755918_728150a3","line":3149,"updated":"2022-06-11 09:06:20.000000000","message":"add one more TAB for indentation","commit_id":"c74601fdb9cc8af003eb4f1f450375542991fb6a"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b4c636e5ab6db5266da5f48e2046bd891f096828","unresolved":false,"context_lines":[{"line_number":3146,"context_line":"\t\t\tgdb_connection-\u003eoutput_flag \u003d GDB_OUTPUT_NO;"},{"line_number":3147,"context_line":"\t\t} else"},{"line_number":3148,"context_line":"\t\t\tgdb_connection-\u003efrontend_state \u003d TARGET_RUNNING;"},{"line_number":3149,"context_line":"\treturn true;"},{"line_number":3150,"context_line":"\t}"},{"line_number":3151,"context_line":""},{"line_number":3152,"context_line":"\treturn false;"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"1c64e782_a279b3cf","line":3149,"in_reply_to":"91755918_728150a3","updated":"2022-06-15 09:27:28.000000000","message":"Done","commit_id":"c74601fdb9cc8af003eb4f1f450375542991fb6a"},{"author":{"_account_id":1001997,"name":"FORGETTE Benoit ","email":"benoit.forgette@ci-yow.com","username":"Mrbenoit624"},"change_message_id":"08842fe6e34213a7050f3f4c796a62d14a75f989","unresolved":false,"context_lines":[{"line_number":3146,"context_line":"\t\t\tgdb_connection-\u003eoutput_flag \u003d GDB_OUTPUT_NO;"},{"line_number":3147,"context_line":"\t\t} else"},{"line_number":3148,"context_line":"\t\t\tgdb_connection-\u003efrontend_state \u003d TARGET_RUNNING;"},{"line_number":3149,"context_line":"\treturn true;"},{"line_number":3150,"context_line":"\t}"},{"line_number":3151,"context_line":""},{"line_number":3152,"context_line":"\treturn false;"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"5f6f062c_a36ab6d0","line":3149,"in_reply_to":"91755918_728150a3","updated":"2022-08-11 09:54:53.000000000","message":"Done","commit_id":"c74601fdb9cc8af003eb4f1f450375542991fb6a"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"dd0142681244bb1fd48c12331a79653a2ca5e384","unresolved":true,"context_lines":[{"line_number":3036,"context_line":"\t\t\tparse++;"},{"line_number":3037,"context_line":"\t\t\tpacket_size -\u003d 1;"},{"line_number":3038,"context_line":"\t\t\tthread_id \u003d strtoll(parse, \u0026endp, 16);"},{"line_number":3039,"context_line":"\t\t\tpacket_size -\u003d endp - parse;"},{"line_number":3040,"context_line":"\t\t\tparse \u003d endp;"},{"line_number":3041,"context_line":"\t\t} else {"},{"line_number":3042,"context_line":"\t\t\tthread_id \u003d 0;"},{"line_number":3043,"context_line":"\t\t}"}],"source_content_type":"text/x-csrc","patch_set":6,"id":"e36290c1_a53b75de","line":3040,"range":{"start_line":3039,"start_character":1,"end_line":3040,"end_character":16},"updated":"2022-06-13 22:31:43.000000000","message":"still no, these two lines must stay inside \u0027if (endp) {...}\u0027. The code here should be (including some extra line):\n\t\t\tthread_id \u003d strtoll(parse, \u0026endp, 16);\n\t\t\tif (endp) {\n\t\t\t\tpacket_size -\u003d endp - parse;\n\t\t\t\tparse \u003d endp;\n\t\t\t}\n\t\t} else {","commit_id":"c90dcf7803e8e92979a1f8407e77e211e904e5f6"},{"author":{"_account_id":1001997,"name":"FORGETTE Benoit ","email":"benoit.forgette@ci-yow.com","username":"Mrbenoit624"},"change_message_id":"08842fe6e34213a7050f3f4c796a62d14a75f989","unresolved":false,"context_lines":[{"line_number":3036,"context_line":"\t\t\tparse++;"},{"line_number":3037,"context_line":"\t\t\tpacket_size -\u003d 1;"},{"line_number":3038,"context_line":"\t\t\tthread_id \u003d strtoll(parse, \u0026endp, 16);"},{"line_number":3039,"context_line":"\t\t\tpacket_size -\u003d endp - parse;"},{"line_number":3040,"context_line":"\t\t\tparse \u003d endp;"},{"line_number":3041,"context_line":"\t\t} else {"},{"line_number":3042,"context_line":"\t\t\tthread_id \u003d 0;"},{"line_number":3043,"context_line":"\t\t}"}],"source_content_type":"text/x-csrc","patch_set":6,"id":"1ce52692_d47f19bc","line":3040,"range":{"start_line":3039,"start_character":1,"end_line":3040,"end_character":16},"in_reply_to":"e36290c1_a53b75de","updated":"2022-08-11 09:54:53.000000000","message":"Done","commit_id":"c90dcf7803e8e92979a1f8407e77e211e904e5f6"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b4c636e5ab6db5266da5f48e2046bd891f096828","unresolved":false,"context_lines":[{"line_number":3036,"context_line":"\t\t\tparse++;"},{"line_number":3037,"context_line":"\t\t\tpacket_size -\u003d 1;"},{"line_number":3038,"context_line":"\t\t\tthread_id \u003d strtoll(parse, \u0026endp, 16);"},{"line_number":3039,"context_line":"\t\t\tpacket_size -\u003d endp - parse;"},{"line_number":3040,"context_line":"\t\t\tparse \u003d endp;"},{"line_number":3041,"context_line":"\t\t} else {"},{"line_number":3042,"context_line":"\t\t\tthread_id \u003d 0;"},{"line_number":3043,"context_line":"\t\t}"}],"source_content_type":"text/x-csrc","patch_set":6,"id":"d1ef8254_3209c4f0","line":3040,"range":{"start_line":3039,"start_character":1,"end_line":3040,"end_character":16},"in_reply_to":"e36290c1_a53b75de","updated":"2022-06-15 09:27:28.000000000","message":"Done","commit_id":"c90dcf7803e8e92979a1f8407e77e211e904e5f6"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"dd0142681244bb1fd48c12331a79653a2ca5e384","unresolved":true,"context_lines":[{"line_number":3098,"context_line":"\t\t* for a real target running a multi-threading OS. We just fake"},{"line_number":3099,"context_line":"\t\t* the step to not trigger an internal error in gdb. See"},{"line_number":3100,"context_line":"\t\t* https://sourceware.org/bugzilla/show_bug.cgi?id\u003d22925 for details"},{"line_number":3101,"context_line":"\t\t*/"},{"line_number":3102,"context_line":"\t\tif (fake_step) {"},{"line_number":3103,"context_line":"\t\t\tint sig_reply_len;"},{"line_number":3104,"context_line":"\t\t\tchar sig_reply[128];"}],"source_content_type":"text/x-csrc","patch_set":6,"id":"d8e12346_e9f64d81","line":3101,"updated":"2022-06-13 22:31:43.000000000","message":"no reason to change this, it was ok before","commit_id":"c90dcf7803e8e92979a1f8407e77e211e904e5f6"},{"author":{"_account_id":1001997,"name":"FORGETTE Benoit ","email":"benoit.forgette@ci-yow.com","username":"Mrbenoit624"},"change_message_id":"08842fe6e34213a7050f3f4c796a62d14a75f989","unresolved":false,"context_lines":[{"line_number":3098,"context_line":"\t\t* for a real target running a multi-threading OS. We just fake"},{"line_number":3099,"context_line":"\t\t* the step to not trigger an internal error in gdb. See"},{"line_number":3100,"context_line":"\t\t* https://sourceware.org/bugzilla/show_bug.cgi?id\u003d22925 for details"},{"line_number":3101,"context_line":"\t\t*/"},{"line_number":3102,"context_line":"\t\tif (fake_step) {"},{"line_number":3103,"context_line":"\t\t\tint sig_reply_len;"},{"line_number":3104,"context_line":"\t\t\tchar sig_reply[128];"}],"source_content_type":"text/x-csrc","patch_set":6,"id":"031d4ea7_3fafb76f","line":3101,"in_reply_to":"d8e12346_e9f64d81","updated":"2022-08-11 09:54:53.000000000","message":"Done","commit_id":"c90dcf7803e8e92979a1f8407e77e211e904e5f6"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b4c636e5ab6db5266da5f48e2046bd891f096828","unresolved":false,"context_lines":[{"line_number":3098,"context_line":"\t\t* for a real target running a multi-threading OS. We just fake"},{"line_number":3099,"context_line":"\t\t* the step to not trigger an internal error in gdb. See"},{"line_number":3100,"context_line":"\t\t* https://sourceware.org/bugzilla/show_bug.cgi?id\u003d22925 for details"},{"line_number":3101,"context_line":"\t\t*/"},{"line_number":3102,"context_line":"\t\tif (fake_step) {"},{"line_number":3103,"context_line":"\t\t\tint sig_reply_len;"},{"line_number":3104,"context_line":"\t\t\tchar sig_reply[128];"}],"source_content_type":"text/x-csrc","patch_set":6,"id":"c5ae998f_608da03f","line":3101,"in_reply_to":"d8e12346_e9f64d81","updated":"2022-06-15 09:27:28.000000000","message":"Done","commit_id":"c90dcf7803e8e92979a1f8407e77e211e904e5f6"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"dd0142681244bb1fd48c12331a79653a2ca5e384","unresolved":true,"context_lines":[{"line_number":3119,"context_line":"\t\t\tgdb_connection-\u003esync \u003d false;"},{"line_number":3120,"context_line":"\t\t\tif (ct-\u003estate \u003d\u003d TARGET_HALTED) {"},{"line_number":3121,"context_line":"\t\t\t\tLOG_DEBUG(\"stepi ignored. GDB will now fetch the register state \""},{"line_number":3122,"context_line":"\t\t\t\t\t\t\t\"from the target.\");"},{"line_number":3123,"context_line":"\t\t\t\tgdb_sig_halted(connection);"},{"line_number":3124,"context_line":"\t\t\t\tgdb_connection-\u003eoutput_flag \u003d GDB_OUTPUT_NO;"},{"line_number":3125,"context_line":"\t\t\t} else"}],"source_content_type":"text/x-csrc","patch_set":6,"id":"dd754601_34f6dc38","line":3122,"updated":"2022-06-13 22:31:43.000000000","message":"also no reason to change this","commit_id":"c90dcf7803e8e92979a1f8407e77e211e904e5f6"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b4c636e5ab6db5266da5f48e2046bd891f096828","unresolved":false,"context_lines":[{"line_number":3119,"context_line":"\t\t\tgdb_connection-\u003esync \u003d false;"},{"line_number":3120,"context_line":"\t\t\tif (ct-\u003estate \u003d\u003d TARGET_HALTED) {"},{"line_number":3121,"context_line":"\t\t\t\tLOG_DEBUG(\"stepi ignored. GDB will now fetch the register state \""},{"line_number":3122,"context_line":"\t\t\t\t\t\t\t\"from the target.\");"},{"line_number":3123,"context_line":"\t\t\t\tgdb_sig_halted(connection);"},{"line_number":3124,"context_line":"\t\t\t\tgdb_connection-\u003eoutput_flag \u003d GDB_OUTPUT_NO;"},{"line_number":3125,"context_line":"\t\t\t} else"}],"source_content_type":"text/x-csrc","patch_set":6,"id":"81018942_a5a2fd5a","line":3122,"in_reply_to":"dd754601_34f6dc38","updated":"2022-06-15 09:27:28.000000000","message":"Done","commit_id":"c90dcf7803e8e92979a1f8407e77e211e904e5f6"},{"author":{"_account_id":1001997,"name":"FORGETTE Benoit ","email":"benoit.forgette@ci-yow.com","username":"Mrbenoit624"},"change_message_id":"08842fe6e34213a7050f3f4c796a62d14a75f989","unresolved":false,"context_lines":[{"line_number":3119,"context_line":"\t\t\tgdb_connection-\u003esync \u003d false;"},{"line_number":3120,"context_line":"\t\t\tif (ct-\u003estate \u003d\u003d TARGET_HALTED) {"},{"line_number":3121,"context_line":"\t\t\t\tLOG_DEBUG(\"stepi ignored. GDB will now fetch the register state \""},{"line_number":3122,"context_line":"\t\t\t\t\t\t\t\"from the target.\");"},{"line_number":3123,"context_line":"\t\t\t\tgdb_sig_halted(connection);"},{"line_number":3124,"context_line":"\t\t\t\tgdb_connection-\u003eoutput_flag \u003d GDB_OUTPUT_NO;"},{"line_number":3125,"context_line":"\t\t\t} else"}],"source_content_type":"text/x-csrc","patch_set":6,"id":"d56c06ba_863ecb1b","line":3122,"in_reply_to":"dd754601_34f6dc38","updated":"2022-08-11 09:54:53.000000000","message":"Done","commit_id":"c90dcf7803e8e92979a1f8407e77e211e904e5f6"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b4c636e5ab6db5266da5f48e2046bd891f096828","unresolved":true,"context_lines":[{"line_number":3029,"context_line":"\t\tstruct target *ct \u003d target;"},{"line_number":3030,"context_line":"\t\tint current_pc \u003d 1;"},{"line_number":3031,"context_line":"\t\tint64_t thread_id;"},{"line_number":3032,"context_line":"\t\tchar *endp \u003d NULL;"},{"line_number":3033,"context_line":"\t\tparse++;"},{"line_number":3034,"context_line":"\t\tpacket_size -\u003d 1;"},{"line_number":3035,"context_line":"\t\tif (parse[0] \u003d\u003d \u0027:\u0027) {"}],"source_content_type":"text/x-csrc","patch_set":7,"id":"e90cb653_2bda1d0d","line":3032,"updated":"2022-06-15 09:27:28.000000000","message":"no need to initialize it to NULL\nMove the declaration inside the \u0027if (parse[0] \u003d\u003d \u0027:\u0027) {\u0027, as this variable is used there only.","commit_id":"4faa697a0ff3319d815350ce5528e125454696ec"},{"author":{"_account_id":1001997,"name":"FORGETTE Benoit ","email":"benoit.forgette@ci-yow.com","username":"Mrbenoit624"},"change_message_id":"08842fe6e34213a7050f3f4c796a62d14a75f989","unresolved":false,"context_lines":[{"line_number":3029,"context_line":"\t\tstruct target *ct \u003d target;"},{"line_number":3030,"context_line":"\t\tint current_pc \u003d 1;"},{"line_number":3031,"context_line":"\t\tint64_t thread_id;"},{"line_number":3032,"context_line":"\t\tchar *endp \u003d NULL;"},{"line_number":3033,"context_line":"\t\tparse++;"},{"line_number":3034,"context_line":"\t\tpacket_size -\u003d 1;"},{"line_number":3035,"context_line":"\t\tif (parse[0] \u003d\u003d \u0027:\u0027) {"}],"source_content_type":"text/x-csrc","patch_set":7,"id":"a374730e_5fe485ca","line":3032,"in_reply_to":"e90cb653_2bda1d0d","updated":"2022-08-11 09:54:53.000000000","message":"Done","commit_id":"4faa697a0ff3319d815350ce5528e125454696ec"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b4c636e5ab6db5266da5f48e2046bd891f096828","unresolved":true,"context_lines":[{"line_number":3031,"context_line":"\t\tint64_t thread_id;"},{"line_number":3032,"context_line":"\t\tchar *endp \u003d NULL;"},{"line_number":3033,"context_line":"\t\tparse++;"},{"line_number":3034,"context_line":"\t\tpacket_size -\u003d 1;"},{"line_number":3035,"context_line":"\t\tif (parse[0] \u003d\u003d \u0027:\u0027) {"},{"line_number":3036,"context_line":"\t\t\tparse++;"},{"line_number":3037,"context_line":"\t\t\tpacket_size -\u003d 1;"}],"source_content_type":"text/x-csrc","patch_set":7,"id":"52a25de3_d388e1f1","line":3034,"updated":"2022-06-15 09:27:28.000000000","message":"use \"packet_size--;\"","commit_id":"4faa697a0ff3319d815350ce5528e125454696ec"},{"author":{"_account_id":1001997,"name":"FORGETTE Benoit ","email":"benoit.forgette@ci-yow.com","username":"Mrbenoit624"},"change_message_id":"08842fe6e34213a7050f3f4c796a62d14a75f989","unresolved":false,"context_lines":[{"line_number":3031,"context_line":"\t\tint64_t thread_id;"},{"line_number":3032,"context_line":"\t\tchar *endp \u003d NULL;"},{"line_number":3033,"context_line":"\t\tparse++;"},{"line_number":3034,"context_line":"\t\tpacket_size -\u003d 1;"},{"line_number":3035,"context_line":"\t\tif (parse[0] \u003d\u003d \u0027:\u0027) {"},{"line_number":3036,"context_line":"\t\t\tparse++;"},{"line_number":3037,"context_line":"\t\t\tpacket_size -\u003d 1;"}],"source_content_type":"text/x-csrc","patch_set":7,"id":"05d515b0_16c049c2","line":3034,"in_reply_to":"52a25de3_d388e1f1","updated":"2022-08-11 09:54:53.000000000","message":"Done","commit_id":"4faa697a0ff3319d815350ce5528e125454696ec"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b4c636e5ab6db5266da5f48e2046bd891f096828","unresolved":true,"context_lines":[{"line_number":3034,"context_line":"\t\tpacket_size -\u003d 1;"},{"line_number":3035,"context_line":"\t\tif (parse[0] \u003d\u003d \u0027:\u0027) {"},{"line_number":3036,"context_line":"\t\t\tparse++;"},{"line_number":3037,"context_line":"\t\t\tpacket_size -\u003d 1;"},{"line_number":3038,"context_line":"\t\t\tthread_id \u003d strtoll(parse, \u0026endp, 16);"},{"line_number":3039,"context_line":"\t\t\tif (endp) {"},{"line_number":3040,"context_line":"\t\t\t\tpacket_size -\u003d endp - parse;"}],"source_content_type":"text/x-csrc","patch_set":7,"id":"1d0c3859_1dbcaa94","line":3037,"updated":"2022-06-15 09:27:28.000000000","message":"also here, \"packet_size--;\"","commit_id":"4faa697a0ff3319d815350ce5528e125454696ec"},{"author":{"_account_id":1001997,"name":"FORGETTE Benoit ","email":"benoit.forgette@ci-yow.com","username":"Mrbenoit624"},"change_message_id":"08842fe6e34213a7050f3f4c796a62d14a75f989","unresolved":false,"context_lines":[{"line_number":3034,"context_line":"\t\tpacket_size -\u003d 1;"},{"line_number":3035,"context_line":"\t\tif (parse[0] \u003d\u003d \u0027:\u0027) {"},{"line_number":3036,"context_line":"\t\t\tparse++;"},{"line_number":3037,"context_line":"\t\t\tpacket_size -\u003d 1;"},{"line_number":3038,"context_line":"\t\t\tthread_id \u003d strtoll(parse, \u0026endp, 16);"},{"line_number":3039,"context_line":"\t\t\tif (endp) {"},{"line_number":3040,"context_line":"\t\t\t\tpacket_size -\u003d endp - parse;"}],"source_content_type":"text/x-csrc","patch_set":7,"id":"872ba79c_5e1d2f1d","line":3037,"in_reply_to":"1d0c3859_1dbcaa94","updated":"2022-08-11 09:54:53.000000000","message":"Done","commit_id":"4faa697a0ff3319d815350ce5528e125454696ec"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b4c636e5ab6db5266da5f48e2046bd891f096828","unresolved":true,"context_lines":[{"line_number":3147,"context_line":"\t\treturn true;"},{"line_number":3148,"context_line":"\t}"},{"line_number":3149,"context_line":""},{"line_number":3150,"context_line":"\treturn false;"},{"line_number":3151,"context_line":"}"},{"line_number":3152,"context_line":""},{"line_number":3153,"context_line":"static char *next_hex_encoded_field(const char **str, char sep)"}],"source_content_type":"text/x-csrc","patch_set":7,"id":"df756615_39411780","line":3150,"updated":"2022-06-15 09:27:28.000000000","message":"Would you mind adding here, before return:\nLOG_ERROR(\"Unknown vCont packet\");\nThis line was present before but only in case \"s:\" was not recognized.\nI think could be good to have it for the general case.","commit_id":"4faa697a0ff3319d815350ce5528e125454696ec"},{"author":{"_account_id":1001997,"name":"FORGETTE Benoit ","email":"benoit.forgette@ci-yow.com","username":"Mrbenoit624"},"change_message_id":"08842fe6e34213a7050f3f4c796a62d14a75f989","unresolved":false,"context_lines":[{"line_number":3147,"context_line":"\t\treturn true;"},{"line_number":3148,"context_line":"\t}"},{"line_number":3149,"context_line":""},{"line_number":3150,"context_line":"\treturn false;"},{"line_number":3151,"context_line":"}"},{"line_number":3152,"context_line":""},{"line_number":3153,"context_line":"static char *next_hex_encoded_field(const char **str, char sep)"}],"source_content_type":"text/x-csrc","patch_set":7,"id":"900b4b9c_956fe54a","line":3150,"in_reply_to":"df756615_39411780","updated":"2022-08-11 09:54:53.000000000","message":"Done","commit_id":"4faa697a0ff3319d815350ce5528e125454696ec"}]}