)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"32ba0f416a2d28ddd489871babb12f2f7feb3e4d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"70ea8289_f7f419d2","updated":"2022-06-10 09:48:55.000000000","message":"I\u0027m not fully convinced on this patch, so added more people as reviewers and I will wait before merging it.\nOn one side I would say it\u0027s good to have the same behavior on different host PC (win vs Linux vs Mac).\nOn another side, this patch overwrites the flag to open the file in text mode, so no way to get text mode files anymore.","commit_id":"c5c93f5b29fbc3f4aa8114a5ec2191abad1de49a"},{"author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"change_message_id":"0b00fa4d3ee9e5e8497085684e02a076aca7b2b9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a78ea2bd_c53fba20","updated":"2022-09-07 06:41:26.000000000","message":"I\u0027m sorry but I believe we shouldn\u0027t force the binary mode when the mode argument does not explicitly says so. This violates the ARM semihosting spec. See Table 11-3 at: https://developer.arm.com/documentation/dui0375/g/What-is-Semihosting-/SYS-OPEN--0x01-\n\nAnd yes, text files look differently on Windows vs. Linux - and this is another reason why the binary mode should not be forced when the caller does not want it.\n\nWhat use case would require this change?","commit_id":"c5c93f5b29fbc3f4aa8114a5ec2191abad1de49a"}]}