)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"2d8c8d33c74dd300b135b4ef890eee0b841ae3b1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"88d14bb4_93faf85e","updated":"2022-06-15 09:29:30.000000000","message":"thanks!","commit_id":"2686b573bdfc97653dcf282d2329829c8019202d"}],"tcl/target/imx8m.cfg":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"0bc6c14855090d6b0e48a4b30ca2c967e3901c00","unresolved":true,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    set _command \"target create $_TARGETNAME.$_core aarch64 -dap $_CHIPNAME.dap \\"},{"line_number":41,"context_line":"        -dbgbase [lindex $DBGBASE $_core] -cti $_CTINAME.$_core -coreid $_core \\"},{"line_number":42,"context_line":"        -rtos hwthread\""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    if { $_core !\u003d 0 } {"},{"line_number":45,"context_line":"        # non-boot core examination may fail"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"0bf7da24_64477e79","line":42,"updated":"2022-06-11 08:35:25.000000000","message":"Other config script:\n- tcl/target/rk3308.cfg\n- tcl/target/rk3399.cfg\n- tcl/target/lsch3_common.cfg\n- tcl/target/ls1046a.cfg\nuse the flag \u0027-rtos hwthread\u0027 only on core 0. Instead\n- tcl/target/ampere_emag.cfg\nuse it to every core. I have never checked the code nor tested at runtime qif there is really need to use it on core 0 only. Any idea on your side?\n\nSaid that, I prefer to keep \u0027-rtos hwthread\u0027 in a separate line, so it\u0027s easy to comment it out if user doesn\u0027t want to use hwthread. For example, after line\neval $_command\n$_TARGETNAME.$_core configure -rtos hwthread\nor, if used on core 0 only, in the else case below\nset _command \"$_command -rtos hwthread\"","commit_id":"f4bbb899e989fa9a44eeef05a9b342d3e1822271"},{"author":{"_account_id":1002000,"name":"Alvin Šipraga","email":"alsi@bang-olufsen.dk","username":"sipraga"},"change_message_id":"a10490c6a317bcc52e861416be9c980f41c52a7c","unresolved":true,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    set _command \"target create $_TARGETNAME.$_core aarch64 -dap $_CHIPNAME.dap \\"},{"line_number":41,"context_line":"        -dbgbase [lindex $DBGBASE $_core] -cti $_CTINAME.$_core -coreid $_core \\"},{"line_number":42,"context_line":"        -rtos hwthread\""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    if { $_core !\u003d 0 } {"},{"line_number":45,"context_line":"        # non-boot core examination may fail"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"c10cdd80_461755d8","line":42,"in_reply_to":"0bf7da24_64477e79","updated":"2022-06-11 09:58:10.000000000","message":"I can confirm that it works correctly in its current form, but I agree it would be better to stay consistent with the other scripts.\n\nI\u0027ll try it when I\u0027m in the office on Monday and update the patch if it works.","commit_id":"f4bbb899e989fa9a44eeef05a9b342d3e1822271"},{"author":{"_account_id":1002000,"name":"Alvin Šipraga","email":"alsi@bang-olufsen.dk","username":"sipraga"},"change_message_id":"ec8047036ceb09fbc225210ad2b3c7ee350a4b39","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    set _command \"target create $_TARGETNAME.$_core aarch64 -dap $_CHIPNAME.dap \\"},{"line_number":41,"context_line":"        -dbgbase [lindex $DBGBASE $_core] -cti $_CTINAME.$_core -coreid $_core \\"},{"line_number":42,"context_line":"        -rtos hwthread\""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    if { $_core !\u003d 0 } {"},{"line_number":45,"context_line":"        # non-boot core examination may fail"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"c8e5bf26_c802ca96","line":42,"in_reply_to":"c10cdd80_461755d8","updated":"2022-06-13 13:01:55.000000000","message":"If I specify -rtos hwthread on just core 0, and coreid on cores 1-3, then it also works. I have sent an updated patch.","commit_id":"f4bbb899e989fa9a44eeef05a9b342d3e1822271"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b61f29e79ade26285ff4bccd331799bdee6c02fb","unresolved":true,"context_lines":[{"line_number":38,"context_line":"        -baseaddr [lindex $CTIBASE $_core]"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    set _command \"target create $_TARGETNAME.$_core aarch64 -dap $_CHIPNAME.dap \\"},{"line_number":41,"context_line":"        -dbgbase [lindex $DBGBASE $_core] -cti $_CTINAME.$_core -rtos hwthread\""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    if { $_core !\u003d 0 } {"},{"line_number":44,"context_line":"        # non-boot core examination may fail"}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"39cb8c50_7cf4aef3","line":41,"updated":"2022-06-13 15:17:58.000000000","message":"My suggestion was to left here \u0027-coreid $_core\u0027 for every core, and ..","commit_id":"193aa06522361b7b90337383dcb88ecee7d4baac"},{"author":{"_account_id":1002000,"name":"Alvin Šipraga","email":"alsi@bang-olufsen.dk","username":"sipraga"},"change_message_id":"aa2b578732acec8f3f6995ce085d8ccd62e51ec8","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        -baseaddr [lindex $CTIBASE $_core]"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    set _command \"target create $_TARGETNAME.$_core aarch64 -dap $_CHIPNAME.dap \\"},{"line_number":41,"context_line":"        -dbgbase [lindex $DBGBASE $_core] -cti $_CTINAME.$_core -rtos hwthread\""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    if { $_core !\u003d 0 } {"},{"line_number":44,"context_line":"        # non-boot core examination may fail"}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"fead0167_eb338981","line":41,"in_reply_to":"39cb8c50_7cf4aef3","updated":"2022-06-14 08:31:31.000000000","message":"Done","commit_id":"193aa06522361b7b90337383dcb88ecee7d4baac"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b61f29e79ade26285ff4bccd331799bdee6c02fb","unresolved":true,"context_lines":[{"line_number":45,"context_line":"        set _command \"$_command -coreid $_core -defer-examine\""},{"line_number":46,"context_line":"        set _smp_command \"$_smp_command $_TARGETNAME.$_core\""},{"line_number":47,"context_line":"    } else {"},{"line_number":48,"context_line":"        set _smp_command \"target smp $_TARGETNAME.$_core\""},{"line_number":49,"context_line":"    }"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    eval $_command"}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"bad99d0c_595009f5","line":48,"updated":"2022-06-13 15:17:58.000000000","message":".. and add here for core0 only \u0027-rtos hwthread\u0027","commit_id":"193aa06522361b7b90337383dcb88ecee7d4baac"},{"author":{"_account_id":1002000,"name":"Alvin Šipraga","email":"alsi@bang-olufsen.dk","username":"sipraga"},"change_message_id":"aa2b578732acec8f3f6995ce085d8ccd62e51ec8","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        set _command \"$_command -coreid $_core -defer-examine\""},{"line_number":46,"context_line":"        set _smp_command \"$_smp_command $_TARGETNAME.$_core\""},{"line_number":47,"context_line":"    } else {"},{"line_number":48,"context_line":"        set _smp_command \"target smp $_TARGETNAME.$_core\""},{"line_number":49,"context_line":"    }"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    eval $_command"}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"862daab5_50928e74","line":48,"in_reply_to":"bad99d0c_595009f5","updated":"2022-06-14 08:31:31.000000000","message":"Done","commit_id":"193aa06522361b7b90337383dcb88ecee7d4baac"}]}
