)]}'
{"id":"openocd~master~Ia8d26426850008f0465858a1d84cc774bc1146ed","project":"openocd","branch":"master","topic":"checkpatch","hashtags":[],"change_id":"Ia8d26426850008f0465858a1d84cc774bc1146ed","subject":"checkpatch: add variable $OpenOCD","status":"MERGED","created":"2022-06-12 14:41:58.000000000","updated":"2022-09-18 08:17:23.000000000","submitted":"2022-09-18 08:17:23.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7021-checkpatch","meta_rev_id":"682588db6191b9493b88d86673461ff235912e73","_number":7021,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-09-18 08:17:23.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-09-18 08:17:23.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-06-12 20:52:33.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"0ad615402f681962ec84546deea3add1756155e0","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-06-12 14:41:58.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"877a4f3806a6f97eb39fd31b9ecba8e5a3934f2c","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-06-12 14:56:37.000000000","message":"Topic set to checkpatch","accounts_in_message":[],"_revision_number":1},{"id":"5f952c1fdce1f50bd5a3910216e55b77519ed886","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-06-12 20:52:33.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/16286/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/15496/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"a7e691291eec8429b6b8241192ead31f01272b56","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-07-21 21:27:53.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"5de618a8b403a7ec1a14b70e8594ef88373cde9f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-09-01 20:28:50.000000000","message":"Uploaded patch set 2: Code-Review+1.","accounts_in_message":[],"_revision_number":2},{"id":"40b0921437e49d99bea6408cefce268ba3d48d36","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-09-01 22:27:27.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/15825/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/16616/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"3b66a30468b4190230ff6d838a13a09d28a88a16","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-09-02 13:36:40.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"024b50128eb4219aefbebb89fa41d56df98d47dc","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-09-13 23:11:50.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.","accounts_in_message":[],"_revision_number":3},{"id":"222717817d72e26a5d54f9d22baf2b66f7f9f6ae","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-09-14 03:28:35.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/15911/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/16702/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"9de4aa6453b7961557f9577bcd41353ad7dcfa91","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-09-14 14:48:05.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"682588db6191b9493b88d86673461ff235912e73","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-09-18 08:17:23.000000000","message":"Change has been successfully cherry-picked as 9c6c5b61b3c78a9f78152be6d403d9e3b76ef6f9","accounts_in_message":[],"_revision_number":4}],"current_revision":"9c6c5b61b3c78a9f78152be6d403d9e3b76ef6f9","revisions":{"bcc95746ad7a08b1a63ffa7d0f3dfc90ee6d8193":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2022-09-13 23:11:50.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/21/7021/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/21/7021/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/21/7021/3 \u0026\u0026 git checkout -b change-7021 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/21/7021/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/21/7021/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/21/7021/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/21/7021/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/21/7021/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"c13e1a753b8a14612752bd60e32e26e3db9202b6","subject":"checkpatch: add OpenOCD specific config flags"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-06-11 20:41:17.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-09-13 23:06:15.000000000","tz":120},"subject":"checkpatch: add variable $OpenOCD","message":"checkpatch: add variable $OpenOCD\n\nThe script checkpatch.pl require some adaptation for OpenOCD that\ncannot be achieved through the config file .checkpatch.conf; the\nscript\u0027s code has to be modified.\nTo merge new version of the script from Linux kernel it becomes\nrelevant highlighting the changes, while minimizing the diff wrt\nthe initial script.\n\nAdd the perl variable \u0027$OpenOCD\u0027 and suggest how to highlight\nchanges.\n\nChange-Id: Ia8d26426850008f0465858a1d84cc774bc1146ed\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"cc13a889251ce7c3e1969f09cc5c9241a07a329e":{"kind":"REWORK","_number":2,"created":"2022-09-01 20:28:50.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/21/7021/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/21/7021/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/21/7021/2 \u0026\u0026 git checkout -b change-7021 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/21/7021/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/21/7021/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/21/7021/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/21/7021/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/21/7021/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"470ffba162453f3eb3a82b3db5605c1bf992339f","subject":"checkpatch: add OpenOCD specific config flags"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-06-11 20:41:17.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-09-01 20:22:28.000000000","tz":120},"subject":"checkpatch: add variable $OpenOCD","message":"checkpatch: add variable $OpenOCD\n\nThe script checkpatch.pl require some adaptation for OpenOCD that\ncannot be achieved through the config file .checkpatch.conf; the\nscript\u0027s code has to be modified.\nTo merge new version of the script from Linux kernel it becomes\nrelevant highlighting the changes, while minimizing the diff wrt\nthe initial script.\n\nAdd the perl variable \u0027$OpenOCD\u0027 and suggest how to highlight\nchanges.\n\nChange-Id: Ia8d26426850008f0465858a1d84cc774bc1146ed\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"018839a39d4313506f0e574740ce19f490f12347":{"kind":"REWORK","_number":1,"created":"2022-06-12 14:41:58.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/21/7021/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/21/7021/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/21/7021/1 \u0026\u0026 git checkout -b change-7021 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/21/7021/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/21/7021/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/21/7021/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/21/7021/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/21/7021/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3d4ad2b85ff162b1e1b2b0573fc09da83ff0202e","subject":"checkpatch: add OpenOCD specific config flags"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-06-11 20:41:17.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-06-11 23:12:17.000000000","tz":120},"subject":"checkpatch: add variable $OpenOCD","message":"checkpatch: add variable $OpenOCD\n\nThe script checkpatch.pl require some adaptation for OpenOCD that\ncannot be achieved through the config file .checkpatch.conf; the\nscript\u0027s code has to be modified.\nTo merge new version of the script from Linux kernel it becomes\nrelevant highlighting the changes, while minimizing the diff wrt\nthe initial script.\n\nAdd the perl variable \u0027$OpenOCD\u0027 and suggest how to highlight\nchanges.\n\nChange-Id: I18acb59166871bd3f6d188f6484f1caaca15cb41\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n\nf\n\nChange-Id: Ia8d26426850008f0465858a1d84cc774bc1146ed\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"9c6c5b61b3c78a9f78152be6d403d9e3b76ef6f9":{"kind":"REWORK","_number":4,"created":"2022-09-18 08:17:23.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/21/7021/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/21/7021/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/21/7021/4 \u0026\u0026 git checkout -b change-7021 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/21/7021/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/21/7021/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/21/7021/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/21/7021/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/21/7021/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"85a918b44d4f297e0dd30fc5bf6e798c991ddc6c","subject":"checkpatch: add OpenOCD specific config flags"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-06-11 20:41:17.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-09-18 08:17:23.000000000","tz":0},"subject":"checkpatch: add variable $OpenOCD","message":"checkpatch: add variable $OpenOCD\n\nThe script checkpatch.pl require some adaptation for OpenOCD that\ncannot be achieved through the config file .checkpatch.conf; the\nscript\u0027s code has to be modified.\nTo merge new version of the script from Linux kernel it becomes\nrelevant highlighting the changes, while minimizing the diff wrt\nthe initial script.\n\nAdd the perl variable \u0027$OpenOCD\u0027 and suggest how to highlight\nchanges.\n\nChange-Id: Ia8d26426850008f0465858a1d84cc774bc1146ed\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/7021\nTested-by: jenkins\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}
