)]}'
{"id":"openocd~master~Ice4333c50d16f7592f0ff86b1640217fa42e34f6","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000863":{"account":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"last_update":"2022-06-24 21:50:41.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ice4333c50d16f7592f0ff86b1640217fa42e34f6","subject":"semihosting: remove comparison with NULL","status":"MERGED","created":"2022-06-13 21:25:27.000000000","updated":"2022-06-24 21:50:41.000000000","submitted":"2022-06-24 21:50:41.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7031","meta_rev_id":"e3fe7e25daec1c5dec67cf4b79e71476f6b22b19","_number":7031,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-06-24 21:50:41.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-06-24 21:50:41.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"}],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-06-13 21:25:27.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"state":"REVIEWER"},{"updated":"2022-06-13 21:54:25.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"d5f8fc771c6e62f96ed6a5d572f11a5d934a0bee","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-06-13 21:25:27.000000000","message":"Uploaded patch set 1: Code-Review+1.","accounts_in_message":[],"_revision_number":1},{"id":"e37a4846de5ec66355e9c7282d32aa909ff04f7e","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-06-13 21:54:25.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/16304/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/15514/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"2d745f1c9bc4c15671444af57cd2f4b796deacd1","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-06-24 21:50:37.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"e3fe7e25daec1c5dec67cf4b79e71476f6b22b19","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-06-24 21:50:41.000000000","message":"Change has been successfully cherry-picked as 717b99164adc09c5a74bd25edeca87d66308e9dd","accounts_in_message":[],"_revision_number":2}],"current_revision":"717b99164adc09c5a74bd25edeca87d66308e9dd","revisions":{"2e1e20821a6f5eb0223440fb27cd4f3e7872d451":{"kind":"REWORK","_number":1,"created":"2022-06-13 21:25:27.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/31/7031/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/31/7031/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/31/7031/1 \u0026\u0026 git checkout -b change-7031 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/31/7031/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/31/7031/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/31/7031/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/31/7031/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/31/7031/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"480d4e17727864f75dc60e22cb1a42e022cb1db3","subject":"semihosting: fix accessing memory outside the bounds of the fn array"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-06-13 13:41:22.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-06-13 13:53:26.000000000","tz":120},"subject":"semihosting: remove comparison with NULL","message":"semihosting: remove comparison with NULL\n\nCommit b9526f140127 (\"semihosting: permit redirection of\nsemihosting I/O to TCP\") introduces a new comparison with NULL.\n\nRemove it.\n\nChange-Id: Ice4333c50d16f7592f0ff86b1640217fa42e34f6\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nFixes: b9526f140127 (\"semihosting: permit redirection of semihosting I/O to TCP\")\n"}},"717b99164adc09c5a74bd25edeca87d66308e9dd":{"kind":"REWORK","_number":2,"created":"2022-06-24 21:50:41.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/31/7031/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/31/7031/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/31/7031/2 \u0026\u0026 git checkout -b change-7031 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/31/7031/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/31/7031/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/31/7031/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/31/7031/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/31/7031/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"eab88eadd7b828f9c07007a8ac91988c37b5d036","subject":"drivers/linuxgpiod: simplify gpio release"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-06-13 13:41:22.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-06-24 21:50:41.000000000","tz":0},"subject":"semihosting: remove comparison with NULL","message":"semihosting: remove comparison with NULL\n\nCommit b9526f140127 (\"semihosting: permit redirection of\nsemihosting I/O to TCP\") introduces a new comparison with NULL.\n\nRemove it.\n\nChange-Id: Ice4333c50d16f7592f0ff86b1640217fa42e34f6\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nFixes: b9526f140127 (\"semihosting: permit redirection of semihosting I/O to TCP\")\nReviewed-on: https://review.openocd.org/c/openocd/+/7031\nTested-by: jenkins\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}