)]}'
{"id":"openocd~master~I6f839f06f7b091e234ede31ec18096e51f017bcd","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2022-06-24 21:49:18.000000000","reason":"Antonio Borneo replied on the change"},"1001834":{"account":{"_account_id":1001834,"name":"Christian Hoff","email":"christian.hoff@advantest.com","username":"chrihoff"},"last_update":"2022-06-24 21:49:25.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I6f839f06f7b091e234ede31ec18096e51f017bcd","subject":"aarch64: fix handling of \u0027reset halt\u0027","status":"MERGED","created":"2022-06-13 21:26:41.000000000","updated":"2022-06-24 21:49:25.000000000","submitted":"2022-06-24 21:49:25.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":5,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7034","meta_rev_id":"de88e57757d999aa54ea657d7d10839dd399e664","_number":7034,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1001834,"name":"Christian Hoff","email":"christian.hoff@advantest.com","username":"chrihoff"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-06-24 21:49:25.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-06-24 21:49:25.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-06-24 21:49:25.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1001834,"name":"Christian Hoff","email":"christian.hoff@advantest.com","username":"chrihoff"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1001834,"name":"Christian Hoff","email":"christian.hoff@advantest.com","username":"chrihoff"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-06-13 21:26:41.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1001834,"name":"Christian Hoff","email":"christian.hoff@advantest.com","username":"chrihoff"},"state":"REVIEWER"},{"updated":"2022-06-13 23:01:12.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"1d3dcf023e46b5ef7903b7846d2c3199fb026f04","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-06-13 21:26:41.000000000","message":"Uploaded patch set 1: Code-Review+1.","accounts_in_message":[],"_revision_number":1},{"id":"fd38d34db0a661d288c0160c35cfe9b1c237242b","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-06-13 23:01:12.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/16307/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/15517/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"9c766c15cb331706af9349ebf7b329e92dade979","author":{"_account_id":1001834,"name":"Christian Hoff","email":"christian.hoff@advantest.com","username":"chrihoff"},"real_author":{"_account_id":1001834,"name":"Christian Hoff","email":"christian.hoff@advantest.com","username":"chrihoff"},"date":"2022-06-14 09:26:22.000000000","message":"Patch Set 1: Code-Review-1\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"b76bfe34864cb49f525fdbcc9eefdac6653faef7","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-06-15 09:02:28.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"223603120d57a8b2f2223fdee781cffb5bdc6e38","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-06-15 09:05:18.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"9a81020451f7fd613440297441e5acd5328c3bbe","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-06-15 09:25:57.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/16311/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/15521/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"a7b9b299908bb43ffe7ef9421d540639b8225605","author":{"_account_id":1001834,"name":"Christian Hoff","email":"christian.hoff@advantest.com","username":"chrihoff"},"real_author":{"_account_id":1001834,"name":"Christian Hoff","email":"christian.hoff@advantest.com","username":"chrihoff"},"date":"2022-06-15 10:31:45.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"fd7306d19d19f6651b683a5611c3dbbeee277d89","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-06-24 21:49:18.000000000","message":"Patch Set 2: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"de88e57757d999aa54ea657d7d10839dd399e664","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-06-24 21:49:25.000000000","message":"Change has been successfully cherry-picked as e4f5ce5d3e342826794739a273b1f72a48d63540","accounts_in_message":[],"_revision_number":3}],"current_revision":"e4f5ce5d3e342826794739a273b1f72a48d63540","revisions":{"5813ca6d83d678b162a18c7fc442dbc89e6e8349":{"kind":"REWORK","_number":1,"created":"2022-06-13 21:26:41.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/34/7034/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/34/7034/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/34/7034/1 \u0026\u0026 git checkout -b change-7034 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/34/7034/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/34/7034/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/34/7034/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/34/7034/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/34/7034/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"480d4e17727864f75dc60e22cb1a42e022cb1db3","subject":"semihosting: fix accessing memory outside the bounds of the fn array"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-06-13 14:41:11.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-06-13 21:24:11.000000000","tz":120},"subject":"aarch64: fix handling of \u0027reset halt\u0027","message":"aarch64: fix handling of \u0027reset halt\u0027\n\nCommit 6c0151623cb0 (\"aarch64: add support for \"reset halt\"\")\nintroduces the register setting to halt at reset vector, but:\n- does not consider the case \u0027srst_pulls_trst\u0027 that makes useless\n  setting the registers as they will be erased by the pulled trst;\n- does not clean sticky errors in case of \u0027srst_gates_jtag\u0027.\n\nAvoid any register initialization on \u0027srst_pulls_trst\u0027 and move\nthe cleaning of sticky errors in the common block.\n\nChange-Id: I6f839f06f7b091e234ede31ec18096e51f017bcd\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nFixes: 6c0151623cb0 (\"aarch64: add support for \"reset halt\"\")\n"}},"8c6573bc5105a309ab8655b59c256edca2b0420d":{"kind":"REWORK","_number":2,"created":"2022-06-15 09:02:28.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/34/7034/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/34/7034/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/34/7034/2 \u0026\u0026 git checkout -b change-7034 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/34/7034/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/34/7034/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/34/7034/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/34/7034/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/34/7034/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"480d4e17727864f75dc60e22cb1a42e022cb1db3","subject":"semihosting: fix accessing memory outside the bounds of the fn array"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-06-13 14:41:11.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-06-15 08:05:43.000000000","tz":120},"subject":"aarch64: fix handling of \u0027reset halt\u0027","message":"aarch64: fix handling of \u0027reset halt\u0027\n\nCommit 6c0151623cb0 (\"aarch64: add support for \"reset halt\"\")\nintroduces the register setting to halt at reset vector, but:\n- does not consider the case \u0027srst_pulls_trst\u0027 that makes useless\n  setting the registers as they will be erased by the pulled trst;\n- does not clean sticky errors in case of \u0027srst_gates_jtag\u0027.\n\nAvoid any register initialization on \u0027srst_pulls_trst\u0027 and move\nthe cleaning of sticky errors in the common block.\n\nChange-Id: I6f839f06f7b091e234ede31ec18096e51f017bcd\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nFixes: 6c0151623cb0 (\"aarch64: add support for \"reset halt\"\")\n"}},"e4f5ce5d3e342826794739a273b1f72a48d63540":{"kind":"REWORK","_number":3,"created":"2022-06-24 21:49:25.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/34/7034/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/34/7034/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/34/7034/3 \u0026\u0026 git checkout -b change-7034 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/34/7034/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/34/7034/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/34/7034/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/34/7034/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/34/7034/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f23ac683430ffb08b511dd02afc93bc1f454a017","subject":"tcl/target/imx8m: use hwthread rtos"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-06-13 14:41:11.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-06-24 21:49:25.000000000","tz":0},"subject":"aarch64: fix handling of \u0027reset halt\u0027","message":"aarch64: fix handling of \u0027reset halt\u0027\n\nCommit 6c0151623cb0 (\"aarch64: add support for \"reset halt\"\")\nintroduces the register setting to halt at reset vector, but:\n- does not consider the case \u0027srst_pulls_trst\u0027 that makes useless\n  setting the registers as they will be erased by the pulled trst;\n- does not clean sticky errors in case of \u0027srst_gates_jtag\u0027.\n\nAvoid any register initialization on \u0027srst_pulls_trst\u0027 and move\nthe cleaning of sticky errors in the common block.\n\nChange-Id: I6f839f06f7b091e234ede31ec18096e51f017bcd\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nFixes: 6c0151623cb0 (\"aarch64: add support for \"reset halt\"\")\nReviewed-on: https://review.openocd.org/c/openocd/+/7034\nTested-by: jenkins\nReviewed-by: Christian Hoff \u003cchristian.hoff@advantest.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}