)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"f63befcce4f5465289fd03e94339673d338ebac7","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2022-06-18 16:23:00 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"configure: provide advice if PKG_PROG_PKG_CONFIG unavailable"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I21bcc7715eeac0f3d0bcc60bba6801e6a895cdd0"},{"line_number":10,"context_line":"Signed-off-by: R. Diez \u003crdiezmail-openocd@yahoo.de\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"d17c7416_8e2de7e3","line":8,"updated":"2022-06-18 17:22:55.000000000","message":"can you report the misleading error in the commit message?","commit_id":"846fd7784fcd37c1ce85beccb1665e9c929319a8"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"242a3dd82dc5dc0c3eae800232b895e4bcd0d6d8","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2022-06-18 16:23:00 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"configure: provide advice if PKG_PROG_PKG_CONFIG unavailable"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I21bcc7715eeac0f3d0bcc60bba6801e6a895cdd0"},{"line_number":10,"context_line":"Signed-off-by: R. Diez \u003crdiezmail-openocd@yahoo.de\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"0c341496_516b0d9a","line":8,"in_reply_to":"d17c7416_8e2de7e3","updated":"2022-06-18 20:24:06.000000000","message":"Done","commit_id":"846fd7784fcd37c1ce85beccb1665e9c929319a8"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"242a3dd82dc5dc0c3eae800232b895e4bcd0d6d8","unresolved":false,"context_lines":[{"line_number":7,"context_line":"configure: provide advice if PKG_PROG_PKG_CONFIG unavailable"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"These are the misleading error messages that this change prevents:"},{"line_number":10,"context_line":"configure.ac:13: error: possibly undefined macro: AC_MSG_WARN"},{"line_number":11,"context_line":"  If this token and others are legitimate, please use m4_pattern_allow."},{"line_number":12,"context_line":"  See the Autoconf documentation."},{"line_number":13,"context_line":"configure.ac:48: error: possibly undefined macro: AC_DEFINE"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"eed6869e_d4982663","line":10,"updated":"2022-06-18 20:24:06.000000000","message":"this is really odd, error in line 13 for a macro that has nothing to do with pkg-config. I was expecting a strange error at line 27 where PKG_PROG_PKG_CONFIG is used.","commit_id":"39c04ddb79265b45f5f6fc4016631be0c09de076"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"f63befcce4f5465289fd03e94339673d338ebac7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"75534110_549838a9","updated":"2022-06-18 17:22:55.000000000","message":"Thanks for the patch.\nI agree on it; I would like to get some minor modification","commit_id":"846fd7784fcd37c1ce85beccb1665e9c929319a8"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"242a3dd82dc5dc0c3eae800232b895e4bcd0d6d8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d6fe6469_08b55a3f","updated":"2022-06-18 20:24:06.000000000","message":"I\u0027m surprised by the error you have reported, but anyway looks ok. Thanks","commit_id":"39c04ddb79265b45f5f6fc4016631be0c09de076"}],"configure.ac":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"f63befcce4f5465289fd03e94339673d338ebac7","unresolved":true,"context_lines":[{"line_number":26,"context_line":"AC_PROG_RANLIB"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"# If macro PKG_PROG_PKG_CONFIG is not available, Autoconf generates a misleading error message,"},{"line_number":29,"context_line":"# so check for existance first, and otherwise provide helpful advice."},{"line_number":30,"context_line":"m4_ifndef([PKG_PROG_PKG_CONFIG], [m4_fatal([Macro PKG_PROG_PKG_CONFIG is not available. It is usually defined in file pkg.m4 provided by package pkg-config.])])"},{"line_number":31,"context_line":"PKG_PROG_PKG_CONFIG([0.23])"},{"line_number":32,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"03d01cef_590c40a7","line":29,"updated":"2022-06-18 17:22:55.000000000","message":"This long description is more valuable in the commit message. Here would be enough:\n# provide helpful advice on missing macro PKG_PROG_PKG_CONFIG","commit_id":"846fd7784fcd37c1ce85beccb1665e9c929319a8"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"242a3dd82dc5dc0c3eae800232b895e4bcd0d6d8","unresolved":false,"context_lines":[{"line_number":26,"context_line":"AC_PROG_RANLIB"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"# If macro PKG_PROG_PKG_CONFIG is not available, Autoconf generates a misleading error message,"},{"line_number":29,"context_line":"# so check for existance first, and otherwise provide helpful advice."},{"line_number":30,"context_line":"m4_ifndef([PKG_PROG_PKG_CONFIG], [m4_fatal([Macro PKG_PROG_PKG_CONFIG is not available. It is usually defined in file pkg.m4 provided by package pkg-config.])])"},{"line_number":31,"context_line":"PKG_PROG_PKG_CONFIG([0.23])"},{"line_number":32,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"8f61497a_2ffb381d","line":29,"in_reply_to":"03d01cef_590c40a7","updated":"2022-06-18 20:24:06.000000000","message":"Ack","commit_id":"846fd7784fcd37c1ce85beccb1665e9c929319a8"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"f63befcce4f5465289fd03e94339673d338ebac7","unresolved":true,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"# If macro PKG_PROG_PKG_CONFIG is not available, Autoconf generates a misleading error message,"},{"line_number":29,"context_line":"# so check for existance first, and otherwise provide helpful advice."},{"line_number":30,"context_line":"m4_ifndef([PKG_PROG_PKG_CONFIG], [m4_fatal([Macro PKG_PROG_PKG_CONFIG is not available. It is usually defined in file pkg.m4 provided by package pkg-config.])])"},{"line_number":31,"context_line":"PKG_PROG_PKG_CONFIG([0.23])"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"dnl disable checks for C++, Fortran and GNU Java Compiler"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"291bfc11_0cc6d3d4","line":30,"updated":"2022-06-18 17:22:55.000000000","message":"split the line to stay in max 120 char. Shorter msg could help. e.g.\n m4_ifndef([PKG_PROG_PKG_CONFIG], [m4_fatal(\n    [Macro PKG_PROG_PKG_CONFIG not available. Package pkg-config not installed?]\n )])","commit_id":"846fd7784fcd37c1ce85beccb1665e9c929319a8"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"242a3dd82dc5dc0c3eae800232b895e4bcd0d6d8","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"# If macro PKG_PROG_PKG_CONFIG is not available, Autoconf generates a misleading error message,"},{"line_number":29,"context_line":"# so check for existance first, and otherwise provide helpful advice."},{"line_number":30,"context_line":"m4_ifndef([PKG_PROG_PKG_CONFIG], [m4_fatal([Macro PKG_PROG_PKG_CONFIG is not available. It is usually defined in file pkg.m4 provided by package pkg-config.])])"},{"line_number":31,"context_line":"PKG_PROG_PKG_CONFIG([0.23])"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"dnl disable checks for C++, Fortran and GNU Java Compiler"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"23cdec60_0e661e6b","line":30,"in_reply_to":"291bfc11_0cc6d3d4","updated":"2022-06-18 20:24:06.000000000","message":"Done","commit_id":"846fd7784fcd37c1ce85beccb1665e9c929319a8"}]}