)]}'
{"id":"openocd~master~I21bcc7715eeac0f3d0bcc60bba6801e6a895cdd0","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000438":{"account":{"_account_id":1000438,"name":"R. Diez","email":"rdiez-2006@rd10.de","username":"rdiez"},"last_update":"2022-07-02 08:23:13.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I21bcc7715eeac0f3d0bcc60bba6801e6a895cdd0","subject":"configure: provide advice if PKG_PROG_PKG_CONFIG unavailable","status":"MERGED","created":"2022-06-18 14:23:31.000000000","updated":"2022-07-02 08:23:13.000000000","submitted":"2022-07-02 08:23:13.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":9,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7035","meta_rev_id":"d18ef04031a00554e9f47e1f8f32f1c0365c3929","_number":7035,"owner":{"_account_id":1000438,"name":"R. Diez","email":"rdiez-2006@rd10.de","username":"rdiez"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-07-02 08:23:13.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-07-02 08:23:13.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-06-18 14:59:20.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-06-18 17:22:55.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"CC"},{"updated":"2022-06-18 20:24:06.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"b883433b42362ea6e028e62dbffb81c62f811d36","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000438,"name":"R. Diez","email":"rdiez-2006@rd10.de","username":"rdiez"},"real_author":{"_account_id":1000438,"name":"R. Diez","email":"rdiez-2006@rd10.de","username":"rdiez"},"date":"2022-06-18 14:23:31.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"0c80f45d34c4276cfe264760e894035acb0c5a43","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-06-18 14:59:20.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/16325/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/15535/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"f63befcce4f5465289fd03e94339673d338ebac7","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-06-18 17:22:55.000000000","message":"Patch Set 1:\n\n(4 comments)","accounts_in_message":[],"_revision_number":1},{"id":"7a37ed185e611ca10f9c5493b80d49fc5807a3d2","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000438,"name":"R. Diez","email":"rdiez-2006@rd10.de","username":"rdiez"},"real_author":{"_account_id":1000438,"name":"R. Diez","email":"rdiez-2006@rd10.de","username":"rdiez"},"date":"2022-06-18 18:37:16.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"f6b8e91a914938aef59f6a095514cb21b8fd05ea","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-06-18 19:03:16.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/16326/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/15536/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"242a3dd82dc5dc0c3eae800232b895e4bcd0d6d8","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-06-18 20:24:06.000000000","message":"Patch Set 2: Code-Review+1\n\n(5 comments)","accounts_in_message":[],"_revision_number":2},{"id":"87f9eb59dd0ea445f4d12eff66a3d540f3586ce1","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-07-02 08:22:53.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"d18ef04031a00554e9f47e1f8f32f1c0365c3929","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-07-02 08:23:13.000000000","message":"Change has been successfully cherry-picked as c7bdce33e2edd3b9d6d0eb85d38e7cac8e0a4e6e","accounts_in_message":[],"_revision_number":3}],"current_revision":"c7bdce33e2edd3b9d6d0eb85d38e7cac8e0a4e6e","revisions":{"846fd7784fcd37c1ce85beccb1665e9c929319a8":{"kind":"REWORK","_number":1,"created":"2022-06-18 14:23:31.000000000","uploader":{"_account_id":1000438,"name":"R. Diez","email":"rdiez-2006@rd10.de","username":"rdiez"},"ref":"refs/changes/35/7035/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/35/7035/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/35/7035/1 \u0026\u0026 git checkout -b change-7035 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/35/7035/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/35/7035/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/35/7035/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/35/7035/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/35/7035/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"480d4e17727864f75dc60e22cb1a42e022cb1db3","subject":"semihosting: fix accessing memory outside the bounds of the fn array"}],"author":{"name":"R. Diez","email":"rdiezmail-openocd@yahoo.de","date":"2022-06-18 14:23:00.000000000","tz":120},"committer":{"name":"R. Diez","email":"rdiezmail-openocd@yahoo.de","date":"2022-06-18 14:23:00.000000000","tz":120},"subject":"configure: provide advice if PKG_PROG_PKG_CONFIG unavailable","message":"configure: provide advice if PKG_PROG_PKG_CONFIG unavailable\n\nChange-Id: I21bcc7715eeac0f3d0bcc60bba6801e6a895cdd0\nSigned-off-by: R. Diez \u003crdiezmail-openocd@yahoo.de\u003e\n"}},"39c04ddb79265b45f5f6fc4016631be0c09de076":{"kind":"REWORK","_number":2,"created":"2022-06-18 18:37:16.000000000","uploader":{"_account_id":1000438,"name":"R. Diez","email":"rdiez-2006@rd10.de","username":"rdiez"},"ref":"refs/changes/35/7035/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/35/7035/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/35/7035/2 \u0026\u0026 git checkout -b change-7035 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/35/7035/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/35/7035/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/35/7035/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/35/7035/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/35/7035/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"480d4e17727864f75dc60e22cb1a42e022cb1db3","subject":"semihosting: fix accessing memory outside the bounds of the fn array"}],"author":{"name":"R. Diez","email":"rdiezmail-openocd@yahoo.de","date":"2022-06-18 14:23:00.000000000","tz":120},"committer":{"name":"R. Diez","email":"rdiezmail-openocd@yahoo.de","date":"2022-06-18 18:34:13.000000000","tz":120},"subject":"configure: provide advice if PKG_PROG_PKG_CONFIG unavailable","message":"configure: provide advice if PKG_PROG_PKG_CONFIG unavailable\n\nThese are the misleading error messages that this change prevents:\nconfigure.ac:13: error: possibly undefined macro: AC_MSG_WARN\n  If this token and others are legitimate, please use m4_pattern_allow.\n  See the Autoconf documentation.\nconfigure.ac:48: error: possibly undefined macro: AC_DEFINE\nconfigure.ac:342: error: possibly undefined macro: AC_MSG_ERROR\nconfigure.ac:608: error: possibly undefined macro: AC_MSG_NOTICE\n\nChange-Id: I21bcc7715eeac0f3d0bcc60bba6801e6a895cdd0\nSigned-off-by: R. Diez \u003crdiezmail-openocd@yahoo.de\u003e\n"}},"c7bdce33e2edd3b9d6d0eb85d38e7cac8e0a4e6e":{"kind":"REWORK","_number":3,"created":"2022-07-02 08:23:13.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/35/7035/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/35/7035/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/35/7035/3 \u0026\u0026 git checkout -b change-7035 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/35/7035/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/35/7035/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/35/7035/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/35/7035/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/35/7035/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a70bab9e5185c8853882748737ceebabde7c4781","subject":"helper: fix build with mingw gcc 12.1.0"}],"author":{"name":"R. Diez","email":"rdiezmail-openocd@yahoo.de","date":"2022-06-18 14:23:00.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-07-02 08:23:13.000000000","tz":0},"subject":"configure: provide advice if PKG_PROG_PKG_CONFIG unavailable","message":"configure: provide advice if PKG_PROG_PKG_CONFIG unavailable\n\nThese are the misleading error messages that this change prevents:\nconfigure.ac:13: error: possibly undefined macro: AC_MSG_WARN\n  If this token and others are legitimate, please use m4_pattern_allow.\n  See the Autoconf documentation.\nconfigure.ac:48: error: possibly undefined macro: AC_DEFINE\nconfigure.ac:342: error: possibly undefined macro: AC_MSG_ERROR\nconfigure.ac:608: error: possibly undefined macro: AC_MSG_NOTICE\n\nChange-Id: I21bcc7715eeac0f3d0bcc60bba6801e6a895cdd0\nSigned-off-by: R. Diez \u003crdiezmail-openocd@yahoo.de\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/7035\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}