)]}'
{"id":"openocd~master~I2f239d98fca6882c4361691af306a5652b58ee78","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2022-07-02 08:24:22.000000000","reason":"removed on reply"},"1001964":{"account":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"last_update":"2022-07-02 08:24:28.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I2f239d98fca6882c4361691af306a5652b58ee78","subject":"tcl/esp32s2: check memory protection on gdb attach","status":"MERGED","created":"2022-06-18 21:19:27.000000000","updated":"2022-07-02 08:24:28.000000000","submitted":"2022-07-02 08:24:28.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":5,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7036","meta_rev_id":"372a4390882ecaca6d6b833f2b0a7d89c9563cdf","_number":7036,"owner":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-07-02 08:24:28.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-07-02 08:24:28.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-06-18 21:55:33.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-06-19 17:08:03.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"CC"},{"updated":"2022-06-19 17:09:51.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"af00f447e0a605e7805b5840a03427805bc7c521","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"real_author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"date":"2022-06-18 21:19:27.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"23213bf6e3ddbbfd48ffd79656db6a0336846c3e","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-06-18 21:55:33.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/16327/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/15537/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"2eb2f7e6416cec0c6d5993ba94d05a69442a6b07","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"real_author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"date":"2022-06-18 21:56:12.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"c4d8687dda976e96ba6bb20f50cf78487dd9d38a","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-06-18 22:36:36.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/16329/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/15539/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"a06e67ff86665c47e411b70bb1791fe2eb1d2dfd","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-06-19 17:08:03.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"5aad936422b6f67d86d824aea799b061238d69ab","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-06-19 17:09:51.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"725d263a797abdde772bb433c911fb3797519e22","author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"real_author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"date":"2022-06-20 08:47:52.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"5b71cd146eddae10ad720baec494b1af0b586506","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-06-20 09:04:51.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"a068928a320054723610bcd86668a3c361b4e016","author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"real_author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"date":"2022-06-20 09:37:13.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"5c5bdd09ad8a535c9238f4c45e396cf350d60e96","author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"real_author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"date":"2022-06-20 10:05:05.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"f17bdb2311ab2d548c7fa5901e1b01793bb68b2c","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-07-02 08:24:22.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"372a4390882ecaca6d6b833f2b0a7d89c9563cdf","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-07-02 08:24:28.000000000","message":"Change has been successfully cherry-picked as c1ef4e52079c4aaf7aec2cda7bec46406bc8bbac","accounts_in_message":[],"_revision_number":3}],"current_revision":"c1ef4e52079c4aaf7aec2cda7bec46406bc8bbac","revisions":{"0e65dd0d6bd439dd9e66f565ee86984d88cda4dc":{"kind":"REWORK","_number":1,"created":"2022-06-18 21:19:27.000000000","uploader":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"ref":"refs/changes/36/7036/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/36/7036/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/36/7036/1 \u0026\u0026 git checkout -b change-7036 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/36/7036/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/36/7036/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/36/7036/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/36/7036/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/36/7036/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"480d4e17727864f75dc60e22cb1a42e022cb1db3","subject":"semihosting: fix accessing memory outside the bounds of the fn array"}],"author":{"name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","date":"2022-06-18 21:01:28.000000000","tz":120},"committer":{"name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","date":"2022-06-18 21:01:28.000000000","tz":120},"subject":"tcl/esp32s2: check memory protection on gdb attach","message":"tcl/esp32s2: check memory protection on gdb attach\n\nMemory protection must be disabled to allow stub flasher\noperate correctly.\n\nSigned-off-by: Erhan Kurubas \u003cerhan.kurubas@espressif.com\u003e\nChange-Id: I2f239d98fca6882c4361691af306a5652b58ee78\n"}},"c1ef4e52079c4aaf7aec2cda7bec46406bc8bbac":{"kind":"REWORK","_number":3,"created":"2022-07-02 08:24:28.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/36/7036/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/36/7036/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/36/7036/3 \u0026\u0026 git checkout -b change-7036 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/36/7036/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/36/7036/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/36/7036/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/36/7036/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/36/7036/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3d61a9593e9f61e37dacff27c5dafc1fd452873d","subject":"jtag: add esp_usb_jtag driver"}],"author":{"name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","date":"2022-06-18 21:01:28.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-07-02 08:24:28.000000000","tz":0},"subject":"tcl/esp32s2: check memory protection on gdb attach","message":"tcl/esp32s2: check memory protection on gdb attach\n\nMemory protection must be disabled to allow stub flasher\noperate correctly.\n\nSigned-off-by: Erhan Kurubas \u003cerhan.kurubas@espressif.com\u003e\nChange-Id: I2f239d98fca6882c4361691af306a5652b58ee78\nReviewed-on: https://review.openocd.org/c/openocd/+/7036\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"01331e09b67e10b7530addd6996d1daed9aa8b17":{"kind":"REWORK","_number":2,"created":"2022-06-18 21:56:12.000000000","uploader":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"ref":"refs/changes/36/7036/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/36/7036/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/36/7036/2 \u0026\u0026 git checkout -b change-7036 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/36/7036/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/36/7036/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/36/7036/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/36/7036/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/36/7036/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"480d4e17727864f75dc60e22cb1a42e022cb1db3","subject":"semihosting: fix accessing memory outside the bounds of the fn array"}],"author":{"name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","date":"2022-06-18 21:01:28.000000000","tz":120},"committer":{"name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","date":"2022-06-18 21:49:58.000000000","tz":120},"subject":"tcl/esp32s2: check memory protection on gdb attach","message":"tcl/esp32s2: check memory protection on gdb attach\n\nMemory protection must be disabled to allow stub flasher\noperate correctly.\n\nSigned-off-by: Erhan Kurubas \u003cerhan.kurubas@espressif.com\u003e\nChange-Id: I2f239d98fca6882c4361691af306a5652b58ee78\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}