)]}'
{"id":"openocd~master~I6f292ee672ae001cd6e4df5d24eb7bb862639093","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1001964":{"account":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"last_update":"2022-07-02 08:25:00.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I6f292ee672ae001cd6e4df5d24eb7bb862639093","subject":"tcl/esp32s3: check memory protection on gdb attach","status":"MERGED","created":"2022-06-18 21:21:17.000000000","updated":"2022-07-02 08:25:00.000000000","submitted":"2022-07-02 08:25:00.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7037","meta_rev_id":"1f42fae4992da3c1b84a6739a14e661cda6d39de","_number":7037,"owner":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-07-02 08:25:00.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-07-02 08:25:00.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-06-18 22:00:19.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-06-19 17:09:20.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"cba6f3aaad12d2380e2bc7fb464a70445dfe42d5","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"real_author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"date":"2022-06-18 21:21:17.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"56f94f93d1ebf0d63163a70b616483e3dc711295","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"real_author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"date":"2022-06-18 21:59:47.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"484bac1f04ecf63ce4e54432b380fbf95f10758f","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-06-18 22:00:19.000000000","message":"Patch Set 1: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit-build/15538/ : ABORTED\n\nhttps://build.openocd.org/job/openocd-gerrit/16328/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"904c8970fe4735f158c99150921fb60fc0cbd2d3","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-06-18 22:55:31.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/16330/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/15540/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"10df538266675304c960ac6c3b1f080d1537aa33","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-06-19 17:09:20.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"b94a8bb04b4b1d8f566e9261f7705a1ee8a547d5","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-07-02 08:24:54.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"1f42fae4992da3c1b84a6739a14e661cda6d39de","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-07-02 08:25:00.000000000","message":"Change has been successfully cherry-picked as 6eda28ef67ba183f75ce0013828fd0e5e47eb83a","accounts_in_message":[],"_revision_number":3}],"current_revision":"6eda28ef67ba183f75ce0013828fd0e5e47eb83a","revisions":{"6eda28ef67ba183f75ce0013828fd0e5e47eb83a":{"kind":"REWORK","_number":3,"created":"2022-07-02 08:25:00.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/37/7037/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/37/7037/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/37/7037/3 \u0026\u0026 git checkout -b change-7037 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/37/7037/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/37/7037/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/37/7037/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/37/7037/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/37/7037/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"c1ef4e52079c4aaf7aec2cda7bec46406bc8bbac","subject":"tcl/esp32s2: check memory protection on gdb attach"}],"author":{"name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","date":"2022-06-18 21:16:37.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-07-02 08:25:00.000000000","tz":0},"subject":"tcl/esp32s3: check memory protection on gdb attach","message":"tcl/esp32s3: check memory protection on gdb attach\n\nMemory protection must be disabled to allow stub flasher\noperate correctly.\n\nSigned-off-by: Erhan Kurubas \u003cerhan.kurubas@espressif.com\u003e\nChange-Id: I6f292ee672ae001cd6e4df5d24eb7bb862639093\nReviewed-on: https://review.openocd.org/c/openocd/+/7037\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"823e50a9b127460323537125bf23feb685fbdaf2":{"kind":"REWORK","_number":2,"created":"2022-06-18 21:59:47.000000000","uploader":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"ref":"refs/changes/37/7037/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/37/7037/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/37/7037/2 \u0026\u0026 git checkout -b change-7037 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/37/7037/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/37/7037/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/37/7037/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/37/7037/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/37/7037/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"5e8c119a6fa153e32d143ce83ff25a3cbecf815d","subject":"target: add Espressif ESP32-S3 basic support"}],"author":{"name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","date":"2022-06-18 21:16:37.000000000","tz":120},"committer":{"name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","date":"2022-06-18 21:59:40.000000000","tz":120},"subject":"tcl/esp32s3: check memory protection on gdb attach","message":"tcl/esp32s3: check memory protection on gdb attach\n\nMemory protection must be disabled to allow stub flasher\noperate correctly.\n\nSigned-off-by: Erhan Kurubas \u003cerhan.kurubas@espressif.com\u003e\nChange-Id: I6f292ee672ae001cd6e4df5d24eb7bb862639093\n"}},"831a00cd64aad3e188341792919102ac49241b80":{"kind":"REWORK","_number":1,"created":"2022-06-18 21:21:17.000000000","uploader":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"ref":"refs/changes/37/7037/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/37/7037/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/37/7037/1 \u0026\u0026 git checkout -b change-7037 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/37/7037/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/37/7037/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/37/7037/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/37/7037/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/37/7037/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"5e8c119a6fa153e32d143ce83ff25a3cbecf815d","subject":"target: add Espressif ESP32-S3 basic support"}],"author":{"name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","date":"2022-06-18 21:16:37.000000000","tz":120},"committer":{"name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","date":"2022-06-18 21:19:56.000000000","tz":120},"subject":"tcl/esp32s3: check memory protection on gdb attach","message":"tcl/esp32s3: check memory protection on gdb attach\n\nMemory protection must be disabled to allow stub flasher\noperate correctly.\n\nSigned-off-by: Erhan Kurubas \u003cerhan.kurubas@espressif.com\u003e\nChange-Id: I6f292ee672ae001cd6e4df5d24eb7bb862639093\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}