)]}'
{"id":"openocd~master~I4a43a03c007c9f0d5c4cee962a9f7cc83ca49637","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2022-06-20 20:35:42.000000000","reason":"Antonio Borneo replied on the change"},"1001918":{"account":{"_account_id":1001918,"name":"Dietmar May","email":"dietmar.may@outlook.com","username":"dmay"},"last_update":"2022-06-24 21:54:46.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I4a43a03c007c9f0d5c4cee962a9f7cc83ca49637","subject":"helper: fix build with mingw gcc 12.1.0","status":"MERGED","created":"2022-06-19 20:22:44.000000000","updated":"2022-06-24 21:54:46.000000000","submitted":"2022-06-24 21:54:46.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7038","meta_rev_id":"70faccf5fbbdfe8ed32fc69f4daf806374f42f70","_number":7038,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-06-24 21:54:46.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"value":0,"_account_id":1001918,"name":"Dietmar May","email":"dietmar.may@outlook.com","username":"dmay"}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-06-24 21:54:46.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-06-24 21:54:46.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1001918,"name":"Dietmar May","email":"dietmar.may@outlook.com","username":"dmay"}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1001918,"name":"Dietmar May","email":"dietmar.may@outlook.com","username":"dmay"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-06-19 20:22:44.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1001918,"name":"Dietmar May","email":"dietmar.may@outlook.com","username":"dmay"},"state":"REVIEWER"},{"updated":"2022-06-19 20:53:37.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"e32dc9ec9ddbd698daec6896bebff438d12cd12e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-06-19 20:22:44.000000000","message":"Uploaded patch set 1: Code-Review+1.","accounts_in_message":[],"_revision_number":1},{"id":"f0e7032db7b05662c54c8c5c3243c95aac96e1b4","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-06-19 20:53:37.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/16332/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/15542/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"6878d7b19a3b30ff300eb4f5aa533ef48f61364c","author":{"_account_id":1001918,"name":"Dietmar May","email":"dietmar.may@outlook.com","username":"dmay"},"real_author":{"_account_id":1001918,"name":"Dietmar May","email":"dietmar.may@outlook.com","username":"dmay"},"date":"2022-06-20 11:02:07.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"30a71d13a4fa269a3dbe8ffa7b3ded89b408627e","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-06-20 20:35:42.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"0f6bb9b18ccda2f5e4b351d90bed169d86b94abd","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-06-24 21:54:42.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"70faccf5fbbdfe8ed32fc69f4daf806374f42f70","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-06-24 21:54:46.000000000","message":"Change has been successfully cherry-picked as a70bab9e5185c8853882748737ceebabde7c4781","accounts_in_message":[],"_revision_number":2}],"current_revision":"a70bab9e5185c8853882748737ceebabde7c4781","revisions":{"32348220eea3aec24e9bece61d333cb9e3009246":{"kind":"REWORK","_number":1,"created":"2022-06-19 20:22:44.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/38/7038/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/38/7038/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/38/7038/1 \u0026\u0026 git checkout -b change-7038 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/38/7038/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/38/7038/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/38/7038/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/38/7038/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/38/7038/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"480d4e17727864f75dc60e22cb1a42e022cb1db3","subject":"semihosting: fix accessing memory outside the bounds of the fn array"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-06-19 20:10:47.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-06-19 20:10:47.000000000","tz":120},"subject":"helper: fix build with mingw gcc 12.1.0","message":"helper: fix build with mingw gcc 12.1.0\n\nNew mingw compiler correctly complains for using a freed memory\narea:\n\n\tsrc/helper/configuration.c: In function \u0027get_home_dir\u0027:\n\tsrc/helper/configuration.c:182:29: error: dangling pointer \u0027home\u0027\n\t\tto \u0027homepath\u0027 may be used [-Werror\u003ddangling-pointer\u003d]\n\t182 | home_path \u003d alloc_printf(\"%s/%s\", home, append_path);\n\t    |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n\nIn fact the variable \u0027homepath\u0027 is declared inside an \u0027if\u0027 branch\nand is not available outside.\n\nMove the declaration of \u0027homepath\u0027 to have it available in a wider\ncontext.\n\nChange-Id: I4a43a03c007c9f0d5c4cee962a9f7cc83ca49637\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReported-by: Dietmar May \u003cdietmar.may@outlook.com\u003e\n"}},"a70bab9e5185c8853882748737ceebabde7c4781":{"kind":"REWORK","_number":2,"created":"2022-06-24 21:54:46.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/38/7038/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/38/7038/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/38/7038/2 \u0026\u0026 git checkout -b change-7038 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/38/7038/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/38/7038/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/38/7038/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/38/7038/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/38/7038/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"573a39b36cf133bb7403b12337301a5616112f1a","subject":"tcl: add SPDX tag"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-06-19 20:10:47.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-06-24 21:54:46.000000000","tz":0},"subject":"helper: fix build with mingw gcc 12.1.0","message":"helper: fix build with mingw gcc 12.1.0\n\nNew mingw compiler correctly complains for using a freed memory\narea:\n\n\tsrc/helper/configuration.c: In function \u0027get_home_dir\u0027:\n\tsrc/helper/configuration.c:182:29: error: dangling pointer \u0027home\u0027\n\t\tto \u0027homepath\u0027 may be used [-Werror\u003ddangling-pointer\u003d]\n\t182 | home_path \u003d alloc_printf(\"%s/%s\", home, append_path);\n\t    |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n\nIn fact the variable \u0027homepath\u0027 is declared inside an \u0027if\u0027 branch\nand is not available outside.\n\nMove the declaration of \u0027homepath\u0027 to have it available in a wider\ncontext.\n\nChange-Id: I4a43a03c007c9f0d5c4cee962a9f7cc83ca49637\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReported-by: Dietmar May \u003cdietmar.may@outlook.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/7038\nTested-by: jenkins\nReviewed-by: Dietmar May \u003cdietmar.may@outlook.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}