)]}'
{"id":"openocd~master~I8f63749cc203c59b07862f33edf3c393cd7e33a9","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2022-06-20 20:48:12.000000000","reason":"Antonio Borneo replied on the change"},"1001242":{"account":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"last_update":"2022-06-20 15:06:55.000000000","reason":"Tim Newsome replied on the change"},"1001964":{"account":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"last_update":"2022-07-02 08:27:12.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I8f63749cc203c59b07862f33edf3c393cd7e33a9","subject":"semihosting: move semihosting_result_t from riscv.h to the semihosting_common.h","status":"MERGED","created":"2022-06-20 13:43:33.000000000","updated":"2022-07-02 08:27:12.000000000","submitted":"2022-07-02 08:27:12.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7039","meta_rev_id":"0e6157fa933dad9c1dc20ca5edb5a24b974b81ab","_number":7039,"owner":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-07-02 08:27:12.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-07-02 08:27:12.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-06-20 13:44:11.000000000","updated_by":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"reviewer":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"state":"REVIEWER"},{"updated":"2022-06-20 13:44:11.000000000","updated_by":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"},{"updated":"2022-06-20 14:11:52.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"cae7316d86f394d203d601e31dd8b5fad135ba16","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"real_author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"date":"2022-06-20 13:43:33.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"89fb509a4c307bf398354582dcf04fba4e40b647","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-06-20 14:11:52.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/16336/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/15546/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"51d619fcae9d91a8ea0f4c562c2a57a138ff01a5","author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"real_author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"date":"2022-06-20 15:06:55.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"15f2c18db22dfe0ab56ae5b27ec349fa358651f1","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-06-20 20:48:12.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"4886b13db85895cdf314f4c398f45a1e68012190","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"real_author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"date":"2022-06-30 19:11:07.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"f32219536e6303a21165f78678cb4ace560d725f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"real_author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"date":"2022-06-30 19:14:43.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.","accounts_in_message":[],"_revision_number":3},{"id":"fbe10e29189086320f2f6417719fc801e8841149","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-06-30 19:14:52.000000000","message":"Patch Set 2: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit-build/15604/ : ABORTED","accounts_in_message":[],"_revision_number":2},{"id":"bcbd70e876c3c2ae942b0f85884d613a48116f11","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-06-30 19:58:43.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/15606/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/16397/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"8ed872f9dcd898751ab83402351a52a22eabcb8e","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-07-02 08:27:07.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"0e6157fa933dad9c1dc20ca5edb5a24b974b81ab","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-07-02 08:27:12.000000000","message":"Change has been successfully cherry-picked as 06c3240155ccbb22b2db5782ffedf1e0c544b073","accounts_in_message":[],"_revision_number":4}],"current_revision":"06c3240155ccbb22b2db5782ffedf1e0c544b073","revisions":{"fa095684eab67f19b10843f27666ed4ac92bc7b6":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2022-06-30 19:14:43.000000000","uploader":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"ref":"refs/changes/39/7039/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/39/7039/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/39/7039/3 \u0026\u0026 git checkout -b change-7039 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/39/7039/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/39/7039/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/39/7039/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/39/7039/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/39/7039/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a70bab9e5185c8853882748737ceebabde7c4781","subject":"helper: fix build with mingw gcc 12.1.0"}],"author":{"name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","date":"2022-06-20 13:34:10.000000000","tz":120},"committer":{"name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","date":"2022-06-30 19:14:28.000000000","tz":180},"subject":"semihosting: move semihosting_result_t from riscv.h to the semihosting_common.h","message":"semihosting: move semihosting_result_t from riscv.h to the semihosting_common.h\n\nThese enum values are useful for the arch level semihosting call handlers.\nCurrently riscv uses them, we also need similar return codes for the xtensa.\n\nSigned-off-by: Erhan Kurubas \u003cerhan.kurubas@espressif.com\u003e\nChange-Id: I8f63749cc203c59b07862f33edf3c393cd7e33a9\n"}},"cbca697b756b3981b3282e94a83b94d3be57dc72":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2022-06-30 19:11:07.000000000","uploader":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"ref":"refs/changes/39/7039/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/39/7039/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/39/7039/2 \u0026\u0026 git checkout -b change-7039 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/39/7039/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/39/7039/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/39/7039/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/39/7039/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/39/7039/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3e7b1a05759168a3d43778662895c9ab0f2ee60e","subject":"target: add generic Xtensa LX support"}],"author":{"name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","date":"2022-06-20 13:34:10.000000000","tz":120},"committer":{"name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","date":"2022-06-30 08:25:01.000000000","tz":180},"subject":"semihosting: move semihosting_result_t from riscv.h to the semihosting_common.h","message":"semihosting: move semihosting_result_t from riscv.h to the semihosting_common.h\n\nThese enum values are useful for the arch level semihosting call handlers.\nCurrently riscv uses them, we also need similar return codes for the xtensa.\n\nSigned-off-by: Erhan Kurubas \u003cerhan.kurubas@espressif.com\u003e\nChange-Id: I8f63749cc203c59b07862f33edf3c393cd7e33a9\n"}},"d04307539387d9cc5fd9cd26fceb0297583d9865":{"kind":"REWORK","_number":1,"created":"2022-06-20 13:43:33.000000000","uploader":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"ref":"refs/changes/39/7039/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/39/7039/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/39/7039/1 \u0026\u0026 git checkout -b change-7039 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/39/7039/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/39/7039/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/39/7039/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/39/7039/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/39/7039/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"480d4e17727864f75dc60e22cb1a42e022cb1db3","subject":"semihosting: fix accessing memory outside the bounds of the fn array"}],"author":{"name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","date":"2022-06-20 13:34:10.000000000","tz":120},"committer":{"name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","date":"2022-06-20 13:34:10.000000000","tz":120},"subject":"semihosting: move semihosting_result_t from riscv.h to the semihosting_common.h","message":"semihosting: move semihosting_result_t from riscv.h to the semihosting_common.h\n\nThese enum values are useful for the arch level semihosting call handlers.\nCurrently riscv uses them, we also need similar return codes for the xtensa.\n\nSigned-off-by: Erhan Kurubas \u003cerhan.kurubas@espressif.com\u003e\nChange-Id: I8f63749cc203c59b07862f33edf3c393cd7e33a9\n"}},"06c3240155ccbb22b2db5782ffedf1e0c544b073":{"kind":"REWORK","_number":4,"created":"2022-07-02 08:27:12.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/39/7039/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/39/7039/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/39/7039/4 \u0026\u0026 git checkout -b change-7039 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/39/7039/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/39/7039/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/39/7039/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/39/7039/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/39/7039/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"6eda28ef67ba183f75ce0013828fd0e5e47eb83a","subject":"tcl/esp32s3: check memory protection on gdb attach"}],"author":{"name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","date":"2022-06-20 13:34:10.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-07-02 08:27:12.000000000","tz":0},"subject":"semihosting: move semihosting_result_t from riscv.h to the semihosting_common.h","message":"semihosting: move semihosting_result_t from riscv.h to the semihosting_common.h\n\nThese enum values are useful for the arch level semihosting call handlers.\nCurrently riscv uses them, we also need similar return codes for the xtensa.\n\nSigned-off-by: Erhan Kurubas \u003cerhan.kurubas@espressif.com\u003e\nChange-Id: I8f63749cc203c59b07862f33edf3c393cd7e33a9\nReviewed-on: https://review.openocd.org/c/openocd/+/7039\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}