)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"bef3c9fab8f552ca2ff948615f12429e77c5c51e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ae06d1f0_287479e0","updated":"2022-06-22 11:31:19.000000000","message":"Looks good, thanks.\nOnly one comment regarding the license, and one for an optional feature","commit_id":"d12418d65f401fd554fea750e10b45572e68bbbf"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"c6cafc7d320f57692682c4c80ba3beffee88b98f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f18fba62_74d08f6d","updated":"2022-06-25 17:03:41.000000000","message":"Thanks!","commit_id":"fd5dac4240e6317b0745a5cbaa85b343bfefb041"},{"author":{"_account_id":1001945,"name":"Adrien Grassein","email":"adrien.grassein@gmail.com","username":"grassead"},"change_message_id":"324022d32efd95acb66b0593ced9da357d6e1ca1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"43020944_cc9a3182","in_reply_to":"f18fba62_74d08f6d","updated":"2022-06-25 17:22:02.000000000","message":"Thanks too.","commit_id":"fd5dac4240e6317b0745a5cbaa85b343bfefb041"}],"tcl/target/ngultra.cfg":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"bef3c9fab8f552ca2ff948615f12429e77c5c51e","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# configuration file for NG-Ultra SoC from NanoXplore."},{"line_number":3,"context_line":"# NG-Ultra is a quad-core Cortex-R52 SoC + an FPGA."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"db6579ed_5ccbd1ac","line":1,"updated":"2022-06-22 11:31:19.000000000","message":"please add as very first line\n# SPDX-License-Identifier: GPL-2.0-or-later","commit_id":"d12418d65f401fd554fea750e10b45572e68bbbf"},{"author":{"_account_id":1001945,"name":"Adrien Grassein","email":"adrien.grassein@gmail.com","username":"grassead"},"change_message_id":"e9d777e577cdaf02597a371f9aa301bbaf999812","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# configuration file for NG-Ultra SoC from NanoXplore."},{"line_number":3,"context_line":"# NG-Ultra is a quad-core Cortex-R52 SoC + an FPGA."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"c281ba89_13e6cbde","line":1,"in_reply_to":"06e907ee_42cf9994","updated":"2022-06-23 07:45:12.000000000","message":"Done","commit_id":"d12418d65f401fd554fea750e10b45572e68bbbf"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"f5269f82761c6660b79282b6f1d7f1424e154efb","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# configuration file for NG-Ultra SoC from NanoXplore."},{"line_number":3,"context_line":"# NG-Ultra is a quad-core Cortex-R52 SoC + an FPGA."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"b869018a_cfeca054","line":1,"in_reply_to":"4d05d15a_e4d1efcb","updated":"2022-06-22 13:32:04.000000000","message":"No problem for BSD; in such case one of\n# SPDX-License-Identifier: BSD-1-Clause\n# SPDX-License-Identifier: BSD-2-Clause\n# SPDX-License-Identifier: BSD-3-Clause\nshould work. I think BDS requires also a copyright line, because the license text explicitly mention the copyright owner, that should then be identified. Adding\n# (C) 2022 Adrien Grassein \u003cagrassein@nanoxplore.com\u003e\nand/or\n# (C) 2022 company name\nis enough.\n\nWith Apache 2 is a little more complex because it\u0027s incompatible with GPL-v2.\nHere we are talking about a script that is not \"linked\" inside a GPL binary, so probably Apache 2 is still ok, but could create some headache packaging all together.\nIf BSD works for you, I would prefer it.\n\nFor my curiosity, what makes you avoid GPL?\nAll other files in OpenOCD src folder are under GPL. Will this prevent you to contribute to the code?","commit_id":"d12418d65f401fd554fea750e10b45572e68bbbf"},{"author":{"_account_id":1001945,"name":"Adrien Grassein","email":"adrien.grassein@gmail.com","username":"grassead"},"change_message_id":"984c38763e31e2317819e38581f2f33aa5998f2a","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# configuration file for NG-Ultra SoC from NanoXplore."},{"line_number":3,"context_line":"# NG-Ultra is a quad-core Cortex-R52 SoC + an FPGA."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"06e907ee_42cf9994","line":1,"in_reply_to":"b869018a_cfeca054","updated":"2022-06-23 07:43:08.000000000","message":"Thanks a lot.\nTo answer to your question, our SoC is used in some critical sector with restricted diffusion. This configuration file may be provided alongside other component that are not GPL and we want to avoid any future issue.\n\nFor your second question, no it will not prevent us to contribute to the code.\n\nThanks again,","commit_id":"d12418d65f401fd554fea750e10b45572e68bbbf"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"c6cafc7d320f57692682c4c80ba3beffee88b98f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# configuration file for NG-Ultra SoC from NanoXplore."},{"line_number":3,"context_line":"# NG-Ultra is a quad-core Cortex-R52 SoC + an FPGA."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"f5079b69_783b0bf8","line":1,"in_reply_to":"c281ba89_13e6cbde","updated":"2022-06-25 17:03:41.000000000","message":"This file has sense only if used with OpenOCD, so it still will be distributed with the GPL code or the GPL binary.\nAnyway, not a problem using BSD-3-Clause.\nYou mention that this device would not be a widely used, so I questioned myself if this file makes sense inside OpenOCD. But it\u0027s a good example of Cortex-R52, so why not!","commit_id":"d12418d65f401fd554fea750e10b45572e68bbbf"},{"author":{"_account_id":1001945,"name":"Adrien Grassein","email":"adrien.grassein@gmail.com","username":"grassead"},"change_message_id":"937e8ddb19cc5a4c0a31e3217267d66114979d2a","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# configuration file for NG-Ultra SoC from NanoXplore."},{"line_number":3,"context_line":"# NG-Ultra is a quad-core Cortex-R52 SoC + an FPGA."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"4d05d15a_e4d1efcb","line":1,"in_reply_to":"db6579ed_5ccbd1ac","updated":"2022-06-22 12:08:00.000000000","message":"Thanks, but could it be another licence (BSD or Apache v2 for example)?\n\nAdrien","commit_id":"d12418d65f401fd554fea750e10b45572e68bbbf"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"bef3c9fab8f552ca2ff948615f12429e77c5c51e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d9a66964_fa83cc07","line":50,"updated":"2022-06-22 11:31:19.000000000","message":"just a suggestion, you can skip it if you disagree.\nAfter this line the default target is AXI\nIf you want to use core.0 as default target, you can add here\ntargets core.0","commit_id":"d12418d65f401fd554fea750e10b45572e68bbbf"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"f5269f82761c6660b79282b6f1d7f1424e154efb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f661f173_1c284543","line":50,"in_reply_to":"9d177a70_054b35a3","updated":"2022-06-22 13:32:04.000000000","message":"Ok, no problem","commit_id":"d12418d65f401fd554fea750e10b45572e68bbbf"},{"author":{"_account_id":1001945,"name":"Adrien Grassein","email":"adrien.grassein@gmail.com","username":"grassead"},"change_message_id":"937e8ddb19cc5a4c0a31e3217267d66114979d2a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9d177a70_054b35a3","line":50,"in_reply_to":"d9a66964_fa83cc07","updated":"2022-06-22 12:08:00.000000000","message":"Thanks, the default target is the AXI one.","commit_id":"d12418d65f401fd554fea750e10b45572e68bbbf"}]}
