)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"173e8962df0d4bbfdc602f0d2f06ea3cf22d7660","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"563707d8_2b6f0bdb","updated":"2022-06-25 16:44:30.000000000","message":"Looks even better than I though.\nTested with DLN-2 adapter on SWD and JTAG\nBut after my recent merges, this requires a rebase on top of new master branch.\nI also have a minor comment on the first patch of the series, so probably rebasing all after the fix is better.","commit_id":"e1d0d1d9749584be20e1cfcbfbac51346d2f2a35"},{"author":{"_account_id":1001975,"name":"Steve Marple","email":"stevemarple@googlemail.com","username":"stevemarple"},"change_message_id":"618ca201318bb900d522ad7a610641336910c7c9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"aeb2e3e3_f6580c7f","updated":"2022-07-04 17:22:54.000000000","message":"I\u0027ve updated the migration TCL commands now that I\u0027ve figured out how to do it. I\u0027ll push a new patchset shortly. It needs rebasing onto a minor change in https://review.openocd.org/c/openocd/+/6967/","commit_id":"66d46a941b14724aa2bad538c3fd9039456b1343"},{"author":{"_account_id":1001975,"name":"Steve Marple","email":"stevemarple@googlemail.com","username":"stevemarple"},"change_message_id":"64394274dd9dcae77086d991502702d71a4ac268","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"f70ccefb_18640046","updated":"2022-06-29 15:13:57.000000000","message":"This fixes a problem where the migration commands defined in startup.tcl did not work (could not be called). Common fixup procedures are provided in https://review.openocd.org/c/openocd/+/6967 as they are relevant for other drivers such as bcm2835gpio.\n\nThe older migration commands (e.g., \"linuxgpiod_jtag_nums\") have been updated to call and display the \"adapter gpio\" command usage.","commit_id":"66d46a941b14724aa2bad538c3fd9039456b1343"},{"author":{"_account_id":1001975,"name":"Steve Marple","email":"stevemarple@googlemail.com","username":"stevemarple"},"change_message_id":"2deb587dbbe6977491875e58dcf36cddc6bc32c7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"a67cae01_0209f79a","updated":"2022-07-10 21:12:04.000000000","message":"Hi Antonio,\nOver last few submissions I feel I know better what you are wanting to achieve at the end of the review process. Normally I can follow your logic - sometimes being annoyed with myself for not seeing certain things that you have pointed out. I\u0027m struggling with this one though and hope you don\u0027t mind explaining it to me,\n\nSteve","commit_id":"9c63e34ef7158745c8c8123763714938e02c52ec"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"392b418aac48f83557a8ba584b0f7171d3213afe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"ca48ea8d_c2474ca9","updated":"2022-08-06 21:55:54.000000000","message":"there is a conflict with https://review.openocd.org/6984\nif I merge 6967, 6984, 7047, then this cannot be merged.\nCan you rebase this on top of the other 3, or rebase them somehow in a single chain?","commit_id":"9c63e34ef7158745c8c8123763714938e02c52ec"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"81d0d879e831d8b1cc2da198bf0151a45814625a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"d1131285_7d93c1a7","updated":"2022-08-08 09:26:49.000000000","message":"Thanks!","commit_id":"587895878f73c1fc2fa0649f4f64460d2f9132be"}],"src/jtag/startup.tcl":[{"author":{"_account_id":1001975,"name":"Steve Marple","email":"stevemarple@googlemail.com","username":"stevemarple"},"change_message_id":"64394274dd9dcae77086d991502702d71a4ac268","unresolved":false,"context_lines":[{"line_number":860,"context_line":"}"},{"line_number":861,"context_line":""},{"line_number":862,"context_line":"lappend _telnet_autocomplete_skip linuxgpiod"},{"line_number":863,"context_line":"# linuxgpiod command completely removed, this is required for the sub-commands to work"},{"line_number":864,"context_line":"proc linuxgpiod {args} {"},{"line_number":865,"context_line":"\tset subproc [lindex $args 0]"},{"line_number":866,"context_line":"\tset outargs [lreplace $args 0 0]"}],"source_content_type":"text/x-tcl","patch_set":6,"id":"df9370b7_cabe3659","line":863,"updated":"2022-06-29 15:13:57.000000000","message":"I thought I had tested the changes with the newly-added test script. Maybe I hadn\u0027t removed the \"linuxgpiod\" command handler at the time of testing. \n\nThe only  significant difference that I can see between am335xgpio and linuxgpiod is that the former has a \"am335xgpio\" command registered, and linuxgpiod no longer needs any custom commands so is missing a \"linuxgpiod\" command handler. Adding a \"linuxgpiod\" procedure to startup.tcl wasn\u0027t sufficient to allow commands of the type \"linuxgpiod subcommand\", hence the result here.","commit_id":"66d46a941b14724aa2bad538c3fd9039456b1343"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"8129e9847742fdebad45646236fcdaecaa920246","unresolved":false,"context_lines":[{"line_number":860,"context_line":"}"},{"line_number":861,"context_line":""},{"line_number":862,"context_line":"lappend _telnet_autocomplete_skip linuxgpiod"},{"line_number":863,"context_line":"# linuxgpiod command completely removed, this is required for the sub-commands to work"},{"line_number":864,"context_line":"proc linuxgpiod {args} {"},{"line_number":865,"context_line":"\tset subproc [lindex $args 0]"},{"line_number":866,"context_line":"\tset outargs [lreplace $args 0 0]"}],"source_content_type":"text/x-tcl","patch_set":6,"id":"fc2b5f4d_fa7aa252","line":863,"in_reply_to":"df9370b7_cabe3659","updated":"2022-07-02 09:02:47.000000000","message":"you could add\nproc linuxgpiod {subcommand args} {\n  eval \"linuxgpiod $subcommand\" $args\n}\n\nproc \"linuxgpiod jtag_nums\" {args} {\n  ...\n}\n\nUp to you if you want to modify them; all these backward compatible commands are supposed to be dropped after a while, so we can accept some odd corner case.","commit_id":"66d46a941b14724aa2bad538c3fd9039456b1343"},{"author":{"_account_id":1001975,"name":"Steve Marple","email":"stevemarple@googlemail.com","username":"stevemarple"},"change_message_id":"618ca201318bb900d522ad7a610641336910c7c9","unresolved":false,"context_lines":[{"line_number":860,"context_line":"}"},{"line_number":861,"context_line":""},{"line_number":862,"context_line":"lappend _telnet_autocomplete_skip linuxgpiod"},{"line_number":863,"context_line":"# linuxgpiod command completely removed, this is required for the sub-commands to work"},{"line_number":864,"context_line":"proc linuxgpiod {args} {"},{"line_number":865,"context_line":"\tset subproc [lindex $args 0]"},{"line_number":866,"context_line":"\tset outargs [lreplace $args 0 0]"}],"source_content_type":"text/x-tcl","patch_set":6,"id":"b512a78c_b25c0816","line":863,"in_reply_to":"fc2b5f4d_fa7aa252","updated":"2022-07-04 17:22:54.000000000","message":"That was my first approach when I found it was necessary to add a linuxgpiod procedure but it results in an \"Infinite eval recursion\" error. I\u0027ve found the answer is to define the procedure as:\n\nproc linuxgpiod {subcommand args} {\n\teval {\"linuxgpiod $subcommand\"} $args\n}\n\nso that eval does not interpret linuxgpiod and $subcommand as two separate entries in its argument list. I\u0027ll update the migration commands to follow this approach as I think it is neater.","commit_id":"66d46a941b14724aa2bad538c3fd9039456b1343"}],"testing/test-linuxgpiod-deprecated-commands.cfg":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"8286ed29467808c8213b1fe73c0bedf13aa52527","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# SPDX-License-Identifier: GPL-2.0-or-later"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# OpenOCD script to test that the deprecated \"linuxgpiod *\" and \"linuxgpiod_*\""},{"line_number":4,"context_line":"# commands produce the expected results. Run this command as:"}],"source_content_type":"text/x-ttcn-cfg","patch_set":7,"id":"6953380a_a04fc285","line":1,"updated":"2022-07-05 08:43:00.000000000","message":"I don\u0027t think we need this file in OpenOCD.\nThe deprecated commands will be dropped after a while.\nAnd, by the way, this testing folder really needs some major rework!","commit_id":"9c63e34ef7158745c8c8123763714938e02c52ec"},{"author":{"_account_id":1001975,"name":"Steve Marple","email":"stevemarple@googlemail.com","username":"stevemarple"},"change_message_id":"2deb587dbbe6977491875e58dcf36cddc6bc32c7","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# SPDX-License-Identifier: GPL-2.0-or-later"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# OpenOCD script to test that the deprecated \"linuxgpiod *\" and \"linuxgpiod_*\""},{"line_number":4,"context_line":"# commands produce the expected results. Run this command as:"}],"source_content_type":"text/x-ttcn-cfg","patch_set":7,"id":"f13b9863_e973d6d4","line":1,"in_reply_to":"6953380a_a04fc285","updated":"2022-07-10 21:12:04.000000000","message":"Testing software is normally considered good practice, however I do understand the difficulty of implementing which involve hardware interactions. As a result there are few easy opportunities for testing in OpenOCD. This seems like one of the easy opportunities. I realise the migration commands have a limited lifetime however having a test to check their behaviour helped me ensure they were correct (and the underlying \"adapter gpio\" commands).\nCan you please explain why you think this isn\u0027t needed?","commit_id":"9c63e34ef7158745c8c8123763714938e02c52ec"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"e96b3148a018a4159e3e16b31ad271f2dc196f35","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# SPDX-License-Identifier: GPL-2.0-or-later"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# OpenOCD script to test that the deprecated \"linuxgpiod *\" and \"linuxgpiod_*\""},{"line_number":4,"context_line":"# commands produce the expected results. Run this command as:"}],"source_content_type":"text/x-ttcn-cfg","patch_set":7,"id":"7c66817a_f051ecd3","line":1,"in_reply_to":"f13b9863_e973d6d4","updated":"2022-08-06 21:49:28.000000000","message":"Sorry, I completely lost this patch series... too many patches to check.\n\nThe deprecated commands are there to help users to migrate their own old scripts to the new commands.\nDeprecated commands are removed after few releases when we expect all users have complete the migration. This file will be removed too.\nThe deprecated command are kind of \"best effort\" implementation but sometimes are broken as they fail to cover some use case; it\u0027s not so critical if it still prints the deprecated message. Anyway user has to update its script.\nProbably the user will fix the deprecated command, but I personally don\u0027t expect he will run this file.\n\nAnyway, not a big problem to keep it.\n\nI will merge this series by next weekend\nThanks","commit_id":"9c63e34ef7158745c8c8123763714938e02c52ec"}]}