)]}'
{"id":"openocd~master~Ifa25a84fe9ffa25b8b58d7920ec77994c3b7ebfe","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2022-07-02 08:27:28.000000000","reason":"removed on reply"},"1001964":{"account":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"last_update":"2022-06-25 11:17:30.000000000","reason":"Erhan Kurubas replied on the change"}},"hashtags":[],"change_id":"Ifa25a84fe9ffa25b8b58d7920ec77994c3b7ebfe","subject":"target: esp_xtensa_smp: fix clang report","status":"MERGED","created":"2022-06-25 10:47:16.000000000","updated":"2022-07-02 08:27:31.000000000","submitted":"2022-07-02 08:27:31.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7050","meta_rev_id":"2fa7da10802242a649f7dea081f76fa65dacf40d","_number":7050,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-07-02 08:27:31.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"value":0,"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-07-02 08:27:31.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-07-02 08:27:31.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-06-25 10:47:16.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"state":"REVIEWER"},{"updated":"2022-06-25 10:50:58.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"6a484e13cbafa753b75a289ba616ef8ef2b9e54d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-06-25 10:47:16.000000000","message":"Uploaded patch set 1: Code-Review+1.","accounts_in_message":[],"_revision_number":1},{"id":"959ca5db7ee764a61a5aeadb842d97edfebef4bf","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-06-25 10:50:45.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"c5759e7f29f2e345bd329823d4e2bc4d4358ea1a","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-06-25 10:50:58.000000000","message":"Patch Set 1: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit-build/15564/ : ABORTED\n\nhttps://build.openocd.org/job/openocd-gerrit/16356/ : ABORTED","accounts_in_message":[],"_revision_number":1},{"id":"f6bfaf6ae8dc5310809b9a9da03147be9c16515f","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-06-25 10:52:57.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"353732abf1d40d88e2133093dd34e9cd2986e471","author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"real_author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"date":"2022-06-25 11:17:30.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"2201071f06176dfe896798a65df23fe0ad740983","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-06-25 11:21:28.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/15565/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/16357/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"8850976f23549a55a694722b0a804abdd30bd8ae","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-07-02 08:27:28.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"2fa7da10802242a649f7dea081f76fa65dacf40d","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-07-02 08:27:31.000000000","message":"Change has been successfully cherry-picked as b7125c369c4e5bde86d6688cbd1b7a87384d3d24","accounts_in_message":[],"_revision_number":3}],"current_revision":"b7125c369c4e5bde86d6688cbd1b7a87384d3d24","revisions":{"243eb06791bc1f2f08b3edf2605487fe98dd9208":{"kind":"REWORK","_number":1,"created":"2022-06-25 10:47:16.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/50/7050/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/50/7050/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/50/7050/1 \u0026\u0026 git checkout -b change-7050 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/50/7050/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/50/7050/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/50/7050/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/50/7050/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/50/7050/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a70bab9e5185c8853882748737ceebabde7c4781","subject":"helper: fix build with mingw gcc 12.1.0"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-06-25 10:40:24.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-06-25 10:40:24.000000000","tz":120},"subject":"target: esp_xtensa_smp: fix clang report","message":"target: esp_xtensa_smp: fix clang report\n\nThe variable \u0027smp_break\u0027 is only set and used in case of smp.\nBut clang cannot track if \u0027target-\u003esmp\u0027 get modified between the\nset and the use of \u0027smp_break\u0027, so it consider possible to use\n\u0027smp_break\u0027 uninitialized.\n\nInitialize \u0027smp_break\u0027 to silent clang.\n\nChange-Id: Ifa25a84fe9ffa25b8b58d7920ec77994c3b7ebfe\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"6a5ea3b1ec3bc19fd0d7ee1c0116f06e8552dd70":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2022-06-25 10:50:45.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/50/7050/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/50/7050/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/50/7050/2 \u0026\u0026 git checkout -b change-7050 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/50/7050/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/50/7050/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/50/7050/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/50/7050/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/50/7050/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a70bab9e5185c8853882748737ceebabde7c4781","subject":"helper: fix build with mingw gcc 12.1.0"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-06-25 10:40:24.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-06-25 10:49:51.000000000","tz":120},"subject":"target: esp_xtensa_smp: fix clang report","message":"target: esp_xtensa_smp: fix clang report\n\nThe variable \u0027smp_break\u0027 is only set and used in case of smp.\nBut clang cannot track if \u0027target-\u003esmp\u0027 get modified between the\nset and the use of \u0027smp_break\u0027, so it consider possible to use\n\u0027smp_break\u0027 uninitialized.\n\nInitialize \u0027smp_break\u0027 to silent clang.\n\nChange-Id: Ifa25a84fe9ffa25b8b58d7920ec77994c3b7ebfe\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nFixes: 77287b8d47b4 (\"target: add Espressif ESP32 basic support\")\n"}},"b7125c369c4e5bde86d6688cbd1b7a87384d3d24":{"kind":"REWORK","_number":3,"created":"2022-07-02 08:27:31.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/50/7050/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/50/7050/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/50/7050/3 \u0026\u0026 git checkout -b change-7050 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/50/7050/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/50/7050/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/50/7050/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/50/7050/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/50/7050/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"06c3240155ccbb22b2db5782ffedf1e0c544b073","subject":"semihosting: move semihosting_result_t from riscv.h to the semihosting_common.h"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-06-25 10:40:24.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-07-02 08:27:31.000000000","tz":0},"subject":"target: esp_xtensa_smp: fix clang report","message":"target: esp_xtensa_smp: fix clang report\n\nThe variable \u0027smp_break\u0027 is only set and used in case of smp.\nBut clang cannot track if \u0027target-\u003esmp\u0027 get modified between the\nset and the use of \u0027smp_break\u0027, so it consider possible to use\n\u0027smp_break\u0027 uninitialized.\n\nInitialize \u0027smp_break\u0027 to silent clang.\n\nChange-Id: Ifa25a84fe9ffa25b8b58d7920ec77994c3b7ebfe\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nFixes: 77287b8d47b4 (\"target: add Espressif ESP32 basic support\")\nReviewed-on: https://review.openocd.org/c/openocd/+/7050\nReviewed-by: Erhan Kurubas \u003cerhan.kurubas@espressif.com\u003e\nTested-by: jenkins\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}