)]}'
{"id":"openocd~master~I52ce47eda69a51c2dd29aac15f16e285492d89b4","project":"openocd","branch":"master","hashtags":[],"change_id":"I52ce47eda69a51c2dd29aac15f16e285492d89b4","subject":"helper/jim-nvp: avoid camelcase error by deprecated API","status":"MERGED","created":"2022-06-25 17:18:01.000000000","updated":"2022-07-23 13:59:49.000000000","submitted":"2022-07-23 13:59:49.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7052","meta_rev_id":"fd0e960cbb6a8e893562f1ba11f135e5f17432f5","_number":7052,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-07-23 13:59:49.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-07-23 13:59:49.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-06-25 18:17:54.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"0b8e55d4d19236230e1ae49beb8c9072493a2c0d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-06-25 17:18:01.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"a9322b5cde0bd823f7569469bcbff2bc99d66a90","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-06-25 18:17:54.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/15571/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/16363/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"2022fec866a50635c63ef76baed6c8f17de2f05a","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-07-23 13:59:46.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"fd0e960cbb6a8e893562f1ba11f135e5f17432f5","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-07-23 13:59:49.000000000","message":"Change has been successfully cherry-picked as 32f517f5d6efb9fb7178fd9a9614fbf64aff963e","accounts_in_message":[],"_revision_number":2}],"current_revision":"32f517f5d6efb9fb7178fd9a9614fbf64aff963e","revisions":{"a565309aceeca3718bbafd5fd6cb2e2c52db89ac":{"kind":"REWORK","_number":1,"created":"2022-06-25 17:18:01.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/52/7052/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/52/7052/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/52/7052/1 \u0026\u0026 git checkout -b change-7052 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/52/7052/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/52/7052/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/52/7052/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/52/7052/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/52/7052/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a70bab9e5185c8853882748737ceebabde7c4781","subject":"helper: fix build with mingw gcc 12.1.0"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-04-26 06:57:28.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-06-25 17:16:22.000000000","tz":120},"subject":"helper/jim-nvp: avoid camelcase error by deprecated API","message":"helper/jim-nvp: avoid camelcase error by deprecated API\n\nCommit b8e18d292eb6 (\"helper/jim-nvp: comply with coding style\n[1/2]\") tags as deprecated the old CamelCase API of jim-nvp, so\nthat old patches already in gerrit or in user\u0027s local git can\nstill build while dumping a deprecated message.\n\nSo far, we have not found any such case, so the deprecated API can\nbe safely dropped in preparation of v0.12.0-rc1.\n\nDrop the compile flag \"-Wno-error\u003ddeprecated-declarations\" and the\ndeprecated API.\n\nChange-Id: I52ce47eda69a51c2dd29aac15f16e285492d89b4\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"32f517f5d6efb9fb7178fd9a9614fbf64aff963e":{"kind":"REWORK","_number":2,"created":"2022-07-23 13:59:49.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/52/7052/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/52/7052/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/52/7052/2 \u0026\u0026 git checkout -b change-7052 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/52/7052/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/52/7052/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/52/7052/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/52/7052/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/52/7052/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"757895b8ee2d6b82630f10d0a19abc3f56e09c44","subject":"openocd: src: replace SPDX to remaining files"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-04-26 06:57:28.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-07-23 13:59:49.000000000","tz":0},"subject":"helper/jim-nvp: avoid camelcase error by deprecated API","message":"helper/jim-nvp: avoid camelcase error by deprecated API\n\nCommit b8e18d292eb6 (\"helper/jim-nvp: comply with coding style\n[1/2]\") tags as deprecated the old CamelCase API of jim-nvp, so\nthat old patches already in gerrit or in user\u0027s local git can\nstill build while dumping a deprecated message.\n\nSo far, we have not found any such case, so the deprecated API can\nbe safely dropped in preparation of v0.12.0-rc1.\n\nDrop the compile flag \"-Wno-error\u003ddeprecated-declarations\" and the\ndeprecated API.\n\nChange-Id: I52ce47eda69a51c2dd29aac15f16e285492d89b4\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/7052\nTested-by: jenkins\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}
