)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"412371ebcf0293cb271e00e162b1379e7d5beae0","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"target: add generic Xtensa LX support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Generic Xtensa LX support extends the original Espressif/Xtensa patch-set to support arbitrary Xtensa configurations, as defined in a core-specific .cfg file.  Not yet fully-featured.  Additional functionality to be added:"},{"line_number":10,"context_line":"- Xtensa NX support"},{"line_number":11,"context_line":"- DAP/SWD support"},{"line_number":12,"context_line":"- File-IO support"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"0891531a_0d643c5d","line":9,"updated":"2022-07-25 15:28:31.000000000","message":"please split this line to keep each line within 72 char (git log adds one TAB in front)","commit_id":"2956b0353914d2fc81655cc8a7133228b0f5555c"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"c5b0f250831da2735ba01a7815be1871588e2f62","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"target: add generic Xtensa LX support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Generic Xtensa LX support extends the original Espressif/Xtensa patch-set to support arbitrary Xtensa configurations, as defined in a core-specific .cfg file.  Not yet fully-featured.  Additional functionality to be added:"},{"line_number":10,"context_line":"- Xtensa NX support"},{"line_number":11,"context_line":"- DAP/SWD support"},{"line_number":12,"context_line":"- File-IO support"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"f495f9d9_9a9fd103","line":9,"in_reply_to":"0891531a_0d643c5d","updated":"2022-08-02 01:05:14.000000000","message":"Done.","commit_id":"2956b0353914d2fc81655cc8a7133228b0f5555c"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"7d0a383c1295a500d4dc155e5f0dd297ee657c70","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ff87e621_78c30da7","updated":"2022-06-26 01:38:15.000000000","message":"Adding support for generic Xtensa LX support.  Confirmed functionality with multiple Xtensa LX configurations on FPGA and emulation targets, as well as ESP32 wrover dual-core target.  Looking forward to your comments and feedback.  Please advise if other reviewers should be added--this is my first OOCD patch.  Thanks in advance.","commit_id":"3e7b1a05759168a3d43778662895c9ab0f2ee60e"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"4e87044845712ee28c45b62c1cf9736c3cdeb15e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"cf042587_374bbf8e","updated":"2022-06-30 19:09:05.000000000","message":"Hi Ian, \nI have tested with Espressif chips. Found an issue with ESP32-S2 config. \nExcept that one, patch works fine.\nThanks for the good work.","commit_id":"3e7b1a05759168a3d43778662895c9ab0f2ee60e"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"953ecbe6f58c71102bf6f12a89727fd64418890c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d4d3b0eb_06664b2c","updated":"2022-07-01 04:20:05.000000000","message":"Updating formatting per Espressif style guidelines.  Thanks for the feedback, @erhan.","commit_id":"3e7b1a05759168a3d43778662895c9ab0f2ee60e"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"e70dcb598c55716a7fe8711c93d85a9b4a9a5569","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b31546a7_c50066e5","updated":"2022-07-02 10:46:25.000000000","message":"Hi Ian, thanks for this patch.\nI have run a very fast review, busy time...\nDo you think this patch could be split to simplify the review? I see at least some parts that could be in independent patches:\n- make register map configurable, move ESP32 dedicated register in configuration\n- add GDB extension\n- add new board, target and interfaces config files","commit_id":"3ad47b3e590c83481e235836447cb3c57adf68ab"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"e8e58b52c712bb777c4e5328fef656f1a2830d92","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"286ac331_1715d0eb","updated":"2022-07-04 22:48:12.000000000","message":"Hi, Antonio,\n\nYes, I will reduce the scope of this patch as you suggest.  Xtensa targets won\u0027t be usable until all patches are merged, but I will keep Espressif targets running.  I\u0027m out of the office this week and will get this done when I\u0027m back.  In the meantime, I\u0027m addressing some of the simpler comments and rebasing off master.  \n\nThanks for the feedback--will follow up within a week.","commit_id":"3ad47b3e590c83481e235836447cb3c57adf68ab"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"57cea4e224a3054044dfbfbc7a3249e1d0f5c059","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"36ffa7c9_c3b094b2","updated":"2022-07-09 20:07:03.000000000","message":"Splitting out into 3 separate patches.  This one contains updates to support configurable Xtensa registers via parameters specified in per-core TCL files.  Espressif platforms updated accordingly.  ","commit_id":"bf6fac437919cc17853bda7d50998ce3d01ec0d2"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"7bc3cda84816256d9178edfb09798dfeaf1fbb4a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"e7834e76_82ffba1f","updated":"2022-07-10 12:48:22.000000000","message":"Formatting is also done in the separate patch. https://review.openocd.org/c/openocd/+/7080","commit_id":"6ee279edcf92a4453aeffd1cd89a2d57752491c3"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"415fa425b7557afd0ba10ec3e8df898bdfafc525","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"a7c9a4d6_1bd8dc62","updated":"2022-07-14 15:27:04.000000000","message":"Resolved remaining open comment.  ","commit_id":"6ee279edcf92a4453aeffd1cd89a2d57752491c3"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"891b7d276ebd97a45efdaccfa7519fb5d47cf582","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"79f2faeb_79141b95","updated":"2022-07-11 00:45:12.000000000","message":"Thanks @erhan.  \n\n@antonio, I\u0027ve split this review out to also include patches 7082 and 7083.  Please review at your convenience.  Thanks in advance. ","commit_id":"6ee279edcf92a4453aeffd1cd89a2d57752491c3"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"a6e0c50c57cd72875f997a15e874ca4fdb83b4d2","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"1f297b67_1bc0f3a7","updated":"2022-07-19 16:45:21.000000000","message":"Hi Ian,\n\nI noticed an error msg coming from ESP32 only. Not related to your patch changes, it is there from the beginning. S2 and S3 looks fine. \n\nDebug: 1621 22434 gdb_server.c:401 gdb_log_incoming_packet(): [esp32.cpu0] received packet: qXfer:threads:read::0,1000\nDebug: 1622 22434 gdb_server.c:415 gdb_log_outgoing_packet(): [esp32.cpu0] sending packet: $\u003cbinary-data-44-bytes\u003e#02\nDebug: 1623 22439 gdb_server.c:401 gdb_log_incoming_packet(): [esp32.cpu0] received packet: m3f403504,8\nDebug: 1624 22439 gdb_server.c:1531 gdb_read_memory_packet(): addr: 0x000000003f403504, len: 0x00000008\nDebug: 1625 22439 target.c:2490 target_read_buffer(): reading buffer of 8 byte at 0x3f403504\nDebug: 1626 22439 xtensa.c:904 xtensa_core_status_check(): [esp32.cpu0] DSR (8080CC19)\nError: 1627 22439 xtensa.c:922 xtensa_core_status_check(): [esp32.cpu0] DSR (8080CC19) indicates DIR instruction generated an overrun!\nInfo : 1628 22439 xtensa.c:1809 xtensa_read_memory(): [esp32.cpu0] Disabling LDDR32.P/SDDR32.P\nDebug: 1629 22440 xtensa.c:904 xtensa_core_status_check(): [esp32.cpu0] DSR (8080CC11)\nDebug: 1630 22440 gdb_server.c:418 gdb_log_outgoing_packet(): [esp32.cpu0] sending packet: $7461736b31000000#58\n\nI will look at more deeply, also I can share my test app if you need.","commit_id":"f059119aad3626a35c79242610116946f9639edd"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"8b2f2761145144ed952bf5e39579fc639d6eb214","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"930b4126_54512784","updated":"2022-07-20 19:37:21.000000000","message":"Thanks, Erhan.  Comments addressed with next patch.","commit_id":"f059119aad3626a35c79242610116946f9639edd"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"8b2f2761145144ed952bf5e39579fc639d6eb214","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"700e96f1_c95d69e2","in_reply_to":"1f297b67_1bc0f3a7","updated":"2022-07-20 19:37:21.000000000","message":"This occurs when a memory read or write attempting to use the fast-path LDDR32.P/SDDR32.P instructions encounters an exception.  Since the xtensa target already handles this by disabling the fast-path instructions and retrying the memory access, it\u0027s not technically an error, so I\u0027m suppressing it (with the same logic used when we probe for these instructions).","commit_id":"f059119aad3626a35c79242610116946f9639edd"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"ff8ce1355058885aecec4e7aa85418e6acfaa63a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"51dc416c_60383650","updated":"2022-07-21 00:10:07.000000000","message":"Oops, forgot to run checkpatch.  Sorry about that, Erhan.  Should be fixed now.","commit_id":"8490c7412d2223f766096fde641c604fd6c30c10"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"e635dc4e6740057f1ce5e412defe81f5ddf762bc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"1befb6f0_111129da","updated":"2022-07-20 20:56:35.000000000","message":"Thanks Ian, \n\nThere is 2 checkpatch issues. \n\nIn general patchset 9 looks OK to me. ","commit_id":"8490c7412d2223f766096fde641c604fd6c30c10"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"efa427b26e1c9333009c08fefef1bd6ef353a945","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"80486cd1_d54c37e4","updated":"2022-07-23 15:36:24.000000000","message":"rebased onto master","commit_id":"e20816b8209f9e35b2efdb01a2da0293f4cc9227"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"412371ebcf0293cb271e00e162b1379e7d5beae0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"f4e1623f_1deb21b6","updated":"2022-07-25 15:28:31.000000000","message":"Thanks for the split.\nYes, you will need all the patches together to get it functional; you can consider pushing them in a series so gets clear that there are dependencies. Anyway, ping me if I forget to merge something","commit_id":"2956b0353914d2fc81655cc8a7133228b0f5555c"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"c5b0f250831da2735ba01a7815be1871588e2f62","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"09c91438_46b3bbb8","updated":"2022-08-02 01:05:14.000000000","message":"Thanks for your comments, Antonio.  Resolved most with a couple of open questions remaining.  Patchset coming shortly; look forward to your feedback.","commit_id":"2956b0353914d2fc81655cc8a7133228b0f5555c"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"74cb2e6fa91588f14df9a96621d4a1440a6394da","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"15bb94fc_573bee21","updated":"2022-08-04 15:45:55.000000000","message":"Braces style issues resolved.  No functional changes in this patchset, just {} removal.  ","commit_id":"d798f4fd370aa6de1b92595e7b50949fa9a9458f"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"4d47f581978db6e51b77f270f5750647a302d947","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":14,"id":"288dfe6c_dcdf1608","updated":"2022-08-04 16:58:56.000000000","message":"@Ian, there may be misunderstanding. You can check from here. https://www.kernel.org/doc/html/v4.10/process/coding-style.html \n\ne.g. \n\n// No need braces\n\nif (condition)\n        do_this();\nelse\n        do_that();\n\n// need braces \n\nif (condition) {\n        do_this();\n        do_that();\n} else { //need braces. because one of the chain has multiple statement.\n        otherwise();\n}\n\n","commit_id":"a7069787c658f59ffdf59858fad08327cf2cf5a4"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"7ebf5f5aa3fa080d38ebe411244d7fdecc441abf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"85c56277_7006aba7","updated":"2022-08-04 17:25:26.000000000","message":"Ah, that makes things much more readable and less error-prone.  Let me fix this up.  Thanks for the pointer, @erhan.","commit_id":"a7069787c658f59ffdf59858fad08327cf2cf5a4"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"959e8112b5a333a02942b658091f314399e771f7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"4131d735_66149cfc","in_reply_to":"288dfe6c_dcdf1608","updated":"2022-08-04 18:50:30.000000000","message":"Updated per K\u0026R / kernel.org guidelines.  This looks much cleaner now.  Sorry for the noise.","commit_id":"a7069787c658f59ffdf59858fad08327cf2cf5a4"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b9e524d1dc17a4c692f894f1d768b7f84923d270","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"926ccec1_b27417d9","updated":"2022-08-11 15:26:20.000000000","message":"Only few remaining points, than I think this could be ready\nThanks","commit_id":"a817f792f2204ffe905d92e52a8809043d08372b"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"8b0ed4950024dbea49d61e55615556b08c46c2df","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"3aaa9c29_3b201784","updated":"2022-08-04 20:33:52.000000000","message":"Thanks Ian. Now differences with our internal style check job is the multiline, single statement conditions. But no worries. Manuel check will not hurt much.","commit_id":"a817f792f2204ffe905d92e52a8809043d08372b"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"c58c0783e8d29dc0143e37c0b1b6a71045e648d8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"6f13f050_66da47e1","updated":"2022-08-11 18:02:23.000000000","message":"Thanks, Antonio.  Addressed remaining points with next patchset.  Really appreciate your thoroughness.","commit_id":"a817f792f2204ffe905d92e52a8809043d08372b"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"060b90462b3b697deeeb42c87a572939e0c39c79","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"396ef3bc_c29c01b1","updated":"2022-08-11 19:04:34.000000000","message":"Thanks","commit_id":"24a4853f5b0a9ff65486d38a662ce1647c0de2f9"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"9b024f2032c0904e5322636cca89942f0d6c437b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"4eb6b5d9_61ca09d5","updated":"2022-08-15 16:14:23.000000000","message":"Resolved merge conflict; re-added .gdb_query_custom hook back into xtensa_chip.c after today\u0027s merge (per Antonio\u0027s comment on patchset 16).  Thanks, Antonio.","commit_id":"88de2f483e72c215f0a269731fc8001823f8b0a5"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"7f49fac1c7400a06dd7a512d255b2872c26283d3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"537ce5d3_7fc7a266","updated":"2022-08-19 20:08:31.000000000","message":"Sorry It was busy week. I was just able to test it. Still works fine with Espressif chips. \nThanks Ian, Antonio. ","commit_id":"88de2f483e72c215f0a269731fc8001823f8b0a5"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"dca7d44ecdc06e06a2d74a55990a05f21fa4e32b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"afc0124e_25ed00e9","updated":"2022-08-15 22:17:23.000000000","message":"Tested and working for me with TCL files from 7083.","commit_id":"88de2f483e72c215f0a269731fc8001823f8b0a5"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"5ca3fe5fcdd908bf65b680e9d5f864cd1054cb80","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"e3c9c55e_583e8126","updated":"2022-08-15 21:36:45.000000000","message":"Thanks.\nErhan, Ian, please add your +1; I cannot test this so I have to rely on you","commit_id":"88de2f483e72c215f0a269731fc8001823f8b0a5"}],"README":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"e70dcb598c55716a7fe8711c93d85a9b4a9a5569","unresolved":true,"context_lines":[{"line_number":121,"context_line":"ARM: AArch64, ARM11, ARM7, ARM9, Cortex-A/R (v7-A/R), Cortex-M (ARMv{6/7/8}-M),"},{"line_number":122,"context_line":"FA526, Feroceon/Dragonite, XScale."},{"line_number":123,"context_line":"ARCv2, AVR32, DSP563xx, DSP5680xx, EnSilica eSi-RISC, EJTAG (MIPS32, MIPS64),"},{"line_number":124,"context_line":"Espressif, Intel Quark, LS102x-SAP, NDS32, RISC-V, ST STM8, Xtensa."},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"Flash drivers"},{"line_number":127,"context_line":"-------------"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"f6645b74_475611c3","line":124,"updated":"2022-07-02 10:46:25.000000000","message":"I\u0027m keeping track of these changes in a single patch that I update periodically\nPlease remove this change and add comments to \nhttps://review.openocd.org/6192/\nif you find I\u0027ve missed something","commit_id":"3ad47b3e590c83481e235836447cb3c57adf68ab"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"e8e58b52c712bb777c4e5328fef656f1a2830d92","unresolved":false,"context_lines":[{"line_number":121,"context_line":"ARM: AArch64, ARM11, ARM7, ARM9, Cortex-A/R (v7-A/R), Cortex-M (ARMv{6/7/8}-M),"},{"line_number":122,"context_line":"FA526, Feroceon/Dragonite, XScale."},{"line_number":123,"context_line":"ARCv2, AVR32, DSP563xx, DSP5680xx, EnSilica eSi-RISC, EJTAG (MIPS32, MIPS64),"},{"line_number":124,"context_line":"Espressif, Intel Quark, LS102x-SAP, NDS32, RISC-V, ST STM8, Xtensa."},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"Flash drivers"},{"line_number":127,"context_line":"-------------"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"ef68c62f_8291dec0","line":124,"in_reply_to":"f6645b74_475611c3","updated":"2022-07-04 22:48:12.000000000","message":"Thanks, done.","commit_id":"3ad47b3e590c83481e235836447cb3c57adf68ab"}],"doc/openocd.texi":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"e70dcb598c55716a7fe8711c93d85a9b4a9a5569","unresolved":true,"context_lines":[{"line_number":10999,"context_line":"their debug interconnect (termed \"break/stall networks\"), which control how debug"},{"line_number":11000,"context_line":"signals are distributed among cores.  Xtensa \"break networks\" are compatible with"},{"line_number":11001,"context_line":"ARM\u0027s Cross Trigger Interface (CTI).  OpenOCD implements both generic Xtensa targets"},{"line_number":11002,"context_line":"as well as several Epsressif Xtensa-based chips from the"},{"line_number":11003,"context_line":"@uref{https://www.espressif.com/en/products/socs, ESP32 family}."},{"line_number":11004,"context_line":""},{"line_number":11005,"context_line":"OCD sessions for Xtensa processor and DSP targets are accessed via the Xtensa"}],"source_content_type":"text/x-texinfo","patch_set":2,"id":"9e44c5f3_b62d53f1","line":11002,"updated":"2022-07-02 10:46:25.000000000","message":"typo s/Epsressif/Espressif/\nIt was already there, but if you can fix it, it would be nice.","commit_id":"3ad47b3e590c83481e235836447cb3c57adf68ab"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"e8e58b52c712bb777c4e5328fef656f1a2830d92","unresolved":false,"context_lines":[{"line_number":10999,"context_line":"their debug interconnect (termed \"break/stall networks\"), which control how debug"},{"line_number":11000,"context_line":"signals are distributed among cores.  Xtensa \"break networks\" are compatible with"},{"line_number":11001,"context_line":"ARM\u0027s Cross Trigger Interface (CTI).  OpenOCD implements both generic Xtensa targets"},{"line_number":11002,"context_line":"as well as several Epsressif Xtensa-based chips from the"},{"line_number":11003,"context_line":"@uref{https://www.espressif.com/en/products/socs, ESP32 family}."},{"line_number":11004,"context_line":""},{"line_number":11005,"context_line":"OCD sessions for Xtensa processor and DSP targets are accessed via the Xtensa"}],"source_content_type":"text/x-texinfo","patch_set":2,"id":"d4fec36d_257c6813","line":11002,"in_reply_to":"9e44c5f3_b62d53f1","updated":"2022-07-04 22:48:12.000000000","message":"Done, thanks for catching this.","commit_id":"3ad47b3e590c83481e235836447cb3c57adf68ab"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"e70dcb598c55716a7fe8711c93d85a9b4a9a5569","unresolved":true,"context_lines":[{"line_number":11060,"context_line":""},{"line_number":11061,"context_line":"@deffn {Command} {xtensa xtopt} option value"},{"line_number":11062,"context_line":"Configure Xtensa target options that are relevant to the debug subsystem."},{"line_number":11063,"context_line":"@var{option} is one of: @option{bigendian}, @option{arnum}, @option{windowed},"},{"line_number":11064,"context_line":"@option{cpenable}, @option{exceptions}, @option{intnum}, @option{hipriints},"},{"line_number":11065,"context_line":"@option{excmlevel}, @option{intlevels}, @option{debuglevel},"},{"line_number":11066,"context_line":"@option{ibreaknum}, or @option{dbreaknum}.  @var{value} is an integer with"}],"source_content_type":"text/x-texinfo","patch_set":2,"id":"45583bf5_4bf363fa","line":11063,"updated":"2022-07-02 10:46:25.000000000","message":"for coherency with OpenOCD framework, endianness should be part of commands \"target create\" or \"\u003ctargetname\u003e configure\"","commit_id":"3ad47b3e590c83481e235836447cb3c57adf68ab"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"412371ebcf0293cb271e00e162b1379e7d5beae0","unresolved":false,"context_lines":[{"line_number":11060,"context_line":""},{"line_number":11061,"context_line":"@deffn {Command} {xtensa xtopt} option value"},{"line_number":11062,"context_line":"Configure Xtensa target options that are relevant to the debug subsystem."},{"line_number":11063,"context_line":"@var{option} is one of: @option{bigendian}, @option{arnum}, @option{windowed},"},{"line_number":11064,"context_line":"@option{cpenable}, @option{exceptions}, @option{intnum}, @option{hipriints},"},{"line_number":11065,"context_line":"@option{excmlevel}, @option{intlevels}, @option{debuglevel},"},{"line_number":11066,"context_line":"@option{ibreaknum}, or @option{dbreaknum}.  @var{value} is an integer with"}],"source_content_type":"text/x-texinfo","patch_set":2,"id":"ac88c145_8f248f2b","line":11063,"in_reply_to":"0a622b0a_10788a6b","updated":"2022-07-25 15:28:31.000000000","message":"Yes, it\u0027s ok to keep the command as deprecated for some time.\nPlease add also a comment including the uppercase \u0027DEPRECATED\u0027 string so can be easily grepped out.","commit_id":"3ad47b3e590c83481e235836447cb3c57adf68ab"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"e8e58b52c712bb777c4e5328fef656f1a2830d92","unresolved":true,"context_lines":[{"line_number":11060,"context_line":""},{"line_number":11061,"context_line":"@deffn {Command} {xtensa xtopt} option value"},{"line_number":11062,"context_line":"Configure Xtensa target options that are relevant to the debug subsystem."},{"line_number":11063,"context_line":"@var{option} is one of: @option{bigendian}, @option{arnum}, @option{windowed},"},{"line_number":11064,"context_line":"@option{cpenable}, @option{exceptions}, @option{intnum}, @option{hipriints},"},{"line_number":11065,"context_line":"@option{excmlevel}, @option{intlevels}, @option{debuglevel},"},{"line_number":11066,"context_line":"@option{ibreaknum}, or @option{dbreaknum}.  @var{value} is an integer with"}],"source_content_type":"text/x-texinfo","patch_set":2,"id":"4a18661e_2bf74c0c","line":11063,"in_reply_to":"45583bf5_4bf363fa","updated":"2022-07-04 22:48:12.000000000","message":"I will see about changing this.  Our toolchain currently generates these files, but I can probably take big endian target support out of this patch in the meantime.","commit_id":"3ad47b3e590c83481e235836447cb3c57adf68ab"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"57cea4e224a3054044dfbfbc7a3249e1d0f5c059","unresolved":true,"context_lines":[{"line_number":11060,"context_line":""},{"line_number":11061,"context_line":"@deffn {Command} {xtensa xtopt} option value"},{"line_number":11062,"context_line":"Configure Xtensa target options that are relevant to the debug subsystem."},{"line_number":11063,"context_line":"@var{option} is one of: @option{bigendian}, @option{arnum}, @option{windowed},"},{"line_number":11064,"context_line":"@option{cpenable}, @option{exceptions}, @option{intnum}, @option{hipriints},"},{"line_number":11065,"context_line":"@option{excmlevel}, @option{intlevels}, @option{debuglevel},"},{"line_number":11066,"context_line":"@option{ibreaknum}, or @option{dbreaknum}.  @var{value} is an integer with"}],"source_content_type":"text/x-texinfo","patch_set":2,"id":"c459c45f_03bf3d61","line":11063,"in_reply_to":"4a18661e_2bf74c0c","updated":"2022-07-09 20:07:03.000000000","message":"Removed \"xtensa xtopt bigendian\" from documentation.  @antonio, would you be OK with leaving this as an undocumented option until our tools are updated to generate the proper configure command, or should I remove big endian generic xtensa target support from the patch?","commit_id":"3ad47b3e590c83481e235836447cb3c57adf68ab"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"415fa425b7557afd0ba10ec3e8df898bdfafc525","unresolved":false,"context_lines":[{"line_number":11060,"context_line":""},{"line_number":11061,"context_line":"@deffn {Command} {xtensa xtopt} option value"},{"line_number":11062,"context_line":"Configure Xtensa target options that are relevant to the debug subsystem."},{"line_number":11063,"context_line":"@var{option} is one of: @option{bigendian}, @option{arnum}, @option{windowed},"},{"line_number":11064,"context_line":"@option{cpenable}, @option{exceptions}, @option{intnum}, @option{hipriints},"},{"line_number":11065,"context_line":"@option{excmlevel}, @option{intlevels}, @option{debuglevel},"},{"line_number":11066,"context_line":"@option{ibreaknum}, or @option{dbreaknum}.  @var{value} is an integer with"}],"source_content_type":"text/x-texinfo","patch_set":2,"id":"0a622b0a_10788a6b","line":11063,"in_reply_to":"c459c45f_03bf3d61","updated":"2022-07-14 15:27:04.000000000","message":"Confirmed that xtensa core config files can specify \"xtensa configure -endian big\".  Deprecating \"xtopt bigendian\" but leaving it in-place until our tools are updated.  Removed xtensa-\u003ecore_config endian option and now rely on target-\u003eendianness instead.  Antonio, please advise if you\u0027d prefer this is removed entirely.","commit_id":"3ad47b3e590c83481e235836447cb3c57adf68ab"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"412371ebcf0293cb271e00e162b1379e7d5beae0","unresolved":true,"context_lines":[{"line_number":11028,"context_line":""},{"line_number":11029,"context_line":"Xtensa is a highly-customizable, user-extensible microprocessor and DSP"},{"line_number":11030,"context_line":"architecture for complex embedded systems provided by Cadence Design"},{"line_number":11031,"context_line":"Systems, Inc.  See the"},{"line_number":11032,"context_line":"@uref{https://www.cadence.com/en_US/home/tools/ip/tensilica-ip.html, Tensilica IP}"},{"line_number":11033,"context_line":"website for additional information and documentation."},{"line_number":11034,"context_line":""}],"source_content_type":"text/x-texinfo","patch_set":12,"id":"0722d577_43885936","line":11031,"updated":"2022-07-25 15:28:31.000000000","message":"remove the double space","commit_id":"2956b0353914d2fc81655cc8a7133228b0f5555c"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"c5b0f250831da2735ba01a7815be1871588e2f62","unresolved":false,"context_lines":[{"line_number":11028,"context_line":""},{"line_number":11029,"context_line":"Xtensa is a highly-customizable, user-extensible microprocessor and DSP"},{"line_number":11030,"context_line":"architecture for complex embedded systems provided by Cadence Design"},{"line_number":11031,"context_line":"Systems, Inc.  See the"},{"line_number":11032,"context_line":"@uref{https://www.cadence.com/en_US/home/tools/ip/tensilica-ip.html, Tensilica IP}"},{"line_number":11033,"context_line":"website for additional information and documentation."},{"line_number":11034,"context_line":""}],"source_content_type":"text/x-texinfo","patch_set":12,"id":"aae16fca_b945c471","line":11031,"in_reply_to":"0722d577_43885936","updated":"2022-08-02 01:05:14.000000000","message":"Done","commit_id":"2956b0353914d2fc81655cc8a7133228b0f5555c"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"412371ebcf0293cb271e00e162b1379e7d5beae0","unresolved":true,"context_lines":[{"line_number":11038,"context_line":"size instructions support, memory banks configuration etc.  OpenOCD also supports SMP"},{"line_number":11039,"context_line":"configurations for Xtensa processors with any number of cores and allows configuring"},{"line_number":11040,"context_line":"their debug interconnect (termed \"break/stall networks\"), which control how debug"},{"line_number":11041,"context_line":"signals are distributed among cores.  Xtensa \"break networks\" are compatible with"},{"line_number":11042,"context_line":"ARM\u0027s Cross Trigger Interface (CTI).  OpenOCD implements both generic Xtensa targets"},{"line_number":11043,"context_line":"as well as several Espressif Xtensa-based chips from the"},{"line_number":11044,"context_line":"@uref{https://www.espressif.com/en/products/socs, ESP32 family}."}],"source_content_type":"text/x-texinfo","patch_set":12,"id":"73f626ab_4fe83623","line":11041,"updated":"2022-07-25 15:28:31.000000000","message":"remove the double space","commit_id":"2956b0353914d2fc81655cc8a7133228b0f5555c"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"c5b0f250831da2735ba01a7815be1871588e2f62","unresolved":false,"context_lines":[{"line_number":11038,"context_line":"size instructions support, memory banks configuration etc.  OpenOCD also supports SMP"},{"line_number":11039,"context_line":"configurations for Xtensa processors with any number of cores and allows configuring"},{"line_number":11040,"context_line":"their debug interconnect (termed \"break/stall networks\"), which control how debug"},{"line_number":11041,"context_line":"signals are distributed among cores.  Xtensa \"break networks\" are compatible with"},{"line_number":11042,"context_line":"ARM\u0027s Cross Trigger Interface (CTI).  OpenOCD implements both generic Xtensa targets"},{"line_number":11043,"context_line":"as well as several Espressif Xtensa-based chips from the"},{"line_number":11044,"context_line":"@uref{https://www.espressif.com/en/products/socs, ESP32 family}."}],"source_content_type":"text/x-texinfo","patch_set":12,"id":"a44e5816_60caed58","line":11041,"in_reply_to":"73f626ab_4fe83623","updated":"2022-08-02 01:05:14.000000000","message":"Done","commit_id":"2956b0353914d2fc81655cc8a7133228b0f5555c"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"412371ebcf0293cb271e00e162b1379e7d5beae0","unresolved":true,"context_lines":[{"line_number":11039,"context_line":"configurations for Xtensa processors with any number of cores and allows configuring"},{"line_number":11040,"context_line":"their debug interconnect (termed \"break/stall networks\"), which control how debug"},{"line_number":11041,"context_line":"signals are distributed among cores.  Xtensa \"break networks\" are compatible with"},{"line_number":11042,"context_line":"ARM\u0027s Cross Trigger Interface (CTI).  OpenOCD implements both generic Xtensa targets"},{"line_number":11043,"context_line":"as well as several Espressif Xtensa-based chips from the"},{"line_number":11044,"context_line":"@uref{https://www.espressif.com/en/products/socs, ESP32 family}."},{"line_number":11045,"context_line":""}],"source_content_type":"text/x-texinfo","patch_set":12,"id":"f0483dbb_84848005","line":11042,"updated":"2022-07-25 15:28:31.000000000","message":"remove the double space","commit_id":"2956b0353914d2fc81655cc8a7133228b0f5555c"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"c5b0f250831da2735ba01a7815be1871588e2f62","unresolved":false,"context_lines":[{"line_number":11039,"context_line":"configurations for Xtensa processors with any number of cores and allows configuring"},{"line_number":11040,"context_line":"their debug interconnect (termed \"break/stall networks\"), which control how debug"},{"line_number":11041,"context_line":"signals are distributed among cores.  Xtensa \"break networks\" are compatible with"},{"line_number":11042,"context_line":"ARM\u0027s Cross Trigger Interface (CTI).  OpenOCD implements both generic Xtensa targets"},{"line_number":11043,"context_line":"as well as several Espressif Xtensa-based chips from the"},{"line_number":11044,"context_line":"@uref{https://www.espressif.com/en/products/socs, ESP32 family}."},{"line_number":11045,"context_line":""}],"source_content_type":"text/x-texinfo","patch_set":12,"id":"67ae12ad_41c40ed2","line":11042,"in_reply_to":"f0483dbb_84848005","updated":"2022-08-02 01:05:14.000000000","message":"Done","commit_id":"2956b0353914d2fc81655cc8a7133228b0f5555c"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"412371ebcf0293cb271e00e162b1379e7d5beae0","unresolved":true,"context_lines":[{"line_number":11045,"context_line":""},{"line_number":11046,"context_line":"OCD sessions for Xtensa processor and DSP targets are accessed via the Xtensa"},{"line_number":11047,"context_line":"Debug Module (XDM), which provides external connectivity either through a"},{"line_number":11048,"context_line":"traditional JTAG interface or an ARM DAP interface.  If used, the DAP interface"},{"line_number":11049,"context_line":"can control Xtensa targets through JTAG or SWD probes."},{"line_number":11050,"context_line":""},{"line_number":11051,"context_line":"@subsection Xtensa Core Configuration"}],"source_content_type":"text/x-texinfo","patch_set":12,"id":"ed3a70d3_7f584453","line":11048,"updated":"2022-07-25 15:28:31.000000000","message":"remove the double space","commit_id":"2956b0353914d2fc81655cc8a7133228b0f5555c"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"c5b0f250831da2735ba01a7815be1871588e2f62","unresolved":false,"context_lines":[{"line_number":11045,"context_line":""},{"line_number":11046,"context_line":"OCD sessions for Xtensa processor and DSP targets are accessed via the Xtensa"},{"line_number":11047,"context_line":"Debug Module (XDM), which provides external connectivity either through a"},{"line_number":11048,"context_line":"traditional JTAG interface or an ARM DAP interface.  If used, the DAP interface"},{"line_number":11049,"context_line":"can control Xtensa targets through JTAG or SWD probes."},{"line_number":11050,"context_line":""},{"line_number":11051,"context_line":"@subsection Xtensa Core Configuration"}],"source_content_type":"text/x-texinfo","patch_set":12,"id":"50d5fc39_7b816f28","line":11048,"in_reply_to":"ed3a70d3_7f584453","updated":"2022-08-02 01:05:14.000000000","message":"Done","commit_id":"2956b0353914d2fc81655cc8a7133228b0f5555c"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"ce47b5e04fde40afa679f35fb34d37948f516179","unresolved":false,"context_lines":[{"line_number":11051,"context_line":"@subsection Xtensa Core Configuration"},{"line_number":11052,"context_line":""},{"line_number":11053,"context_line":"Due to the high level of configurability in Xtensa cores, the Xtensa target"},{"line_number":11054,"context_line":"configuration comprises two categories:"},{"line_number":11055,"context_line":""},{"line_number":11056,"context_line":"@enumerate"},{"line_number":11057,"context_line":"@item Base Xtensa support common to all core configurations, and"}],"source_content_type":"text/x-texinfo","patch_set":12,"id":"fa10badb_b071c2a9","line":11054,"updated":"2022-07-23 16:24:39.000000000","message":"pushing minor change to ensure jenkins kicks off (prior patchset had no diffs)","commit_id":"2956b0353914d2fc81655cc8a7133228b0f5555c"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"412371ebcf0293cb271e00e162b1379e7d5beae0","unresolved":true,"context_lines":[{"line_number":11060,"context_line":""},{"line_number":11061,"context_line":"All common Xtensa support is built into the OpenOCD Xtensa target layer and"},{"line_number":11062,"context_line":"is enabled through a combination of TCL scripts: the target-specific"},{"line_number":11063,"context_line":"@code{target/xtensa.cfg} and a board-specific @code{board/xtensa-*.cfg},"},{"line_number":11064,"context_line":"similar to other target architectures."},{"line_number":11065,"context_line":""},{"line_number":11066,"context_line":"Importantly, core-specific configuration information must be provided by"}],"source_content_type":"text/x-texinfo","patch_set":12,"id":"704e8118_17931688","line":11063,"updated":"2022-07-25 15:28:31.000000000","message":"use @file{target/xtensa.cfg} and @file{board/xtensa-*.cfg}","commit_id":"2956b0353914d2fc81655cc8a7133228b0f5555c"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"c5b0f250831da2735ba01a7815be1871588e2f62","unresolved":false,"context_lines":[{"line_number":11060,"context_line":""},{"line_number":11061,"context_line":"All common Xtensa support is built into the OpenOCD Xtensa target layer and"},{"line_number":11062,"context_line":"is enabled through a combination of TCL scripts: the target-specific"},{"line_number":11063,"context_line":"@code{target/xtensa.cfg} and a board-specific @code{board/xtensa-*.cfg},"},{"line_number":11064,"context_line":"similar to other target architectures."},{"line_number":11065,"context_line":""},{"line_number":11066,"context_line":"Importantly, core-specific configuration information must be provided by"}],"source_content_type":"text/x-texinfo","patch_set":12,"id":"a34ffb37_015efb25","line":11063,"in_reply_to":"704e8118_17931688","updated":"2022-08-02 01:05:14.000000000","message":"Done","commit_id":"2956b0353914d2fc81655cc8a7133228b0f5555c"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"412371ebcf0293cb271e00e162b1379e7d5beae0","unresolved":true,"context_lines":[{"line_number":11064,"context_line":"similar to other target architectures."},{"line_number":11065,"context_line":""},{"line_number":11066,"context_line":"Importantly, core-specific configuration information must be provided by"},{"line_number":11067,"context_line":"the user, and takes the form of an @code{xtensa-core-XXX.cfg} TCL script that"},{"line_number":11068,"context_line":"defines the core\u0027s configurable features through a series of Xtensa"},{"line_number":11069,"context_line":"configuration commands (detailed below)."},{"line_number":11070,"context_line":""}],"source_content_type":"text/x-texinfo","patch_set":12,"id":"4eee5a42_d6d6ddc7","line":11067,"updated":"2022-07-25 15:28:31.000000000","message":"@file{xtensa-core-*.cfg}","commit_id":"2956b0353914d2fc81655cc8a7133228b0f5555c"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"c5b0f250831da2735ba01a7815be1871588e2f62","unresolved":false,"context_lines":[{"line_number":11064,"context_line":"similar to other target architectures."},{"line_number":11065,"context_line":""},{"line_number":11066,"context_line":"Importantly, core-specific configuration information must be provided by"},{"line_number":11067,"context_line":"the user, and takes the form of an @code{xtensa-core-XXX.cfg} TCL script that"},{"line_number":11068,"context_line":"defines the core\u0027s configurable features through a series of Xtensa"},{"line_number":11069,"context_line":"configuration commands (detailed below)."},{"line_number":11070,"context_line":""}],"source_content_type":"text/x-texinfo","patch_set":12,"id":"1b323ae5_053a9b7f","line":11067,"in_reply_to":"4eee5a42_d6d6ddc7","updated":"2022-08-02 01:05:14.000000000","message":"Done","commit_id":"2956b0353914d2fc81655cc8a7133228b0f5555c"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"412371ebcf0293cb271e00e162b1379e7d5beae0","unresolved":true,"context_lines":[{"line_number":11068,"context_line":"defines the core\u0027s configurable features through a series of Xtensa"},{"line_number":11069,"context_line":"configuration commands (detailed below)."},{"line_number":11070,"context_line":""},{"line_number":11071,"context_line":"This core-specific @code{xtensa-core-XXX.cfg} file is typically either:"},{"line_number":11072,"context_line":""},{"line_number":11073,"context_line":"@itemize @bullet"},{"line_number":11074,"context_line":"@item Located within the Xtensa core configuration build as"}],"source_content_type":"text/x-texinfo","patch_set":12,"id":"4676dd06_4b454d88","line":11071,"updated":"2022-07-25 15:28:31.000000000","message":"same here, @file{xtensa-core-*.cfg}\nFew more cases below","commit_id":"2956b0353914d2fc81655cc8a7133228b0f5555c"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"c5b0f250831da2735ba01a7815be1871588e2f62","unresolved":false,"context_lines":[{"line_number":11068,"context_line":"defines the core\u0027s configurable features through a series of Xtensa"},{"line_number":11069,"context_line":"configuration commands (detailed below)."},{"line_number":11070,"context_line":""},{"line_number":11071,"context_line":"This core-specific @code{xtensa-core-XXX.cfg} file is typically either:"},{"line_number":11072,"context_line":""},{"line_number":11073,"context_line":"@itemize @bullet"},{"line_number":11074,"context_line":"@item Located within the Xtensa core configuration build as"}],"source_content_type":"text/x-texinfo","patch_set":12,"id":"ed427a5e_0f90a6cd","line":11071,"in_reply_to":"4676dd06_4b454d88","updated":"2022-08-02 01:05:14.000000000","message":"Done","commit_id":"2956b0353914d2fc81655cc8a7133228b0f5555c"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"412371ebcf0293cb271e00e162b1379e7d5beae0","unresolved":true,"context_lines":[{"line_number":11082,"context_line":""},{"line_number":11083,"context_line":"Some example Xtensa configurations are bundled with OpenOCD for reference:"},{"line_number":11084,"context_line":"@itemize @bullet"},{"line_number":11085,"context_line":"@item Cadence Palladium VDebug emulation target.  The user can combine their"},{"line_number":11086,"context_line":"@code{xtensa-core-XXX.cfg} with the provided"},{"line_number":11087,"context_line":"@code{board/xtensa-palladium-vdebug.cfg} to debug an emulated Xtensa RTL design."},{"line_number":11088,"context_line":"@item NXP MIMXRT685-EVK evaluation kit.  The relevant configuration files are"}],"source_content_type":"text/x-texinfo","patch_set":12,"id":"c56a0fe9_abfe1761","line":11085,"updated":"2022-07-25 15:28:31.000000000","message":"remove the double space\nother cases below","commit_id":"2956b0353914d2fc81655cc8a7133228b0f5555c"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"c5b0f250831da2735ba01a7815be1871588e2f62","unresolved":false,"context_lines":[{"line_number":11082,"context_line":""},{"line_number":11083,"context_line":"Some example Xtensa configurations are bundled with OpenOCD for reference:"},{"line_number":11084,"context_line":"@itemize @bullet"},{"line_number":11085,"context_line":"@item Cadence Palladium VDebug emulation target.  The user can combine their"},{"line_number":11086,"context_line":"@code{xtensa-core-XXX.cfg} with the provided"},{"line_number":11087,"context_line":"@code{board/xtensa-palladium-vdebug.cfg} to debug an emulated Xtensa RTL design."},{"line_number":11088,"context_line":"@item NXP MIMXRT685-EVK evaluation kit.  The relevant configuration files are"}],"source_content_type":"text/x-texinfo","patch_set":12,"id":"76268745_ac5a85de","line":11085,"in_reply_to":"c56a0fe9_abfe1761","updated":"2022-08-02 01:05:14.000000000","message":"Done. Sorry for all the double-spacing. \u003d)","commit_id":"2956b0353914d2fc81655cc8a7133228b0f5555c"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b9e524d1dc17a4c692f894f1d768b7f84923d270","unresolved":true,"context_lines":[{"line_number":11159,"context_line":""},{"line_number":11160,"context_line":"@subsection Xtensa Debug Module Configuration Commands"},{"line_number":11161,"context_line":""},{"line_number":11162,"context_line":"@deffn {Command} {xtensa dm offset} value"},{"line_number":11163,"context_line":"Configure the Xtensa Debug Module (DM) to apply a fixed offset when accessing"},{"line_number":11164,"context_line":"debug registers behind a DAP interface (typically over APB). The offset"},{"line_number":11165,"context_line":"value must be aligned to the size of the DM register file, typically 16KB."}],"source_content_type":"text/x-texinfo","patch_set":15,"id":"a056f5ef_d7b5d76d","line":11162,"updated":"2022-08-11 15:26:20.000000000","message":"I cannot find this command in the code.\nActually I was checking if \"offset\" is a parameter and has to be placed outside the {}, but cannot find this at all!","commit_id":"a817f792f2204ffe905d92e52a8809043d08372b"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"c58c0783e8d29dc0143e37c0b1b6a71045e648d8","unresolved":false,"context_lines":[{"line_number":11159,"context_line":""},{"line_number":11160,"context_line":"@subsection Xtensa Debug Module Configuration Commands"},{"line_number":11161,"context_line":""},{"line_number":11162,"context_line":"@deffn {Command} {xtensa dm offset} value"},{"line_number":11163,"context_line":"Configure the Xtensa Debug Module (DM) to apply a fixed offset when accessing"},{"line_number":11164,"context_line":"debug registers behind a DAP interface (typically over APB). The offset"},{"line_number":11165,"context_line":"value must be aligned to the size of the DM register file, typically 16KB."}],"source_content_type":"text/x-texinfo","patch_set":15,"id":"b45dd5a1_8169d70e","line":11162,"in_reply_to":"a056f5ef_d7b5d76d","updated":"2022-08-11 18:02:23.000000000","message":"This is a debug module command that will be added with another upcoming patch for DAP support.  I\u0027ll pull it out of this patch.  Thanks for catching this!","commit_id":"a817f792f2204ffe905d92e52a8809043d08372b"}],"src/server/gdb_server.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"e70dcb598c55716a7fe8711c93d85a9b4a9a5569","unresolved":true,"context_lines":[{"line_number":1335,"context_line":"\tfor (i \u003d 0; i \u003c reg_list_size; i++) {"},{"line_number":1336,"context_line":"\t\tuint8_t *bin_buf;"},{"line_number":1337,"context_line":"\t\tif (!reg_list[i] || !reg_list[i]-\u003eexist)"},{"line_number":1338,"context_line":"\t\t\tcontinue;"},{"line_number":1339,"context_line":"\t\tint chars \u003d (DIV_ROUND_UP(reg_list[i]-\u003esize, 8) * 2);"},{"line_number":1340,"context_line":""},{"line_number":1341,"context_line":"\t\tif (packet_p + chars \u003e packet + packet_size)"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"f0e38724_2d1380ca","line":1338,"updated":"2022-07-02 10:46:25.000000000","message":"maybe in a separate patch, explaining why?\nSame for some other changes in this file","commit_id":"3ad47b3e590c83481e235836447cb3c57adf68ab"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"57cea4e224a3054044dfbfbc7a3249e1d0f5c059","unresolved":false,"context_lines":[{"line_number":1335,"context_line":"\tfor (i \u003d 0; i \u003c reg_list_size; i++) {"},{"line_number":1336,"context_line":"\t\tuint8_t *bin_buf;"},{"line_number":1337,"context_line":"\t\tif (!reg_list[i] || !reg_list[i]-\u003eexist)"},{"line_number":1338,"context_line":"\t\t\tcontinue;"},{"line_number":1339,"context_line":"\t\tint chars \u003d (DIV_ROUND_UP(reg_list[i]-\u003esize, 8) * 2);"},{"line_number":1340,"context_line":""},{"line_number":1341,"context_line":"\t\tif (packet_p + chars \u003e packet + packet_size)"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"0399d1a9_a2f599ba","line":1338,"in_reply_to":"6792fc17_42c630b2","updated":"2022-07-09 20:07:03.000000000","message":"Moving out to a separate patch","commit_id":"3ad47b3e590c83481e235836447cb3c57adf68ab"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"6813ae26ab1302fe0374ed373fbba4d4ca9495a3","unresolved":true,"context_lines":[{"line_number":1335,"context_line":"\tfor (i \u003d 0; i \u003c reg_list_size; i++) {"},{"line_number":1336,"context_line":"\t\tuint8_t *bin_buf;"},{"line_number":1337,"context_line":"\t\tif (!reg_list[i] || !reg_list[i]-\u003eexist)"},{"line_number":1338,"context_line":"\t\t\tcontinue;"},{"line_number":1339,"context_line":"\t\tint chars \u003d (DIV_ROUND_UP(reg_list[i]-\u003esize, 8) * 2);"},{"line_number":1340,"context_line":""},{"line_number":1341,"context_line":"\t\tif (packet_p + chars \u003e packet + packet_size)"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"6792fc17_42c630b2","line":1338,"in_reply_to":"b8fd33da_c430fd72","updated":"2022-07-05 09:03:57.000000000","message":"I think this covers the \"generic\" case of non-contiguous address, for example on Xtensa processors.\nIt makes sense to be in a separate patch","commit_id":"3ad47b3e590c83481e235836447cb3c57adf68ab"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"e8e58b52c712bb777c4e5328fef656f1a2830d92","unresolved":true,"context_lines":[{"line_number":1335,"context_line":"\tfor (i \u003d 0; i \u003c reg_list_size; i++) {"},{"line_number":1336,"context_line":"\t\tuint8_t *bin_buf;"},{"line_number":1337,"context_line":"\t\tif (!reg_list[i] || !reg_list[i]-\u003eexist)"},{"line_number":1338,"context_line":"\t\t\tcontinue;"},{"line_number":1339,"context_line":"\t\tint chars \u003d (DIV_ROUND_UP(reg_list[i]-\u003esize, 8) * 2);"},{"line_number":1340,"context_line":""},{"line_number":1341,"context_line":"\t\tif (packet_p + chars \u003e packet + packet_size)"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"b8fd33da_c430fd72","line":1338,"in_reply_to":"f0e38724_2d1380ca","updated":"2022-07-04 22:48:12.000000000","message":"These are required for compatibility with Cadence\u0027s xt-gdb (Xtensa GDB port) because Cadence addresses target registers through non-contiguous addresses--different Xtensa processor configurations contain combinations of various registers.  \n\nI will split this out into a separate patch, but the resulting intermediate commit will not be verifiable with generic xtensa targets until both reviews are committed (xt-gdb requires this to connect).  Please let me know if this is problematic. I will keep Espressif targets working throughout.","commit_id":"3ad47b3e590c83481e235836447cb3c57adf68ab"}],"src/target/espressif/esp32s2.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"412371ebcf0293cb271e00e162b1379e7d5beae0","unresolved":true,"context_lines":[{"line_number":471,"context_line":"static const struct command_registration esp32s2_command_handlers[] \u003d {"},{"line_number":472,"context_line":"\t{"},{"line_number":473,"context_line":"\t\t.mode \u003d COMMAND_ANY,"},{"line_number":474,"context_line":"\t\t.help \u003d \"Xtensa commands group\","},{"line_number":475,"context_line":"\t\t.chain \u003d xtensa_command_handlers,"},{"line_number":476,"context_line":"\t},"},{"line_number":477,"context_line":"\tCOMMAND_REGISTRATION_DONE"}],"source_content_type":"text/x-csrc","patch_set":12,"id":"6de1bde0_3ab4a06c","line":474,"updated":"2022-07-25 15:28:31.000000000","message":"in case of simple chain with no other .name, you can remove .mode and .help and left .chain alone","commit_id":"2956b0353914d2fc81655cc8a7133228b0f5555c"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"c5b0f250831da2735ba01a7815be1871588e2f62","unresolved":false,"context_lines":[{"line_number":471,"context_line":"static const struct command_registration esp32s2_command_handlers[] \u003d {"},{"line_number":472,"context_line":"\t{"},{"line_number":473,"context_line":"\t\t.mode \u003d COMMAND_ANY,"},{"line_number":474,"context_line":"\t\t.help \u003d \"Xtensa commands group\","},{"line_number":475,"context_line":"\t\t.chain \u003d xtensa_command_handlers,"},{"line_number":476,"context_line":"\t},"},{"line_number":477,"context_line":"\tCOMMAND_REGISTRATION_DONE"}],"source_content_type":"text/x-csrc","patch_set":12,"id":"65f1230a_e2cba7bb","line":474,"in_reply_to":"6de1bde0_3ab4a06c","updated":"2022-08-02 01:05:14.000000000","message":"Done","commit_id":"2956b0353914d2fc81655cc8a7133228b0f5555c"}],"src/target/espressif/esp32s3.h":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"e70dcb598c55716a7fe8711c93d85a9b4a9a5569","unresolved":true,"context_lines":[{"line_number":19,"context_line":"#ifndef OPENOCD_TARGET_ESP32S3_H"},{"line_number":20,"context_line":"#define OPENOCD_TARGET_ESP32S3_H"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"#include \u003ctarget/xtensa/xtensa_regs.h\u003e"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"#endif\t/* OPENOCD_TARGET_ESP32S3_H */"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"d1b6d8e1_aea9600a","line":22,"updated":"2022-07-02 10:46:25.000000000","message":"this include file is now empty. Can be removed and let C files include directly xtensa_regs.h ?","commit_id":"3ad47b3e590c83481e235836447cb3c57adf68ab"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"4db412858b6a79a2d0bc2057e53e6ab833324fd3","unresolved":true,"context_lines":[{"line_number":19,"context_line":"#ifndef OPENOCD_TARGET_ESP32S3_H"},{"line_number":20,"context_line":"#define OPENOCD_TARGET_ESP32S3_H"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"#include \u003ctarget/xtensa/xtensa_regs.h\u003e"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"#endif\t/* OPENOCD_TARGET_ESP32S3_H */"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"cba9545f_413ea37b","line":22,"in_reply_to":"94bc2643_b34b983a","updated":"2022-07-05 04:36:34.000000000","message":"@Ian, lets remove esp32.h, esp32s2.h and esp32s3.h for now. If needed, I can add them later.","commit_id":"3ad47b3e590c83481e235836447cb3c57adf68ab"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"57cea4e224a3054044dfbfbc7a3249e1d0f5c059","unresolved":false,"context_lines":[{"line_number":19,"context_line":"#ifndef OPENOCD_TARGET_ESP32S3_H"},{"line_number":20,"context_line":"#define OPENOCD_TARGET_ESP32S3_H"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"#include \u003ctarget/xtensa/xtensa_regs.h\u003e"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"#endif\t/* OPENOCD_TARGET_ESP32S3_H */"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"0b09e271_4dd0f1d1","line":22,"in_reply_to":"cba9545f_413ea37b","updated":"2022-07-09 20:07:03.000000000","message":"Done","commit_id":"3ad47b3e590c83481e235836447cb3c57adf68ab"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"e8e58b52c712bb777c4e5328fef656f1a2830d92","unresolved":true,"context_lines":[{"line_number":19,"context_line":"#ifndef OPENOCD_TARGET_ESP32S3_H"},{"line_number":20,"context_line":"#define OPENOCD_TARGET_ESP32S3_H"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"#include \u003ctarget/xtensa/xtensa_regs.h\u003e"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"#endif\t/* OPENOCD_TARGET_ESP32S3_H */"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"94bc2643_b34b983a","line":22,"in_reply_to":"d1b6d8e1_aea9600a","updated":"2022-07-04 22:48:12.000000000","message":"I believe @erhan has more code going into these header files, so I left them intact for his upcoming merge, but can remove them from this patch if that doesn\u0027t cause him too much trouble.  Erhan, can you please comment?","commit_id":"3ad47b3e590c83481e235836447cb3c57adf68ab"}],"src/target/espressif/esp_xtensa_smp.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"e70dcb598c55716a7fe8711c93d85a9b4a9a5569","unresolved":true,"context_lines":[{"line_number":831,"context_line":"\t\t.mode \u003d COMMAND_ANY,"},{"line_number":832,"context_line":"\t\t.help \u003d \"Configure format of Xtensa register map\","},{"line_number":833,"context_line":"\t\t.usage \u003d \"\u003cnumgregs\u003e\","},{"line_number":834,"context_line":"\t},"},{"line_number":835,"context_line":"\t{"},{"line_number":836,"context_line":"\t\t.name \u003d \"set_permissive\","},{"line_number":837,"context_line":"\t\t.handler \u003d esp_xtensa_smp_cmd_permissive_mode,"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"76882481_a145c4dd","line":834,"updated":"2022-07-02 10:46:25.000000000","message":"these are all commands to configure the target type. Are you sure can be used after OpenOCD command \"init\" ? Or should have\n.mode \u003d COMMAND_CONFIG,\n?","commit_id":"3ad47b3e590c83481e235836447cb3c57adf68ab"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"57cea4e224a3054044dfbfbc7a3249e1d0f5c059","unresolved":false,"context_lines":[{"line_number":831,"context_line":"\t\t.mode \u003d COMMAND_ANY,"},{"line_number":832,"context_line":"\t\t.help \u003d \"Configure format of Xtensa register map\","},{"line_number":833,"context_line":"\t\t.usage \u003d \"\u003cnumgregs\u003e\","},{"line_number":834,"context_line":"\t},"},{"line_number":835,"context_line":"\t{"},{"line_number":836,"context_line":"\t\t.name \u003d \"set_permissive\","},{"line_number":837,"context_line":"\t\t.handler \u003d esp_xtensa_smp_cmd_permissive_mode,"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"05ed39a5_a2b1091e","line":834,"in_reply_to":"76882481_a145c4dd","updated":"2022-07-09 20:07:03.000000000","message":"Done.  Thanks for the tip!","commit_id":"3ad47b3e590c83481e235836447cb3c57adf68ab"}],"src/target/target_type.h":[{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"4b4bd9c9a9c167e9dbc189b236c1ca2ccfcdc4de","unresolved":false,"context_lines":[{"line_number":299,"context_line":""},{"line_number":300,"context_line":"\t/* parse target-specific GDB query commands"},{"line_number":301,"context_line":"\t */"},{"line_number":302,"context_line":"\tint (*gdb_query_custom)(struct target *target, const char *packet, char **response_p);"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"\t/* do target profiling"},{"line_number":305,"context_line":"\t */"}],"source_content_type":"text/x-csrc","patch_set":7,"id":"75f54bb5_fc362b69","line":302,"updated":"2022-07-11 00:51:08.000000000","message":"Please see patch 7082.  Included here for reference in xtensa_chip.c.","commit_id":"6ee279edcf92a4453aeffd1cd89a2d57752491c3"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b9e524d1dc17a4c692f894f1d768b7f84923d270","unresolved":true,"context_lines":[{"line_number":289,"context_line":"\t/* parse target-specific GDB query commands"},{"line_number":290,"context_line":"\t */"},{"line_number":291,"context_line":"\tint (*gdb_query_custom)(struct target *target, const char *packet, char **response_p);"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"\t/* do target profiling"},{"line_number":294,"context_line":"\t */"},{"line_number":295,"context_line":"\tint (*profiling)(struct target *target, uint32_t *samples,"}],"source_content_type":"text/x-csrc","patch_set":15,"id":"7a903e90_dd9a0cf6","line":292,"updated":"2022-08-11 15:26:20.000000000","message":"???\nIsn\u0027t this already moved to https://review.openocd.org/7082/ ?\nThis patch should be rebase on top of it.\nI plan to merge 7082 in the weekend or Monday at last; you could be able to rebase this on master branch soon","commit_id":"a817f792f2204ffe905d92e52a8809043d08372b"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"25df20b85d48eac43c1f22757111dc7725332f05","unresolved":false,"context_lines":[{"line_number":289,"context_line":"\t/* parse target-specific GDB query commands"},{"line_number":290,"context_line":"\t */"},{"line_number":291,"context_line":"\tint (*gdb_query_custom)(struct target *target, const char *packet, char **response_p);"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"\t/* do target profiling"},{"line_number":294,"context_line":"\t */"},{"line_number":295,"context_line":"\tint (*profiling)(struct target *target, uint32_t *samples,"}],"source_content_type":"text/x-csrc","patch_set":15,"id":"daf98a56_2ac3de0f","line":292,"in_reply_to":"180d491e_0f4c5306","updated":"2022-08-11 18:16:00.000000000","message":"I will approve this version, as it should be possible to merge it next week.\nI do not have preferences.\nI let you decide either to add this line as separate patch or to send a new version of this patch, either can work after the weekend merge.","commit_id":"a817f792f2204ffe905d92e52a8809043d08372b"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"c58c0783e8d29dc0143e37c0b1b6a71045e648d8","unresolved":false,"context_lines":[{"line_number":289,"context_line":"\t/* parse target-specific GDB query commands"},{"line_number":290,"context_line":"\t */"},{"line_number":291,"context_line":"\tint (*gdb_query_custom)(struct target *target, const char *packet, char **response_p);"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"\t/* do target profiling"},{"line_number":294,"context_line":"\t */"},{"line_number":295,"context_line":"\tint (*profiling)(struct target *target, uint32_t *samples,"}],"source_content_type":"text/x-csrc","patch_set":15,"id":"180d491e_0f4c5306","line":292,"in_reply_to":"7a903e90_dd9a0cf6","updated":"2022-08-11 18:02:23.000000000","message":"I originally had this in here to enable easier testing since our Xtensa GDB tool requires responding to query commands for it to connect to the target.  I\u0027m removing it, as it will be merged in 7082, but I also have to remove the hook assignment in xtensa_chip.c.  I will add that one-liner back in after this group of patches is merged.  This should not impact @erhan\u0027s platforms, which use a different GDB overlay.  I\u0027d rather keep these 2 patches independent so both can be merged sooner...please let me know if another plan is preferred though.  Thanks.","commit_id":"a817f792f2204ffe905d92e52a8809043d08372b"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"060b90462b3b697deeeb42c87a572939e0c39c79","unresolved":false,"context_lines":[{"line_number":289,"context_line":"\t/* parse target-specific GDB query commands"},{"line_number":290,"context_line":"\t */"},{"line_number":291,"context_line":"\tint (*gdb_query_custom)(struct target *target, const char *packet, char **response_p);"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"\t/* do target profiling"},{"line_number":294,"context_line":"\t */"},{"line_number":295,"context_line":"\tint (*profiling)(struct target *target, uint32_t *samples,"}],"source_content_type":"text/x-csrc","patch_set":15,"id":"fbfaf9c2_01d71ef9","line":292,"in_reply_to":"daf98a56_2ac3de0f","updated":"2022-08-11 19:04:34.000000000","message":"I\u0027d like to follow up with a separate patch, as having this merged sooner will keep @erhan up and running.  Thanks for the offer.","commit_id":"a817f792f2204ffe905d92e52a8809043d08372b"}],"src/target/xtensa/xtensa.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"e70dcb598c55716a7fe8711c93d85a9b4a9a5569","unresolved":true,"context_lines":[{"line_number":1278,"context_line":"\t\t\t\t\treturn ERROR_FAIL;"},{"line_number":1279,"context_line":"\t\t\t\t}"},{"line_number":1280,"context_line":"\t\t\t\t(*reg_list)[sparse_idx] \u003d \u0026xtensa-\u003ecore_cache-\u003ereg_list[xtensa-\u003eeps_dbglevel_idx];"},{"line_number":1281,"context_line":"#if 0"},{"line_number":1282,"context_line":"\t\t\t\tLOG_DEBUG(\"SPARSE GDB reg 0x%x getting EPS%d 0x%x\","},{"line_number":1283,"context_line":"\t\t\t\t\tsparse_idx, xtensa-\u003ecore_config-\u003edebug.irq_level,"},{"line_number":1284,"context_line":"\t\t\t\t\txtensa_reg_get_value((*reg_list)[sparse_idx]));"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"c1726a2c_25ed293b","line":1281,"updated":"2022-07-02 10:46:25.000000000","message":"please no #if 0. The internal part will not be compiled and after some updates of this file it could become garbage that does not compile anymore.\nIf you really want to hide some message, use another way: at the beginning of this file add\n /* set to true for extra debug logs */\n static const bool extra_debug_logs \u003d false;\nand here:\n if (extra_debug_logs)\n    LOG_DEBUG(...);\nBeing the variable const, the compiler will remove the LOG_DEBUG, but will still check the C syntax.\nI see other similar cases below","commit_id":"3ad47b3e590c83481e235836447cb3c57adf68ab"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"e8e58b52c712bb777c4e5328fef656f1a2830d92","unresolved":false,"context_lines":[{"line_number":1278,"context_line":"\t\t\t\t\treturn ERROR_FAIL;"},{"line_number":1279,"context_line":"\t\t\t\t}"},{"line_number":1280,"context_line":"\t\t\t\t(*reg_list)[sparse_idx] \u003d \u0026xtensa-\u003ecore_cache-\u003ereg_list[xtensa-\u003eeps_dbglevel_idx];"},{"line_number":1281,"context_line":"#if 0"},{"line_number":1282,"context_line":"\t\t\t\tLOG_DEBUG(\"SPARSE GDB reg 0x%x getting EPS%d 0x%x\","},{"line_number":1283,"context_line":"\t\t\t\t\tsparse_idx, xtensa-\u003ecore_config-\u003edebug.irq_level,"},{"line_number":1284,"context_line":"\t\t\t\t\txtensa_reg_get_value((*reg_list)[sparse_idx]));"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"e6dd055a_4fa8102f","line":1281,"in_reply_to":"c1726a2c_25ed293b","updated":"2022-07-04 22:48:12.000000000","message":"Much cleaner.  Thanks for the suggestion.","commit_id":"3ad47b3e590c83481e235836447cb3c57adf68ab"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"a6e0c50c57cd72875f997a15e874ca4fdb83b4d2","unresolved":true,"context_lines":[{"line_number":3122,"context_line":""},{"line_number":3123,"context_line":"\tconst char *opt_name \u003d CMD_ARGV[0];"},{"line_number":3124,"context_line":"\tint opt_val \u003d strtol(CMD_ARGV[1], NULL, 0);"},{"line_number":3125,"context_line":"\tif (strcasecmp(opt_name, \"bigendian\") \u003d\u003d 0) {"},{"line_number":3126,"context_line":"\t\tif (!xtensa_cmd_xtopt_legal_val(\"bigendian\", opt_val, 0, 1))"},{"line_number":3127,"context_line":"\t\t\treturn ERROR_COMMAND_ARGUMENT_INVALID;"},{"line_number":3128,"context_line":"\t\txtensa-\u003ecore_config-\u003eendianness \u003d"}],"source_content_type":"text/x-csrc","patch_set":7,"id":"245f4be1_654df751","line":3125,"updated":"2022-07-19 16:45:21.000000000","message":"We don\u0027t need this command anymore. Endianness is an option to target create command. \n\ne.g.\ntarget create $_TARGETNAME_0 $_CHIPNAME -endian little -chain-position $_TARGETNAME_0 -coreid 0","commit_id":"6ee279edcf92a4453aeffd1cd89a2d57752491c3"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"8b2f2761145144ed952bf5e39579fc639d6eb214","unresolved":false,"context_lines":[{"line_number":3122,"context_line":""},{"line_number":3123,"context_line":"\tconst char *opt_name \u003d CMD_ARGV[0];"},{"line_number":3124,"context_line":"\tint opt_val \u003d strtol(CMD_ARGV[1], NULL, 0);"},{"line_number":3125,"context_line":"\tif (strcasecmp(opt_name, \"bigendian\") \u003d\u003d 0) {"},{"line_number":3126,"context_line":"\t\tif (!xtensa_cmd_xtopt_legal_val(\"bigendian\", opt_val, 0, 1))"},{"line_number":3127,"context_line":"\t\t\treturn ERROR_COMMAND_ARGUMENT_INVALID;"},{"line_number":3128,"context_line":"\t\txtensa-\u003ecore_config-\u003eendianness \u003d"}],"source_content_type":"text/x-csrc","patch_set":7,"id":"528a9a20_9a9e0aa0","line":3125,"in_reply_to":"245f4be1_654df751","updated":"2022-07-20 19:37:21.000000000","message":"Removed from target code and esp core config files.","commit_id":"6ee279edcf92a4453aeffd1cd89a2d57752491c3"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"e635dc4e6740057f1ce5e412defe81f5ddf762bc","unresolved":true,"context_lines":[{"line_number":1796,"context_line":"\t\tbool prev_suppress \u003d xtensa-\u003esuppress_dsr_errors;"},{"line_number":1797,"context_line":"\t\txtensa-\u003esuppress_dsr_errors \u003d true;"},{"line_number":1798,"context_line":"\t\tres \u003d xtensa_core_status_check(target);"},{"line_number":1799,"context_line":"\t\tif (xtensa-\u003eprobe_lsddr32p \u003d\u003d -1) {"},{"line_number":1800,"context_line":"\t\t\txtensa-\u003eprobe_lsddr32p \u003d 1;"},{"line_number":1801,"context_line":"\t\t}"},{"line_number":1802,"context_line":"\t\txtensa-\u003esuppress_dsr_errors \u003d prev_suppress;"}],"source_content_type":"text/x-csrc","patch_set":9,"id":"2e821013_bd00e7fd","line":1799,"updated":"2022-07-20 20:56:35.000000000","message":"WARNING: braces {} are not necessary for single statement blocks","commit_id":"8490c7412d2223f766096fde641c604fd6c30c10"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"ff8ce1355058885aecec4e7aa85418e6acfaa63a","unresolved":false,"context_lines":[{"line_number":1796,"context_line":"\t\tbool prev_suppress \u003d xtensa-\u003esuppress_dsr_errors;"},{"line_number":1797,"context_line":"\t\txtensa-\u003esuppress_dsr_errors \u003d true;"},{"line_number":1798,"context_line":"\t\tres \u003d xtensa_core_status_check(target);"},{"line_number":1799,"context_line":"\t\tif (xtensa-\u003eprobe_lsddr32p \u003d\u003d -1) {"},{"line_number":1800,"context_line":"\t\t\txtensa-\u003eprobe_lsddr32p \u003d 1;"},{"line_number":1801,"context_line":"\t\t}"},{"line_number":1802,"context_line":"\t\txtensa-\u003esuppress_dsr_errors \u003d prev_suppress;"}],"source_content_type":"text/x-csrc","patch_set":9,"id":"b24e381a_254f4a6f","line":1799,"in_reply_to":"2e821013_bd00e7fd","updated":"2022-07-21 00:10:07.000000000","message":"Sorry about that.  I forgot to run checkpatch.  Fixing...","commit_id":"8490c7412d2223f766096fde641c604fd6c30c10"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"e635dc4e6740057f1ce5e412defe81f5ddf762bc","unresolved":true,"context_lines":[{"line_number":1972,"context_line":"\t\tbool prev_suppress \u003d xtensa-\u003esuppress_dsr_errors;"},{"line_number":1973,"context_line":"\t\txtensa-\u003esuppress_dsr_errors \u003d true;"},{"line_number":1974,"context_line":"\t\tres \u003d xtensa_core_status_check(target);"},{"line_number":1975,"context_line":"\t\tif (xtensa-\u003eprobe_lsddr32p \u003d\u003d -1) {"},{"line_number":1976,"context_line":"\t\t\txtensa-\u003eprobe_lsddr32p \u003d 1;"},{"line_number":1977,"context_line":"\t\t}"},{"line_number":1978,"context_line":"\t\txtensa-\u003esuppress_dsr_errors \u003d prev_suppress;"}],"source_content_type":"text/x-csrc","patch_set":9,"id":"fd5ddb15_851750c9","line":1975,"updated":"2022-07-20 20:56:35.000000000","message":"WARNING: braces {} are not necessary for single statement blocks","commit_id":"8490c7412d2223f766096fde641c604fd6c30c10"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"05d0e4c97b95927b38fc970a6a610f3c85760f9e","unresolved":false,"context_lines":[{"line_number":1972,"context_line":"\t\tbool prev_suppress \u003d xtensa-\u003esuppress_dsr_errors;"},{"line_number":1973,"context_line":"\t\txtensa-\u003esuppress_dsr_errors \u003d true;"},{"line_number":1974,"context_line":"\t\tres \u003d xtensa_core_status_check(target);"},{"line_number":1975,"context_line":"\t\tif (xtensa-\u003eprobe_lsddr32p \u003d\u003d -1) {"},{"line_number":1976,"context_line":"\t\t\txtensa-\u003eprobe_lsddr32p \u003d 1;"},{"line_number":1977,"context_line":"\t\t}"},{"line_number":1978,"context_line":"\t\txtensa-\u003esuppress_dsr_errors \u003d prev_suppress;"}],"source_content_type":"text/x-csrc","patch_set":9,"id":"de069dce_82388a98","line":1975,"in_reply_to":"5babe41d_c636d310","updated":"2022-07-21 13:36:11.000000000","message":"Thanks.","commit_id":"8490c7412d2223f766096fde641c604fd6c30c10"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"ff8ce1355058885aecec4e7aa85418e6acfaa63a","unresolved":false,"context_lines":[{"line_number":1972,"context_line":"\t\tbool prev_suppress \u003d xtensa-\u003esuppress_dsr_errors;"},{"line_number":1973,"context_line":"\t\txtensa-\u003esuppress_dsr_errors \u003d true;"},{"line_number":1974,"context_line":"\t\tres \u003d xtensa_core_status_check(target);"},{"line_number":1975,"context_line":"\t\tif (xtensa-\u003eprobe_lsddr32p \u003d\u003d -1) {"},{"line_number":1976,"context_line":"\t\t\txtensa-\u003eprobe_lsddr32p \u003d 1;"},{"line_number":1977,"context_line":"\t\t}"},{"line_number":1978,"context_line":"\t\txtensa-\u003esuppress_dsr_errors \u003d prev_suppress;"}],"source_content_type":"text/x-csrc","patch_set":9,"id":"5babe41d_c636d310","line":1975,"in_reply_to":"fd5ddb15_851750c9","updated":"2022-07-21 00:10:07.000000000","message":"Thanks.  Fixing...","commit_id":"8490c7412d2223f766096fde641c604fd6c30c10"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"412371ebcf0293cb271e00e162b1379e7d5beae0","unresolved":true,"context_lines":[{"line_number":1,"context_line":"/* SPDX-License-Identifier: GPL-2.0-or-later */"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"/***************************************************************************"},{"line_number":4,"context_line":" *   SPDX-License-Identifier: GPL-2.0-or-later                             *"},{"line_number":5,"context_line":" *                                                                         *"},{"line_number":6,"context_line":" *   Generic Xtensa target API for OpenOCD                                 *"},{"line_number":7,"context_line":" *   Copyright (C) 2020-2022 Cadence Design Systems, Inc.                  *"}],"source_content_type":"text/x-csrc","patch_set":12,"id":"572d76c1_2192551e","line":4,"updated":"2022-07-25 15:28:31.000000000","message":"same here, the SPDX is already present","commit_id":"2956b0353914d2fc81655cc8a7133228b0f5555c"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"c5b0f250831da2735ba01a7815be1871588e2f62","unresolved":false,"context_lines":[{"line_number":1,"context_line":"/* SPDX-License-Identifier: GPL-2.0-or-later */"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"/***************************************************************************"},{"line_number":4,"context_line":" *   SPDX-License-Identifier: GPL-2.0-or-later                             *"},{"line_number":5,"context_line":" *                                                                         *"},{"line_number":6,"context_line":" *   Generic Xtensa target API for OpenOCD                                 *"},{"line_number":7,"context_line":" *   Copyright (C) 2020-2022 Cadence Design Systems, Inc.                  *"}],"source_content_type":"text/x-csrc","patch_set":12,"id":"7abc0643_e9982a47","line":4,"in_reply_to":"572d76c1_2192551e","updated":"2022-08-02 01:05:14.000000000","message":"Done","commit_id":"2956b0353914d2fc81655cc8a7133228b0f5555c"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"412371ebcf0293cb271e00e162b1379e7d5beae0","unresolved":true,"context_lines":[{"line_number":1505,"context_line":"\t/* Xtensa LX has an ICOUNTLEVEL register which sets the maximum interrupt level"},{"line_number":1506,"context_line":"\t * at which the instructions are to be counted while stepping."},{"line_number":1507,"context_line":"\t *"},{"line_number":1508,"context_line":"\t * For example, if we need to step by 2 instructions, and an interrupt occurrs"},{"line_number":1509,"context_line":"\t * in between, the processor will trigger the interrupt and halt after the 2nd"},{"line_number":1510,"context_line":"\t * instruction within the interrupt vector and/or handler."},{"line_number":1511,"context_line":"\t *"}],"source_content_type":"text/x-csrc","patch_set":12,"id":"764b7860_3dc3436f","line":1508,"updated":"2022-07-25 15:28:31.000000000","message":"typo? s/occurrs/occurs/ ?? I\u0027m not sure!","commit_id":"2956b0353914d2fc81655cc8a7133228b0f5555c"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"c5b0f250831da2735ba01a7815be1871588e2f62","unresolved":false,"context_lines":[{"line_number":1505,"context_line":"\t/* Xtensa LX has an ICOUNTLEVEL register which sets the maximum interrupt level"},{"line_number":1506,"context_line":"\t * at which the instructions are to be counted while stepping."},{"line_number":1507,"context_line":"\t *"},{"line_number":1508,"context_line":"\t * For example, if we need to step by 2 instructions, and an interrupt occurrs"},{"line_number":1509,"context_line":"\t * in between, the processor will trigger the interrupt and halt after the 2nd"},{"line_number":1510,"context_line":"\t * instruction within the interrupt vector and/or handler."},{"line_number":1511,"context_line":"\t *"}],"source_content_type":"text/x-csrc","patch_set":12,"id":"95dfeda9_38e633dd","line":1508,"in_reply_to":"764b7860_3dc3436f","updated":"2022-08-02 01:05:14.000000000","message":"Good catch! Thanks. Always appreciate getting typos fixed.","commit_id":"2956b0353914d2fc81655cc8a7133228b0f5555c"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"412371ebcf0293cb271e00e162b1379e7d5beae0","unresolved":true,"context_lines":[{"line_number":1512,"context_line":"\t * However, sometimes we don\u0027t want the interrupt handlers to be executed at all"},{"line_number":1513,"context_line":"\t * while stepping through the code. In this case (XT_STEPPING_ISR_OFF),"},{"line_number":1514,"context_line":"\t * ICOUNTLEVEL can be lowered to the executing code\u0027s (level + 1) to prevent ISR"},{"line_number":1515,"context_line":"\t * code from being counted during stepping.  Note that C execption handlers must"},{"line_number":1516,"context_line":"\t * run at level 0 and hence will be counted and stepped into, should one occur."},{"line_number":1517,"context_line":"\t *"},{"line_number":1518,"context_line":"\t * TODO: Certain instructions should never be single-stepped and should instead"}],"source_content_type":"text/x-csrc","patch_set":12,"id":"4adafa3f_ae3397a6","line":1515,"updated":"2022-07-25 15:28:31.000000000","message":"typo s/../exception/","commit_id":"2956b0353914d2fc81655cc8a7133228b0f5555c"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"c5b0f250831da2735ba01a7815be1871588e2f62","unresolved":false,"context_lines":[{"line_number":1512,"context_line":"\t * However, sometimes we don\u0027t want the interrupt handlers to be executed at all"},{"line_number":1513,"context_line":"\t * while stepping through the code. In this case (XT_STEPPING_ISR_OFF),"},{"line_number":1514,"context_line":"\t * ICOUNTLEVEL can be lowered to the executing code\u0027s (level + 1) to prevent ISR"},{"line_number":1515,"context_line":"\t * code from being counted during stepping.  Note that C execption handlers must"},{"line_number":1516,"context_line":"\t * run at level 0 and hence will be counted and stepped into, should one occur."},{"line_number":1517,"context_line":"\t *"},{"line_number":1518,"context_line":"\t * TODO: Certain instructions should never be single-stepped and should instead"}],"source_content_type":"text/x-csrc","patch_set":12,"id":"08e3b6fd_0f86281e","line":1515,"in_reply_to":"4adafa3f_ae3397a6","updated":"2022-08-02 01:05:14.000000000","message":"Thanks!","commit_id":"2956b0353914d2fc81655cc8a7133228b0f5555c"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"412371ebcf0293cb271e00e162b1379e7d5beae0","unresolved":true,"context_lines":[{"line_number":3508,"context_line":"\t\t\treturn ERROR_OK;"},{"line_number":3509,"context_line":"\t\t}"},{"line_number":3510,"context_line":"\t}"},{"line_number":3511,"context_line":"\tLOG_ERROR(\"xtregfmt \u003ccontiguous|sparse\u003e [numgregs]\");"},{"line_number":3512,"context_line":"\treturn ERROR_COMMAND_SYNTAX_ERROR;"},{"line_number":3513,"context_line":"}"},{"line_number":3514,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":12,"id":"64012e0e_2e8a968c","line":3511,"updated":"2022-07-25 15:28:31.000000000","message":"on return ERROR_COMMAND_SYNTAX_ERROR we should not LOG_ERROR the reason. OpenOCD prints the .usage text that should be enough","commit_id":"2956b0353914d2fc81655cc8a7133228b0f5555c"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"c5b0f250831da2735ba01a7815be1871588e2f62","unresolved":false,"context_lines":[{"line_number":3508,"context_line":"\t\t\treturn ERROR_OK;"},{"line_number":3509,"context_line":"\t\t}"},{"line_number":3510,"context_line":"\t}"},{"line_number":3511,"context_line":"\tLOG_ERROR(\"xtregfmt \u003ccontiguous|sparse\u003e [numgregs]\");"},{"line_number":3512,"context_line":"\treturn ERROR_COMMAND_SYNTAX_ERROR;"},{"line_number":3513,"context_line":"}"},{"line_number":3514,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":12,"id":"72535ff7_e194298a","line":3511,"in_reply_to":"64012e0e_2e8a968c","updated":"2022-08-02 01:05:14.000000000","message":"Fixed here as well as in xtensa_cmd_xtreg_do().","commit_id":"2956b0353914d2fc81655cc8a7133228b0f5555c"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"412371ebcf0293cb271e00e162b1379e7d5beae0","unresolved":true,"context_lines":[{"line_number":3880,"context_line":"\t\t}"},{"line_number":3881,"context_line":"\t}"},{"line_number":3882,"context_line":"\tfree(tracemem);"},{"line_number":3883,"context_line":"\tif (is_all_zeroes) {"},{"line_number":3884,"context_line":"\t\tcommand_print("},{"line_number":3885,"context_line":"\t\t\tCMD,"},{"line_number":3886,"context_line":"\t\t\t\"WARNING: File written is all zeroes. Are you sure you enabled trace memory?\");"}],"source_content_type":"text/x-csrc","patch_set":12,"id":"7ee63cf4_becc787f","line":3883,"updated":"2022-07-25 15:28:31.000000000","message":"no need to add {} around a single statement. I have seen you added few other such cases in this file","commit_id":"2956b0353914d2fc81655cc8a7133228b0f5555c"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"c5b0f250831da2735ba01a7815be1871588e2f62","unresolved":true,"context_lines":[{"line_number":3880,"context_line":"\t\t}"},{"line_number":3881,"context_line":"\t}"},{"line_number":3882,"context_line":"\tfree(tracemem);"},{"line_number":3883,"context_line":"\tif (is_all_zeroes) {"},{"line_number":3884,"context_line":"\t\tcommand_print("},{"line_number":3885,"context_line":"\t\t\tCMD,"},{"line_number":3886,"context_line":"\t\t\t\"WARNING: File written is all zeroes. Are you sure you enabled trace memory?\");"}],"source_content_type":"text/x-csrc","patch_set":12,"id":"c19320b8_15fa97e8","line":3883,"in_reply_to":"7ee63cf4_becc787f","updated":"2022-08-02 01:05:14.000000000","message":"I believe this is Espressif\u0027s formatting preference for single statement blocks spanning multiple lines, and will trigger errors from their uncrustify script.  Can braces be kept for these cases, or should I remove them and request @erhan update their scripts?","commit_id":"2956b0353914d2fc81655cc8a7133228b0f5555c"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"19fdf485a22557d4e383bc6d1f9a744d32fad034","unresolved":true,"context_lines":[{"line_number":3880,"context_line":"\t\t}"},{"line_number":3881,"context_line":"\t}"},{"line_number":3882,"context_line":"\tfree(tracemem);"},{"line_number":3883,"context_line":"\tif (is_all_zeroes) {"},{"line_number":3884,"context_line":"\t\tcommand_print("},{"line_number":3885,"context_line":"\t\t\tCMD,"},{"line_number":3886,"context_line":"\t\t\t\"WARNING: File written is all zeroes. Are you sure you enabled trace memory?\");"}],"source_content_type":"text/x-csrc","patch_set":12,"id":"bc2bc632_5ff44e8e","line":3883,"in_reply_to":"7ee63cf4_becc787f","updated":"2022-08-02 09:41:57.000000000","message":"This is because of the uncrustify mod_full_brace_if_chain\u003d1 parameter. It works well with the short lines. But if it splits the line, evaluates as multiple statement. Also if there is a comment under the if() , again thinks that it is multiple statement. checkpatch doesn\u0027t angry with this behavior. \n\nAntonio, Can we keep as is? If not, sorry @Ian for the extra work. I will create another patch to align uncrustify config with this behavior. But I couldn\u0027t find the proper flag yet.","commit_id":"2956b0353914d2fc81655cc8a7133228b0f5555c"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"74cb2e6fa91588f14df9a96621d4a1440a6394da","unresolved":false,"context_lines":[{"line_number":3880,"context_line":"\t\t}"},{"line_number":3881,"context_line":"\t}"},{"line_number":3882,"context_line":"\tfree(tracemem);"},{"line_number":3883,"context_line":"\tif (is_all_zeroes) {"},{"line_number":3884,"context_line":"\t\tcommand_print("},{"line_number":3885,"context_line":"\t\t\tCMD,"},{"line_number":3886,"context_line":"\t\t\t\"WARNING: File written is all zeroes. Are you sure you enabled trace memory?\");"}],"source_content_type":"text/x-csrc","patch_set":12,"id":"3f753967_af7e0b6f","line":3883,"in_reply_to":"b319ad77_44b72fa1","updated":"2022-08-04 15:45:55.000000000","message":"Removed braces around single statements wherever possible.  Hopefully this aligns better with existing OOCD style, and doesn\u0027t create too much trouble for Erhan.  Please advise if I changed too much in xtensa.c.","commit_id":"2956b0353914d2fc81655cc8a7133228b0f5555c"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"4f331a0069d144b713c1c8e4e3f56d0594afbc21","unresolved":true,"context_lines":[{"line_number":3880,"context_line":"\t\t}"},{"line_number":3881,"context_line":"\t}"},{"line_number":3882,"context_line":"\tfree(tracemem);"},{"line_number":3883,"context_line":"\tif (is_all_zeroes) {"},{"line_number":3884,"context_line":"\t\tcommand_print("},{"line_number":3885,"context_line":"\t\t\tCMD,"},{"line_number":3886,"context_line":"\t\t\t\"WARNING: File written is all zeroes. Are you sure you enabled trace memory?\");"}],"source_content_type":"text/x-csrc","patch_set":12,"id":"f40970e2_4b69fe20","line":3883,"in_reply_to":"bc2bc632_5ff44e8e","updated":"2022-08-03 22:10:58.000000000","message":"I have just replied to https://review.openocd.org/7080 regarding the current output of uncrustify.\nThis adding {} around a single statement is not aligned with the rest of the project\u0027s code (even if the coding style does not explicitly mention this point).\nActually uncrustify is broken or its config file not correct and cannot handle this case.\nAccepting this change now would mean we would eventually revert it once a better uncrustify arrives.\nTools like uncrustify and checkpatch are welcome, but humans should filter their output","commit_id":"2956b0353914d2fc81655cc8a7133228b0f5555c"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"91b9aa11546c6971c50609e8b73ecb2f66811170","unresolved":true,"context_lines":[{"line_number":3880,"context_line":"\t\t}"},{"line_number":3881,"context_line":"\t}"},{"line_number":3882,"context_line":"\tfree(tracemem);"},{"line_number":3883,"context_line":"\tif (is_all_zeroes) {"},{"line_number":3884,"context_line":"\t\tcommand_print("},{"line_number":3885,"context_line":"\t\t\tCMD,"},{"line_number":3886,"context_line":"\t\t\t\"WARNING: File written is all zeroes. Are you sure you enabled trace memory?\");"}],"source_content_type":"text/x-csrc","patch_set":12,"id":"b319ad77_44b72fa1","line":3883,"in_reply_to":"f40970e2_4b69fe20","updated":"2022-08-03 23:23:16.000000000","message":"Fair enough.  I will fix these in all files within this patchset, but may not have it completed until tomorrow.","commit_id":"2956b0353914d2fc81655cc8a7133228b0f5555c"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"412371ebcf0293cb271e00e162b1379e7d5beae0","unresolved":true,"context_lines":[{"line_number":4030,"context_line":"\t\t.handler \u003d xtensa_cmd_exe,"},{"line_number":4031,"context_line":"\t\t.mode \u003d COMMAND_ANY,"},{"line_number":4032,"context_line":"\t\t.help \u003d \"Xtensa stub execution\","},{"line_number":4033,"context_line":"\t\t.usage \u003d \"exe \u003cascii-encoded hexadecimal instruction bytes\u003e\","},{"line_number":4034,"context_line":"\t},"},{"line_number":4035,"context_line":"\tCOMMAND_REGISTRATION_DONE"},{"line_number":4036,"context_line":"};"}],"source_content_type":"text/x-csrc","patch_set":12,"id":"d4a24ec6_4bda9930","line":4033,"updated":"2022-07-25 15:28:31.000000000","message":"remove the command name \u0027exe\u0027 from the usage, OpenOCD already prepend it.\nShould this command be under \u0027xtensa\u0027?","commit_id":"2956b0353914d2fc81655cc8a7133228b0f5555c"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"405c7018e65eb02227ea37485439581a5c354d10","unresolved":false,"context_lines":[{"line_number":4030,"context_line":"\t\t.handler \u003d xtensa_cmd_exe,"},{"line_number":4031,"context_line":"\t\t.mode \u003d COMMAND_ANY,"},{"line_number":4032,"context_line":"\t\t.help \u003d \"Xtensa stub execution\","},{"line_number":4033,"context_line":"\t\t.usage \u003d \"exe \u003cascii-encoded hexadecimal instruction bytes\u003e\","},{"line_number":4034,"context_line":"\t},"},{"line_number":4035,"context_line":"\tCOMMAND_REGISTRATION_DONE"},{"line_number":4036,"context_line":"};"}],"source_content_type":"text/x-csrc","patch_set":12,"id":"252f6bd5_d06c9ab4","line":4033,"in_reply_to":"54237948_6dce3a05","updated":"2022-08-02 13:25:23.000000000","message":"Done; thanks Erhan.","commit_id":"2956b0353914d2fc81655cc8a7133228b0f5555c"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"19fdf485a22557d4e383bc6d1f9a744d32fad034","unresolved":true,"context_lines":[{"line_number":4030,"context_line":"\t\t.handler \u003d xtensa_cmd_exe,"},{"line_number":4031,"context_line":"\t\t.mode \u003d COMMAND_ANY,"},{"line_number":4032,"context_line":"\t\t.help \u003d \"Xtensa stub execution\","},{"line_number":4033,"context_line":"\t\t.usage \u003d \"exe \u003cascii-encoded hexadecimal instruction bytes\u003e\","},{"line_number":4034,"context_line":"\t},"},{"line_number":4035,"context_line":"\tCOMMAND_REGISTRATION_DONE"},{"line_number":4036,"context_line":"};"}],"source_content_type":"text/x-csrc","patch_set":12,"id":"54237948_6dce3a05","line":4033,"in_reply_to":"63ee0f4e_9b7c3b79","updated":"2022-08-02 09:41:57.000000000","message":"We don\u0027t use this command. Feel free to move it.","commit_id":"2956b0353914d2fc81655cc8a7133228b0f5555c"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"c5b0f250831da2735ba01a7815be1871588e2f62","unresolved":true,"context_lines":[{"line_number":4030,"context_line":"\t\t.handler \u003d xtensa_cmd_exe,"},{"line_number":4031,"context_line":"\t\t.mode \u003d COMMAND_ANY,"},{"line_number":4032,"context_line":"\t\t.help \u003d \"Xtensa stub execution\","},{"line_number":4033,"context_line":"\t\t.usage \u003d \"exe \u003cascii-encoded hexadecimal instruction bytes\u003e\","},{"line_number":4034,"context_line":"\t},"},{"line_number":4035,"context_line":"\tCOMMAND_REGISTRATION_DONE"},{"line_number":4036,"context_line":"};"}],"source_content_type":"text/x-csrc","patch_set":12,"id":"63ee0f4e_9b7c3b79","line":4033,"in_reply_to":"d4a24ec6_4bda9930","updated":"2022-08-02 01:05:14.000000000","message":"Removed exe and moved under \"xtensa\" command.  @erhan, please advise if this will cause problems for Espressif stub execution.","commit_id":"2956b0353914d2fc81655cc8a7133228b0f5555c"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b9e524d1dc17a4c692f894f1d768b7f84923d270","unresolved":true,"context_lines":[{"line_number":3989,"context_line":"\t\t.handler \u003d xtensa_cmd_exe,"},{"line_number":3990,"context_line":"\t\t.mode \u003d COMMAND_ANY,"},{"line_number":3991,"context_line":"\t\t.help \u003d \"Xtensa stub execution\","},{"line_number":3992,"context_line":"\t\t.usage \u003d \"\u003cascii-encoded hexadecimal instruction bytes\u003e\","},{"line_number":3993,"context_line":"\t},"},{"line_number":3994,"context_line":"\tCOMMAND_REGISTRATION_DONE"},{"line_number":3995,"context_line":"};"}],"source_content_type":"text/x-csrc","patch_set":15,"id":"211edfd0_46f7632c","line":3992,"updated":"2022-08-11 15:26:20.000000000","message":"this command is not documented in doc/openocd.texi\nCan you please add it?","commit_id":"a817f792f2204ffe905d92e52a8809043d08372b"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"c58c0783e8d29dc0143e37c0b1b6a71045e648d8","unresolved":false,"context_lines":[{"line_number":3989,"context_line":"\t\t.handler \u003d xtensa_cmd_exe,"},{"line_number":3990,"context_line":"\t\t.mode \u003d COMMAND_ANY,"},{"line_number":3991,"context_line":"\t\t.help \u003d \"Xtensa stub execution\","},{"line_number":3992,"context_line":"\t\t.usage \u003d \"\u003cascii-encoded hexadecimal instruction bytes\u003e\","},{"line_number":3993,"context_line":"\t},"},{"line_number":3994,"context_line":"\tCOMMAND_REGISTRATION_DONE"},{"line_number":3995,"context_line":"};"}],"source_content_type":"text/x-csrc","patch_set":15,"id":"d1e8282a_44251272","line":3992,"in_reply_to":"211edfd0_46f7632c","updated":"2022-08-11 18:02:23.000000000","message":"Done","commit_id":"a817f792f2204ffe905d92e52a8809043d08372b"}],"src/target/xtensa/xtensa.h":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"e70dcb598c55716a7fe8711c93d85a9b4a9a5569","unresolved":true,"context_lines":[{"line_number":154,"context_line":""},{"line_number":155,"context_line":"struct xtensa_config {"},{"line_number":156,"context_line":"\tenum xtensa_type core_type;"},{"line_number":157,"context_line":"\tbool bigendian;"},{"line_number":158,"context_line":"\tuint8_t aregs_num;"},{"line_number":159,"context_line":"\tbool windowed;"},{"line_number":160,"context_line":"\tbool coproc;"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"5e3bec18_66df369d","line":157,"updated":"2022-07-02 10:46:25.000000000","message":"why not using the existing\n struct target {\n   enum target_endianness endianness;\n   ...\n }","commit_id":"3ad47b3e590c83481e235836447cb3c57adf68ab"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"e8e58b52c712bb777c4e5328fef656f1a2830d92","unresolved":true,"context_lines":[{"line_number":154,"context_line":""},{"line_number":155,"context_line":"struct xtensa_config {"},{"line_number":156,"context_line":"\tenum xtensa_type core_type;"},{"line_number":157,"context_line":"\tbool bigendian;"},{"line_number":158,"context_line":"\tuint8_t aregs_num;"},{"line_number":159,"context_line":"\tbool windowed;"},{"line_number":160,"context_line":"\tbool coproc;"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"e5fd85af_77e806cd","line":157,"in_reply_to":"5e3bec18_66df369d","updated":"2022-07-04 22:48:12.000000000","message":"thanks.  will do.","commit_id":"3ad47b3e590c83481e235836447cb3c57adf68ab"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"57cea4e224a3054044dfbfbc7a3249e1d0f5c059","unresolved":false,"context_lines":[{"line_number":154,"context_line":""},{"line_number":155,"context_line":"struct xtensa_config {"},{"line_number":156,"context_line":"\tenum xtensa_type core_type;"},{"line_number":157,"context_line":"\tbool bigendian;"},{"line_number":158,"context_line":"\tuint8_t aregs_num;"},{"line_number":159,"context_line":"\tbool windowed;"},{"line_number":160,"context_line":"\tbool coproc;"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"7e5e07c3_c2e076ef","line":157,"in_reply_to":"e5fd85af_77e806cd","updated":"2022-07-09 20:07:03.000000000","message":"Done","commit_id":"3ad47b3e590c83481e235836447cb3c57adf68ab"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"412371ebcf0293cb271e00e162b1379e7d5beae0","unresolved":true,"context_lines":[{"line_number":1,"context_line":"/* SPDX-License-Identifier: GPL-2.0-or-later */"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"/***************************************************************************"},{"line_number":4,"context_line":" *   SPDX-License-Identifier: GPL-2.0-or-later                             *"},{"line_number":5,"context_line":" *                                                                         *"},{"line_number":6,"context_line":" *   Generic Xtensa target                                                 *"},{"line_number":7,"context_line":" *   Copyright (C) 2020-2022 Cadence Design Systems, Inc.                  *"}],"source_content_type":"text/x-csrc","patch_set":12,"id":"ac8eca23_86674f6e","line":4,"updated":"2022-07-25 15:28:31.000000000","message":"remove this line, the SPDX tag is already in the first line (and has to be in first line for automatic check)","commit_id":"2956b0353914d2fc81655cc8a7133228b0f5555c"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"c5b0f250831da2735ba01a7815be1871588e2f62","unresolved":false,"context_lines":[{"line_number":1,"context_line":"/* SPDX-License-Identifier: GPL-2.0-or-later */"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"/***************************************************************************"},{"line_number":4,"context_line":" *   SPDX-License-Identifier: GPL-2.0-or-later                             *"},{"line_number":5,"context_line":" *                                                                         *"},{"line_number":6,"context_line":" *   Generic Xtensa target                                                 *"},{"line_number":7,"context_line":" *   Copyright (C) 2020-2022 Cadence Design Systems, Inc.                  *"}],"source_content_type":"text/x-csrc","patch_set":12,"id":"94529ebf_a46f6182","line":4,"in_reply_to":"ac8eca23_86674f6e","updated":"2022-08-02 01:05:14.000000000","message":"Done","commit_id":"2956b0353914d2fc81655cc8a7133228b0f5555c"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b9e524d1dc17a4c692f894f1d768b7f84923d270","unresolved":true,"context_lines":[{"line_number":4,"context_line":" *   Generic Xtensa target                                                 *"},{"line_number":5,"context_line":" *   Copyright (C) 2020-2022 Cadence Design Systems, Inc.                  *"},{"line_number":6,"context_line":" *   Author: Ian Thompson \u003cianst@cadence.com\u003e                              *"},{"line_number":7,"context_line":" *                                                                         *"},{"line_number":8,"context_line":" *   Copyright (C) 2019 Espressif Systems Ltd.                             *"},{"line_number":9,"context_line":" *   Author: Alexey Gerenkov \u003calexey@espressif.com\u003e                        *"},{"line_number":10,"context_line":" ***************************************************************************/"}],"source_content_type":"text/x-csrc","patch_set":15,"id":"7c763d62_6ad43abc","line":7,"updated":"2022-08-11 15:26:20.000000000","message":"Erhan has removed the line below on author from Alexey in https://review.openocd.org/7104/ that I plan to merge in ~1 week.\nGerrit should be smart enough to handle this merge, probably no problem","commit_id":"a817f792f2204ffe905d92e52a8809043d08372b"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"25df20b85d48eac43c1f22757111dc7725332f05","unresolved":false,"context_lines":[{"line_number":4,"context_line":" *   Generic Xtensa target                                                 *"},{"line_number":5,"context_line":" *   Copyright (C) 2020-2022 Cadence Design Systems, Inc.                  *"},{"line_number":6,"context_line":" *   Author: Ian Thompson \u003cianst@cadence.com\u003e                              *"},{"line_number":7,"context_line":" *                                                                         *"},{"line_number":8,"context_line":" *   Copyright (C) 2019 Espressif Systems Ltd.                             *"},{"line_number":9,"context_line":" *   Author: Alexey Gerenkov \u003calexey@espressif.com\u003e                        *"},{"line_number":10,"context_line":" ***************************************************************************/"}],"source_content_type":"text/x-csrc","patch_set":15,"id":"92266cdd_cc8b695e","line":7,"in_reply_to":"708ff535_24848133","updated":"2022-08-11 18:16:00.000000000","message":"I\u0027m ok to left the author\u0027s name. I was only pointing a possible conflict after the weekend merge.\nAgoin, I let you decide.","commit_id":"a817f792f2204ffe905d92e52a8809043d08372b"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"c58c0783e8d29dc0143e37c0b1b6a71045e648d8","unresolved":false,"context_lines":[{"line_number":4,"context_line":" *   Generic Xtensa target                                                 *"},{"line_number":5,"context_line":" *   Copyright (C) 2020-2022 Cadence Design Systems, Inc.                  *"},{"line_number":6,"context_line":" *   Author: Ian Thompson \u003cianst@cadence.com\u003e                              *"},{"line_number":7,"context_line":" *                                                                         *"},{"line_number":8,"context_line":" *   Copyright (C) 2019 Espressif Systems Ltd.                             *"},{"line_number":9,"context_line":" *   Author: Alexey Gerenkov \u003calexey@espressif.com\u003e                        *"},{"line_number":10,"context_line":" ***************************************************************************/"}],"source_content_type":"text/x-csrc","patch_set":15,"id":"708ff535_24848133","line":7,"in_reply_to":"7c763d62_6ad43abc","updated":"2022-08-11 18:02:23.000000000","message":"I will also remove author lines with my name from other Xtensa files, but leave company copyrights intact per Antonio\u0027s conversation mentioned in 7104.  Attempting to do so in a way that won\u0027t cause future merge conflicts with Erhan\u0027s upcoming patch.","commit_id":"a817f792f2204ffe905d92e52a8809043d08372b"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"060b90462b3b697deeeb42c87a572939e0c39c79","unresolved":false,"context_lines":[{"line_number":4,"context_line":" *   Generic Xtensa target                                                 *"},{"line_number":5,"context_line":" *   Copyright (C) 2020-2022 Cadence Design Systems, Inc.                  *"},{"line_number":6,"context_line":" *   Author: Ian Thompson \u003cianst@cadence.com\u003e                              *"},{"line_number":7,"context_line":" *                                                                         *"},{"line_number":8,"context_line":" *   Copyright (C) 2019 Espressif Systems Ltd.                             *"},{"line_number":9,"context_line":" *   Author: Alexey Gerenkov \u003calexey@espressif.com\u003e                        *"},{"line_number":10,"context_line":" ***************************************************************************/"}],"source_content_type":"text/x-csrc","patch_set":15,"id":"d7ce8e55_b31d9f85","line":7,"in_reply_to":"92266cdd_cc8b695e","updated":"2022-08-11 19:04:34.000000000","message":"I checked around internally and our company policy seems to suggest not listing individual authors.  This is also in-line with Espressif\u0027s upcoming change, so I\u0027ll go incognito.  \u003d)","commit_id":"a817f792f2204ffe905d92e52a8809043d08372b"}],"src/target/xtensa/xtensa_chip.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"e70dcb598c55716a7fe8711c93d85a9b4a9a5569","unresolved":true,"context_lines":[{"line_number":83,"context_line":"\tstatic uint32_t value;"},{"line_number":84,"context_line":"\tuint8_t t[4] \u003d { 0, 0, 0, 0 };"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"#if 0"},{"line_number":87,"context_line":"\tstruct xtensa *xtensa \u003d target_to_xtensa(target);"},{"line_number":88,"context_line":"\tstruct xtensa_chip_common *xtensa_chip \u003d xtensa-\u003extensa_chip;"},{"line_number":89,"context_line":"\tif (xtensa_chip-\u003eflash_bootstrap \u003d\u003d FBS_TMSLOW) {"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"d2b78a4e_ddfc83c5","line":86,"updated":"2022-07-02 10:46:25.000000000","message":"what the purpose of having code in #if 0/#endif?","commit_id":"3ad47b3e590c83481e235836447cb3c57adf68ab"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"e8e58b52c712bb777c4e5328fef656f1a2830d92","unresolved":false,"context_lines":[{"line_number":83,"context_line":"\tstatic uint32_t value;"},{"line_number":84,"context_line":"\tuint8_t t[4] \u003d { 0, 0, 0, 0 };"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"#if 0"},{"line_number":87,"context_line":"\tstruct xtensa *xtensa \u003d target_to_xtensa(target);"},{"line_number":88,"context_line":"\tstruct xtensa_chip_common *xtensa_chip \u003d xtensa-\u003extensa_chip;"},{"line_number":89,"context_line":"\tif (xtensa_chip-\u003eflash_bootstrap \u003d\u003d FBS_TMSLOW) {"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"03b70d04_34096797","line":86,"in_reply_to":"d2b78a4e_ddfc83c5","updated":"2022-07-04 22:48:12.000000000","message":"This was from some merged Espressif code and accidentally left in here.  Removed; thanks.","commit_id":"3ad47b3e590c83481e235836447cb3c57adf68ab"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"412371ebcf0293cb271e00e162b1379e7d5beae0","unresolved":true,"context_lines":[{"line_number":1,"context_line":"/***************************************************************************"},{"line_number":2,"context_line":" *   SPDX-License-Identifier: GPL-2.0-or-later                             *"},{"line_number":3,"context_line":" *                                                                         *"},{"line_number":4,"context_line":" *   Xtensa Chip-level Target Support for OpenOCD                          *"}],"source_content_type":"text/x-csrc","patch_set":12,"id":"3e6f95aa_d5483ebf","line":1,"updated":"2022-07-25 15:28:31.000000000","message":"same here, no GPLv2 bolierplate","commit_id":"2956b0353914d2fc81655cc8a7133228b0f5555c"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"c5b0f250831da2735ba01a7815be1871588e2f62","unresolved":false,"context_lines":[{"line_number":1,"context_line":"/***************************************************************************"},{"line_number":2,"context_line":" *   SPDX-License-Identifier: GPL-2.0-or-later                             *"},{"line_number":3,"context_line":" *                                                                         *"},{"line_number":4,"context_line":" *   Xtensa Chip-level Target Support for OpenOCD                          *"}],"source_content_type":"text/x-csrc","patch_set":12,"id":"a63e174b_401acad2","line":1,"in_reply_to":"3e6f95aa_d5483ebf","updated":"2022-08-02 01:05:14.000000000","message":"Done.","commit_id":"2956b0353914d2fc81655cc8a7133228b0f5555c"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"412371ebcf0293cb271e00e162b1379e7d5beae0","unresolved":true,"context_lines":[{"line_number":61,"context_line":"\tenum target_state old_state \u003d target-\u003estate;"},{"line_number":62,"context_line":"\tint ret;"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"\tret \u003d xtensa_poll(target);"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"\tif (old_state !\u003d TARGET_HALTED \u0026\u0026 target-\u003estate \u003d\u003d TARGET_HALTED) {"},{"line_number":67,"context_line":"\t\t/*Call any event callbacks that are applicable */"}],"source_content_type":"text/x-csrc","patch_set":12,"id":"e08cd1e7_8d572d11","line":64,"updated":"2022-07-25 15:28:31.000000000","message":"int ret \u003d ...","commit_id":"2956b0353914d2fc81655cc8a7133228b0f5555c"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"c5b0f250831da2735ba01a7815be1871588e2f62","unresolved":false,"context_lines":[{"line_number":61,"context_line":"\tenum target_state old_state \u003d target-\u003estate;"},{"line_number":62,"context_line":"\tint ret;"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"\tret \u003d xtensa_poll(target);"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"\tif (old_state !\u003d TARGET_HALTED \u0026\u0026 target-\u003estate \u003d\u003d TARGET_HALTED) {"},{"line_number":67,"context_line":"\t\t/*Call any event callbacks that are applicable */"}],"source_content_type":"text/x-csrc","patch_set":12,"id":"323fa580_6ef105bd","line":64,"in_reply_to":"e08cd1e7_8d572d11","updated":"2022-08-02 01:05:14.000000000","message":"Done","commit_id":"2956b0353914d2fc81655cc8a7133228b0f5555c"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"412371ebcf0293cb271e00e162b1379e7d5beae0","unresolved":true,"context_lines":[{"line_number":82,"context_line":"*/"},{"line_number":83,"context_line":"void xtensa_chip_queue_tdi_idle(struct target *target)"},{"line_number":84,"context_line":"{"},{"line_number":85,"context_line":"\tstatic uint32_t value;"},{"line_number":86,"context_line":"\tuint8_t t[4] \u003d { 0, 0, 0, 0 };"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"\t/* Scan out 1 bit, do not move from IRPAUSE after we\u0027re done. */"}],"source_content_type":"text/x-csrc","patch_set":12,"id":"f095df13_d4143e9d","line":85,"updated":"2022-07-25 15:28:31.000000000","message":"why static? Not initialize, what value you transfer in t[]?\nThere is something that has no sense in this function","commit_id":"2956b0353914d2fc81655cc8a7133228b0f5555c"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"c5b0f250831da2735ba01a7815be1871588e2f62","unresolved":false,"context_lines":[{"line_number":82,"context_line":"*/"},{"line_number":83,"context_line":"void xtensa_chip_queue_tdi_idle(struct target *target)"},{"line_number":84,"context_line":"{"},{"line_number":85,"context_line":"\tstatic uint32_t value;"},{"line_number":86,"context_line":"\tuint8_t t[4] \u003d { 0, 0, 0, 0 };"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"\t/* Scan out 1 bit, do not move from IRPAUSE after we\u0027re done. */"}],"source_content_type":"text/x-csrc","patch_set":12,"id":"987f8a9a_d3fa61a3","line":85,"in_reply_to":"f095df13_d4143e9d","updated":"2022-08-02 01:05:14.000000000","message":"This was based on an Espressif function that doesn\u0027t make sense to be in the generic xtensa chip layer.  Removed.  @erhan, I don\u0027t think this should affect your platforms but please test with this change soon.  My testing on generic xtensa targets worked fine without this change.  Thanks.","commit_id":"2956b0353914d2fc81655cc8a7133228b0f5555c"}],"src/target/xtensa/xtensa_chip.h":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"e70dcb598c55716a7fe8711c93d85a9b4a9a5569","unresolved":true,"context_lines":[{"line_number":15,"context_line":" *                                                                         *"},{"line_number":16,"context_line":" *   You should have received a copy of the GNU General Public License     *"},{"line_number":17,"context_line":" *   along with this program.  If not, see \u003chttp://www.gnu.org/licenses/\u003e. *"},{"line_number":18,"context_line":" ***************************************************************************/"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"#ifndef OPENOCD_TARGET_XTENSA_CHIP_H"},{"line_number":21,"context_line":"#define OPENOCD_TARGET_XTENSA_CHIP_H"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"3965d009_fa79b000","line":18,"updated":"2022-07-02 10:46:25.000000000","message":"I\u0027m going to merge the long series for SPDX update of the licenses\nhttps://review.openocd.org/7051/\nPlease use SPDX on new files. Here:\n /* SPDX-License-Identifier: GPL-2.0-or-later */\n \n /*\n  * Copyright (C) 2020-2022 Cadence Design Systems, Inc.\n  * Author: Ian Thompson \u003cianst@cadence.com\u003e\n  *\n  * Xtensa Chip-level Target Support for OpenOCD\n  */","commit_id":"3ad47b3e590c83481e235836447cb3c57adf68ab"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"57cea4e224a3054044dfbfbc7a3249e1d0f5c059","unresolved":false,"context_lines":[{"line_number":15,"context_line":" *                                                                         *"},{"line_number":16,"context_line":" *   You should have received a copy of the GNU General Public License     *"},{"line_number":17,"context_line":" *   along with this program.  If not, see \u003chttp://www.gnu.org/licenses/\u003e. *"},{"line_number":18,"context_line":" ***************************************************************************/"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"#ifndef OPENOCD_TARGET_XTENSA_CHIP_H"},{"line_number":21,"context_line":"#define OPENOCD_TARGET_XTENSA_CHIP_H"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"c426c9d8_a976d8bc","line":18,"in_reply_to":"3965d009_fa79b000","updated":"2022-07-09 20:07:03.000000000","message":"done","commit_id":"3ad47b3e590c83481e235836447cb3c57adf68ab"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"412371ebcf0293cb271e00e162b1379e7d5beae0","unresolved":true,"context_lines":[{"line_number":1,"context_line":"/***************************************************************************"},{"line_number":2,"context_line":" *   SPDX-License-Identifier: GPL-2.0-or-later                             *"},{"line_number":3,"context_line":" *                                                                         *"},{"line_number":4,"context_line":" *   Xtensa Chip-level Target Support for OpenOCD                          *"}],"source_content_type":"text/x-csrc","patch_set":12,"id":"3aea3666_2b52919e","line":1,"updated":"2022-07-25 15:28:31.000000000","message":"I have just merged a huge series to get rid of the GPLv2 boilerplate in favor of SPDX. Here, please do the same:\n\n /* SPDX-License-Identifier: GPL-2.0-or-later */\n \n /***************************************************************************\n  *   Xtensa Chip-level Target Support for OpenOCD                          *\n  *   Copyright (C) 2020-2022 Cadence Design Systems, Inc.                  *\n  *   Author: Ian Thompson \u003cianst@cadence.com\u003e                              *\n  ***************************************************************************/","commit_id":"2956b0353914d2fc81655cc8a7133228b0f5555c"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"c5b0f250831da2735ba01a7815be1871588e2f62","unresolved":false,"context_lines":[{"line_number":1,"context_line":"/***************************************************************************"},{"line_number":2,"context_line":" *   SPDX-License-Identifier: GPL-2.0-or-later                             *"},{"line_number":3,"context_line":" *                                                                         *"},{"line_number":4,"context_line":" *   Xtensa Chip-level Target Support for OpenOCD                          *"}],"source_content_type":"text/x-csrc","patch_set":12,"id":"0af0b3fc_d4d82384","line":1,"in_reply_to":"3aea3666_2b52919e","updated":"2022-08-02 01:05:14.000000000","message":"Done. Sorry for the incorrect SPDX tag formatting.","commit_id":"2956b0353914d2fc81655cc8a7133228b0f5555c"}],"src/target/xtensa/xtensa_debug_module.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"e70dcb598c55716a7fe8711c93d85a9b4a9a5569","unresolved":true,"context_lines":[{"line_number":35,"context_line":"#define TAPINS_IDCODE_LEN       32"},{"line_number":36,"context_line":"#define TAPINS_BYPASS_LEN       1"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"static void xtensa_dm_add_set_ir(struct xtensa_debug_module *dm, uint8_t value)"},{"line_number":39,"context_line":"{"},{"line_number":40,"context_line":"\tstruct scan_field field;"},{"line_number":41,"context_line":"\tuint8_t t[4] \u003d { 0 };"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"36f423e0_a661ed00","line":38,"updated":"2022-07-02 10:46:25.000000000","message":"useless change that only increase the size of this already big patch. Can be dropped?","commit_id":"3ad47b3e590c83481e235836447cb3c57adf68ab"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"57cea4e224a3054044dfbfbc7a3249e1d0f5c059","unresolved":false,"context_lines":[{"line_number":35,"context_line":"#define TAPINS_IDCODE_LEN       32"},{"line_number":36,"context_line":"#define TAPINS_BYPASS_LEN       1"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"static void xtensa_dm_add_set_ir(struct xtensa_debug_module *dm, uint8_t value)"},{"line_number":39,"context_line":"{"},{"line_number":40,"context_line":"\tstruct scan_field field;"},{"line_number":41,"context_line":"\tuint8_t t[4] \u003d { 0 };"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"22680ad7_fcc461cf","line":38,"in_reply_to":"36f423e0_a661ed00","updated":"2022-07-09 20:07:03.000000000","message":"Done.  Was made to keep Espressif formatting tool happy, but will add to separate patch.","commit_id":"3ad47b3e590c83481e235836447cb3c57adf68ab"}],"src/target/xtensa/xtensa_debug_module.h":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"e70dcb598c55716a7fe8711c93d85a9b4a9a5569","unresolved":true,"context_lines":[{"line_number":352,"context_line":"\tint res \u003d xtensa_dm_device_id_read(dm);"},{"line_number":353,"context_line":"\tif (res !\u003d ERROR_OK)"},{"line_number":354,"context_line":"\t\treturn false;"},{"line_number":355,"context_line":"\treturn dm-\u003edevice_id !\u003d 0xffffffff \u0026\u0026 dm-\u003edevice_id !\u003d 0;"},{"line_number":356,"context_line":"}"},{"line_number":357,"context_line":""},{"line_number":358,"context_line":"static inline bool xtensa_dm_tap_was_reset(struct xtensa_debug_module *dm)"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"f2f6b5a4_81be2537","line":355,"updated":"2022-07-02 10:46:25.000000000","message":"maybe this change can be taken out of this already big patch, helping the review process.","commit_id":"3ad47b3e590c83481e235836447cb3c57adf68ab"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"57cea4e224a3054044dfbfbc7a3249e1d0f5c059","unresolved":false,"context_lines":[{"line_number":352,"context_line":"\tint res \u003d xtensa_dm_device_id_read(dm);"},{"line_number":353,"context_line":"\tif (res !\u003d ERROR_OK)"},{"line_number":354,"context_line":"\t\treturn false;"},{"line_number":355,"context_line":"\treturn dm-\u003edevice_id !\u003d 0xffffffff \u0026\u0026 dm-\u003edevice_id !\u003d 0;"},{"line_number":356,"context_line":"}"},{"line_number":357,"context_line":""},{"line_number":358,"context_line":"static inline bool xtensa_dm_tap_was_reset(struct xtensa_debug_module *dm)"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"86fac84a_6fc4237b","line":355,"in_reply_to":"f2f6b5a4_81be2537","updated":"2022-07-09 20:07:03.000000000","message":"Done.  @erhan, I will include this in a separate patch for this file unless you get to it first..","commit_id":"3ad47b3e590c83481e235836447cb3c57adf68ab"}],"src/target/xtensa/xtensa_regs.h":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"e70dcb598c55716a7fe8711c93d85a9b4a9a5569","unresolved":true,"context_lines":[{"line_number":44,"context_line":"\tXT_REG_IDX_AR13,"},{"line_number":45,"context_line":"\tXT_REG_IDX_AR14,"},{"line_number":46,"context_line":"\tXT_REG_IDX_AR15,"},{"line_number":47,"context_line":"\tXT_REG_IDX_ARLAST \u003d XT_REG_IDX_AR15 + 48,\t/* Max 64 ARs */"},{"line_number":48,"context_line":"\tXT_REG_IDX_WINDOWBASE,"},{"line_number":49,"context_line":"\tXT_REG_IDX_WINDOWSTART,"},{"line_number":50,"context_line":"\tXT_REG_IDX_PS,"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"433c5f81_bba2c906","line":47,"updated":"2022-07-02 10:46:25.000000000","message":"maybe something like:\n /* left space for other 48 AR registers */\n XT_REG_IDX_ARLAST \u003d 64,","commit_id":"3ad47b3e590c83481e235836447cb3c57adf68ab"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"e8e58b52c712bb777c4e5328fef656f1a2830d92","unresolved":false,"context_lines":[{"line_number":44,"context_line":"\tXT_REG_IDX_AR13,"},{"line_number":45,"context_line":"\tXT_REG_IDX_AR14,"},{"line_number":46,"context_line":"\tXT_REG_IDX_AR15,"},{"line_number":47,"context_line":"\tXT_REG_IDX_ARLAST \u003d XT_REG_IDX_AR15 + 48,\t/* Max 64 ARs */"},{"line_number":48,"context_line":"\tXT_REG_IDX_WINDOWBASE,"},{"line_number":49,"context_line":"\tXT_REG_IDX_WINDOWSTART,"},{"line_number":50,"context_line":"\tXT_REG_IDX_PS,"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"ba639cb0_888a6d4a","line":47,"in_reply_to":"433c5f81_bba2c906","updated":"2022-07-04 22:48:12.000000000","message":"done","commit_id":"3ad47b3e590c83481e235836447cb3c57adf68ab"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"412371ebcf0293cb271e00e162b1379e7d5beae0","unresolved":true,"context_lines":[{"line_number":1,"context_line":"/* SPDX-License-Identifier: GPL-2.0-or-later */"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"/***************************************************************************"},{"line_number":4,"context_line":" *   SPDX-License-Identifier: GPL-2.0-or-later                             *"},{"line_number":5,"context_line":" *                                                                         *"},{"line_number":6,"context_line":" *   Generic Xtensa target API for OpenOCD                                 *"},{"line_number":7,"context_line":" *   Copyright (C) 2020-2022 Cadence Design Systems, Inc.                  *"}],"source_content_type":"text/x-csrc","patch_set":12,"id":"42642f1a_a9dd6e95","line":4,"updated":"2022-07-25 15:28:31.000000000","message":"ditto","commit_id":"2956b0353914d2fc81655cc8a7133228b0f5555c"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"c5b0f250831da2735ba01a7815be1871588e2f62","unresolved":false,"context_lines":[{"line_number":1,"context_line":"/* SPDX-License-Identifier: GPL-2.0-or-later */"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"/***************************************************************************"},{"line_number":4,"context_line":" *   SPDX-License-Identifier: GPL-2.0-or-later                             *"},{"line_number":5,"context_line":" *                                                                         *"},{"line_number":6,"context_line":" *   Generic Xtensa target API for OpenOCD                                 *"},{"line_number":7,"context_line":" *   Copyright (C) 2020-2022 Cadence Design Systems, Inc.                  *"}],"source_content_type":"text/x-csrc","patch_set":12,"id":"b279014a_e6421371","line":4,"in_reply_to":"42642f1a_a9dd6e95","updated":"2022-08-02 01:05:14.000000000","message":"Done","commit_id":"2956b0353914d2fc81655cc8a7133228b0f5555c"}],"tcl/board/xtensa-kc705-flyswatter2.cfg":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"e70dcb598c55716a7fe8711c93d85a9b4a9a5569","unresolved":true,"context_lines":[{"line_number":10,"context_line":"transport select jtag"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"# Detailed trace output (e.g. level 3) can reduce performance"},{"line_number":13,"context_line":"# debug_level 2"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"# Create Xtensa target first"},{"line_number":16,"context_line":"source [find target/xtensa.cfg]"}],"source_content_type":"text/x-ttcn-cfg","patch_set":2,"id":"d66f07ec_f69880bd","line":13,"updated":"2022-07-02 10:46:25.000000000","message":"I think these 2 lines can be removed from a board file\ndebug_level 2 is already the default","commit_id":"3ad47b3e590c83481e235836447cb3c57adf68ab"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"e8e58b52c712bb777c4e5328fef656f1a2830d92","unresolved":false,"context_lines":[{"line_number":10,"context_line":"transport select jtag"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"# Detailed trace output (e.g. level 3) can reduce performance"},{"line_number":13,"context_line":"# debug_level 2"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"# Create Xtensa target first"},{"line_number":16,"context_line":"source [find target/xtensa.cfg]"}],"source_content_type":"text/x-ttcn-cfg","patch_set":2,"id":"6945a7b4_1fa523c8","line":13,"in_reply_to":"d66f07ec_f69880bd","updated":"2022-07-04 22:48:12.000000000","message":"done","commit_id":"3ad47b3e590c83481e235836447cb3c57adf68ab"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"e70dcb598c55716a7fe8711c93d85a9b4a9a5569","unresolved":true,"context_lines":[{"line_number":16,"context_line":"source [find target/xtensa.cfg]"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# Configure Xtensa core parameters next"},{"line_number":19,"context_line":"# Generate [xtensa-core-XXX.cfg] via \"xt-gdb --dump-oocd-config\""}],"source_content_type":"text/x-ttcn-cfg","patch_set":2,"id":"2d98b0bb_4cb0a2ea","line":19,"updated":"2022-07-02 10:46:25.000000000","message":"It\u0027s not clear, at least to me, what\u0027s the meaning of these two lines","commit_id":"3ad47b3e590c83481e235836447cb3c57adf68ab"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"e8e58b52c712bb777c4e5328fef656f1a2830d92","unresolved":false,"context_lines":[{"line_number":16,"context_line":"source [find target/xtensa.cfg]"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# Configure Xtensa core parameters next"},{"line_number":19,"context_line":"# Generate [xtensa-core-XXX.cfg] via \"xt-gdb --dump-oocd-config\""}],"source_content_type":"text/x-ttcn-cfg","patch_set":2,"id":"bd339a53_5c639a8d","line":19,"in_reply_to":"2d98b0bb_4cb0a2ea","updated":"2022-07-04 22:48:12.000000000","message":"This was intended as a note on how to generate the core-specific configuration .cfg files, but it is explained elsewhere.  Removing.","commit_id":"3ad47b3e590c83481e235836447cb3c57adf68ab"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"6813ae26ab1302fe0374ed373fbba4d4ca9495a3","unresolved":false,"context_lines":[{"line_number":16,"context_line":"source [find target/xtensa.cfg]"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# Configure Xtensa core parameters next"},{"line_number":19,"context_line":"# Generate [xtensa-core-XXX.cfg] via \"xt-gdb --dump-oocd-config\""}],"source_content_type":"text/x-ttcn-cfg","patch_set":2,"id":"b258d012_f73e1a3a","line":19,"in_reply_to":"bd339a53_5c639a8d","updated":"2022-07-05 09:03:57.000000000","message":"This could eventually go in the documentation","commit_id":"3ad47b3e590c83481e235836447cb3c57adf68ab"}],"tcl/interface/ftdi/xt_kc705_ml605.cfg":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"e70dcb598c55716a7fe8711c93d85a9b4a9a5569","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Xilinx KC705 / ML605 with Xtensa daughtercard; onboard USB/FT2232"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":2,"id":"12812fe6_c7b2251e","line":1,"updated":"2022-07-02 10:46:25.000000000","message":"Please add SPDX tag as first line","commit_id":"3ad47b3e590c83481e235836447cb3c57adf68ab"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"57cea4e224a3054044dfbfbc7a3249e1d0f5c059","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Xilinx KC705 / ML605 with Xtensa daughtercard; onboard USB/FT2232"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":2,"id":"b4595b3f_a6957690","line":1,"in_reply_to":"12812fe6_c7b2251e","updated":"2022-07-09 20:07:03.000000000","message":"Will include via separate patch.","commit_id":"3ad47b3e590c83481e235836447cb3c57adf68ab"}],"tcl/target/xtensa-core-esp32.cfg":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"412371ebcf0293cb271e00e162b1379e7d5beae0","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#  SPDX-License-Identifier: GPL-2.0-or-later"},{"line_number":2,"context_line":"#  OpenOCD configuration file for Xtensa ESP32 target"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"#  Core definition and ABI"}],"source_content_type":"text/x-ttcn-cfg","patch_set":12,"id":"75a2e897_f35116c3","line":1,"updated":"2022-07-25 15:28:31.000000000","message":"you really like adding double space ...\nAt least for the SPDX line, please use a single space.","commit_id":"2956b0353914d2fc81655cc8a7133228b0f5555c"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"c5b0f250831da2735ba01a7815be1871588e2f62","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#  SPDX-License-Identifier: GPL-2.0-or-later"},{"line_number":2,"context_line":"#  OpenOCD configuration file for Xtensa ESP32 target"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"#  Core definition and ABI"}],"source_content_type":"text/x-ttcn-cfg","patch_set":12,"id":"082d69ee_4867dc85","line":1,"in_reply_to":"75a2e897_f35116c3","updated":"2022-08-02 01:05:14.000000000","message":"Sorry, old habits. \u003d)\nRemoved double-spacing for first 2 lines, but left remaining comments unchanged as they are generated by some internal tools.","commit_id":"2956b0353914d2fc81655cc8a7133228b0f5555c"}],"tcl/target/xtensa-core-esp32s2.cfg":[{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"4e87044845712ee28c45b62c1cf9736c3cdeb15e","unresolved":true,"context_lines":[{"line_number":18,"context_line":"xtensa xtmem\tdcache\t\t\t\t4 0 1 0"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"#  Memory Options"},{"line_number":21,"context_line":"xtensa xtmem\tirom\t\t\t\t0x40800000\t0x780000"},{"line_number":22,"context_line":"xtensa xtmem\tirom\t\t\t\t0x40000000\t0x20000"},{"line_number":23,"context_line":"xtensa xtmem\tiram\t\t\t\t0x40020000\t0x50000"},{"line_number":24,"context_line":"xtensa xtmem\tiram\t\t\t\t0x40070000\t0x2000"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"60d18dd5_61921dc1","line":21,"updated":"2022-06-30 19:09:05.000000000","message":"correction: 0x40080000\t0x780000","commit_id":"3e7b1a05759168a3d43778662895c9ab0f2ee60e"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"953ecbe6f58c71102bf6f12a89727fd64418890c","unresolved":false,"context_lines":[{"line_number":18,"context_line":"xtensa xtmem\tdcache\t\t\t\t4 0 1 0"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"#  Memory Options"},{"line_number":21,"context_line":"xtensa xtmem\tirom\t\t\t\t0x40800000\t0x780000"},{"line_number":22,"context_line":"xtensa xtmem\tirom\t\t\t\t0x40000000\t0x20000"},{"line_number":23,"context_line":"xtensa xtmem\tiram\t\t\t\t0x40020000\t0x50000"},{"line_number":24,"context_line":"xtensa xtmem\tiram\t\t\t\t0x40070000\t0x2000"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"9408b667_862da18f","line":21,"in_reply_to":"60d18dd5_61921dc1","updated":"2022-07-01 04:20:05.000000000","message":"Thanks for catching this!  Fixed.","commit_id":"3e7b1a05759168a3d43778662895c9ab0f2ee60e"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"412371ebcf0293cb271e00e162b1379e7d5beae0","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#  SPDX-License-Identifier: GPL-2.0-or-later"},{"line_number":2,"context_line":"#  OpenOCD configuration file for Xtensa ESP32S2 target"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"#  Core definition and ABI"}],"source_content_type":"text/x-ttcn-cfg","patch_set":12,"id":"a934fbc3_ab5b677c","line":1,"updated":"2022-07-25 15:28:31.000000000","message":"same here","commit_id":"2956b0353914d2fc81655cc8a7133228b0f5555c"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"c5b0f250831da2735ba01a7815be1871588e2f62","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#  SPDX-License-Identifier: GPL-2.0-or-later"},{"line_number":2,"context_line":"#  OpenOCD configuration file for Xtensa ESP32S2 target"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"#  Core definition and ABI"}],"source_content_type":"text/x-ttcn-cfg","patch_set":12,"id":"659e3e5f_17ea64b7","line":1,"in_reply_to":"a934fbc3_ab5b677c","updated":"2022-08-02 01:05:14.000000000","message":"Removed double-spacing for first 2 lines","commit_id":"2956b0353914d2fc81655cc8a7133228b0f5555c"}],"tcl/target/xtensa-core-esp32s3.cfg":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"412371ebcf0293cb271e00e162b1379e7d5beae0","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#  SPDX-License-Identifier: GPL-2.0-or-later"},{"line_number":2,"context_line":"#  OpenOCD configuration file for Xtensa ESP32S3 target"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"#  Core definition and ABI"}],"source_content_type":"text/x-ttcn-cfg","patch_set":12,"id":"657099a0_d69654c3","line":1,"updated":"2022-07-25 15:28:31.000000000","message":"and here!","commit_id":"2956b0353914d2fc81655cc8a7133228b0f5555c"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"c5b0f250831da2735ba01a7815be1871588e2f62","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#  SPDX-License-Identifier: GPL-2.0-or-later"},{"line_number":2,"context_line":"#  OpenOCD configuration file for Xtensa ESP32S3 target"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"#  Core definition and ABI"}],"source_content_type":"text/x-ttcn-cfg","patch_set":12,"id":"9a7a9caa_ebe728a1","line":1,"in_reply_to":"657099a0_d69654c3","updated":"2022-08-02 01:05:14.000000000","message":"Removed double-spacing for first 2 lines","commit_id":"2956b0353914d2fc81655cc8a7133228b0f5555c"}]}