)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"56fe9e4adf64580d6fb0a64252412aa8d9f6f0c0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9459c71b_6d30e1f8","updated":"2022-07-02 21:02:53.000000000","message":"big patch, but several changes are not supposed to be in this patch.\nCan you please review them and move in independent patch what is not related to this semihosting work?","commit_id":"6bdf673a0129b949802f362486829d5575bef479"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"3ffef3ac6750903c72bd91d0a249c2afa7d67d83","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"03eae104_e471e4b5","in_reply_to":"9459c71b_6d30e1f8","updated":"2022-07-03 05:28:07.000000000","message":"Hi Antonio, This patch created on top of 7055 (generic xtensa). Ian, submitted the indentation changes which I did here. So this patch will be clean after rebasing to 7055.","commit_id":"6bdf673a0129b949802f362486829d5575bef479"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"0f614cba8730659fa4578da15a8dee8e7bc1becd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"34ee0135_98fad127","updated":"2022-07-25 15:58:57.000000000","message":"minor comments, nothing alarming","commit_id":"89c733f881bef5dfca55ad26aa5ed12e3062a666"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"c256674b21771c45e83b1cb71c1648254039057b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"97fd37af_f3136386","updated":"2022-08-22 09:04:41.000000000","message":"Antonio, I think this was also almost done. I made small debug related changes.\n\nNo new warnings from scan-build.","commit_id":"eefb9c3cde04caee6656f2090d0d19d9044e003b"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"811e03e008a2abd7ef0ad61af215ce0e44633366","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"79107148_0f09b09b","updated":"2022-08-22 14:13:30.000000000","message":"Still one comment, then it looks ready to go","commit_id":"eefb9c3cde04caee6656f2090d0d19d9044e003b"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"f43aa283180a78200637c9ca7f325772752ec363","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"493b9c4f_5ff7fc34","updated":"2022-08-22 15:26:21.000000000","message":"Thanks!","commit_id":"30af05948fa2522125f8f946c1a7006a9df1deb5"}],"src/target/espressif/esp32s2.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"56fe9e4adf64580d6fb0a64252412aa8d9f6f0c0","unresolved":true,"context_lines":[{"line_number":502,"context_line":"\treturn ERROR_OK;"},{"line_number":503,"context_line":"}"},{"line_number":504,"context_line":""},{"line_number":505,"context_line":"extern const struct command_registration semihosting_common_handlers[];"},{"line_number":506,"context_line":""},{"line_number":507,"context_line":"static const struct command_registration esp32s2_command_handlers[] \u003d {"},{"line_number":508,"context_line":"\t{"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"b508ae1b_4a2307f1","line":505,"updated":"2022-07-02 21:02:53.000000000","message":"would you mind making a simple patch to put this declaration in semihosting_common.h, including the file and dropping this same declaration from:\n src/target/riscv/riscv.c\n src/target/aarch64.c\n src/target/armv4_5.c\n src/target/espressif/esp32.c\nand of course here?","commit_id":"6bdf673a0129b949802f362486829d5575bef479"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"0ab10805c34ccab241fba1c068eda9be5e7705df","unresolved":false,"context_lines":[{"line_number":502,"context_line":"\treturn ERROR_OK;"},{"line_number":503,"context_line":"}"},{"line_number":504,"context_line":""},{"line_number":505,"context_line":"extern const struct command_registration semihosting_common_handlers[];"},{"line_number":506,"context_line":""},{"line_number":507,"context_line":"static const struct command_registration esp32s2_command_handlers[] \u003d {"},{"line_number":508,"context_line":"\t{"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"83d16dd0_3bff271d","line":505,"in_reply_to":"b508ae1b_4a2307f1","updated":"2022-07-23 17:42:16.000000000","message":"Done in PS 7075","commit_id":"6bdf673a0129b949802f362486829d5575bef479"}],"src/target/espressif/esp_semihosting.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"56fe9e4adf64580d6fb0a64252412aa8d9f6f0c0","unresolved":true,"context_lines":[{"line_number":45,"context_line":"\tsemihosting-\u003eresult \u003d lseek(fd, pos, whence);"},{"line_number":46,"context_line":"\tsemihosting-\u003esys_errno \u003d errno;"},{"line_number":47,"context_line":"\tLOG_DEBUG(\"lseek(%\" PRIx64 \", %d %d)\u003d%d\", fd, (int)pos,"},{"line_number":48,"context_line":"\t\t(int)semihosting-\u003eresult, errno);"},{"line_number":49,"context_line":"\treturn ERROR_OK;"},{"line_number":50,"context_line":"}"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"482dd049_4317203b","line":48,"updated":"2022-07-02 21:02:53.000000000","message":"drop the type cast!\npos is uint32_t, so use \"%\" PRIu32\nresult is int64_t, so use \"%\" PRId64","commit_id":"6bdf673a0129b949802f362486829d5575bef479"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"0ab10805c34ccab241fba1c068eda9be5e7705df","unresolved":false,"context_lines":[{"line_number":45,"context_line":"\tsemihosting-\u003eresult \u003d lseek(fd, pos, whence);"},{"line_number":46,"context_line":"\tsemihosting-\u003esys_errno \u003d errno;"},{"line_number":47,"context_line":"\tLOG_DEBUG(\"lseek(%\" PRIx64 \", %d %d)\u003d%d\", fd, (int)pos,"},{"line_number":48,"context_line":"\t\t(int)semihosting-\u003eresult, errno);"},{"line_number":49,"context_line":"\treturn ERROR_OK;"},{"line_number":50,"context_line":"}"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"35d7ed66_2d6c426f","line":48,"in_reply_to":"482dd049_4317203b","updated":"2022-07-23 17:42:16.000000000","message":"Done","commit_id":"6bdf673a0129b949802f362486829d5575bef479"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"0f614cba8730659fa4578da15a8dee8e7bc1becd","unresolved":true,"context_lines":[{"line_number":1,"context_line":"/***************************************************************************"},{"line_number":2,"context_line":" *   SPDX-License-Identifier: GPL-2.0-or-later                             *"},{"line_number":3,"context_line":" *                                                                         *"},{"line_number":4,"context_line":" *   Semihosting API for Espressif chips                                   *"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"b9ce0740_da715cc8","line":1,"updated":"2022-07-25 15:58:57.000000000","message":"also here","commit_id":"89c733f881bef5dfca55ad26aa5ed12e3062a666"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"3ce9279906c29784bd48adfe9ab6123dce6446a1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"/***************************************************************************"},{"line_number":2,"context_line":" *   SPDX-License-Identifier: GPL-2.0-or-later                             *"},{"line_number":3,"context_line":" *                                                                         *"},{"line_number":4,"context_line":" *   Semihosting API for Espressif chips                                   *"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"190500f6_f5baee09","line":1,"in_reply_to":"b9ce0740_da715cc8","updated":"2022-07-25 16:04:05.000000000","message":"Done","commit_id":"89c733f881bef5dfca55ad26aa5ed12e3062a666"}],"src/target/espressif/esp_semihosting.h":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"56fe9e4adf64580d6fb0a64252412aa8d9f6f0c0","unresolved":true,"context_lines":[{"line_number":1,"context_line":"/***************************************************************************"},{"line_number":2,"context_line":" *   Semihosting API for Espressif chips                                   *"},{"line_number":3,"context_line":" *   Copyright (C) 2022 Espressif Systems Ltd.                             *"},{"line_number":4,"context_line":" *                                                                         *"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"d7b5bb16_1ca651c2","line":1,"updated":"2022-07-02 21:02:53.000000000","message":"please use SPDX only in new files. Check\nhttps://review.openocd.org/7071/","commit_id":"6bdf673a0129b949802f362486829d5575bef479"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"0ab10805c34ccab241fba1c068eda9be5e7705df","unresolved":false,"context_lines":[{"line_number":1,"context_line":"/***************************************************************************"},{"line_number":2,"context_line":" *   Semihosting API for Espressif chips                                   *"},{"line_number":3,"context_line":" *   Copyright (C) 2022 Espressif Systems Ltd.                             *"},{"line_number":4,"context_line":" *                                                                         *"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"763a61da_9a199180","line":1,"in_reply_to":"d7b5bb16_1ca651c2","updated":"2022-07-23 17:42:16.000000000","message":"Done","commit_id":"6bdf673a0129b949802f362486829d5575bef479"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"0f614cba8730659fa4578da15a8dee8e7bc1becd","unresolved":true,"context_lines":[{"line_number":1,"context_line":"/***************************************************************************"},{"line_number":2,"context_line":" *   SPDX-License-Identifier: GPL-2.0-or-later                             *"},{"line_number":3,"context_line":" *                                                                         *"},{"line_number":4,"context_line":" *   Semihosting API for Espressif chips                                   *"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"100cc524_042675d7","line":1,"updated":"2022-07-25 15:58:57.000000000","message":"Please use SPDX in a single comment first line, followed by the comment for copyright and explanation:\n /* SPDX-License-Identifier: GPL-2.0-or-later */\n \n /***************************************************************************\n  *                                                                         *\n  *   Semihosting API for Espressif chips                                   *\n  *   Copyright (C) 2022 Espressif Systems Ltd.                             *\n  *                                                                         *\n  ***************************************************************************/","commit_id":"89c733f881bef5dfca55ad26aa5ed12e3062a666"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"3ce9279906c29784bd48adfe9ab6123dce6446a1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"/***************************************************************************"},{"line_number":2,"context_line":" *   SPDX-License-Identifier: GPL-2.0-or-later                             *"},{"line_number":3,"context_line":" *                                                                         *"},{"line_number":4,"context_line":" *   Semihosting API for Espressif chips                                   *"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"d798774e_6be573a8","line":1,"in_reply_to":"100cc524_042675d7","updated":"2022-07-25 16:04:05.000000000","message":"Done","commit_id":"89c733f881bef5dfca55ad26aa5ed12e3062a666"}],"src/target/espressif/esp_xtensa.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"56fe9e4adf64580d6fb0a64252412aa8d9f6f0c0","unresolved":false,"context_lines":[{"line_number":36,"context_line":"\tint ret \u003d xtensa_init_arch_info(target, \u0026esp_xtensa-\u003extensa, dm_cfg);"},{"line_number":37,"context_line":"\tif (ret !\u003d ERROR_OK)"},{"line_number":38,"context_line":"\t\treturn ret;"},{"line_number":39,"context_line":"\tesp_xtensa-\u003esemihost.ops \u003d (struct esp_semihost_ops *)semihost_ops;"},{"line_number":40,"context_line":"\treturn ERROR_OK;"},{"line_number":41,"context_line":"}"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"79e08022_313389ea","line":39,"updated":"2022-07-02 21:02:53.000000000","message":"not nice to take a const struct and drop the const, but let\u0027s keep it as is.","commit_id":"6bdf673a0129b949802f362486829d5575bef479"}],"src/target/espressif/esp_xtensa_semihosting.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"56fe9e4adf64580d6fb0a64252412aa8d9f6f0c0","unresolved":true,"context_lines":[{"line_number":107,"context_line":"\tint retval \u003d semihosting_common_init(target,"},{"line_number":108,"context_line":"\t\tesp_xtensa_semihosting_setup,"},{"line_number":109,"context_line":"\t\tesp_xtensa_semihosting_post_result);"},{"line_number":110,"context_line":"\treturn retval;"},{"line_number":111,"context_line":"}"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"int esp_xtensa_semihosting_init(struct target *target)"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"22dcfda2_73558c2c","line":110,"updated":"2022-07-02 21:02:53.000000000","message":"directly\nreturn semihosting_common_init(...);","commit_id":"6bdf673a0129b949802f362486829d5575bef479"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"0ab10805c34ccab241fba1c068eda9be5e7705df","unresolved":false,"context_lines":[{"line_number":107,"context_line":"\tint retval \u003d semihosting_common_init(target,"},{"line_number":108,"context_line":"\t\tesp_xtensa_semihosting_setup,"},{"line_number":109,"context_line":"\t\tesp_xtensa_semihosting_post_result);"},{"line_number":110,"context_line":"\treturn retval;"},{"line_number":111,"context_line":"}"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"int esp_xtensa_semihosting_init(struct target *target)"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"315965f4_d4b4337f","line":110,"in_reply_to":"22dcfda2_73558c2c","updated":"2022-07-23 17:42:16.000000000","message":"Done","commit_id":"6bdf673a0129b949802f362486829d5575bef479"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"0f614cba8730659fa4578da15a8dee8e7bc1becd","unresolved":true,"context_lines":[{"line_number":1,"context_line":"/***************************************************************************"},{"line_number":2,"context_line":" *   SPDX-License-Identifier: GPL-2.0-or-later                             *"},{"line_number":3,"context_line":" *                                                                         *"},{"line_number":4,"context_line":" *   Copyright (c) 2020 Espressif Systems (Shanghai) Co. Ltd.              *"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"d09e7d50_cbf82cc4","line":1,"updated":"2022-07-25 15:58:57.000000000","message":"and here","commit_id":"89c733f881bef5dfca55ad26aa5ed12e3062a666"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"3ce9279906c29784bd48adfe9ab6123dce6446a1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"/***************************************************************************"},{"line_number":2,"context_line":" *   SPDX-License-Identifier: GPL-2.0-or-later                             *"},{"line_number":3,"context_line":" *                                                                         *"},{"line_number":4,"context_line":" *   Copyright (c) 2020 Espressif Systems (Shanghai) Co. Ltd.              *"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"0dbeb9a9_29b3bba8","line":1,"in_reply_to":"d09e7d50_cbf82cc4","updated":"2022-07-25 16:04:05.000000000","message":"Done","commit_id":"89c733f881bef5dfca55ad26aa5ed12e3062a666"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"811e03e008a2abd7ef0ad61af215ce0e44633366","unresolved":true,"context_lines":[{"line_number":110,"context_line":"\t\treturn retval;"},{"line_number":111,"context_line":"\ttarget-\u003esemihosting-\u003eword_size_bytes \u003d 4;\t\t\t/* 32 bits */"},{"line_number":112,"context_line":"\ttarget-\u003esemihosting-\u003euser_command_extension \u003d esp_semihosting_common;"},{"line_number":113,"context_line":"\treturn retval;"},{"line_number":114,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":6,"id":"2389893b_a67b0a87","line":113,"updated":"2022-08-22 14:13:30.000000000","message":"return ERROR_OK;","commit_id":"eefb9c3cde04caee6656f2090d0d19d9044e003b"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"78a130e0702087e87f84b1a699ae48f0529ab1ac","unresolved":false,"context_lines":[{"line_number":110,"context_line":"\t\treturn retval;"},{"line_number":111,"context_line":"\ttarget-\u003esemihosting-\u003eword_size_bytes \u003d 4;\t\t\t/* 32 bits */"},{"line_number":112,"context_line":"\ttarget-\u003esemihosting-\u003euser_command_extension \u003d esp_semihosting_common;"},{"line_number":113,"context_line":"\treturn retval;"},{"line_number":114,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":6,"id":"0bf54023_090108b6","line":113,"in_reply_to":"2389893b_a67b0a87","updated":"2022-08-22 15:02:33.000000000","message":"Done.\n\nThanks","commit_id":"eefb9c3cde04caee6656f2090d0d19d9044e003b"}],"src/target/espressif/esp_xtensa_semihosting.h":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"0f614cba8730659fa4578da15a8dee8e7bc1becd","unresolved":true,"context_lines":[{"line_number":1,"context_line":"/***************************************************************************"},{"line_number":2,"context_line":" *   SPDX-License-Identifier: GPL-2.0-or-later                             *"},{"line_number":3,"context_line":" *                                                                         *"},{"line_number":4,"context_line":" *   Copyright (c) 2020 Espressif Systems (Shanghai) Co. Ltd.              *"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"50fb577b_6a489d6a","line":1,"updated":"2022-07-25 15:58:57.000000000","message":"and here","commit_id":"89c733f881bef5dfca55ad26aa5ed12e3062a666"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"3ce9279906c29784bd48adfe9ab6123dce6446a1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"/***************************************************************************"},{"line_number":2,"context_line":" *   SPDX-License-Identifier: GPL-2.0-or-later                             *"},{"line_number":3,"context_line":" *                                                                         *"},{"line_number":4,"context_line":" *   Copyright (c) 2020 Espressif Systems (Shanghai) Co. Ltd.              *"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"7f09d794_c89b429a","line":1,"in_reply_to":"50fb577b_6a489d6a","updated":"2022-07-25 16:04:05.000000000","message":"Done","commit_id":"89c733f881bef5dfca55ad26aa5ed12e3062a666"}],"src/target/xtensa/xtensa.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"56fe9e4adf64580d6fb0a64252412aa8d9f6f0c0","unresolved":true,"context_lines":[{"line_number":2115,"context_line":"\t\t\t} else if (halt_cause \u0026 DEBUGCAUSE_DB) {"},{"line_number":2116,"context_line":"\t\t\t\ttarget-\u003edebug_reason \u003d DBG_REASON_WATCHPOINT;"},{"line_number":2117,"context_line":"\t\t\t}"},{"line_number":2118,"context_line":"\t\t\tLOG_TARGET_INFO(target, \"Target halted, pc\u003d0x%08\" PRIx32"},{"line_number":2119,"context_line":"\t\t\t\t\", debug_reason\u003d%08\" PRIx32 \", oldstate\u003d%08\" PRIx32,"},{"line_number":2120,"context_line":"\t\t\t\txtensa_reg_get(target, XT_REG_IDX_PC),"},{"line_number":2121,"context_line":"\t\t\t\ttarget-\u003edebug_reason,"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"f2582aa9_1892299d","line":2118,"updated":"2022-07-02 21:02:53.000000000","message":"this is the only real change in this file.\nCan the rest (and maybe also this) stay out of this patch?\nI prefer having independent patches to change indentation or style.","commit_id":"6bdf673a0129b949802f362486829d5575bef479"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"3ffef3ac6750903c72bd91d0a249c2afa7d67d83","unresolved":false,"context_lines":[{"line_number":2115,"context_line":"\t\t\t} else if (halt_cause \u0026 DEBUGCAUSE_DB) {"},{"line_number":2116,"context_line":"\t\t\t\ttarget-\u003edebug_reason \u003d DBG_REASON_WATCHPOINT;"},{"line_number":2117,"context_line":"\t\t\t}"},{"line_number":2118,"context_line":"\t\t\tLOG_TARGET_INFO(target, \"Target halted, pc\u003d0x%08\" PRIx32"},{"line_number":2119,"context_line":"\t\t\t\t\", debug_reason\u003d%08\" PRIx32 \", oldstate\u003d%08\" PRIx32,"},{"line_number":2120,"context_line":"\t\t\t\txtensa_reg_get(target, XT_REG_IDX_PC),"},{"line_number":2121,"context_line":"\t\t\t\ttarget-\u003edebug_reason,"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"9ca17ea7_9dd7cdde","line":2118,"in_reply_to":"f2582aa9_1892299d","updated":"2022-07-03 05:28:07.000000000","message":"I will ask Ian to change the debug level in the patch 7055","commit_id":"6bdf673a0129b949802f362486829d5575bef479"}],"src/target/xtensa/xtensa.h":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"56fe9e4adf64580d6fb0a64252412aa8d9f6f0c0","unresolved":true,"context_lines":[{"line_number":35,"context_line":" */"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"/* Big-endian vs. little-endian detection */"},{"line_number":38,"context_line":"#define XT_ISBE(X)                                              ((X)-\u003ecore_config-\u003ebigendian)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"/* 24-bit break; BE version field-swapped then byte-swapped for use in memory R/W fns */"},{"line_number":41,"context_line":"#define XT_INS_BREAK_LE(S, T)                   (0x004000 | (((S) \u0026 0xF) \u003c\u003c 8) | (((T) \u0026 0xF) \u003c\u003c 4))"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"139d3ae6_4ea9679c","line":38,"updated":"2022-07-02 21:02:53.000000000","message":"nothing really changed in this file\nCan it stay out of the patch?","commit_id":"6bdf673a0129b949802f362486829d5575bef479"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"3ffef3ac6750903c72bd91d0a249c2afa7d67d83","unresolved":false,"context_lines":[{"line_number":35,"context_line":" */"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"/* Big-endian vs. little-endian detection */"},{"line_number":38,"context_line":"#define XT_ISBE(X)                                              ((X)-\u003ecore_config-\u003ebigendian)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"/* 24-bit break; BE version field-swapped then byte-swapped for use in memory R/W fns */"},{"line_number":41,"context_line":"#define XT_INS_BREAK_LE(S, T)                   (0x004000 | (((S) \u0026 0xF) \u003c\u003c 8) | (((T) \u0026 0xF) \u003c\u003c 4))"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"7709f2a9_3c412159","line":38,"in_reply_to":"139d3ae6_4ea9679c","updated":"2022-07-03 05:28:07.000000000","message":"Indentations are fixed in the patch 7055. I will rebase.","commit_id":"6bdf673a0129b949802f362486829d5575bef479"}],"src/target/xtensa/xtensa_chip.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"56fe9e4adf64580d6fb0a64252412aa8d9f6f0c0","unresolved":true,"context_lines":[{"line_number":94,"context_line":"\t\tvalue \u003d 1;"},{"line_number":95,"context_line":"\t} else {"},{"line_number":96,"context_line":"\t\treturn;"},{"line_number":97,"context_line":"\t}"},{"line_number":98,"context_line":"#endif"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"\t/* Scan out 1 bit, do not move from IRPAUSE after we\u0027re done. */"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"57dafdc3_725d13e2","line":97,"updated":"2022-07-02 21:02:53.000000000","message":"also here, keep it in a separate patch.\nBy the way, what about this code within #if 0 / #endif? Can be dropped?","commit_id":"6bdf673a0129b949802f362486829d5575bef479"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"3ffef3ac6750903c72bd91d0a249c2afa7d67d83","unresolved":false,"context_lines":[{"line_number":94,"context_line":"\t\tvalue \u003d 1;"},{"line_number":95,"context_line":"\t} else {"},{"line_number":96,"context_line":"\t\treturn;"},{"line_number":97,"context_line":"\t}"},{"line_number":98,"context_line":"#endif"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"\t/* Scan out 1 bit, do not move from IRPAUSE after we\u0027re done. */"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"db86abd2_0f4ad60e","line":97,"in_reply_to":"57dafdc3_725d13e2","updated":"2022-07-03 05:28:07.000000000","message":"I think you already commented for the #if 0 / #endif lines in the patch 7055. This patch will be on top if it.","commit_id":"6bdf673a0129b949802f362486829d5575bef479"}],"src/target/xtensa/xtensa_chip.h":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"56fe9e4adf64580d6fb0a64252412aa8d9f6f0c0","unresolved":true,"context_lines":[{"line_number":35,"context_line":"}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"int xtensa_chip_init_arch_info(struct target *target, void *arch_info,"},{"line_number":38,"context_line":"\tstruct xtensa_debug_module_config *dm_cfg);"},{"line_number":39,"context_line":"int xtensa_chip_target_init(struct command_context *cmd_ctx, struct target *target);"},{"line_number":40,"context_line":"int xtensa_chip_arch_state(struct target *target);"},{"line_number":41,"context_line":"void xtensa_chip_queue_tdi_idle(struct target *target);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"5a7a032e_97083948","line":38,"updated":"2022-07-02 21:02:53.000000000","message":"same here","commit_id":"6bdf673a0129b949802f362486829d5575bef479"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"3ffef3ac6750903c72bd91d0a249c2afa7d67d83","unresolved":false,"context_lines":[{"line_number":35,"context_line":"}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"int xtensa_chip_init_arch_info(struct target *target, void *arch_info,"},{"line_number":38,"context_line":"\tstruct xtensa_debug_module_config *dm_cfg);"},{"line_number":39,"context_line":"int xtensa_chip_target_init(struct command_context *cmd_ctx, struct target *target);"},{"line_number":40,"context_line":"int xtensa_chip_arch_state(struct target *target);"},{"line_number":41,"context_line":"void xtensa_chip_queue_tdi_idle(struct target *target);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"e4852e63_e6f676ea","line":38,"in_reply_to":"5a7a032e_97083948","updated":"2022-07-03 05:28:07.000000000","message":"This is done in the patch 7055. I will rebase.","commit_id":"6bdf673a0129b949802f362486829d5575bef479"}],"src/target/xtensa/xtensa_debug_module.h":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"56fe9e4adf64580d6fb0a64252412aa8d9f6f0c0","unresolved":true,"context_lines":[{"line_number":352,"context_line":"\tint res \u003d xtensa_dm_device_id_read(dm);"},{"line_number":353,"context_line":"\tif (res !\u003d ERROR_OK)"},{"line_number":354,"context_line":"\t\treturn false;"},{"line_number":355,"context_line":"\treturn dm-\u003edevice_id !\u003d 0xffffffff \u0026\u0026 dm-\u003edevice_id !\u003d 0;"},{"line_number":356,"context_line":"}"},{"line_number":357,"context_line":""},{"line_number":358,"context_line":"static inline bool xtensa_dm_tap_was_reset(struct xtensa_debug_module *dm)"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"dab92748_9f771f9a","line":355,"updated":"2022-07-02 21:02:53.000000000","message":"same here, move it in another patch","commit_id":"6bdf673a0129b949802f362486829d5575bef479"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"3ffef3ac6750903c72bd91d0a249c2afa7d67d83","unresolved":false,"context_lines":[{"line_number":352,"context_line":"\tint res \u003d xtensa_dm_device_id_read(dm);"},{"line_number":353,"context_line":"\tif (res !\u003d ERROR_OK)"},{"line_number":354,"context_line":"\t\treturn false;"},{"line_number":355,"context_line":"\treturn dm-\u003edevice_id !\u003d 0xffffffff \u0026\u0026 dm-\u003edevice_id !\u003d 0;"},{"line_number":356,"context_line":"}"},{"line_number":357,"context_line":""},{"line_number":358,"context_line":"static inline bool xtensa_dm_tap_was_reset(struct xtensa_debug_module *dm)"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"8f4642ef_e2766f2c","line":355,"in_reply_to":"dab92748_9f771f9a","updated":"2022-07-03 05:28:07.000000000","message":"This is done in the patch 7055. I will rebase.","commit_id":"6bdf673a0129b949802f362486829d5575bef479"}],"src/target/xtensa/xtensa_regs.h":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"56fe9e4adf64580d6fb0a64252412aa8d9f6f0c0","unresolved":true,"context_lines":[{"line_number":90,"context_line":"\tXT_REG_SPECIAL \u003d 2,\t\t/* Special register, needs RSR to read */"},{"line_number":91,"context_line":"\tXT_REG_DEBUG \u003d 3,\t\t/* Register used for the debug interface. Don\u0027t mess with this. */"},{"line_number":92,"context_line":"\tXT_REG_RELGEN \u003d 4,\t\t/* Relative general address. Points to the absolute addresses plus the window"},{"line_number":93,"context_line":"\t\t\t\t\t * index */"},{"line_number":94,"context_line":"\tXT_REG_FR \u003d 5,\t\t\t/* Floating-point register */"},{"line_number":95,"context_line":"\tXT_REG_TIE \u003d 6,\t\t\t/* TIE (custom) register */"},{"line_number":96,"context_line":"\tXT_REG_OTHER \u003d 7,\t\t/* Other (typically legacy) register */"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"3f590ca2_a58e6f31","line":93,"updated":"2022-07-02 21:02:53.000000000","message":"same for this file","commit_id":"6bdf673a0129b949802f362486829d5575bef479"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"3ffef3ac6750903c72bd91d0a249c2afa7d67d83","unresolved":false,"context_lines":[{"line_number":90,"context_line":"\tXT_REG_SPECIAL \u003d 2,\t\t/* Special register, needs RSR to read */"},{"line_number":91,"context_line":"\tXT_REG_DEBUG \u003d 3,\t\t/* Register used for the debug interface. Don\u0027t mess with this. */"},{"line_number":92,"context_line":"\tXT_REG_RELGEN \u003d 4,\t\t/* Relative general address. Points to the absolute addresses plus the window"},{"line_number":93,"context_line":"\t\t\t\t\t * index */"},{"line_number":94,"context_line":"\tXT_REG_FR \u003d 5,\t\t\t/* Floating-point register */"},{"line_number":95,"context_line":"\tXT_REG_TIE \u003d 6,\t\t\t/* TIE (custom) register */"},{"line_number":96,"context_line":"\tXT_REG_OTHER \u003d 7,\t\t/* Other (typically legacy) register */"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"dee5ba31_ae67301f","line":93,"in_reply_to":"3f590ca2_a58e6f31","updated":"2022-07-03 05:28:07.000000000","message":"This is done in the patch 7055. I will rebase.","commit_id":"6bdf673a0129b949802f362486829d5575bef479"}],"tcl/target/esp_common.cfg":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"0f614cba8730659fa4578da15a8dee8e7bc1becd","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"bec71970_cbadc3dd","line":11,"updated":"2022-07-25 15:58:57.000000000","message":"do you plan to add something else in this file?\nIf it will remains only like this, better inlining it in the callers","commit_id":"89c733f881bef5dfca55ad26aa5ed12e3062a666"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"3ce9279906c29784bd48adfe9ab6123dce6446a1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"45cb220d_cffaa396","line":11,"in_reply_to":"bec71970_cbadc3dd","updated":"2022-07-25 16:04:05.000000000","message":"Yes there will be functions related to flash programming support.\n\nhttps://github.com/espressif/openocd-esp32/blob/master/tcl/target/esp_common.cfg","commit_id":"89c733f881bef5dfca55ad26aa5ed12e3062a666"}],"tcl/target/xtensa-core-esp32s2.cfg":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"56fe9e4adf64580d6fb0a64252412aa8d9f6f0c0","unresolved":true,"context_lines":[{"line_number":18,"context_line":"xtensa xtmem\tdcache\t\t\t\t4 0 1 0"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"#  Memory Options"},{"line_number":21,"context_line":"xtensa xtmem\tirom\t\t\t\t0x40080000\t0x780000"},{"line_number":22,"context_line":"xtensa xtmem\tirom\t\t\t\t0x40000000\t0x20000"},{"line_number":23,"context_line":"xtensa xtmem\tiram\t\t\t\t0x40020000\t0x50000"},{"line_number":24,"context_line":"xtensa xtmem\tiram\t\t\t\t0x40070000\t0x2000"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"66b2f6b5_00c9e5bc","line":21,"updated":"2022-07-02 21:02:53.000000000","message":"this should be a separate fix in a independent patch","commit_id":"6bdf673a0129b949802f362486829d5575bef479"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"3ffef3ac6750903c72bd91d0a249c2afa7d67d83","unresolved":false,"context_lines":[{"line_number":18,"context_line":"xtensa xtmem\tdcache\t\t\t\t4 0 1 0"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"#  Memory Options"},{"line_number":21,"context_line":"xtensa xtmem\tirom\t\t\t\t0x40080000\t0x780000"},{"line_number":22,"context_line":"xtensa xtmem\tirom\t\t\t\t0x40000000\t0x20000"},{"line_number":23,"context_line":"xtensa xtmem\tiram\t\t\t\t0x40020000\t0x50000"},{"line_number":24,"context_line":"xtensa xtmem\tiram\t\t\t\t0x40070000\t0x2000"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"9b8d7a0e_a3a2c5e3","line":21,"in_reply_to":"66b2f6b5_00c9e5bc","updated":"2022-07-03 05:28:07.000000000","message":"Yes. It is done in the patch 7055. I will rebase.","commit_id":"6bdf673a0129b949802f362486829d5575bef479"}]}