)]}'
{"id":"openocd~master~I684a259ed29f3651cbce668101cff421e522f79e","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2022-08-03 17:59:58.000000000","reason":"Antonio Borneo replied on the change"},"1001982":{"account":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"last_update":"2022-08-15 13:23:05.000000000","reason":"Change was submitted"},"1001964":{"account":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"last_update":"2022-08-15 13:23:05.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I684a259ed29f3651cbce668101cff421e522f79e","subject":"gdb_server: custom target-specific GDB queries","status":"MERGED","created":"2022-07-11 00:32:23.000000000","updated":"2022-08-15 13:23:05.000000000","submitted":"2022-08-15 13:23:05.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":17,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7082","meta_rev_id":"29e194b74d8583c8ad3081834b981a015de44d56","_number":7082,"owner":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-08-15 13:23:05.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-08-15 13:23:05.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"}],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-07-11 00:39:50.000000000","updated_by":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"},{"updated":"2022-07-11 00:39:50.000000000","updated_by":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"reviewer":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"state":"REVIEWER"},{"updated":"2022-07-11 00:57:47.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"274203faa69f91eddba494652aec411b85a103f6","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"real_author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"date":"2022-07-11 00:32:23.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"de20749d05582861c8e505772c4bc46452671682","author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"real_author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"date":"2022-07-11 00:39:50.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"8b90e9d9f22c835bf01486037b194468f242ad58","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-07-11 00:57:47.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/15628/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/16419/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"f5ec06baa5f2c5d86bcf3ea536337be971c4f651","author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"real_author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"date":"2022-07-11 19:34:45.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"262daab20e28b634a4ea0f4dbc78b00401d54817","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-07-25 14:20:35.000000000","message":"Patch Set 1:\n\n(3 comments)","accounts_in_message":[],"_revision_number":1},{"id":"a2aada5cfb9200b0463e2d57ada8b152d284403f","author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"real_author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"date":"2022-08-01 23:22:17.000000000","message":"Patch Set 1:\n\n(4 comments)","accounts_in_message":[],"_revision_number":1},{"id":"c2d48590b242f4fbdc783f5b681b25dfa47618f2","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"real_author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"date":"2022-08-01 23:23:01.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"504806eaff2cf2032dd2b748da97f79a92fe274b","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-08-01 23:57:44.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/15683/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/16474/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"7f00873eded83042ef0ec160bdcfd7b1eb924c9b","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-08-03 16:47:27.000000000","message":"Patch Set 2:\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"9a5258d32aa9cd1f79b132ab02dfaef032eafa14","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-08-03 16:51:41.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"0929e59c1c9c9209468f60e8944fa2b33454bfb9","author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"real_author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"date":"2022-08-03 17:51:23.000000000","message":"Patch Set 2:\n\n(4 comments)","accounts_in_message":[],"_revision_number":2},{"id":"cf1b74377659e606d92ca87a49dbde4f7271318c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"real_author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"date":"2022-08-03 17:54:23.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"5cfa95066de211edb0ed73cbd757436d7f28bb66","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-08-03 17:59:58.000000000","message":"Patch Set 3: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"2e1a71f61cbb6b1a7381def48df01d78d98ff97d","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-08-03 18:42:03.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/15698/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/16489/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"a20c58c343e985278199b09b10f2a310423de217","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-08-15 13:23:01.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"29e194b74d8583c8ad3081834b981a015de44d56","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-08-15 13:23:05.000000000","message":"Change has been successfully cherry-picked as 48db36f436fe212fdda8d3fb7f79db43d9a2aa99","accounts_in_message":[],"_revision_number":4}],"current_revision":"48db36f436fe212fdda8d3fb7f79db43d9a2aa99","revisions":{"bca1ffb3a374fc5cf8b47b423ac4f72f0955866e":{"kind":"REWORK","_number":1,"created":"2022-07-11 00:32:23.000000000","uploader":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"ref":"refs/changes/82/7082/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/82/7082/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/82/7082/1 \u0026\u0026 git checkout -b change-7082 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/82/7082/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/82/7082/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/82/7082/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/82/7082/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/82/7082/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"5e96b012af91c4dc6eae680b67a594e9a22b3ead","subject":"semihosting: fix return value of SYS_READ and SYS_WRITE"}],"author":{"name":"Ian Thompson","email":"ianst@cadence.com","date":"2022-07-11 00:14:10.000000000","tz":-420},"committer":{"name":"Ian Thompson","email":"ianst@cadence.com","date":"2022-07-11 00:30:37.000000000","tz":-420},"subject":"target/server: custom target-specific GDB queries, sparse register maps","message":"target/server: custom target-specific GDB queries, sparse register maps\n\nThe following server extensions are provided in the context of generic Xtensa target support:\n- Handle sparse register addressing, where gaps may exist in reg_list[]\n- Add \"SW breakpoints unsupported\" non-error reply for Z-packets\n- Add customizable hook for handling target-specific GDB queries\n\nValgrind-clean, no new Clang analyzer warnings\n\nSigned-off-by: Ian Thompson \u003cianst@cadence.com\u003e\nChange-Id: I684a259ed29f3651cbce668101cff421e522f79e\n"}},"42429b06e67bdb7597909d063ecdb0926b7eef03":{"kind":"REWORK","_number":3,"created":"2022-08-03 17:54:23.000000000","uploader":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"ref":"refs/changes/82/7082/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/82/7082/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/82/7082/3 \u0026\u0026 git checkout -b change-7082 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/82/7082/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/82/7082/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/82/7082/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/82/7082/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/82/7082/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a895b3b4f830d24d714cb9f11fc8cef92b84df72","subject":"flash/nor/fespi: check target type"}],"author":{"name":"Ian Thompson","email":"ianst@cadence.com","date":"2022-07-11 00:14:10.000000000","tz":-420},"committer":{"name":"Ian Thompson","email":"ianst@cadence.com","date":"2022-08-03 17:53:25.000000000","tz":-420},"subject":"gdb_server: custom target-specific GDB queries","message":"gdb_server: custom target-specific GDB queries\n\nProvide a customizable hook for handling target-specific GDB queries\n\nValgrind-clean, no new Clang analyzer warnings\n\nSigned-off-by: Ian Thompson \u003cianst@cadence.com\u003e\nChange-Id: I684a259ed29f3651cbce668101cff421e522f79e\n"}},"264f4e3101c88c1bead8922a26713b5a75773702":{"kind":"REWORK","_number":2,"created":"2022-08-01 23:23:01.000000000","uploader":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"ref":"refs/changes/82/7082/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/82/7082/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/82/7082/2 \u0026\u0026 git checkout -b change-7082 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/82/7082/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/82/7082/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/82/7082/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/82/7082/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/82/7082/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a895b3b4f830d24d714cb9f11fc8cef92b84df72","subject":"flash/nor/fespi: check target type"}],"author":{"name":"Ian Thompson","email":"ianst@cadence.com","date":"2022-07-11 00:14:10.000000000","tz":-420},"committer":{"name":"Ian Thompson","email":"ianst@cadence.com","date":"2022-08-01 22:58:20.000000000","tz":-420},"subject":"target/server: custom target-specific GDB queries","message":"target/server: custom target-specific GDB queries\n\nProvide a customizable hook for handling target-specific GDB queries\n\nValgrind-clean, no new Clang analyzer warnings\n\nSigned-off-by: Ian Thompson \u003cianst@cadence.com\u003e\nChange-Id: I684a259ed29f3651cbce668101cff421e522f79e\n"}},"48db36f436fe212fdda8d3fb7f79db43d9a2aa99":{"kind":"REWORK","_number":4,"created":"2022-08-15 13:23:05.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/82/7082/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/82/7082/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/82/7082/4 \u0026\u0026 git checkout -b change-7082 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/82/7082/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/82/7082/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/82/7082/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/82/7082/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/82/7082/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d9b2607ca094898d8d7180085a913e8a5b46ecac","subject":"gdb_server: support sparse register maps"}],"author":{"name":"Ian Thompson","email":"ianst@cadence.com","date":"2022-07-11 00:14:10.000000000","tz":-420},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-08-15 13:23:05.000000000","tz":0},"subject":"gdb_server: custom target-specific GDB queries","message":"gdb_server: custom target-specific GDB queries\n\nProvide a customizable hook for handling target-specific GDB queries\n\nValgrind-clean, no new Clang analyzer warnings\n\nSigned-off-by: Ian Thompson \u003cianst@cadence.com\u003e\nChange-Id: I684a259ed29f3651cbce668101cff421e522f79e\nReviewed-on: https://review.openocd.org/c/openocd/+/7082\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}
