)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"777cde9b3cedabfd13d12ad7e25078939bd60f48","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"524504ac_84e2b298","updated":"2022-07-11 00:43:30.000000000","message":"Required for review 7055.  Thanks in advance for your comments/suggestions.","commit_id":"7257f4ff9952d7746bf0b02d7cdf25975b02b7a3"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"ad24f598f0a9e1b6caa11c3daddc7fd122b6f1c1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"293463b3_347544cd","updated":"2022-08-02 18:22:22.000000000","message":"Thanks for the suggestions, Antonio.  All addressed with upcoming patchset.","commit_id":"7257f4ff9952d7746bf0b02d7cdf25975b02b7a3"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"67abf778dcba0291f100bd94de511c7e325af503","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d52b8d26_723eb145","updated":"2022-08-10 13:21:57.000000000","message":"Antonio, is there anything else to be addressed, or does patchset 2 look reasonable?  Thanks in advance.","commit_id":"41c34739b42a3ed6e82c48c56322ab16d84fd2eb"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"cf7b3d4d97ee76cfad4de367a79d51ff9466c943","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"08d58549_2173238f","updated":"2022-08-11 15:46:15.000000000","message":"thanks","commit_id":"41c34739b42a3ed6e82c48c56322ab16d84fd2eb"}],"tcl/board/xtensa-kc705-flyswatter2.cfg":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"7a4a0b3b2ce7796cdc21e83d122ef20f0d7680a1","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# SPDX-License-Identifier: GPL-2.0-or-later"},{"line_number":2,"context_line":"# Cadence KC705 FPGA Development Platform for Xtensa targets"},{"line_number":3,"context_line":"# Can be used with on-board (FTDI) adapter or various external adapters"},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"source [find interface/ftdi/flyswatter2.cfg]"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"12745071_336496af","line":3,"updated":"2022-07-25 15:41:47.000000000","message":"when the adapter is not on-board, we do not make a board file, otherwise there is a proliferation of config files for every possible adapter that can be connected.\nIf your board has a connector for external adapters, consider having a file \"xtensa-kc705-ext.cfg\" and call\nopenocd -f interface/whatever.cfg -f board/xtensa-kc705-ext.cfg","commit_id":"7257f4ff9952d7746bf0b02d7cdf25975b02b7a3"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"ad24f598f0a9e1b6caa11c3daddc7fd122b6f1c1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# SPDX-License-Identifier: GPL-2.0-or-later"},{"line_number":2,"context_line":"# Cadence KC705 FPGA Development Platform for Xtensa targets"},{"line_number":3,"context_line":"# Can be used with on-board (FTDI) adapter or various external adapters"},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"source [find interface/ftdi/flyswatter2.cfg]"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"56a99443_c55cb59e","line":3,"in_reply_to":"12745071_336496af","updated":"2022-08-02 18:22:22.000000000","message":"Thanks, that\u0027s much cleaner.  Replaced board/xtensa-kc705-jlink.cfg and board/xtensa-kc705-flyswatter2.cfg with board/xtensa-kc705-ext.cfg.","commit_id":"7257f4ff9952d7746bf0b02d7cdf25975b02b7a3"}],"tcl/interface/ftdi/xt_kc705_ml605.cfg":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"7a4a0b3b2ce7796cdc21e83d122ef20f0d7680a1","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Xilinx KC705 / ML605 with Xtensa daughtercard; onboard USB/FT2232"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"5bfd2e5c_8358bdcc","line":1,"updated":"2022-07-25 15:41:47.000000000","message":"please add the SPDX tag","commit_id":"7257f4ff9952d7746bf0b02d7cdf25975b02b7a3"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"ad24f598f0a9e1b6caa11c3daddc7fd122b6f1c1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Xilinx KC705 / ML605 with Xtensa daughtercard; onboard USB/FT2232"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"388b3824_bf9819e9","line":1,"in_reply_to":"5bfd2e5c_8358bdcc","updated":"2022-08-02 18:22:22.000000000","message":"Done","commit_id":"7257f4ff9952d7746bf0b02d7cdf25975b02b7a3"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"7a4a0b3b2ce7796cdc21e83d122ef20f0d7680a1","unresolved":true,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"adapter driver ftdi"},{"line_number":6,"context_line":"ftdi_vid_pid 0x0403 0x6010"},{"line_number":7,"context_line":"ftdi_serial ML605-3223"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"ftdi_layout_init 0x0010 0x007b"},{"line_number":10,"context_line":"ftdi_layout_signal nTRST -data 0x0010"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"11617884_ab54486b","line":7,"updated":"2022-07-25 15:41:47.000000000","message":"odd, every board has the same serial number?","commit_id":"7257f4ff9952d7746bf0b02d7cdf25975b02b7a3"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"ad24f598f0a9e1b6caa11c3daddc7fd122b6f1c1","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"adapter driver ftdi"},{"line_number":6,"context_line":"ftdi_vid_pid 0x0403 0x6010"},{"line_number":7,"context_line":"ftdi_serial ML605-3223"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"ftdi_layout_init 0x0010 0x007b"},{"line_number":10,"context_line":"ftdi_layout_signal nTRST -data 0x0010"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"d9dd91fd_0e09c38a","line":7,"in_reply_to":"11617884_ab54486b","updated":"2022-08-02 18:22:22.000000000","message":"Oops, good catch!  Removing and adding useful comment instead.","commit_id":"7257f4ff9952d7746bf0b02d7cdf25975b02b7a3"}],"tcl/target/xtensa.cfg":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"7a4a0b3b2ce7796cdc21e83d122ef20f0d7680a1","unresolved":true,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"\tif { [using_jtag] } {"},{"line_number":34,"context_line":"\t\t# DAP/JTAG"},{"line_number":35,"context_line":"\t\teval swj_newdap $_CHIPNAME cpu -irlen 4 $_CPUTAPARGLIST"},{"line_number":36,"context_line":"\t} else {"},{"line_number":37,"context_line":"\t\t# DAP/SWD"},{"line_number":38,"context_line":"\t\teval swj_newdap $_CHIPNAME cpu -irlen 5 $_CPUTAPARGLIST"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"6a242072_e4f482a4","line":35,"updated":"2022-07-25 15:41:47.000000000","message":"no need to use the \u0027eval\u0027 command. Directly\nswj_newdap $_CHIPNAME cpu -irlen 4 $_CPUTAPARGLIST\nSame below.\nIf I remember correctly, in SWD mode OpenOCD ignores the irlen (that by the way, has no meaning in SWD). So you can use this line for both JTAG and SWD.\nPlease test it before submitting a new version of this patch.","commit_id":"7257f4ff9952d7746bf0b02d7cdf25975b02b7a3"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"cf7b3d4d97ee76cfad4de367a79d51ff9466c943","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"\tif { [using_jtag] } {"},{"line_number":34,"context_line":"\t\t# DAP/JTAG"},{"line_number":35,"context_line":"\t\teval swj_newdap $_CHIPNAME cpu -irlen 4 $_CPUTAPARGLIST"},{"line_number":36,"context_line":"\t} else {"},{"line_number":37,"context_line":"\t\t# DAP/SWD"},{"line_number":38,"context_line":"\t\teval swj_newdap $_CHIPNAME cpu -irlen 5 $_CPUTAPARGLIST"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"a6fd8893_66e44aae","line":35,"in_reply_to":"32094426_f64c806f","updated":"2022-08-11 15:46:15.000000000","message":"\u003e It seems that the \"eval\" command is required to correctly pass $_CPUTAPARGLIST to swj_newdap.  Without it, I get the following error on a DAP/JTAG config:\n\u003e \n\u003e tcl/target/swj-dp.tcl:28: Error: Unknown param: -expected-id 0x3ba00477, try one of: -irlen, -irmask, -ircapture, -enable, -disable, -expected-id, or -ignore-version\n\nThat\u0027s TCL. $_CPUTAPARGLIST contains two words separated by space, but it is expanded as a single element thus as a single parameter for the function.\nUse of \"eval\" is ok. Another option is to use {*} in front of the variable expansion: {*}$_CPUTAPARGLIST","commit_id":"7257f4ff9952d7746bf0b02d7cdf25975b02b7a3"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"ad24f598f0a9e1b6caa11c3daddc7fd122b6f1c1","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"\tif { [using_jtag] } {"},{"line_number":34,"context_line":"\t\t# DAP/JTAG"},{"line_number":35,"context_line":"\t\teval swj_newdap $_CHIPNAME cpu -irlen 4 $_CPUTAPARGLIST"},{"line_number":36,"context_line":"\t} else {"},{"line_number":37,"context_line":"\t\t# DAP/SWD"},{"line_number":38,"context_line":"\t\teval swj_newdap $_CHIPNAME cpu -irlen 5 $_CPUTAPARGLIST"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"32094426_f64c806f","line":35,"in_reply_to":"6a242072_e4f482a4","updated":"2022-08-02 18:22:22.000000000","message":"It seems that the \"eval\" command is required to correctly pass $_CPUTAPARGLIST to swj_newdap.  Without it, I get the following error on a DAP/JTAG config:\n\ntcl/target/swj-dp.tcl:28: Error: Unknown param: -expected-id 0x3ba00477, try one of: -irlen, -irmask, -ircapture, -enable, -disable, -expected-id, or -ignore-version\n\nSWD mode does appear to ignore the -irlen parameter as you say, so I can simplify this conditional as suggested. Thanks for the idea!\n\nThe updated patchset has been tested and works with JTAG (no DAP), DAP/JTAG, and DAP/SWD, although I had to use our OOCD fork to test the DAP configs with this updated .tcl file.","commit_id":"7257f4ff9952d7746bf0b02d7cdf25975b02b7a3"}]}