)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"94f54a0b0656ac2e159cc7985423d3b91bb22c56","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2771830e_037e840a","updated":"2022-08-02 17:18:49.000000000","message":"Temporarily put on hold.\nThe patent restriction could make openocd not acceptable by Fedora.\n","commit_id":"efc6d08a2918ef0fd44910210e8101ac10e08e7b"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"6317ba9c79ba2c233fe8065c4d8d020973d62d7e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e39b1b24_abddaf70","updated":"2022-07-21 14:24:06.000000000","message":"Thanks Tim,\nI will take care of adding the text of the license BSD-3-Clause-Clear in a separate commit.\n","commit_id":"efc6d08a2918ef0fd44910210e8101ac10e08e7b"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"f1acc973cdf0bd57d4993df5a86c0bddeb1b01b1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"cdf84594_62b9bab4","updated":"2022-08-26 09:50:54.000000000","message":"Thank you very much, Tim. Really appreciate your effort on this license topic.","commit_id":"da47f7289763be6333e156c3ace14c2486b92343"}],"src/target/riscv/encoding.h":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"6317ba9c79ba2c233fe8065c4d8d020973d62d7e","unresolved":true,"context_lines":[{"line_number":1,"context_line":""},{"line_number":2,"context_line":"/*"},{"line_number":3,"context_line":"* This file is auto-generated by running \u0027make\u0027 in"},{"line_number":4,"context_line":"* https://github.com/riscv/riscv-opcodes (d2bbcb8)"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"457a6c21_4fd8b175","line":1,"updated":"2022-07-21 14:24:06.000000000","message":"Please consider that the new checkpatch\nhttps://review.openocd.org/q/topic:checkpatch\nwill enforce having the SPDX tag in the very first line of the file, so a new version of this file will be refused if it keeps the first line as this one.\nYou will be either forced to manually edit the generated file, or to update the script for generating it.\nI\u0027m going to merge this patch as is, but if you update the script shortly, please send us the new generated header as delta patch on this one.","commit_id":"efc6d08a2918ef0fd44910210e8101ac10e08e7b"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"bc1e9a7b0c016a864647ab302d66cc5301e44b5b","unresolved":false,"context_lines":[{"line_number":1,"context_line":""},{"line_number":2,"context_line":"/*"},{"line_number":3,"context_line":"* This file is auto-generated by running \u0027make\u0027 in"},{"line_number":4,"context_line":"* https://github.com/riscv/riscv-opcodes (d2bbcb8)"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"b0737348_f675072a","line":1,"in_reply_to":"34ca87e6_6a3e509b","updated":"2022-08-22 17:02:23.000000000","message":"Done","commit_id":"efc6d08a2918ef0fd44910210e8101ac10e08e7b"},{"author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"change_message_id":"2149099dbb3cef85abc400494b17e10aab21008e","unresolved":true,"context_lines":[{"line_number":1,"context_line":""},{"line_number":2,"context_line":"/*"},{"line_number":3,"context_line":"* This file is auto-generated by running \u0027make\u0027 in"},{"line_number":4,"context_line":"* https://github.com/riscv/riscv-opcodes (d2bbcb8)"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"53f0dde1_0a371344","line":1,"in_reply_to":"457a6c21_4fd8b175","updated":"2022-07-21 17:17:48.000000000","message":"Why does checkpatch do that? I can\u0027t find anything in the SPDX website that says it has to be the first line. This seems like a requirement that doesn\u0027t improve anything but makes more work in cases like this.","commit_id":"efc6d08a2918ef0fd44910210e8101ac10e08e7b"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"80a4a90ea3310b989d2163b851ed79a69dabace4","unresolved":true,"context_lines":[{"line_number":1,"context_line":""},{"line_number":2,"context_line":"/*"},{"line_number":3,"context_line":"* This file is auto-generated by running \u0027make\u0027 in"},{"line_number":4,"context_line":"* https://github.com/riscv/riscv-opcodes (d2bbcb8)"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"34ca87e6_6a3e509b","line":1,"in_reply_to":"53f0dde1_0a371344","updated":"2022-07-21 20:42:58.000000000","message":"It\u0027s part of Linux coding style, in file Documentation/process/license-rules.rst\n License identifier syntax\n -------------------------\n 1. Placement:\n    The SPDX license identifier in kernel files shall be added at the first\n    possible line in a file which can contain a comment.  For the majority\n    of files this is the first line, except for scripts which require the\n    \u0027#!PATH_TO_INTERPRETER\u0027 in the first line.  For those scripts the SPDX\n    identifier goes into the second line.\n\nWe reuse the checkpatch from the kernel, and with checkpatch.sh we get spdxcheck.py that verifies the SPDX tag against the licenses in folder LICENSES.","commit_id":"efc6d08a2918ef0fd44910210e8101ac10e08e7b"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"6317ba9c79ba2c233fe8065c4d8d020973d62d7e","unresolved":true,"context_lines":[{"line_number":2,"context_line":"/*"},{"line_number":3,"context_line":"* This file is auto-generated by running \u0027make\u0027 in"},{"line_number":4,"context_line":"* https://github.com/riscv/riscv-opcodes (d2bbcb8)"},{"line_number":5,"context_line":"*/"},{"line_number":6,"context_line":"/* SPDX-License-Identifier: BSD-3-Clause-Clear */"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"#ifndef RISCV_CSR_ENCODING_H"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"fd0c0d6c_732e5184","line":5,"updated":"2022-07-21 14:24:06.000000000","message":"please fix, in future versions, the style of the comment block.","commit_id":"efc6d08a2918ef0fd44910210e8101ac10e08e7b"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"bc1e9a7b0c016a864647ab302d66cc5301e44b5b","unresolved":false,"context_lines":[{"line_number":2,"context_line":"/*"},{"line_number":3,"context_line":"* This file is auto-generated by running \u0027make\u0027 in"},{"line_number":4,"context_line":"* https://github.com/riscv/riscv-opcodes (d2bbcb8)"},{"line_number":5,"context_line":"*/"},{"line_number":6,"context_line":"/* SPDX-License-Identifier: BSD-3-Clause-Clear */"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"#ifndef RISCV_CSR_ENCODING_H"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"9a3084e3_708a60b3","line":5,"in_reply_to":"47602a8a_b4d148c6","updated":"2022-08-22 17:02:23.000000000","message":"Done","commit_id":"efc6d08a2918ef0fd44910210e8101ac10e08e7b"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"80a4a90ea3310b989d2163b851ed79a69dabace4","unresolved":true,"context_lines":[{"line_number":2,"context_line":"/*"},{"line_number":3,"context_line":"* This file is auto-generated by running \u0027make\u0027 in"},{"line_number":4,"context_line":"* https://github.com/riscv/riscv-opcodes (d2bbcb8)"},{"line_number":5,"context_line":"*/"},{"line_number":6,"context_line":"/* SPDX-License-Identifier: BSD-3-Clause-Clear */"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"#ifndef RISCV_CSR_ENCODING_H"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"47602a8a_b4d148c6","line":5,"in_reply_to":"ce2403a2_41ad4d33","updated":"2022-07-21 20:42:58.000000000","message":"before this patch, file encoding.h has the comment with the \u0027*\u0027 aligned on the 4 lines of the comment. This patch changes the alignement.\nI have checked the repo riscv-opcodes, this has never changed. So it was probably manually changed during previous submit.\nI have created\nhttps://github.com/riscv/riscv-opcodes/pull/137\nPlease have a look. It mainly changes the python script, should be safe enough.","commit_id":"efc6d08a2918ef0fd44910210e8101ac10e08e7b"},{"author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"change_message_id":"2149099dbb3cef85abc400494b17e10aab21008e","unresolved":true,"context_lines":[{"line_number":2,"context_line":"/*"},{"line_number":3,"context_line":"* This file is auto-generated by running \u0027make\u0027 in"},{"line_number":4,"context_line":"* https://github.com/riscv/riscv-opcodes (d2bbcb8)"},{"line_number":5,"context_line":"*/"},{"line_number":6,"context_line":"/* SPDX-License-Identifier: BSD-3-Clause-Clear */"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"#ifndef RISCV_CSR_ENCODING_H"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"ce2403a2_41ad4d33","line":5,"in_reply_to":"fd0c0d6c_732e5184","updated":"2022-07-21 17:17:48.000000000","message":"Are you suggesting replacing */ /* with * *? That is a bit annoying to have to do (this header is generated by combining different files), and again doesn\u0027t really add anything.","commit_id":"efc6d08a2918ef0fd44910210e8101ac10e08e7b"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"bc1e9a7b0c016a864647ab302d66cc5301e44b5b","unresolved":true,"context_lines":[{"line_number":1,"context_line":"/* SPDX-License-Identifier: BSD-3-Clause */"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"/*"},{"line_number":4,"context_line":" * This file is auto-generated by running \u0027make\u0027 in"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"eb6e997e_26fdafe7","line":1,"updated":"2022-08-22 17:02:23.000000000","message":"Tim, from Alexios email, the BSD license requires one Copyright line to be copied with this file.\nI\u0027m ok to merge this because it\u0027s way better than current situation.\nIn mean time I have added a pull request for the copyright\nhttps://github.com/riscv/riscv-opcodes/pull/140\nPlease re-generate encoding.h with the copyright notice in a further patch.","commit_id":"4f47b77b72b27224eb50b4dfa4017db1bbc498b1"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"f1acc973cdf0bd57d4993df5a86c0bddeb1b01b1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"/* SPDX-License-Identifier: BSD-3-Clause */"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"/*"},{"line_number":4,"context_line":" * This file is auto-generated by running \u0027make\u0027 in"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"e6ba4058_ec2725c1","line":1,"in_reply_to":"ccbd790a_fc60913d","updated":"2022-08-26 09:50:54.000000000","message":"Done","commit_id":"4f47b77b72b27224eb50b4dfa4017db1bbc498b1"},{"author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"change_message_id":"9bbe7893ff09a751e3d4a724478a2bb57e027264","unresolved":true,"context_lines":[{"line_number":1,"context_line":"/* SPDX-License-Identifier: BSD-3-Clause */"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"/*"},{"line_number":4,"context_line":" * This file is auto-generated by running \u0027make\u0027 in"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"ccbd790a_fc60913d","line":1,"in_reply_to":"eb6e997e_26fdafe7","updated":"2022-08-25 18:07:58.000000000","message":"Done.","commit_id":"4f47b77b72b27224eb50b4dfa4017db1bbc498b1"}]}
