)]}'
{"id":"openocd~master~I8ba27801172ffa955470d2627fa656cad282ee99","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1001242":{"account":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"last_update":"2022-08-15 13:18:16.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I8ba27801172ffa955470d2627fa656cad282ee99","subject":"target/riscv: Update debug_defines.h.","status":"MERGED","created":"2022-07-18 16:25:54.000000000","updated":"2022-08-15 13:18:16.000000000","submitted":"2022-08-15 13:18:16.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7087","meta_rev_id":"a1c122e40c45ce4f0aa83de7a1d21b7e22f91a4e","_number":7087,"owner":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-08-15 13:18:16.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-08-15 13:18:16.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-07-18 16:34:48.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-07-21 14:32:32.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"dad71fb8430ecd70ffeb9ddcfc9fe21952769f00","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"real_author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"date":"2022-07-18 16:25:54.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f619297e7aac7a3c232cb2254efa6a35699be73a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"real_author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"date":"2022-07-18 16:30:34.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"dd208b5221f4f93080937f746267b84216869336","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-07-18 16:34:48.000000000","message":"Patch Set 1: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit-build/15634/ : ABORTED\n\nhttps://build.openocd.org/job/openocd-gerrit/16425/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"82d3754ac813964d548a47139bdbae2616c7b615","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"real_author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"date":"2022-07-18 16:37:50.000000000","message":"Uploaded patch set 3: Commit message was updated.","accounts_in_message":[],"_revision_number":3},{"id":"4f65f65829912dc0790856fab4d318c20f8289c6","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-07-18 16:38:36.000000000","message":"Patch Set 2: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit-build/15635/ : ABORTED\n\nhttps://build.openocd.org/job/openocd-gerrit/16426/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"0eca8449c4149ceec8a27be6b24540718eb22af3","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-07-18 17:49:09.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/15637/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/16428/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"6dde902cacd7b5c24ac9f9c339fdb6142517585c","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-07-21 14:32:32.000000000","message":"Patch Set 3: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"0e35cf13a0237b74f6aad64123720b59dc953b48","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-08-15 13:17:49.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"a1c122e40c45ce4f0aa83de7a1d21b7e22f91a4e","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-08-15 13:18:16.000000000","message":"Change has been successfully cherry-picked as 81aa5fd6b477cb03b718625a48e50099fc2ae0f2","accounts_in_message":[],"_revision_number":4}],"current_revision":"81aa5fd6b477cb03b718625a48e50099fc2ae0f2","revisions":{"81aa5fd6b477cb03b718625a48e50099fc2ae0f2":{"kind":"REWORK","_number":4,"created":"2022-08-15 13:18:16.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/87/7087/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/87/7087/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/87/7087/4 \u0026\u0026 git checkout -b change-7087 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/87/7087/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/87/7087/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/87/7087/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/87/7087/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/87/7087/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"0e1fe03f4ba2b313d80c0a2d3c2ecfb7aee85a77","subject":"target/arm: do not expose \u0027arm reg\u0027, \u0027arm mcr/mrc\u0027 commands on Cortex-M"}],"author":{"name":"Tim Newsome","email":"tim@sifive.com","date":"2022-07-18 16:20:22.000000000","tz":-420},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-08-15 13:18:16.000000000","tz":0},"subject":"target/riscv: Update debug_defines.h.","message":"target/riscv: Update debug_defines.h.\n\nThis one doesn\u0027t have the license in there, which means now it\u0027s\nacceptable to GPLv2 again.\n\nSee https://github.com/riscv/riscv-openocd/pull/711\n\nChange-Id: I8ba27801172ffa955470d2627fa656cad282ee99\nSigned-off-by: Tim Newsome \u003ctim@sifive.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/7087\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"16035b3954c8411279f50d3bf4282342ceb75a93":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2022-07-18 16:30:34.000000000","uploader":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"ref":"refs/changes/87/7087/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/87/7087/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/87/7087/2 \u0026\u0026 git checkout -b change-7087 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/87/7087/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/87/7087/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/87/7087/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/87/7087/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/87/7087/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"5e96b012af91c4dc6eae680b67a594e9a22b3ead","subject":"semihosting: fix return value of SYS_READ and SYS_WRITE"}],"author":{"name":"Tim Newsome","email":"tim@sifive.com","date":"2022-07-18 16:20:22.000000000","tz":-420},"committer":{"name":"Tim Newsome","email":"tim@sifive.com","date":"2022-07-18 16:30:17.000000000","tz":-420},"subject":"target/riscv: Update debug_defines.h. (#711)","message":"target/riscv: Update debug_defines.h. (#711)\n\nThis one doesn\u0027t have the license in there, which means now it\u0027s\nacceptable to GPLv2 again.\n\nChange-Id: I8ba27801172ffa955470d2627fa656cad282ee99\nSigned-off-by: Tim Newsome \u003ctim@sifive.com\u003e\n"}},"71a067381e5913ba58ad445dc1bf6204efa49c59":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2022-07-18 16:37:50.000000000","uploader":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"ref":"refs/changes/87/7087/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/87/7087/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/87/7087/3 \u0026\u0026 git checkout -b change-7087 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/87/7087/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/87/7087/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/87/7087/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/87/7087/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/87/7087/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"5e96b012af91c4dc6eae680b67a594e9a22b3ead","subject":"semihosting: fix return value of SYS_READ and SYS_WRITE"}],"author":{"name":"Tim Newsome","email":"tim@sifive.com","date":"2022-07-18 16:20:22.000000000","tz":-420},"committer":{"name":"Tim Newsome","email":"tim@sifive.com","date":"2022-07-18 16:37:21.000000000","tz":-420},"subject":"target/riscv: Update debug_defines.h.","message":"target/riscv: Update debug_defines.h.\n\nThis one doesn\u0027t have the license in there, which means now it\u0027s\nacceptable to GPLv2 again.\n\nSee https://github.com/riscv/riscv-openocd/pull/711\n\nChange-Id: I8ba27801172ffa955470d2627fa656cad282ee99\nSigned-off-by: Tim Newsome \u003ctim@sifive.com\u003e\n"}},"ff18976cf13f133b06deec86315501c4ebd41097":{"kind":"REWORK","_number":1,"created":"2022-07-18 16:25:54.000000000","uploader":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"ref":"refs/changes/87/7087/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/87/7087/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/87/7087/1 \u0026\u0026 git checkout -b change-7087 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/87/7087/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/87/7087/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/87/7087/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/87/7087/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/87/7087/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"5e96b012af91c4dc6eae680b67a594e9a22b3ead","subject":"semihosting: fix return value of SYS_READ and SYS_WRITE"}],"author":{"name":"Tim Newsome","email":"tim@sifive.com","date":"2022-07-18 16:20:22.000000000","tz":-420},"committer":{"name":"Tim Newsome","email":"tim@sifive.com","date":"2022-07-18 16:24:36.000000000","tz":-420},"subject":"Update debug_defines.h. (#711)","message":"Update debug_defines.h. (#711)\n\nThis one doesn\u0027t have the license in there, which means now it\u0027s\nacceptable to GPLv2 again.\n\nChange-Id: I8ba27801172ffa955470d2627fa656cad282ee99\nSigned-off-by: Tim Newsome \u003ctim@sifive.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}