)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"change_message_id":"c4927517698b545526f217c25b82245aef749a6e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ccd6bbb0_ee14bf2f","updated":"2022-07-18 21:11:09.000000000","message":"\u003e Patch Set 1: Verified-1\n\u003e \n\u003e Build Failed \n\u003e \n\u003e https://build.openocd.org/job/openocd-gerrit-build/15639/ : FAILURE\n\u003e \n\u003e https://build.openocd.org/job/openocd-gerrit/16431/ : FAILURE\n\nThank you. funny mingw should catchit, but hey, bug is a bug.. will fixup the comments from \nhttps://build.openocd.org/job/openocd-gerrit-build/15639/TARGET\u003dmingw64/consoleText\n\n```\n+ /home/jenkins/.jenkins/bin/build.sh checkpatch mingw64\nchecking patch ...\nWARNING: space prohibited between function name and open parenthesis \u0027(\u0027\n#279: FILE: src/jtag/drivers/dmem.c:386:\n+\t\t\tLOG_ERROR (\"Please align emulated base and size to pagesize 0x%lx\\n\", page_size);\n\ntotal: 0 errors, 1 warnings, 338 lines checked\n```\njust holding off to see if additional comments come in.","commit_id":"661354f240332a378004812586306b376222258e"},{"author":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"change_message_id":"0d43408591bea73732a81b3f14a7e1761869c6e6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ba763fbf_2101868a","in_reply_to":"ccd6bbb0_ee14bf2f","updated":"2022-07-19 12:39:24.000000000","message":"Fixed.","commit_id":"661354f240332a378004812586306b376222258e"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"0651675802770f428af764ec75e44995ddc43441","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b1f26b33_8ffc6146","updated":"2022-07-23 21:32:13.000000000","message":"I\u0027ve just run a very quick review.\nSome comment for https://review.openocd.org/7088 are valid here too:\n- command description in documentation\n- .usage field for comments\n- TAB 4 spaces","commit_id":"3325d86b0c665b29a41554c501e04fbb8cf1ed16"},{"author":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"change_message_id":"a30274de2e90afe564f6545e7b70182701820eb6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"90249974_3d83ec2a","in_reply_to":"b1f26b33_8ffc6146","updated":"2022-07-25 18:50:07.000000000","message":"Ack.","commit_id":"3325d86b0c665b29a41554c501e04fbb8cf1ed16"},{"author":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"change_message_id":"684804fc49ebb137ee2c76074aa9a80118a2d4f9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"a7bdd760_49e9d270","updated":"2023-08-08 17:52:21.000000000","message":"Thank you Antonio -\u003e Hopefully last set of comments for this should now be addressed.","commit_id":"503347ab0dc377b7fa2cf8dc5b8e9510a0805a51"},{"author":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"change_message_id":"0f64a001735b38340e229b5b6064920484858588","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"059186fd_57c47266","updated":"2023-08-11 01:16:27.000000000","message":"Thank you for the review. fixed in the next rev","commit_id":"e2e7cf67866e0f6d311d181cdcab08a586490cf7"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"2b4ba933df824f96c85c2a18584147d8165b4462","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"8b54aa1a_3d52ef09","updated":"2023-08-15 14:06:03.000000000","message":"Thanks!","commit_id":"582bfb141081ffce6214e9a2879c7d660b1f149c"}],"doc/openocd.texi":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"3a3439061ca82c09dcc9e583afcff71a6396f792","unresolved":true,"context_lines":[{"line_number":3627,"context_line":"protected using other SoC mechanisms."},{"line_number":3628,"context_line":"@end deffn"},{"line_number":3629,"context_line":""},{"line_number":3630,"context_line":"@deffn {Config Command} {dmem emu_base_address} base_address address_window_size"},{"line_number":3631,"context_line":"Set the emulated address and address window size. Both of these"},{"line_number":3632,"context_line":"parameters must be aligned to page size."},{"line_number":3633,"context_line":"@end deffn"}],"source_content_type":"text/x-texinfo","patch_set":7,"id":"e8596884_06f3f59b","line":3630,"updated":"2023-08-10 22:17:34.000000000","message":"the command name is changed. Please update the documentation accordingly","commit_id":"e2e7cf67866e0f6d311d181cdcab08a586490cf7"},{"author":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"change_message_id":"0f64a001735b38340e229b5b6064920484858588","unresolved":false,"context_lines":[{"line_number":3627,"context_line":"protected using other SoC mechanisms."},{"line_number":3628,"context_line":"@end deffn"},{"line_number":3629,"context_line":""},{"line_number":3630,"context_line":"@deffn {Config Command} {dmem emu_base_address} base_address address_window_size"},{"line_number":3631,"context_line":"Set the emulated address and address window size. Both of these"},{"line_number":3632,"context_line":"parameters must be aligned to page size."},{"line_number":3633,"context_line":"@end deffn"}],"source_content_type":"text/x-texinfo","patch_set":7,"id":"3435d191_ab67f5de","line":3630,"in_reply_to":"e8596884_06f3f59b","updated":"2023-08-11 01:16:27.000000000","message":"Uggh. I missed it. Thanks for catching it. Fixed in next rev.","commit_id":"e2e7cf67866e0f6d311d181cdcab08a586490cf7"}],"src/jtag/drivers/dmem.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"0651675802770f428af764ec75e44995ddc43441","unresolved":true,"context_lines":[{"line_number":55,"context_line":"static uint64_t dmem_emu_mapped_size;"},{"line_number":56,"context_line":"static void *dmem_emu_virt_base_addr;"},{"line_number":57,"context_line":"#define DMEM_MAX_EMULATE_APS 5"},{"line_number":58,"context_line":"static uint8_t dmem_emu_ap_count;"},{"line_number":59,"context_line":"static uint64_t dmem_emu_ap_list[DMEM_MAX_EMULATE_APS];"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"/* Emulation mode state variables */"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"55e3c558_4afc2b54","line":58,"updated":"2022-07-23 21:32:13.000000000","message":"we use uintX_t types when we need to match the size of HW register in the target.\nThis is just a counter in OpenOCD. Use \u0027unsigned int\u0027 type","commit_id":"3325d86b0c665b29a41554c501e04fbb8cf1ed16"},{"author":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"change_message_id":"a30274de2e90afe564f6545e7b70182701820eb6","unresolved":false,"context_lines":[{"line_number":55,"context_line":"static uint64_t dmem_emu_mapped_size;"},{"line_number":56,"context_line":"static void *dmem_emu_virt_base_addr;"},{"line_number":57,"context_line":"#define DMEM_MAX_EMULATE_APS 5"},{"line_number":58,"context_line":"static uint8_t dmem_emu_ap_count;"},{"line_number":59,"context_line":"static uint64_t dmem_emu_ap_list[DMEM_MAX_EMULATE_APS];"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"/* Emulation mode state variables */"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"d6542a5b_99d8d1ae","line":58,"in_reply_to":"55e3c558_4afc2b54","updated":"2022-07-25 18:50:07.000000000","message":"Ack","commit_id":"3325d86b0c665b29a41554c501e04fbb8cf1ed16"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"0651675802770f428af764ec75e44995ddc43441","unresolved":true,"context_lines":[{"line_number":69,"context_line":"/*"},{"line_number":70,"context_line":" * EMULATION MODE: In Emulation MODE, we assume the following:"},{"line_number":71,"context_line":" * TCL still describes as system is operational from the view of AP (ex. jtag)"},{"line_number":72,"context_line":" * However, the hardware does\u0027nt permit direct memory access to these APs"},{"line_number":73,"context_line":" * (only permitted via JTAG)."},{"line_number":74,"context_line":" *"},{"line_number":75,"context_line":" * So, the access to these APs have to be decoded to a memory map"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"5bd2b732_c7861d32","line":72,"updated":"2022-07-23 21:32:13.000000000","message":"type: doesn\u0027t","commit_id":"3325d86b0c665b29a41554c501e04fbb8cf1ed16"},{"author":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"change_message_id":"a30274de2e90afe564f6545e7b70182701820eb6","unresolved":false,"context_lines":[{"line_number":69,"context_line":"/*"},{"line_number":70,"context_line":" * EMULATION MODE: In Emulation MODE, we assume the following:"},{"line_number":71,"context_line":" * TCL still describes as system is operational from the view of AP (ex. jtag)"},{"line_number":72,"context_line":" * However, the hardware does\u0027nt permit direct memory access to these APs"},{"line_number":73,"context_line":" * (only permitted via JTAG)."},{"line_number":74,"context_line":" *"},{"line_number":75,"context_line":" * So, the access to these APs have to be decoded to a memory map"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"c75c7185_abe9b58a","line":72,"in_reply_to":"5bd2b732_c7861d32","updated":"2022-07-25 18:50:07.000000000","message":"Ack","commit_id":"3325d86b0c665b29a41554c501e04fbb8cf1ed16"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"0651675802770f428af764ec75e44995ddc43441","unresolved":true,"context_lines":[{"line_number":77,"context_line":" *"},{"line_number":78,"context_line":" * A few TI processors have this issue."},{"line_number":79,"context_line":" */"},{"line_number":80,"context_line":"static int dmem_is_emulated_ap(struct adiv5_ap *ap)"},{"line_number":81,"context_line":"{"},{"line_number":82,"context_line":"\tint i;"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":2,"id":"b94ee2b4_32c0d826","line":80,"updated":"2022-07-23 21:32:13.000000000","message":"please return bool type (true/false) instead of ERROR_OK/ERROR_FAIL;\nthere is no failure here!","commit_id":"3325d86b0c665b29a41554c501e04fbb8cf1ed16"},{"author":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"change_message_id":"a30274de2e90afe564f6545e7b70182701820eb6","unresolved":false,"context_lines":[{"line_number":77,"context_line":" *"},{"line_number":78,"context_line":" * A few TI processors have this issue."},{"line_number":79,"context_line":" */"},{"line_number":80,"context_line":"static int dmem_is_emulated_ap(struct adiv5_ap *ap)"},{"line_number":81,"context_line":"{"},{"line_number":82,"context_line":"\tint i;"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":2,"id":"c02b9f2b_9e5583e4","line":80,"in_reply_to":"b94ee2b4_32c0d826","updated":"2022-07-25 18:50:07.000000000","message":"Ack","commit_id":"3325d86b0c665b29a41554c501e04fbb8cf1ed16"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"0651675802770f428af764ec75e44995ddc43441","unresolved":true,"context_lines":[{"line_number":81,"context_line":"{"},{"line_number":82,"context_line":"\tint i;"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"\tfor (i \u003d 0; i \u003c dmem_emu_ap_count; i++) {"},{"line_number":85,"context_line":"\t\tif (ap-\u003eap_num \u003d\u003d dmem_emu_ap_list[i])"},{"line_number":86,"context_line":"\t\t\treturn ERROR_OK;"},{"line_number":87,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"f27c6442_c659f2fb","line":84,"updated":"2022-07-23 21:32:13.000000000","message":"use:\nfor (unsigned int i \u003d 0; ...","commit_id":"3325d86b0c665b29a41554c501e04fbb8cf1ed16"},{"author":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"change_message_id":"a30274de2e90afe564f6545e7b70182701820eb6","unresolved":false,"context_lines":[{"line_number":81,"context_line":"{"},{"line_number":82,"context_line":"\tint i;"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"\tfor (i \u003d 0; i \u003c dmem_emu_ap_count; i++) {"},{"line_number":85,"context_line":"\t\tif (ap-\u003eap_num \u003d\u003d dmem_emu_ap_list[i])"},{"line_number":86,"context_line":"\t\t\treturn ERROR_OK;"},{"line_number":87,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"629f416a_36bc829e","line":84,"in_reply_to":"f27c6442_c659f2fb","updated":"2022-07-25 18:50:07.000000000","message":"Ack","commit_id":"3325d86b0c665b29a41554c501e04fbb8cf1ed16"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"3adfd5ee502dac95613899565f48c4d7e84a85b5","unresolved":true,"context_lines":[{"line_number":28,"context_line":" * This bit tells if the transaction is coming in from jtag or not"},{"line_number":29,"context_line":" * we just mask this out to emulate direct address access"},{"line_number":30,"context_line":" */"},{"line_number":31,"context_line":"#define ARM_APB_PADDR31 (0x1 \u003c\u003c 31)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"/* Dmem file handler. */"},{"line_number":34,"context_line":"static int dmem_fd \u003d -1;"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"38a7bde0_be6d96d1","line":31,"updated":"2022-10-03 23:04:46.000000000","message":"please use BIT(31)","commit_id":"f4463d3959a47778c0e7cfdb4fcb57e9b6254e6a"},{"author":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"change_message_id":"a10a28d723b87b46de41c37b3f1db103a67d4e33","unresolved":false,"context_lines":[{"line_number":28,"context_line":" * This bit tells if the transaction is coming in from jtag or not"},{"line_number":29,"context_line":" * we just mask this out to emulate direct address access"},{"line_number":30,"context_line":" */"},{"line_number":31,"context_line":"#define ARM_APB_PADDR31 (0x1 \u003c\u003c 31)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"/* Dmem file handler. */"},{"line_number":34,"context_line":"static int dmem_fd \u003d -1;"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"dde3624e_9aa06249","line":31,"in_reply_to":"38a7bde0_be6d96d1","updated":"2022-10-13 21:16:51.000000000","message":"Done","commit_id":"f4463d3959a47778c0e7cfdb4fcb57e9b6254e6a"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"3adfd5ee502dac95613899565f48c4d7e84a85b5","unresolved":true,"context_lines":[{"line_number":54,"context_line":"static uint64_t dmem_emu_ap_list[DMEM_MAX_EMULATE_APS];"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"/* Emulation mode state variables */"},{"line_number":57,"context_line":"static uint32_t apbap_tar;"},{"line_number":58,"context_line":"static uint32_t apbap_tar_inc;"},{"line_number":59,"context_line":"static uint32_t apbap_csw;"},{"line_number":60,"context_line":"static uint32_t apbap_cfg;"},{"line_number":61,"context_line":"static uint32_t apbap_base;"},{"line_number":62,"context_line":"static uint32_t apbap_idr;"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"/*"},{"line_number":65,"context_line":" * EMULATION MODE: In Emulation MODE, we assume the following:"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"94ab1b6c_cb38fdb7","line":62,"range":{"start_line":57,"start_character":0,"end_line":62,"end_character":26},"updated":"2022-10-03 23:04:46.000000000","message":"Are you sure that is enough having a single set of global?\nOr you need one set for each emulated AP?","commit_id":"f4463d3959a47778c0e7cfdb4fcb57e9b6254e6a"},{"author":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"change_message_id":"a10a28d723b87b46de41c37b3f1db103a67d4e33","unresolved":false,"context_lines":[{"line_number":54,"context_line":"static uint64_t dmem_emu_ap_list[DMEM_MAX_EMULATE_APS];"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"/* Emulation mode state variables */"},{"line_number":57,"context_line":"static uint32_t apbap_tar;"},{"line_number":58,"context_line":"static uint32_t apbap_tar_inc;"},{"line_number":59,"context_line":"static uint32_t apbap_csw;"},{"line_number":60,"context_line":"static uint32_t apbap_cfg;"},{"line_number":61,"context_line":"static uint32_t apbap_base;"},{"line_number":62,"context_line":"static uint32_t apbap_idr;"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"/*"},{"line_number":65,"context_line":" * EMULATION MODE: In Emulation MODE, we assume the following:"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"0d9aca83_257eff5c","line":62,"range":{"start_line":57,"start_character":0,"end_line":62,"end_character":26},"in_reply_to":"94ab1b6c_cb38fdb7","updated":"2022-10-13 21:16:51.000000000","message":"You are correct - fixed.","commit_id":"f4463d3959a47778c0e7cfdb4fcb57e9b6254e6a"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"3adfd5ee502dac95613899565f48c4d7e84a85b5","unresolved":true,"context_lines":[{"line_number":85,"context_line":"{"},{"line_number":86,"context_line":"\taddr \u0026\u003d ~ARM_APB_PADDR31;"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"\t*(volatile uint32_t *)((char *)dmem_emu_virt_base_addr + addr) \u003d val;"},{"line_number":89,"context_line":"}"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"static uint32_t dmem_emu_get_ap_reg(uint64_t addr)"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"3b8a4509_a553bbd3","line":88,"updated":"2022-10-03 23:04:46.000000000","message":"uintptr_t","commit_id":"f4463d3959a47778c0e7cfdb4fcb57e9b6254e6a"},{"author":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"change_message_id":"a10a28d723b87b46de41c37b3f1db103a67d4e33","unresolved":false,"context_lines":[{"line_number":85,"context_line":"{"},{"line_number":86,"context_line":"\taddr \u0026\u003d ~ARM_APB_PADDR31;"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"\t*(volatile uint32_t *)((char *)dmem_emu_virt_base_addr + addr) \u003d val;"},{"line_number":89,"context_line":"}"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"static uint32_t dmem_emu_get_ap_reg(uint64_t addr)"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"6805afba_42b68e56","line":88,"in_reply_to":"3b8a4509_a553bbd3","updated":"2022-10-13 21:16:51.000000000","message":"Done","commit_id":"f4463d3959a47778c0e7cfdb4fcb57e9b6254e6a"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"3adfd5ee502dac95613899565f48c4d7e84a85b5","unresolved":true,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":"\taddr \u0026\u003d ~ARM_APB_PADDR31;"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"\tval \u003d *(volatile uint32_t *)((char *)dmem_emu_virt_base_addr + addr);"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"\treturn val;"},{"line_number":100,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"aa6b38e8_0136200c","line":97,"updated":"2022-10-03 23:04:46.000000000","message":"uintptr_t","commit_id":"f4463d3959a47778c0e7cfdb4fcb57e9b6254e6a"},{"author":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"change_message_id":"a10a28d723b87b46de41c37b3f1db103a67d4e33","unresolved":false,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":"\taddr \u0026\u003d ~ARM_APB_PADDR31;"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"\tval \u003d *(volatile uint32_t *)((char *)dmem_emu_virt_base_addr + addr);"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"\treturn val;"},{"line_number":100,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"9826bca1_d329d20b","line":97,"in_reply_to":"aa6b38e8_0136200c","updated":"2022-10-13 21:16:51.000000000","message":"Done","commit_id":"f4463d3959a47778c0e7cfdb4fcb57e9b6254e6a"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"3adfd5ee502dac95613899565f48c4d7e84a85b5","unresolved":true,"context_lines":[{"line_number":115,"context_line":"\t\t\t*data \u003d 0;"},{"line_number":116,"context_line":"\t\t\tbreak;"},{"line_number":117,"context_line":"\t\tcase ADIV5_MEM_AP_REG_BASE:"},{"line_number":118,"context_line":"\t\t\t*data \u003d 0;"},{"line_number":119,"context_line":"\t\t\tbreak;"},{"line_number":120,"context_line":"\t\tcase ADIV5_AP_REG_IDR:"},{"line_number":121,"context_line":"\t\t\t*data \u003d 0;"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"04628f2a_4bd5ac20","line":118,"updated":"2022-10-03 23:04:46.000000000","message":"Without \u0027base\u0027 value OpenOCD cannot parse the ROM tables in this AP. SO you have to put the -dbgbase flag to the targets and you cannot use autodetection.\nDo you have any way to provide the base address of the ROM table in some automatic way? Don\u0027t add another config command for this, it would be same as using -dbgbase.","commit_id":"f4463d3959a47778c0e7cfdb4fcb57e9b6254e6a"},{"author":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"change_message_id":"a10a28d723b87b46de41c37b3f1db103a67d4e33","unresolved":false,"context_lines":[{"line_number":115,"context_line":"\t\t\t*data \u003d 0;"},{"line_number":116,"context_line":"\t\t\tbreak;"},{"line_number":117,"context_line":"\t\tcase ADIV5_MEM_AP_REG_BASE:"},{"line_number":118,"context_line":"\t\t\t*data \u003d 0;"},{"line_number":119,"context_line":"\t\t\tbreak;"},{"line_number":120,"context_line":"\t\tcase ADIV5_AP_REG_IDR:"},{"line_number":121,"context_line":"\t\t\t*data \u003d 0;"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"995ea4f2_bf787586","line":118,"in_reply_to":"04628f2a_4bd5ac20","updated":"2022-10-13 21:16:51.000000000","message":"Jason and I discussed this - we cant think of a scheme to be able to do autodetection :( yeah - we already use -dbgbase atm. Unless someone has a way to dig this up..","commit_id":"f4463d3959a47778c0e7cfdb4fcb57e9b6254e6a"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"3adfd5ee502dac95613899565f48c4d7e84a85b5","unresolved":true,"context_lines":[{"line_number":135,"context_line":"\t\t\t*data \u003d dmem_emu_get_ap_reg(addr);"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"\t\t\tif (apbap_csw \u0026 CSW_ADDRINC_MASK)"},{"line_number":138,"context_line":"\t\t\t\tapbap_tar_inc +\u003d (apbap_csw \u0026 0x03) * 2;"},{"line_number":139,"context_line":"\t\t\tbreak;"},{"line_number":140,"context_line":"\t\tdefault:"},{"line_number":141,"context_line":"\t\t\tLOG_INFO(\"%s: Unknown reg: 0x%02x\\n\", __func__, reg);"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"2486bc6b_b1b25270","line":138,"updated":"2022-10-03 23:04:46.000000000","message":"Do 8 and 16 bits read/write work fine? No issue reading misaligned uint32_t from mmap() area?","commit_id":"f4463d3959a47778c0e7cfdb4fcb57e9b6254e6a"},{"author":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"change_message_id":"a10a28d723b87b46de41c37b3f1db103a67d4e33","unresolved":false,"context_lines":[{"line_number":135,"context_line":"\t\t\t*data \u003d dmem_emu_get_ap_reg(addr);"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"\t\t\tif (apbap_csw \u0026 CSW_ADDRINC_MASK)"},{"line_number":138,"context_line":"\t\t\t\tapbap_tar_inc +\u003d (apbap_csw \u0026 0x03) * 2;"},{"line_number":139,"context_line":"\t\t\tbreak;"},{"line_number":140,"context_line":"\t\tdefault:"},{"line_number":141,"context_line":"\t\t\tLOG_INFO(\"%s: Unknown reg: 0x%02x\\n\", __func__, reg);"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"35029a76_ea699dae","line":138,"in_reply_to":"2486bc6b_b1b25270","updated":"2022-10-13 21:16:51.000000000","message":"from the mem-ap configs that we are aware of (and use), 32bit is the norm. Not aware of options from any other companies that do 8bit or 16bit options 😞","commit_id":"f4463d3959a47778c0e7cfdb4fcb57e9b6254e6a"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"3adfd5ee502dac95613899565f48c4d7e84a85b5","unresolved":true,"context_lines":[{"line_number":165,"context_line":"\t\t\tbreak;"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"\t\tcase ADIV5_MEM_AP_REG_CFG:"},{"line_number":168,"context_line":"\t\t\tapbap_cfg \u003d data;"},{"line_number":169,"context_line":"\t\t\tbreak;"},{"line_number":170,"context_line":"\t\tcase ADIV5_MEM_AP_REG_BASE:"},{"line_number":171,"context_line":"\t\t\tapbap_base \u003d data;"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"fbb100a6_f3abb047","line":168,"updated":"2022-10-03 23:04:46.000000000","message":"assigned but never used. Can be dropped?","commit_id":"f4463d3959a47778c0e7cfdb4fcb57e9b6254e6a"},{"author":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"change_message_id":"a10a28d723b87b46de41c37b3f1db103a67d4e33","unresolved":false,"context_lines":[{"line_number":165,"context_line":"\t\t\tbreak;"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"\t\tcase ADIV5_MEM_AP_REG_CFG:"},{"line_number":168,"context_line":"\t\t\tapbap_cfg \u003d data;"},{"line_number":169,"context_line":"\t\t\tbreak;"},{"line_number":170,"context_line":"\t\tcase ADIV5_MEM_AP_REG_BASE:"},{"line_number":171,"context_line":"\t\t\tapbap_base \u003d data;"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"9fc51455_e6ff2f2b","line":168,"in_reply_to":"fbb100a6_f3abb047","updated":"2022-10-13 21:16:51.000000000","message":"Done","commit_id":"f4463d3959a47778c0e7cfdb4fcb57e9b6254e6a"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"3adfd5ee502dac95613899565f48c4d7e84a85b5","unresolved":true,"context_lines":[{"line_number":168,"context_line":"\t\t\tapbap_cfg \u003d data;"},{"line_number":169,"context_line":"\t\t\tbreak;"},{"line_number":170,"context_line":"\t\tcase ADIV5_MEM_AP_REG_BASE:"},{"line_number":171,"context_line":"\t\t\tapbap_base \u003d data;"},{"line_number":172,"context_line":"\t\t\tbreak;"},{"line_number":173,"context_line":"\t\tcase ADIV5_AP_REG_IDR:"},{"line_number":174,"context_line":"\t\t\tapbap_idr \u003d data;"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"a485b3a5_93a85ec0","line":171,"updated":"2022-10-03 23:04:46.000000000","message":"same here","commit_id":"f4463d3959a47778c0e7cfdb4fcb57e9b6254e6a"},{"author":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"change_message_id":"a10a28d723b87b46de41c37b3f1db103a67d4e33","unresolved":false,"context_lines":[{"line_number":168,"context_line":"\t\t\tapbap_cfg \u003d data;"},{"line_number":169,"context_line":"\t\t\tbreak;"},{"line_number":170,"context_line":"\t\tcase ADIV5_MEM_AP_REG_BASE:"},{"line_number":171,"context_line":"\t\t\tapbap_base \u003d data;"},{"line_number":172,"context_line":"\t\t\tbreak;"},{"line_number":173,"context_line":"\t\tcase ADIV5_AP_REG_IDR:"},{"line_number":174,"context_line":"\t\t\tapbap_idr \u003d data;"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"21313e17_04028f9a","line":171,"in_reply_to":"a485b3a5_93a85ec0","updated":"2022-10-13 21:16:51.000000000","message":"Done","commit_id":"f4463d3959a47778c0e7cfdb4fcb57e9b6254e6a"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"3adfd5ee502dac95613899565f48c4d7e84a85b5","unresolved":true,"context_lines":[{"line_number":171,"context_line":"\t\t\tapbap_base \u003d data;"},{"line_number":172,"context_line":"\t\t\tbreak;"},{"line_number":173,"context_line":"\t\tcase ADIV5_AP_REG_IDR:"},{"line_number":174,"context_line":"\t\t\tapbap_idr \u003d data;"},{"line_number":175,"context_line":"\t\t\tbreak;"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"\t\tcase ADIV5_MEM_AP_REG_BD0:"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"0f46976b_2a2662ef","line":174,"updated":"2022-10-03 23:04:46.000000000","message":"and here","commit_id":"f4463d3959a47778c0e7cfdb4fcb57e9b6254e6a"},{"author":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"change_message_id":"a10a28d723b87b46de41c37b3f1db103a67d4e33","unresolved":false,"context_lines":[{"line_number":171,"context_line":"\t\t\tapbap_base \u003d data;"},{"line_number":172,"context_line":"\t\t\tbreak;"},{"line_number":173,"context_line":"\t\tcase ADIV5_AP_REG_IDR:"},{"line_number":174,"context_line":"\t\t\tapbap_idr \u003d data;"},{"line_number":175,"context_line":"\t\t\tbreak;"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"\t\tcase ADIV5_MEM_AP_REG_BD0:"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"c98554bf_8ed7d22a","line":174,"in_reply_to":"0f46976b_2a2662ef","updated":"2022-10-13 21:16:51.000000000","message":"Done","commit_id":"f4463d3959a47778c0e7cfdb4fcb57e9b6254e6a"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"3adfd5ee502dac95613899565f48c4d7e84a85b5","unresolved":true,"context_lines":[{"line_number":360,"context_line":"COMMAND_HANDLER(dmem_emu_ap_list_command)"},{"line_number":361,"context_line":"{"},{"line_number":362,"context_line":"\tint i;"},{"line_number":363,"context_line":"\tint argc \u003d CMD_ARGC;"},{"line_number":364,"context_line":"\tuint64_t em_ap;"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"\tif (argc \u003e DMEM_MAX_EMULATE_APS)"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"20cea74f_9bc18ba9","line":363,"updated":"2022-10-03 23:04:46.000000000","message":"you can skip temporarily variable \u0027argc\u0027","commit_id":"f4463d3959a47778c0e7cfdb4fcb57e9b6254e6a"},{"author":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"change_message_id":"a10a28d723b87b46de41c37b3f1db103a67d4e33","unresolved":false,"context_lines":[{"line_number":360,"context_line":"COMMAND_HANDLER(dmem_emu_ap_list_command)"},{"line_number":361,"context_line":"{"},{"line_number":362,"context_line":"\tint i;"},{"line_number":363,"context_line":"\tint argc \u003d CMD_ARGC;"},{"line_number":364,"context_line":"\tuint64_t em_ap;"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"\tif (argc \u003e DMEM_MAX_EMULATE_APS)"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"b9f0efa9_56ccde7b","line":363,"in_reply_to":"20cea74f_9bc18ba9","updated":"2022-10-13 21:16:51.000000000","message":"Done","commit_id":"f4463d3959a47778c0e7cfdb4fcb57e9b6254e6a"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"3adfd5ee502dac95613899565f48c4d7e84a85b5","unresolved":true,"context_lines":[{"line_number":363,"context_line":"\tint argc \u003d CMD_ARGC;"},{"line_number":364,"context_line":"\tuint64_t em_ap;"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"\tif (argc \u003e DMEM_MAX_EMULATE_APS)"},{"line_number":367,"context_line":"\t\treturn ERROR_COMMAND_SYNTAX_ERROR;"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"\tfor (i \u003d 0; i \u003c argc; i++) {"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"55d72165_e39bf9bc","line":366,"updated":"2022-10-03 23:04:46.000000000","message":"if (CMD_ARGC \u003c 1 || CMD_ARGC \u003e DMEM_MAX_EMULATE_APS)","commit_id":"f4463d3959a47778c0e7cfdb4fcb57e9b6254e6a"},{"author":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"change_message_id":"a10a28d723b87b46de41c37b3f1db103a67d4e33","unresolved":false,"context_lines":[{"line_number":363,"context_line":"\tint argc \u003d CMD_ARGC;"},{"line_number":364,"context_line":"\tuint64_t em_ap;"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"\tif (argc \u003e DMEM_MAX_EMULATE_APS)"},{"line_number":367,"context_line":"\t\treturn ERROR_COMMAND_SYNTAX_ERROR;"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"\tfor (i \u003d 0; i \u003c argc; i++) {"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"24d5cde8_9edbcc35","line":366,"in_reply_to":"55d72165_e39bf9bc","updated":"2022-10-13 21:16:51.000000000","message":"Done","commit_id":"f4463d3959a47778c0e7cfdb4fcb57e9b6254e6a"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"3adfd5ee502dac95613899565f48c4d7e84a85b5","unresolved":true,"context_lines":[{"line_number":366,"context_line":"\tif (argc \u003e DMEM_MAX_EMULATE_APS)"},{"line_number":367,"context_line":"\t\treturn ERROR_COMMAND_SYNTAX_ERROR;"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"\tfor (i \u003d 0; i \u003c argc; i++) {"},{"line_number":370,"context_line":"\t\tCOMMAND_PARSE_NUMBER(u64, CMD_ARGV[i], em_ap);"},{"line_number":371,"context_line":"\t\tdmem_emu_ap_list[i] \u003d em_ap;"},{"line_number":372,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"38dc12d8_0f4b4e40","line":369,"updated":"2022-10-03 23:04:46.000000000","message":"for (unsigned int i \u003d 0; i \u003c CMD_ARGC; i++) {","commit_id":"f4463d3959a47778c0e7cfdb4fcb57e9b6254e6a"},{"author":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"change_message_id":"a10a28d723b87b46de41c37b3f1db103a67d4e33","unresolved":false,"context_lines":[{"line_number":366,"context_line":"\tif (argc \u003e DMEM_MAX_EMULATE_APS)"},{"line_number":367,"context_line":"\t\treturn ERROR_COMMAND_SYNTAX_ERROR;"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"\tfor (i \u003d 0; i \u003c argc; i++) {"},{"line_number":370,"context_line":"\t\tCOMMAND_PARSE_NUMBER(u64, CMD_ARGV[i], em_ap);"},{"line_number":371,"context_line":"\t\tdmem_emu_ap_list[i] \u003d em_ap;"},{"line_number":372,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"8bcd94c2_a7e864d2","line":369,"in_reply_to":"38dc12d8_0f4b4e40","updated":"2022-10-13 21:16:51.000000000","message":"Done","commit_id":"f4463d3959a47778c0e7cfdb4fcb57e9b6254e6a"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"3adfd5ee502dac95613899565f48c4d7e84a85b5","unresolved":true,"context_lines":[{"line_number":387,"context_line":"\tcommand_print(CMD, \" Base Address : 0x%lx\", dmem_dap_base_address);"},{"line_number":388,"context_line":"\tcommand_print(CMD, \" Max APs      : %d\", dmem_dap_max_aps);"},{"line_number":389,"context_line":"\tcommand_print(CMD, \" AP offset    : 0x%08x\", dmem_dap_ap_offset);"},{"line_number":390,"context_line":"\tcommand_print(CMD, \" Emulated AP Count : %d\", dmem_emu_ap_count);"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"\tif (dmem_emu_ap_count) {"},{"line_number":393,"context_line":"\t\tunsigned int i;"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"fa5d239e_2ad70f08","line":390,"updated":"2022-10-03 23:04:46.000000000","message":"%u","commit_id":"f4463d3959a47778c0e7cfdb4fcb57e9b6254e6a"},{"author":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"change_message_id":"a10a28d723b87b46de41c37b3f1db103a67d4e33","unresolved":false,"context_lines":[{"line_number":387,"context_line":"\tcommand_print(CMD, \" Base Address : 0x%lx\", dmem_dap_base_address);"},{"line_number":388,"context_line":"\tcommand_print(CMD, \" Max APs      : %d\", dmem_dap_max_aps);"},{"line_number":389,"context_line":"\tcommand_print(CMD, \" AP offset    : 0x%08x\", dmem_dap_ap_offset);"},{"line_number":390,"context_line":"\tcommand_print(CMD, \" Emulated AP Count : %d\", dmem_emu_ap_count);"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"\tif (dmem_emu_ap_count) {"},{"line_number":393,"context_line":"\t\tunsigned int i;"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"d4fb164c_db92f256","line":390,"in_reply_to":"fa5d239e_2ad70f08","updated":"2022-10-13 21:16:51.000000000","message":"Done","commit_id":"f4463d3959a47778c0e7cfdb4fcb57e9b6254e6a"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"3adfd5ee502dac95613899565f48c4d7e84a85b5","unresolved":true,"context_lines":[{"line_number":393,"context_line":"\t\tunsigned int i;"},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"\t\tcommand_print(CMD, \" Emulated AP details:\");"},{"line_number":396,"context_line":"\t\tcommand_print(CMD, \" Emulated address  : 0x%lx\", dmem_emu_base_address);"},{"line_number":397,"context_line":"\t\tcommand_print(CMD, \" Emulated size     : 0x%lx\", dmem_emu_mapped_size);"},{"line_number":398,"context_line":"\t\tfor (i \u003d 0; i \u003c dmem_emu_ap_count; i++)"},{"line_number":399,"context_line":"\t\t\tcommand_print(CMD, \" Emulated AP [%d]  : %ld\", i,"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"14f3298a_44b80323","line":396,"updated":"2022-10-03 23:04:46.000000000","message":"Here and in next two:\n command_print(CMD, \" Emulated address  : 0x%\" PRIx64, dmem_emu_base_address);","commit_id":"f4463d3959a47778c0e7cfdb4fcb57e9b6254e6a"},{"author":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"change_message_id":"a10a28d723b87b46de41c37b3f1db103a67d4e33","unresolved":false,"context_lines":[{"line_number":393,"context_line":"\t\tunsigned int i;"},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"\t\tcommand_print(CMD, \" Emulated AP details:\");"},{"line_number":396,"context_line":"\t\tcommand_print(CMD, \" Emulated address  : 0x%lx\", dmem_emu_base_address);"},{"line_number":397,"context_line":"\t\tcommand_print(CMD, \" Emulated size     : 0x%lx\", dmem_emu_mapped_size);"},{"line_number":398,"context_line":"\t\tfor (i \u003d 0; i \u003c dmem_emu_ap_count; i++)"},{"line_number":399,"context_line":"\t\t\tcommand_print(CMD, \" Emulated AP [%d]  : %ld\", i,"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"12d88700_e990de64","line":396,"in_reply_to":"14f3298a_44b80323","updated":"2022-10-13 21:16:51.000000000","message":"Done","commit_id":"f4463d3959a47778c0e7cfdb4fcb57e9b6254e6a"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"3adfd5ee502dac95613899565f48c4d7e84a85b5","unresolved":true,"context_lines":[{"line_number":517,"context_line":"\t/* Lets Map the emulated address if necessary */"},{"line_number":518,"context_line":"\tif (dmem_emu_ap_count) {"},{"line_number":519,"context_line":"\t\tif ((dmem_emu_base_address % page_size) ||"},{"line_number":520,"context_line":"\t\t    (dmem_emu_mapped_size % page_size)) {"},{"line_number":521,"context_line":"\t\t\tLOG_ERROR(\"Please align emulated base and size to pagesize 0x%lx\\n\", page_size);"},{"line_number":522,"context_line":"\t\t\treturn ERROR_FAIL;"},{"line_number":523,"context_line":"\t\t}"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"971b62d4_2c04e25a","line":520,"updated":"2022-10-03 23:04:46.000000000","message":"as in previous patch, use ALIGN_DOWN() and ALIGN_UP()\nremove \u0027\\n\u0027 form LOG_XXX()\nno need to align again dmem_emu_base_address in mmap()","commit_id":"f4463d3959a47778c0e7cfdb4fcb57e9b6254e6a"},{"author":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"change_message_id":"a10a28d723b87b46de41c37b3f1db103a67d4e33","unresolved":false,"context_lines":[{"line_number":517,"context_line":"\t/* Lets Map the emulated address if necessary */"},{"line_number":518,"context_line":"\tif (dmem_emu_ap_count) {"},{"line_number":519,"context_line":"\t\tif ((dmem_emu_base_address % page_size) ||"},{"line_number":520,"context_line":"\t\t    (dmem_emu_mapped_size % page_size)) {"},{"line_number":521,"context_line":"\t\t\tLOG_ERROR(\"Please align emulated base and size to pagesize 0x%lx\\n\", page_size);"},{"line_number":522,"context_line":"\t\t\treturn ERROR_FAIL;"},{"line_number":523,"context_line":"\t\t}"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"935e1df5_623adf7b","line":520,"in_reply_to":"971b62d4_2c04e25a","updated":"2022-10-13 21:16:51.000000000","message":"Done","commit_id":"f4463d3959a47778c0e7cfdb4fcb57e9b6254e6a"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"bc77cba29d771949de00221a2f399b0c4886aefa","unresolved":true,"context_lines":[{"line_number":111,"context_line":"\t\t\t*data \u003d ap_info-\u003eapbap_csw;"},{"line_number":112,"context_line":"\t\t\tbreak;"},{"line_number":113,"context_line":"\t\tcase ADIV5_MEM_AP_REG_TAR:"},{"line_number":114,"context_line":"\t\t\t*data \u003d ap_info-\u003eapbap_tar;"},{"line_number":115,"context_line":"\t\t\tbreak;"},{"line_number":116,"context_line":"\t\tcase ADIV5_MEM_AP_REG_CFG:"},{"line_number":117,"context_line":"\t\t\t*data \u003d 0;"}],"source_content_type":"text/x-csrc","patch_set":6,"id":"8ea80726_2f464aa8","line":114,"updated":"2022-10-20 08:38:52.000000000","message":"I see that you handle separately apbap_tar and apbap_tar_inc.\nIn real AP, TAR register content gets really incremented and reading back TAR returns the incremented value.\nIs there a specific reason to keep TAR constant in this emulation?\n\nIf you only plan to handle 32 bits read/write that\u0027s perfectly fine.\nBut in such case I would suggest to hack the write in apbap_csw, ignore the CSW_SIZE_MASK bits and always set them as CSW_32BIT. This is the behavior in ADIv5 spec for AP that only support 32 bits.","commit_id":"503347ab0dc377b7fa2cf8dc5b8e9510a0805a51"},{"author":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"change_message_id":"684804fc49ebb137ee2c76074aa9a80118a2d4f9","unresolved":false,"context_lines":[{"line_number":111,"context_line":"\t\t\t*data \u003d ap_info-\u003eapbap_csw;"},{"line_number":112,"context_line":"\t\t\tbreak;"},{"line_number":113,"context_line":"\t\tcase ADIV5_MEM_AP_REG_TAR:"},{"line_number":114,"context_line":"\t\t\t*data \u003d ap_info-\u003eapbap_tar;"},{"line_number":115,"context_line":"\t\t\tbreak;"},{"line_number":116,"context_line":"\t\tcase ADIV5_MEM_AP_REG_CFG:"},{"line_number":117,"context_line":"\t\t\t*data \u003d 0;"}],"source_content_type":"text/x-csrc","patch_set":6,"id":"d52a756c_310d6a28","line":114,"in_reply_to":"8ea80726_2f464aa8","updated":"2023-08-08 17:52:21.000000000","message":"Ack- This should be resolved in the latest revision.","commit_id":"503347ab0dc377b7fa2cf8dc5b8e9510a0805a51"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"bc77cba29d771949de00221a2f399b0c4886aefa","unresolved":true,"context_lines":[{"line_number":397,"context_line":"\t\tcommand_print(CMD, \" Emulated AP details:\");"},{"line_number":398,"context_line":"\t\tcommand_print(CMD, \" Emulated address  : 0x%\" PRIx64, dmem_emu_base_address);"},{"line_number":399,"context_line":"\t\tcommand_print(CMD, \" Emulated size     : 0x%\" PRIx64, dmem_emu_size);"},{"line_number":400,"context_line":"\t\tfor (i \u003d 0; i \u003c dmem_emu_ap_count; i++)"},{"line_number":401,"context_line":"\t\t\tcommand_print(CMD, \" Emulated AP [%u]  : %\" PRIx64, i,"},{"line_number":402,"context_line":"\t\t\t\t      dmem_emu_ap_list[i].ap_num);"},{"line_number":403,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":6,"id":"2bc03e49_18834350","line":400,"updated":"2022-10-20 08:38:52.000000000","message":"for (unsigned int i \u003d 0; ...","commit_id":"503347ab0dc377b7fa2cf8dc5b8e9510a0805a51"},{"author":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"change_message_id":"684804fc49ebb137ee2c76074aa9a80118a2d4f9","unresolved":false,"context_lines":[{"line_number":397,"context_line":"\t\tcommand_print(CMD, \" Emulated AP details:\");"},{"line_number":398,"context_line":"\t\tcommand_print(CMD, \" Emulated address  : 0x%\" PRIx64, dmem_emu_base_address);"},{"line_number":399,"context_line":"\t\tcommand_print(CMD, \" Emulated size     : 0x%\" PRIx64, dmem_emu_size);"},{"line_number":400,"context_line":"\t\tfor (i \u003d 0; i \u003c dmem_emu_ap_count; i++)"},{"line_number":401,"context_line":"\t\t\tcommand_print(CMD, \" Emulated AP [%u]  : %\" PRIx64, i,"},{"line_number":402,"context_line":"\t\t\t\t      dmem_emu_ap_list[i].ap_num);"},{"line_number":403,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":6,"id":"7c6d2cb0_3fb84686","line":400,"in_reply_to":"2bc03e49_18834350","updated":"2023-08-08 17:52:21.000000000","message":"Ack. Done in the next rev","commit_id":"503347ab0dc377b7fa2cf8dc5b8e9510a0805a51"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"bc77cba29d771949de00221a2f399b0c4886aefa","unresolved":true,"context_lines":[{"line_number":448,"context_line":"\t\t.usage \u003d \"n\","},{"line_number":449,"context_line":"\t},"},{"line_number":450,"context_line":"\t{"},{"line_number":451,"context_line":"\t\t.name \u003d \"emu_base_address\","},{"line_number":452,"context_line":"\t\t.handler \u003d dmem_emu_base_address_command,"},{"line_number":453,"context_line":"\t\t.mode \u003d COMMAND_CONFIG,"},{"line_number":454,"context_line":"\t\t.help \u003d \"set the base address and size of emulated AP range (all emulated APs access this range)\","}],"source_content_type":"text/x-csrc","patch_set":6,"id":"a3af70ba_4035bafa","line":451,"updated":"2022-10-20 08:38:52.000000000","message":"command name is \"base address\" but it\u0027s used to specify a range through base and size. Can be changed with a more intuitive name?","commit_id":"503347ab0dc377b7fa2cf8dc5b8e9510a0805a51"},{"author":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"change_message_id":"684804fc49ebb137ee2c76074aa9a80118a2d4f9","unresolved":false,"context_lines":[{"line_number":448,"context_line":"\t\t.usage \u003d \"n\","},{"line_number":449,"context_line":"\t},"},{"line_number":450,"context_line":"\t{"},{"line_number":451,"context_line":"\t\t.name \u003d \"emu_base_address\","},{"line_number":452,"context_line":"\t\t.handler \u003d dmem_emu_base_address_command,"},{"line_number":453,"context_line":"\t\t.mode \u003d COMMAND_CONFIG,"},{"line_number":454,"context_line":"\t\t.help \u003d \"set the base address and size of emulated AP range (all emulated APs access this range)\","}],"source_content_type":"text/x-csrc","patch_set":6,"id":"272511e3_26603bd6","line":451,"in_reply_to":"a3af70ba_4035bafa","updated":"2023-08-08 17:52:21.000000000","message":"emu_base_address_range - hopefully that should help?","commit_id":"503347ab0dc377b7fa2cf8dc5b8e9510a0805a51"}]}