)]}'
{"id":"openocd~master~I2c6befdf82575e95cf05ed158ab5e6faa1a182c3","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2022-08-08 20:46:36.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"I2c6befdf82575e95cf05ed158ab5e6faa1a182c3","subject":"target/arm: do not expose \u0027arm reg\u0027, \u0027arm mcr/mrc\u0027 commands on Cortex-M","status":"MERGED","created":"2022-08-01 17:36:54.000000000","updated":"2022-08-14 14:43:48.000000000","submitted":"2022-08-14 14:43:48.000000000","submitter":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7101","meta_rev_id":"fab68d2e18ef800cf83ab6f49a54ae2adee4004d","_number":7101,"owner":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-08-14 14:43:48.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-08-14 14:43:48.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-08-14 14:43:48.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-08-01 18:01:52.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"},{"updated":"2022-08-01 18:38:19.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"75254d77ca7cb13104428710391adf89662165a3","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-08-01 17:36:54.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d45e51e192d88d7b6f327d8d554524813fcf03ae","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-08-01 18:01:52.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"e7156ee3f5003fc7df6259133926e5efe4b1b277","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-08-01 18:38:19.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/15676/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/16467/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"16ead9a3e370993ecaf7cfd118da695659e18963","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-08-08 20:46:36.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"fab68d2e18ef800cf83ab6f49a54ae2adee4004d","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-08-14 14:43:48.000000000","message":"Change has been successfully cherry-picked as 0e1fe03f4ba2b313d80c0a2d3c2ecfb7aee85a77","accounts_in_message":[],"_revision_number":2}],"current_revision":"0e1fe03f4ba2b313d80c0a2d3c2ecfb7aee85a77","revisions":{"0e1fe03f4ba2b313d80c0a2d3c2ecfb7aee85a77":{"kind":"REWORK","_number":2,"created":"2022-08-14 14:43:48.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/01/7101/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/01/7101/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/01/7101/2 \u0026\u0026 git checkout -b change-7101 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/01/7101/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/01/7101/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/01/7101/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/01/7101/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/01/7101/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"dee7b7d8212dbe94d5afd6bba736de4fcd1a05ac","subject":"target/arm: make \u0027arm core_state\u0027 command compatible with Cortex-M"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2022-08-01 17:28:18.000000000","tz":120},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2022-08-14 14:43:48.000000000","tz":0},"subject":"target/arm: do not expose \u0027arm reg\u0027, \u0027arm mcr/mrc\u0027 commands on Cortex-M","message":"target/arm: do not expose \u0027arm reg\u0027, \u0027arm mcr/mrc\u0027 commands on Cortex-M\n\nTcl commands \u0027arm reg\u0027, \u0027arm mcr/mrc\u0027 do not work on M-profile based devices.\nIsolate them from \u0027arm core_state\u0027 and \u0027arm disassemble\u0027 and do not chain\nthem from armv7m_command_handlers.\n\nChange-Id: I2c6befdf82575e95cf05ed158ab5e6faa1a182c3\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/7101\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nTested-by: jenkins\n"}},"c0e78873a3fff6785fe9ad1cda9ddd8f8a58e5ac":{"kind":"REWORK","_number":1,"created":"2022-08-01 17:36:54.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/01/7101/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/01/7101/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/01/7101/1 \u0026\u0026 git checkout -b change-7101 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/01/7101/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/01/7101/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/01/7101/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/01/7101/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/01/7101/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"6da64bd663b8139dab9673fc288ee6a659599d07","subject":"target/arm: make \u0027arm core_state\u0027 command compatible with Cortex-M"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2022-08-01 17:28:18.000000000","tz":120},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2022-08-01 17:35:15.000000000","tz":120},"subject":"target/arm: do not expose \u0027arm reg\u0027, \u0027arm mcr/mrc\u0027 commands on Cortex-M","message":"target/arm: do not expose \u0027arm reg\u0027, \u0027arm mcr/mrc\u0027 commands on Cortex-M\n\nTcl commands \u0027arm reg\u0027, \u0027arm mcr/mrc\u0027 do not work on M-profile based devices.\nIsolate them from \u0027arm core_state\u0027 and \u0027arm disassemble\u0027 and do not chain\nthem from armv7m_command_handlers.\n\nChange-Id: I2c6befdf82575e95cf05ed158ab5e6faa1a182c3\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}