)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"8dff5459c3ab4996718f39d282b2f1eab9f2274e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1d2d020c_ad6ab7b2","updated":"2022-08-01 23:28:49.000000000","message":"Forgot to add attn to Tomas","commit_id":"af75954b1daae3bf8d91a5f5f84d8dac76021fc7"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"d2a70a6010dc168efe649659fed4d729b93afe28","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9f0b49a7_4e767574","updated":"2022-08-01 22:39:16.000000000","message":"Split from patch 7082.  Thanks in advance for reviewing!","commit_id":"af75954b1daae3bf8d91a5f5f84d8dac76021fc7"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"5b81bd58c061faacc4b3cde606335769b3ef7d8c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e00439ac_70edbb34","updated":"2022-08-01 23:18:21.000000000","message":"Thanks for your comments, Tomas.  Replied, and requesting your feedback.","commit_id":"af75954b1daae3bf8d91a5f5f84d8dac76021fc7"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"e5c4b39277e8bcba1ddd57ef4251535f3a0ad9cb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9bb49aaa_00fa51ff","updated":"2022-08-02 18:30:11.000000000","message":"Fixing comment. Thanks, Antonio!","commit_id":"703dea85b35e30c240d8568793b0cae9d3f26231"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b0c124f2f7da193e14833cf6d6888d4b1413eb07","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9922a23f_4b9e0c6b","updated":"2022-08-02 16:41:13.000000000","message":"ok for me, just a minor issue in the comment\u0027s text","commit_id":"703dea85b35e30c240d8568793b0cae9d3f26231"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"7622a981acd6be29fed91252a582873985213fa8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"374ef0c9_f1b54953","updated":"2022-08-03 08:58:42.000000000","message":"Thanks","commit_id":"3c6c0b35628649eba42dc4263fc151103a807802"}],"src/server/gdb_server.c":[{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"27e73794439ba92db49f7a23465ba8eb92daf061","unresolved":true,"context_lines":[{"line_number":1770,"context_line":"\t\tcase 1:"},{"line_number":1771,"context_line":"\t\t\tif (packet[0] \u003d\u003d \u0027Z\u0027) {"},{"line_number":1772,"context_line":"\t\t\t\tretval \u003d breakpoint_add(target, address, size, bp_type);"},{"line_number":1773,"context_line":"\t\t\t\tif (retval \u003d\u003d ERROR_TARGET_INVALID) {"},{"line_number":1774,"context_line":"\t\t\t\t\t/* Send empty reply to report that breakpoints of this type are not supported */"},{"line_number":1775,"context_line":"\t\t\t\t\tgdb_put_packet(connection, \"\", 0);"},{"line_number":1776,"context_line":"\t\t\t\t} else if (retval !\u003d ERROR_OK) {"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"e9e7c1cb_c64a15c2","line":1773,"range":{"start_line":1773,"start_character":18,"end_line":1773,"end_character":38},"updated":"2022-08-01 23:05:01.000000000","message":"Can you explain why ERROR_TARGET_INVALID gets special treatment?\nThis error is not typical for breakpoint/watchpoint subsystem.","commit_id":"af75954b1daae3bf8d91a5f5f84d8dac76021fc7"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"df81ffe96ed54ac48b87d67fec09f568820ae0fd","unresolved":true,"context_lines":[{"line_number":1770,"context_line":"\t\tcase 1:"},{"line_number":1771,"context_line":"\t\t\tif (packet[0] \u003d\u003d \u0027Z\u0027) {"},{"line_number":1772,"context_line":"\t\t\t\tretval \u003d breakpoint_add(target, address, size, bp_type);"},{"line_number":1773,"context_line":"\t\t\t\tif (retval \u003d\u003d ERROR_TARGET_INVALID) {"},{"line_number":1774,"context_line":"\t\t\t\t\t/* Send empty reply to report that breakpoints of this type are not supported */"},{"line_number":1775,"context_line":"\t\t\t\t\tgdb_put_packet(connection, \"\", 0);"},{"line_number":1776,"context_line":"\t\t\t\t} else if (retval !\u003d ERROR_OK) {"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"f1f53bc2_bccf17c9","line":1773,"range":{"start_line":1773,"start_character":18,"end_line":1773,"end_character":38},"in_reply_to":"3df0bce5_313d604e","updated":"2022-08-02 00:02:26.000000000","message":"ERROR_TARGET_INVALID means e.g. invalid common magic or mismatched target type.\nYou may consider more generic ERROR_NOT_IMPLEMENTED\nor add a new one with detailed name like ERROR_TARGET_BREAKPOINT_NOT_SUPPORTED","commit_id":"af75954b1daae3bf8d91a5f5f84d8dac76021fc7"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b0c124f2f7da193e14833cf6d6888d4b1413eb07","unresolved":false,"context_lines":[{"line_number":1770,"context_line":"\t\tcase 1:"},{"line_number":1771,"context_line":"\t\t\tif (packet[0] \u003d\u003d \u0027Z\u0027) {"},{"line_number":1772,"context_line":"\t\t\t\tretval \u003d breakpoint_add(target, address, size, bp_type);"},{"line_number":1773,"context_line":"\t\t\t\tif (retval \u003d\u003d ERROR_TARGET_INVALID) {"},{"line_number":1774,"context_line":"\t\t\t\t\t/* Send empty reply to report that breakpoints of this type are not supported */"},{"line_number":1775,"context_line":"\t\t\t\t\tgdb_put_packet(connection, \"\", 0);"},{"line_number":1776,"context_line":"\t\t\t\t} else if (retval !\u003d ERROR_OK) {"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"d02cccaf_7f952f37","line":1773,"range":{"start_line":1773,"start_character":18,"end_line":1773,"end_character":38},"in_reply_to":"88066804_43e0cdd3","updated":"2022-08-02 16:41:13.000000000","message":"Yes, ERROR_NOT_IMPLEMENTED is way better that ERROR_TARGET_INVALID.\nThanks","commit_id":"af75954b1daae3bf8d91a5f5f84d8dac76021fc7"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"5b81bd58c061faacc4b3cde606335769b3ef7d8c","unresolved":true,"context_lines":[{"line_number":1770,"context_line":"\t\tcase 1:"},{"line_number":1771,"context_line":"\t\t\tif (packet[0] \u003d\u003d \u0027Z\u0027) {"},{"line_number":1772,"context_line":"\t\t\t\tretval \u003d breakpoint_add(target, address, size, bp_type);"},{"line_number":1773,"context_line":"\t\t\t\tif (retval \u003d\u003d ERROR_TARGET_INVALID) {"},{"line_number":1774,"context_line":"\t\t\t\t\t/* Send empty reply to report that breakpoints of this type are not supported */"},{"line_number":1775,"context_line":"\t\t\t\t\tgdb_put_packet(connection, \"\", 0);"},{"line_number":1776,"context_line":"\t\t\t\t} else if (retval !\u003d ERROR_OK) {"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"3df0bce5_313d604e","line":1773,"range":{"start_line":1773,"start_character":18,"end_line":1773,"end_character":38},"in_reply_to":"e9e7c1cb_c64a15c2","updated":"2022-08-01 23:18:21.000000000","message":"Hi Tomas, the intention here is for the target layer implementing the breakpoint to send an \"unsupported\" error code up through breakpoint_add().  ERROR_TARGET_* were available since we wanted the target layer to avoid new dependencies on other layers, and ERROR_TARGET_INVALID was the most meaningful of the existing options in target.h.  If you prefer, I could add a new option like ERROR_TARGET_NOTSUPPORTED, but I didn\u0027t want to add potentially duplicate error codes without an official blessing.  Please advise... thanks in advance!","commit_id":"af75954b1daae3bf8d91a5f5f84d8dac76021fc7"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"650b00bdb39e0ae14f9d7dcfe73d8441c5ed34aa","unresolved":false,"context_lines":[{"line_number":1770,"context_line":"\t\tcase 1:"},{"line_number":1771,"context_line":"\t\t\tif (packet[0] \u003d\u003d \u0027Z\u0027) {"},{"line_number":1772,"context_line":"\t\t\t\tretval \u003d breakpoint_add(target, address, size, bp_type);"},{"line_number":1773,"context_line":"\t\t\t\tif (retval \u003d\u003d ERROR_TARGET_INVALID) {"},{"line_number":1774,"context_line":"\t\t\t\t\t/* Send empty reply to report that breakpoints of this type are not supported */"},{"line_number":1775,"context_line":"\t\t\t\t\tgdb_put_packet(connection, \"\", 0);"},{"line_number":1776,"context_line":"\t\t\t\t} else if (retval !\u003d ERROR_OK) {"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"88066804_43e0cdd3","line":1773,"range":{"start_line":1773,"start_character":18,"end_line":1773,"end_character":38},"in_reply_to":"f1f53bc2_bccf17c9","updated":"2022-08-02 13:34:46.000000000","message":"Thanks for the good suggestion, Tomas.  I changed this to use ERROR_NOT_IMPLEMENTED instead.","commit_id":"af75954b1daae3bf8d91a5f5f84d8dac76021fc7"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b0c124f2f7da193e14833cf6d6888d4b1413eb07","unresolved":true,"context_lines":[{"line_number":1791,"context_line":"\t\t\tif (packet[0] \u003d\u003d \u0027Z\u0027) {"},{"line_number":1792,"context_line":"\t\t\t\tretval \u003d watchpoint_add(target, address, size, wp_type, 0, 0xffffffffu);"},{"line_number":1793,"context_line":"\t\t\t\tif (retval \u003d\u003d ERROR_NOT_IMPLEMENTED) {"},{"line_number":1794,"context_line":"\t\t\t\t\t/* Send empty reply to report that breakpoints of this type are not supported */"},{"line_number":1795,"context_line":"\t\t\t\t\tgdb_put_packet(connection, \"\", 0);"},{"line_number":1796,"context_line":"\t\t\t\t} else if (retval !\u003d ERROR_OK) {"},{"line_number":1797,"context_line":"\t\t\t\t\tretval \u003d gdb_error(connection, retval);"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"0db2c07c_751d74ce","line":1794,"updated":"2022-08-02 16:41:13.000000000","message":"Copy/paste error, here it should be \"watchpoint\"","commit_id":"703dea85b35e30c240d8568793b0cae9d3f26231"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"e5c4b39277e8bcba1ddd57ef4251535f3a0ad9cb","unresolved":false,"context_lines":[{"line_number":1791,"context_line":"\t\t\tif (packet[0] \u003d\u003d \u0027Z\u0027) {"},{"line_number":1792,"context_line":"\t\t\t\tretval \u003d watchpoint_add(target, address, size, wp_type, 0, 0xffffffffu);"},{"line_number":1793,"context_line":"\t\t\t\tif (retval \u003d\u003d ERROR_NOT_IMPLEMENTED) {"},{"line_number":1794,"context_line":"\t\t\t\t\t/* Send empty reply to report that breakpoints of this type are not supported */"},{"line_number":1795,"context_line":"\t\t\t\t\tgdb_put_packet(connection, \"\", 0);"},{"line_number":1796,"context_line":"\t\t\t\t} else if (retval !\u003d ERROR_OK) {"},{"line_number":1797,"context_line":"\t\t\t\t\tretval \u003d gdb_error(connection, retval);"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"59977e51_ae9d4c0a","line":1794,"in_reply_to":"0db2c07c_751d74ce","updated":"2022-08-02 18:30:11.000000000","message":"whoops! good catch; thanks.","commit_id":"703dea85b35e30c240d8568793b0cae9d3f26231"}]}