)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"aa1dfeb5125413b0f355648ef50019526207469c","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Ian Thompson \u003cianst@cadence.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-08-01 15:47:52 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"server: support sparse register maps"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add additional error handling for targets where gaps may exist in reg_list[]"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5d68bc3f_175242ae","line":7,"updated":"2022-08-03 16:45:09.000000000","message":"please start the title with\ngdb_server: ...","commit_id":"d23fdefab4952b33fafd57e35958fbe0780e8a43"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"52b9297a095734f7decc7260b6a70501251c837a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Ian Thompson \u003cianst@cadence.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-08-01 15:47:52 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"server: support sparse register maps"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add additional error handling for targets where gaps may exist in reg_list[]"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"a5d9f2fd_56b3aec1","line":7,"in_reply_to":"5d68bc3f_175242ae","updated":"2022-08-03 17:43:31.000000000","message":"Will do. Patchset en route. Thanks, Antonio.","commit_id":"d23fdefab4952b33fafd57e35958fbe0780e8a43"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"2895cf6b97a2804612a0353b5e50e510a4cacec3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c87dc09a_8b6ecd02","updated":"2022-08-01 23:09:59.000000000","message":"Split from patch 7082.  Thanks in advance for reviewing!","commit_id":"d23fdefab4952b33fafd57e35958fbe0780e8a43"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"52b9297a095734f7decc7260b6a70501251c837a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"fe26ac5b_0dd60d2e","updated":"2022-08-03 17:43:31.000000000","message":"Thanks, Antonio.","commit_id":"d23fdefab4952b33fafd57e35958fbe0780e8a43"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"1a5a6351e56370cbe649cc71084417a6632f7402","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5a5df8d6_93fbec76","updated":"2022-08-03 17:58:21.000000000","message":"thanks!","commit_id":"de98287cead5d515bd152ac5405c05d3b5df99a9"}],"src/server/gdb_server.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"aa1dfeb5125413b0f355648ef50019526207469c","unresolved":false,"context_lines":[{"line_number":1260,"context_line":"\treg_packet_p \u003d reg_packet;"},{"line_number":1261,"context_line":""},{"line_number":1262,"context_line":"\tfor (i \u003d 0; i \u003c reg_list_size; i++) {"},{"line_number":1263,"context_line":"\t\tif (!reg_list[i] || reg_list[i]-\u003eexist \u003d\u003d false || reg_list[i]-\u003ehidden)"},{"line_number":1264,"context_line":"\t\t\tcontinue;"},{"line_number":1265,"context_line":"\t\tif (!reg_list[i]-\u003evalid) {"},{"line_number":1266,"context_line":"\t\t\tretval \u003d reg_list[i]-\u003etype-\u003eget(reg_list[i]);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"26cd840c_bdad11e3","line":1263,"updated":"2022-08-03 16:45:09.000000000","message":"I\u0027m comparing this existing line with your modified lines","commit_id":"d23fdefab4952b33fafd57e35958fbe0780e8a43"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"aa1dfeb5125413b0f355648ef50019526207469c","unresolved":true,"context_lines":[{"line_number":1323,"context_line":"\tpacket_p \u003d packet;"},{"line_number":1324,"context_line":"\tfor (i \u003d 0; i \u003c reg_list_size; i++) {"},{"line_number":1325,"context_line":"\t\tuint8_t *bin_buf;"},{"line_number":1326,"context_line":"\t\tif (!reg_list[i] || !reg_list[i]-\u003eexist)"},{"line_number":1327,"context_line":"\t\t\tcontinue;"},{"line_number":1328,"context_line":"\t\tint chars \u003d (DIV_ROUND_UP(reg_list[i]-\u003esize, 8) * 2);"},{"line_number":1329,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"8009ce25_9028ea9d","line":1326,"updated":"2022-08-03 16:45:09.000000000","message":"for similitude should we add here\n || reg_list[i]-\u003ehidden\n\n?","commit_id":"d23fdefab4952b33fafd57e35958fbe0780e8a43"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"52b9297a095734f7decc7260b6a70501251c837a","unresolved":false,"context_lines":[{"line_number":1323,"context_line":"\tpacket_p \u003d packet;"},{"line_number":1324,"context_line":"\tfor (i \u003d 0; i \u003c reg_list_size; i++) {"},{"line_number":1325,"context_line":"\t\tuint8_t *bin_buf;"},{"line_number":1326,"context_line":"\t\tif (!reg_list[i] || !reg_list[i]-\u003eexist)"},{"line_number":1327,"context_line":"\t\t\tcontinue;"},{"line_number":1328,"context_line":"\t\tint chars \u003d (DIV_ROUND_UP(reg_list[i]-\u003esize, 8) * 2);"},{"line_number":1329,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"4a9fc60e_0cde35b0","line":1326,"in_reply_to":"8009ce25_9028ea9d","updated":"2022-08-03 17:43:31.000000000","message":"Good find!  Adding additional checks.  Thanks.","commit_id":"d23fdefab4952b33fafd57e35958fbe0780e8a43"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"aa1dfeb5125413b0f355648ef50019526207469c","unresolved":true,"context_lines":[{"line_number":1377,"context_line":"\tif (retval !\u003d ERROR_OK)"},{"line_number":1378,"context_line":"\t\treturn gdb_error(connection, retval);"},{"line_number":1379,"context_line":""},{"line_number":1380,"context_line":"\tif ((reg_list_size \u003c\u003d reg_num) || !reg_list[reg_num]) {"},{"line_number":1381,"context_line":"\t\tLOG_ERROR(\"gdb requested a non-existing register (reg_num\u003d%d)\", reg_num);"},{"line_number":1382,"context_line":"\t\treturn ERROR_SERVER_REMOTE_CLOSED;"},{"line_number":1383,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"f242b8c3_ea413730","line":1380,"updated":"2022-08-03 16:45:09.000000000","message":"and here\n || !reg_list[reg_num]-\u003eexist || reg_list[reg_num]-\u003ehidden","commit_id":"d23fdefab4952b33fafd57e35958fbe0780e8a43"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"52b9297a095734f7decc7260b6a70501251c837a","unresolved":false,"context_lines":[{"line_number":1377,"context_line":"\tif (retval !\u003d ERROR_OK)"},{"line_number":1378,"context_line":"\t\treturn gdb_error(connection, retval);"},{"line_number":1379,"context_line":""},{"line_number":1380,"context_line":"\tif ((reg_list_size \u003c\u003d reg_num) || !reg_list[reg_num]) {"},{"line_number":1381,"context_line":"\t\tLOG_ERROR(\"gdb requested a non-existing register (reg_num\u003d%d)\", reg_num);"},{"line_number":1382,"context_line":"\t\treturn ERROR_SERVER_REMOTE_CLOSED;"},{"line_number":1383,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"5a1106df_96096f7f","line":1380,"in_reply_to":"f242b8c3_ea413730","updated":"2022-08-03 17:43:31.000000000","message":"Done","commit_id":"d23fdefab4952b33fafd57e35958fbe0780e8a43"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"aa1dfeb5125413b0f355648ef50019526207469c","unresolved":true,"context_lines":[{"line_number":1439,"context_line":"\t\treturn gdb_error(connection, retval);"},{"line_number":1440,"context_line":"\t}"},{"line_number":1441,"context_line":""},{"line_number":1442,"context_line":"\tif ((reg_list_size \u003c\u003d reg_num) || !reg_list[reg_num]) {"},{"line_number":1443,"context_line":"\t\tLOG_ERROR(\"gdb requested a non-existing register (reg_num\u003d%d)\", reg_num);"},{"line_number":1444,"context_line":"\t\tfree(bin_buf);"},{"line_number":1445,"context_line":"\t\tfree(reg_list);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"7d8a1f8b_5ff55d69","line":1442,"updated":"2022-08-03 16:45:09.000000000","message":"same here","commit_id":"d23fdefab4952b33fafd57e35958fbe0780e8a43"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"52b9297a095734f7decc7260b6a70501251c837a","unresolved":false,"context_lines":[{"line_number":1439,"context_line":"\t\treturn gdb_error(connection, retval);"},{"line_number":1440,"context_line":"\t}"},{"line_number":1441,"context_line":""},{"line_number":1442,"context_line":"\tif ((reg_list_size \u003c\u003d reg_num) || !reg_list[reg_num]) {"},{"line_number":1443,"context_line":"\t\tLOG_ERROR(\"gdb requested a non-existing register (reg_num\u003d%d)\", reg_num);"},{"line_number":1444,"context_line":"\t\tfree(bin_buf);"},{"line_number":1445,"context_line":"\t\tfree(reg_list);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"cfd26254_4915b267","line":1442,"in_reply_to":"7d8a1f8b_5ff55d69","updated":"2022-08-03 17:43:31.000000000","message":"Done","commit_id":"d23fdefab4952b33fafd57e35958fbe0780e8a43"}]}