)]}'
{"id":"openocd~master~I0116894d5ebf1655f6011f0d35acdbbc178cd48c","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2022-08-27 16:14:58.000000000","reason":"removed on reply"},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2022-08-27 16:15:01.000000000","reason":"Change was submitted"},"1001422":{"account":{"_account_id":1001422,"name":"Bohdan Tymkiv","email":"bohdan200@gmail.com","username":"bhdt"},"last_update":"2022-08-27 16:15:01.000000000","reason":"Change was submitted"},"1000862":{"account":{"_account_id":1000862,"name":"Forest Crossman","email":"cyrozap@gmail.com","username":"cyrozap"},"last_update":"2022-08-27 16:15:01.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I0116894d5ebf1655f6011f0d35acdbbc178cd48c","subject":"jtag/drivers/kitprog: workaround serious firmware problem","status":"MERGED","created":"2022-08-02 07:38:05.000000000","updated":"2022-08-27 16:15:01.000000000","submitted":"2022-08-27 16:15:01.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7107","meta_rev_id":"6c3446ba5fd038a270f637c6c72f9e42bd365171","_number":7107,"owner":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-08-27 16:15:01.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-08-27 16:15:01.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-08-27 16:15:01.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000862,"name":"Forest Crossman","email":"cyrozap@gmail.com","username":"cyrozap"},{"_account_id":1001422,"name":"Bohdan Tymkiv","email":"bohdan200@gmail.com","username":"bhdt"}],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"_account_id":1000862,"name":"Forest Crossman","email":"cyrozap@gmail.com","username":"cyrozap"},{"_account_id":1001422,"name":"Bohdan Tymkiv","email":"bohdan200@gmail.com","username":"bhdt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-08-02 08:24:15.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-08-02 10:10:56.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000862,"name":"Forest Crossman","email":"cyrozap@gmail.com","username":"cyrozap"},"state":"REVIEWER"},{"updated":"2022-08-15 08:46:20.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1001422,"name":"Bohdan Tymkiv","email":"bohdan200@gmail.com","username":"bhdt"},"state":"REVIEWER"},{"updated":"2022-08-15 13:56:19.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"ce8d2f8ac7458c3758a6b2dd909ab808cf2daf80","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-08-02 07:38:05.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"bc939c8871f913f4949f9095d8b0f0da835ef93f","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-08-02 08:24:15.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/15690/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/16480/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"45caff300221e7e2d42ef64a8690f82c50ce535a","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-08-15 13:56:19.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"40c3f9d0386c03f09d94488ce4c7cba17bd4b497","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-08-15 14:14:05.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"83bbe8780c919b330061d342263d033c8f9fe1cf","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-08-27 16:14:58.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"6c3446ba5fd038a270f637c6c72f9e42bd365171","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-08-27 16:15:01.000000000","message":"Change has been successfully cherry-picked as 65de7c95f41e78746dc41e6173bbee4106a758f9","accounts_in_message":[],"_revision_number":2}],"current_revision":"65de7c95f41e78746dc41e6173bbee4106a758f9","revisions":{"b65133505f8cf6936deac9cd398027ebbcfa56fc":{"kind":"REWORK","_number":1,"created":"2022-08-02 07:38:05.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/07/7107/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/07/7107/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/07/7107/1 \u0026\u0026 git checkout -b change-7107 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/07/7107/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/07/7107/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/07/7107/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/07/7107/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/07/7107/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"c730e91b1c95661db7d452b84665b68966d1910a","subject":"jtag/drivers/kitprog: use HID read timeout"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2022-08-02 07:16:21.000000000","tz":120},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2022-08-02 07:16:21.000000000","tz":120},"subject":"jtag/drivers/kitprog: workaround serious firmware problem","message":"jtag/drivers/kitprog: workaround serious firmware problem\n\nSince commit 88f429ead019fd6df96ec15f0d897385f3cef0d0\n5321: target/cortex_m: faster reading of all CPU registers\ndebugging with a kitprog adapter freezes at debug entry.\n\nHow to replicate:\n openocd -f interface/kitprog.cfg -f target/psoc4.cfg\n\nConnect to telnet server.\nMake sure the target is running:\n resume\n\nHalt the target:\n halt\n\nWithout this patch OpenOCD freezes in kitprog_hid_command()\nin library call hid_write().\n\nReduce the number of SWD transactions sent in one USB bulk write\nas a workaround, simply use shorter buffer.\nFor details see the comment in src/jtag/drivers/kitprog.c\n\nChange-Id: I0116894d5ebf1655f6011f0d35acdbbc178cd48c\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"65de7c95f41e78746dc41e6173bbee4106a758f9":{"kind":"REWORK","_number":2,"created":"2022-08-27 16:15:01.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/07/7107/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/07/7107/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/07/7107/2 \u0026\u0026 git checkout -b change-7107 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/07/7107/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/07/7107/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/07/7107/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/07/7107/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/07/7107/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"1a9d9916193ee7884d942b6119163557edc8dad2","subject":"jtag/drivers/kitprog: use HID read timeout"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2022-08-02 07:16:21.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-08-27 16:15:01.000000000","tz":0},"subject":"jtag/drivers/kitprog: workaround serious firmware problem","message":"jtag/drivers/kitprog: workaround serious firmware problem\n\nSince commit 88f429ead019fd6df96ec15f0d897385f3cef0d0\n5321: target/cortex_m: faster reading of all CPU registers\ndebugging with a kitprog adapter freezes at debug entry.\n\nHow to replicate:\n openocd -f interface/kitprog.cfg -f target/psoc4.cfg\n\nConnect to telnet server.\nMake sure the target is running:\n resume\n\nHalt the target:\n halt\n\nWithout this patch OpenOCD freezes in kitprog_hid_command()\nin library call hid_write().\n\nReduce the number of SWD transactions sent in one USB bulk write\nas a workaround, simply use shorter buffer.\nFor details see the comment in src/jtag/drivers/kitprog.c\n\nChange-Id: I0116894d5ebf1655f6011f0d35acdbbc178cd48c\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/7107\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}