)]}'
{"id":"openocd~master~I9519f48760c91a48a9e5e8c34634d247098cb14a","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2022-08-02 16:52:20.000000000","reason":"Antonio Borneo replied on the change"},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2022-08-08 20:39:45.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"I9519f48760c91a48a9e5e8c34634d247098cb14a","subject":"target/cortex_m: prevent segmentation fault in cortex_m_poll()","status":"MERGED","created":"2022-08-02 09:59:38.000000000","updated":"2022-08-14 12:11:26.000000000","submitted":"2022-08-14 12:11:26.000000000","submitter":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7108","meta_rev_id":"f9ea922b0ec2d5067197c880f25f175c6cceca0b","_number":7108,"owner":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-08-14 12:11:26.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-08-14 12:11:26.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-08-14 12:11:26.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-08-02 10:26:01.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-08-02 11:50:15.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"5d613cd3c2a1df723cc8a004ec47f6d799fd5400","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-08-02 09:59:38.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"6aa4de7d77e1effeca574fbde6bbf6d9f4c72b2f","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-08-02 10:26:01.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/15691/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/16482/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"9e24cf3438793c628ce1b73d4a5e8a4a68cefe15","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-08-02 11:46:59.000000000","message":"Patch Set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"a5eb2af038c310359c7011d28487dd7bae1e4691","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-08-02 11:50:15.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"a301cf716e9ad82ab960b6454a88dde05f1f0c70","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-08-02 12:15:17.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/15693/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/16484/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"b181ec5e89525a068c4d7c7e061923708edaf6ea","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-08-02 16:52:20.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"9b365395ef858c46a4719343c70ec60b219aaa32","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-08-08 20:39:45.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"f9ea922b0ec2d5067197c880f25f175c6cceca0b","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-08-14 12:11:26.000000000","message":"Change has been successfully cherry-picked as b6dad912b85d6bcd78c12a7a44065fb85dd8485a","accounts_in_message":[],"_revision_number":3}],"current_revision":"b6dad912b85d6bcd78c12a7a44065fb85dd8485a","revisions":{"b6dad912b85d6bcd78c12a7a44065fb85dd8485a":{"kind":"REWORK","_number":3,"created":"2022-08-14 12:11:26.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/08/7108/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/08/7108/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/08/7108/3 \u0026\u0026 git checkout -b change-7108 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/08/7108/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/08/7108/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/08/7108/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/08/7108/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/08/7108/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"cae0c8b32b32202f3552860f12f6579e8ad8ce4a","subject":"target: move parent target structs just after common_magic"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2022-08-02 09:33:07.000000000","tz":120},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2022-08-14 12:11:26.000000000","tz":0},"subject":"target/cortex_m: prevent segmentation fault in cortex_m_poll()","message":"target/cortex_m: prevent segmentation fault in cortex_m_poll()\n\nIf a Cortex-M MCU become unresponsive during a debug session and\nre-examination fails to find MEM-AP, debug_ap pointer is set to NULL.\n\nEventual call of cortex_m_poll() dereferences debug_ap.\n\nCheck debug_ap validity at the begin of cortex_m_poll().\n\nChange-Id: I9519f48760c91a48a9e5e8c34634d247098cb14a\nFixes: 35a503b08d14 (arm_adi_v5: add ap refcount and add get/put around ap use)\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/7108\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"ec03364cde1ac3167df41126845c8b4fddc7c1cf":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2022-08-02 11:46:59.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/08/7108/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/08/7108/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/08/7108/2 \u0026\u0026 git checkout -b change-7108 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/08/7108/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/08/7108/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/08/7108/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/08/7108/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/08/7108/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a895b3b4f830d24d714cb9f11fc8cef92b84df72","subject":"flash/nor/fespi: check target type"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2022-08-02 09:33:07.000000000","tz":120},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2022-08-02 11:46:59.000000000","tz":0},"subject":"target/cortex_m: prevent segmentation fault in cortex_m_poll()","message":"target/cortex_m: prevent segmentation fault in cortex_m_poll()\n\nIf a Cortex-M MCU become unresponsive during a debug session and\nre-examination fails to find MEM-AP, debug_ap pointer is set to NULL.\n\nEventual call of cortex_m_poll() dereferences debug_ap.\n\nCheck debug_ap validity at the begin of cortex_m_poll().\n\nChange-Id: I9519f48760c91a48a9e5e8c34634d247098cb14a\nFixes: 35a503b08d14 (arm_adi_v5: add ap refcount and add get/put around ap use)\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"},"description":"Edit commit message"},"b5de26a996b461e0c619522b2643a136634d2ee0":{"kind":"REWORK","_number":1,"created":"2022-08-02 09:59:38.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/08/7108/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/08/7108/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/08/7108/1 \u0026\u0026 git checkout -b change-7108 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/08/7108/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/08/7108/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/08/7108/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/08/7108/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/08/7108/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a895b3b4f830d24d714cb9f11fc8cef92b84df72","subject":"flash/nor/fespi: check target type"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2022-08-02 09:33:07.000000000","tz":120},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2022-08-02 09:33:07.000000000","tz":120},"subject":"target/cortex_m: prevent segmentation fault in cortex_m_poll()","message":"target/cortex_m: prevent segmentation fault in cortex_m_poll()\n\nIf a Cortex-M MCU become unresponsive during a debug session and\nre-examination fails to find MEM-AP, debug_ap pointer is set to NULL.\n\nEventual call of cortex_m_poll() dereferences debug_ap.\n\nCheck debug_ap validity at the begin of cortex_m_poll().\n\nChange-Id: I9519f48760c91a48a9e5e8c34634d247098cb14a\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}