)]}'
{"id":"openocd~master~Ib5b7774de9694d40c55d2a4109d0d1582fc5008b","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1001242":{"account":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"last_update":"2022-08-19 15:34:31.000000000","reason":"Tim Newsome replied on the change"},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2022-08-27 16:17:53.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ib5b7774de9694d40c55d2a4109d0d1582fc5008b","subject":"server/server: fix target timer timing","status":"MERGED","created":"2022-08-15 17:38:30.000000000","updated":"2022-08-27 16:17:53.000000000","submitted":"2022-08-27 16:17:53.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7118","meta_rev_id":"e25ebc3429c243a1a84f129b014a5e5e1a9728a1","_number":7118,"owner":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-08-27 16:17:53.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-08-27 16:17:53.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-08-27 16:17:53.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-08-15 17:58:48.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-08-15 21:07:30.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"},{"updated":"2022-08-15 21:07:30.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"state":"REVIEWER"}],"messages":[{"id":"20e1c1bb37709411bf55c7f624377a6cb48b7fcc","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-08-15 17:38:30.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b833fa79c5912aee1154e11963cce0e473ac0013","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-08-15 17:58:48.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/15734/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/16525/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"2157b532cc1db30759d9d9704102d1fe68bf67e0","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-08-15 21:07:30.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"808c7566fb48a546207cc2da405997be7b6a26a3","author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"real_author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"date":"2022-08-18 22:45:36.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"f2565521e3cb7185efe56416b17a945fb9fccf57","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-08-19 05:38:54.000000000","message":"Patch Set 2: Published edit on patch set 1.","accounts_in_message":[],"_revision_number":2},{"id":"ee11f7671106e38c2239e7fda6be890e3a2f55a0","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-08-19 05:50:59.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"e69dca22c361878e956334f8100088eca9c4c5ed","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-08-19 06:00:19.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/15774/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/16565/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"1af92f559f5f892c7b4b3682e40e5b9364dbd40a","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-08-19 13:33:40.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"55a892e20e7c02394fcffb5ac43df66afd0df160","author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"real_author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"date":"2022-08-19 15:34:31.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"7bc3893a24b6a1fc34a610ff61d089418ab63408","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-08-27 16:17:50.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"e25ebc3429c243a1a84f129b014a5e5e1a9728a1","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-08-27 16:17:53.000000000","message":"Change has been successfully cherry-picked as 63cc08f6a2a50f78a51075991537fa9fa34f378d","accounts_in_message":[],"_revision_number":3}],"current_revision":"63cc08f6a2a50f78a51075991537fa9fa34f378d","revisions":{"755105bc03249ed9ed27b73ed014363aa7f2c917":{"kind":"REWORK","_number":2,"created":"2022-08-19 05:38:54.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/18/7118/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/18/7118/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/18/7118/2 \u0026\u0026 git checkout -b change-7118 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/18/7118/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/18/7118/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/18/7118/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/18/7118/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/18/7118/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"9cd714cd145a73a4f43bdfc37554f4d5ab05f92b","subject":"target/espressif: remove author lines from esp32xx and xtensa files"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2022-08-15 17:18:18.000000000","tz":120},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2022-08-19 05:38:52.000000000","tz":0},"subject":"server/server: fix target timer timing","message":"server/server: fix target timer timing\n\nThe change 6363: Call poll at a fixed interval\nswitched from target_call_timer_callbacks() to target_call_timer_callbacks_now().\nIt breaks the timing as all timers callbacks are called every time\none timer expires.\n\nRevert this part of change and use target_call_timer_callbacks().\n\nFixes: db16b3dc5b06 (Call poll at a fixed interval.)\nChange-Id: Ib5b7774de9694d40c55d2a4109d0d1582fc5008b\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"63cc08f6a2a50f78a51075991537fa9fa34f378d":{"kind":"REWORK","_number":3,"created":"2022-08-27 16:17:53.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/18/7118/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/18/7118/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/18/7118/3 \u0026\u0026 git checkout -b change-7118 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/18/7118/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/18/7118/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/18/7118/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/18/7118/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/18/7118/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"386155419bfd9a47d896dfe23dbda19f8a4cf2d0","subject":"tcl/target: stm32[fl]4x: document the settings for trace"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2022-08-15 17:18:18.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-08-27 16:17:53.000000000","tz":0},"subject":"server/server: fix target timer timing","message":"server/server: fix target timer timing\n\nThe change 6363: Call poll at a fixed interval\nswitched from target_call_timer_callbacks() to target_call_timer_callbacks_now().\nIt breaks the timing as all timers callbacks are called every time\none timer expires.\n\nRevert this part of change and use target_call_timer_callbacks().\n\nFixes: db16b3dc5b06 (Call poll at a fixed interval.)\nChange-Id: Ib5b7774de9694d40c55d2a4109d0d1582fc5008b\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/7118\nTested-by: jenkins\nReviewed-by: Tim Newsome \u003ctim@sifive.com\u003e\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"593c37117edf59a24099164637f40dfbc6db5dfa":{"kind":"REWORK","_number":1,"created":"2022-08-15 17:38:30.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/18/7118/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/18/7118/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/18/7118/1 \u0026\u0026 git checkout -b change-7118 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/18/7118/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/18/7118/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/18/7118/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/18/7118/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/18/7118/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"9cd714cd145a73a4f43bdfc37554f4d5ab05f92b","subject":"target/espressif: remove author lines from esp32xx and xtensa files"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2022-08-15 17:18:18.000000000","tz":120},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2022-08-15 17:18:18.000000000","tz":120},"subject":"server/server: fix target timer timing","message":"server/server: fix target timer timing\n\nThe change 6363: Call poll at a fixed interval\nswitched from target_call_timer_callbacks() to target_call_timer_callbacks_now().\nIt breaks the timing as all timers callbacks are called every time\none timer expires.\n\nRevert this part of change and use target_call_timer_callbacks().\n\nFixes: db16b3dc5b06 (Call poll at a fixed interval.)\nChange-Id: Ib5b7774de9694d40c55d2a4109d0d1582fc5008b\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}