)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1001975,"name":"Steve Marple","email":"stevemarple@googlemail.com","username":"stevemarple"},"change_message_id":"659cb0ecdc26d06ecfd2402c05032dcf50441579","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6bffd4b8_4723b6dc","updated":"2022-08-18 09:01:40.000000000","message":"Thanks for your review. I\u0027ll submit changes for this and the following patchsets very soon.","commit_id":"c8d75a806a442e87a0687fe2ab945ecb1e096bd5"}],"src/jtag/drivers/bcm2835gpio.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"513b466e49f7324ec7e6e069c5e5ca386805531d","unresolved":true,"context_lines":[{"line_number":541,"context_line":"\tclose(dev_mem_fd);"},{"line_number":542,"context_line":""},{"line_number":543,"context_line":"\t/* set 4mA drive strength, slew rate limited, hysteresis on */"},{"line_number":544,"context_line":"\tpads_base[BCM2835_PADS_GPIO_0_27_OFFSET] \u003d 0x5a000008 + 1;"},{"line_number":545,"context_line":""},{"line_number":546,"context_line":"\t/*"},{"line_number":547,"context_line":"\t * Configure TDO as an input, and TDI, TCK, TMS, TRST, SRST"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"b49c0303_f7cc057c","line":544,"updated":"2022-08-17 10:32:10.000000000","message":"we do not need pads_base after this write.\nDoes it make sense to make move pads_base as global?\nDo you plan to re-use it in some further patch?","commit_id":"c8d75a806a442e87a0687fe2ab945ecb1e096bd5"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"1aa6171f576f48a275c5827028c2894ffc43f26b","unresolved":false,"context_lines":[{"line_number":541,"context_line":"\tclose(dev_mem_fd);"},{"line_number":542,"context_line":""},{"line_number":543,"context_line":"\t/* set 4mA drive strength, slew rate limited, hysteresis on */"},{"line_number":544,"context_line":"\tpads_base[BCM2835_PADS_GPIO_0_27_OFFSET] \u003d 0x5a000008 + 1;"},{"line_number":545,"context_line":""},{"line_number":546,"context_line":"\t/*"},{"line_number":547,"context_line":"\t * Configure TDO as an input, and TDI, TCK, TMS, TRST, SRST"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"9f406e64_46050374","line":544,"in_reply_to":"887e7bd7_6720fccf","updated":"2022-09-09 09:01:10.000000000","message":"Yes, I see it, thanks.","commit_id":"c8d75a806a442e87a0687fe2ab945ecb1e096bd5"},{"author":{"_account_id":1001975,"name":"Steve Marple","email":"stevemarple@googlemail.com","username":"stevemarple"},"change_message_id":"659cb0ecdc26d06ecfd2402c05032dcf50441579","unresolved":false,"context_lines":[{"line_number":541,"context_line":"\tclose(dev_mem_fd);"},{"line_number":542,"context_line":""},{"line_number":543,"context_line":"\t/* set 4mA drive strength, slew rate limited, hysteresis on */"},{"line_number":544,"context_line":"\tpads_base[BCM2835_PADS_GPIO_0_27_OFFSET] \u003d 0x5a000008 + 1;"},{"line_number":545,"context_line":""},{"line_number":546,"context_line":"\t/*"},{"line_number":547,"context_line":"\t * Configure TDO as an input, and TDI, TCK, TMS, TRST, SRST"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"887e7bd7_6720fccf","line":544,"in_reply_to":"b49c0303_f7cc057c","updated":"2022-08-18 09:01:40.000000000","message":"Thanks, pads_base should be used when restoring GPIOs so that drive strength etc is returned to the original value.","commit_id":"c8d75a806a442e87a0687fe2ab945ecb1e096bd5"}]}