)]}'
{"id":"openocd~master~I2b6a8365f554e332520fa77ccf076188083a932f","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1001975":{"account":{"_account_id":1001975,"name":"Steve Marple","email":"stevemarple@googlemail.com","username":"stevemarple"},"last_update":"2022-09-13 22:16:59.000000000","reason":"Change was submitted"},"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2022-09-09 09:01:10.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"I2b6a8365f554e332520fa77ccf076188083a932f","subject":"drivers/bcm2835gpio: Release resources on error and when quitting","status":"MERGED","created":"2022-08-16 14:35:17.000000000","updated":"2022-09-13 22:16:59.000000000","submitted":"2022-09-13 22:16:59.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7122","meta_rev_id":"27dc6898ef6eac87af79a9bc2372bb9223ff70c1","_number":7122,"owner":{"_account_id":1001975,"name":"Steve Marple","email":"stevemarple@googlemail.com","username":"stevemarple"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-09-13 22:16:59.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-09-13 22:16:59.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-08-16 15:28:42.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-08-17 10:32:10.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"CC"},{"updated":"2022-09-09 09:01:10.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"847aba4d340fa17adfe30f368d579f933e50e806","tag":"autogenerated:gerrit:newWipPatchSet","author":{"_account_id":1001975,"name":"Steve Marple","email":"stevemarple@googlemail.com","username":"stevemarple"},"real_author":{"_account_id":1001975,"name":"Steve Marple","email":"stevemarple@googlemail.com","username":"stevemarple"},"date":"2022-08-16 14:35:17.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"824d20a60c36820ee7edbbcd1c18d917758f918c","tag":"autogenerated:gerrit:setReadyForReview","author":{"_account_id":1001975,"name":"Steve Marple","email":"stevemarple@googlemail.com","username":"stevemarple"},"real_author":{"_account_id":1001975,"name":"Steve Marple","email":"stevemarple@googlemail.com","username":"stevemarple"},"date":"2022-08-16 15:27:55.000000000","message":"Set Ready For Review","accounts_in_message":[],"_revision_number":1},{"id":"2afad9818a393c0b9f2f06cebb690d4193188bba","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-08-16 15:28:42.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/15742/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/16533/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"513b466e49f7324ec7e6e069c5e5ca386805531d","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-08-17 10:32:10.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"659cb0ecdc26d06ecfd2402c05032dcf50441579","author":{"_account_id":1001975,"name":"Steve Marple","email":"stevemarple@googlemail.com","username":"stevemarple"},"real_author":{"_account_id":1001975,"name":"Steve Marple","email":"stevemarple@googlemail.com","username":"stevemarple"},"date":"2022-08-18 09:01:40.000000000","message":"Patch Set 1:\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"3b87d350f02cdac5fbcf846525688cd34fffc3c3","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001975,"name":"Steve Marple","email":"stevemarple@googlemail.com","username":"stevemarple"},"real_author":{"_account_id":1001975,"name":"Steve Marple","email":"stevemarple@googlemail.com","username":"stevemarple"},"date":"2022-08-28 13:05:39.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"09f1efd0e7024d639a516cae6a0352ad9a095b0f","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-08-28 13:28:18.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/15804/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/16595/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"3b07b0b9a3468805306983acb42926331825d073","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001975,"name":"Steve Marple","email":"stevemarple@googlemail.com","username":"stevemarple"},"real_author":{"_account_id":1001975,"name":"Steve Marple","email":"stevemarple@googlemail.com","username":"stevemarple"},"date":"2022-09-08 20:37:48.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.","accounts_in_message":[],"_revision_number":3},{"id":"2e7bcc79ba6e9f8d7fa58f27ed34bc1e7a76fde9","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-09-08 21:00:34.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/15884/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/16675/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"1aa6171f576f48a275c5827028c2894ffc43f26b","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-09-09 09:01:10.000000000","message":"Patch Set 3: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"27dc6898ef6eac87af79a9bc2372bb9223ff70c1","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-09-13 22:16:59.000000000","message":"Change has been successfully cherry-picked as e643a494d46c571711ccba361ad20faaf6f6503c","accounts_in_message":[],"_revision_number":4}],"current_revision":"e643a494d46c571711ccba361ad20faaf6f6503c","revisions":{"e643a494d46c571711ccba361ad20faaf6f6503c":{"kind":"REWORK","_number":4,"created":"2022-09-13 22:16:59.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/22/7122/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/22/7122/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/22/7122/4 \u0026\u0026 git checkout -b change-7122 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/22/7122/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/22/7122/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/22/7122/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/22/7122/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/22/7122/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ce217538bc2b9c5ef6dc760b0b03d54602ed3be6","subject":"tcl/interface: replace last deprecated commands"}],"author":{"name":"Steve Marple","email":"stevemarple@googlemail.com","date":"2022-06-25 16:02:14.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-09-13 22:16:59.000000000","tz":0},"subject":"drivers/bcm2835gpio: Release resources on error and when quitting","message":"drivers/bcm2835gpio: Release resources on error and when quitting\n\nThe /dev/mem file descriptor can be closed without invalidating the\nmappings so close as soon as possible.\n\nmunmap() all memory, either on error or from quit.\n\nSigned-off-by: Steve Marple \u003cstevemarple@googlemail.com\u003e\nChange-Id: I2b6a8365f554e332520fa77ccf076188083a932f\nReviewed-on: https://review.openocd.org/c/openocd/+/7122\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"1aa64597f328a8f15f3d7e0be3bbb84b87955d21":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2022-09-08 20:37:48.000000000","uploader":{"_account_id":1001975,"name":"Steve Marple","email":"stevemarple@googlemail.com","username":"stevemarple"},"ref":"refs/changes/22/7122/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/22/7122/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/22/7122/3 \u0026\u0026 git checkout -b change-7122 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/22/7122/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/22/7122/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/22/7122/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/22/7122/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/22/7122/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"de99836cf639b63dc357a34c13825669af841f17","subject":"target/xtensa: virtualize XDM registers"}],"author":{"name":"Steve Marple","email":"stevemarple@googlemail.com","date":"2022-06-25 16:02:14.000000000","tz":60},"committer":{"name":"Steve Marple","email":"stevemarple@googlemail.com","date":"2022-09-08 20:08:55.000000000","tz":60},"subject":"drivers/bcm2835gpio: Release resources on error and when quitting","message":"drivers/bcm2835gpio: Release resources on error and when quitting\n\nThe /dev/mem file descriptor can be closed without invalidating the\nmappings so close as soon as possible.\n\nmunmap() all memory, either on error or from quit.\n\nSigned-off-by: Steve Marple \u003cstevemarple@googlemail.com\u003e\nChange-Id: I2b6a8365f554e332520fa77ccf076188083a932f\n"}},"3e8c988dcf075513d5d16f145ac46d93726b6537":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2022-08-28 13:05:39.000000000","uploader":{"_account_id":1001975,"name":"Steve Marple","email":"stevemarple@googlemail.com","username":"stevemarple"},"ref":"refs/changes/22/7122/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/22/7122/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/22/7122/2 \u0026\u0026 git checkout -b change-7122 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/22/7122/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/22/7122/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/22/7122/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/22/7122/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/22/7122/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a527112dae0e8b3a31589c27d01a97174f24e1df","subject":"target/riscv: Update with latest encoding from riscv-opcodes"}],"author":{"name":"Steve Marple","email":"stevemarple@googlemail.com","date":"2022-06-25 16:02:14.000000000","tz":60},"committer":{"name":"Steve Marple","email":"stevemarple@googlemail.com","date":"2022-08-28 13:03:05.000000000","tz":60},"subject":"drivers/bcm2835gpio: Release resources on error and when quitting","message":"drivers/bcm2835gpio: Release resources on error and when quitting\n\nThe /dev/mem file descriptor can be closed without invalidating the\nmappings so close as soon as possible.\n\nmunmap() all memory, either on error or from quit.\n\nSigned-off-by: Steve Marple \u003cstevemarple@googlemail.com\u003e\nChange-Id: I2b6a8365f554e332520fa77ccf076188083a932f\n"}},"c8d75a806a442e87a0687fe2ab945ecb1e096bd5":{"kind":"REWORK","_number":1,"created":"2022-08-16 14:35:17.000000000","uploader":{"_account_id":1001975,"name":"Steve Marple","email":"stevemarple@googlemail.com","username":"stevemarple"},"ref":"refs/changes/22/7122/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/22/7122/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/22/7122/1 \u0026\u0026 git checkout -b change-7122 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/22/7122/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/22/7122/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/22/7122/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/22/7122/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/22/7122/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"9cd714cd145a73a4f43bdfc37554f4d5ab05f92b","subject":"target/espressif: remove author lines from esp32xx and xtensa files"}],"author":{"name":"Steve Marple","email":"stevemarple@googlemail.com","date":"2022-06-25 16:02:14.000000000","tz":60},"committer":{"name":"Steve Marple","email":"stevemarple@googlemail.com","date":"2022-08-15 14:45:06.000000000","tz":60},"subject":"drivers/bcm2835gpio: Release resources on error and when quitting","message":"drivers/bcm2835gpio: Release resources on error and when quitting\n\nThe /dev/mem file descriptor can be closed without invalidating the\nmappings so close as soon as possible.\n\nmunmap() all memory, either on error or from quit.\n\nSigned-off-by: Steve Marple \u003cstevemarple@googlemail.com\u003e\nChange-Id: I2b6a8365f554e332520fa77ccf076188083a932f\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}