)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"691cda7d2c5f3ee8a93c56dd72b485a8f153fb5a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ac2de191_57d5d265","updated":"2022-08-17 16:17:23.000000000","message":"Looks ok.\nBut I see too much code duplication with amx335gpio.c and partially with linuxgpiod.c\nNot in this patch, but would be good to rationalize the code","commit_id":"23814062fe0e04ae97489b7c25159042bd09c254"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"f004a6e55bcf82c3a68a8319d5f50ff064ea0dc3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e8621492_be6abc48","updated":"2022-09-08 16:40:50.000000000","message":"I would like to merge the first 4 patches of this series, that is bcm2835gpio without power and srst sensing.\nBut I do not see the relevant changes for\ntcl/interface/jtag_hat_rpi2.cfg\ntcl/interface/raspberrypi-native.cfg\ntcl/interface/raspberrypi2-native.cfg\nDo you already have them?","commit_id":"28d190a9cc28103991a06004de274701c35fbc40"},{"author":{"_account_id":1001975,"name":"Steve Marple","email":"stevemarple@googlemail.com","username":"stevemarple"},"change_message_id":"56b49df9325d14bdd3e42a92931563c3c0a8a483","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"be6b3b32_d021f4ab","updated":"2022-09-08 20:37:19.000000000","message":"Thanks for reviewing. Changes as requested.","commit_id":"28d190a9cc28103991a06004de274701c35fbc40"},{"author":{"_account_id":1001975,"name":"Steve Marple","email":"stevemarple@googlemail.com","username":"stevemarple"},"change_message_id":"56b49df9325d14bdd3e42a92931563c3c0a8a483","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"334bfe4b_56c7686b","in_reply_to":"e8621492_be6abc48","updated":"2022-09-08 20:37:19.000000000","message":"Now included.","commit_id":"28d190a9cc28103991a06004de274701c35fbc40"}],"src/jtag/drivers/bcm2835gpio.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"f004a6e55bcf82c3a68a8319d5f50ff064ea0dc3","unresolved":true,"context_lines":[{"line_number":306,"context_line":"\tCOMMAND_REGISTRATION_DONE"},{"line_number":307,"context_line":"};"},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"static const char * const bcm2835_transports[] \u003d { \"jtag\", \"swd\", NULL };"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"static struct jtag_interface bcm2835gpio_interface \u003d {"},{"line_number":312,"context_line":"\t.supported \u003d DEBUG_CAP_TMS_SEQ,"},{"line_number":313,"context_line":"\t.execute_queue \u003d bitbang_execute_queue,"},{"line_number":314,"context_line":"};"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"static bool bcm2835gpio_jtag_mode_possible(void)"},{"line_number":317,"context_line":"{"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"a14afc31_674b319c","line":314,"range":{"start_line":309,"start_character":0,"end_line":314,"end_character":2},"updated":"2022-09-08 16:40:50.000000000","message":"can you please move these two declarations so they stay together with\nstruct adapter_driver bcm2835gpio_adapter_driver \u003d {","commit_id":"28d190a9cc28103991a06004de274701c35fbc40"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b3dd05d8aa15dc8811d4ba7cc2c1acac1b4603f2","unresolved":false,"context_lines":[{"line_number":306,"context_line":"\tCOMMAND_REGISTRATION_DONE"},{"line_number":307,"context_line":"};"},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"static const char * const bcm2835_transports[] \u003d { \"jtag\", \"swd\", NULL };"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"static struct jtag_interface bcm2835gpio_interface \u003d {"},{"line_number":312,"context_line":"\t.supported \u003d DEBUG_CAP_TMS_SEQ,"},{"line_number":313,"context_line":"\t.execute_queue \u003d bitbang_execute_queue,"},{"line_number":314,"context_line":"};"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"static bool bcm2835gpio_jtag_mode_possible(void)"},{"line_number":317,"context_line":"{"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"33661031_2aba8271","line":314,"range":{"start_line":309,"start_character":0,"end_line":314,"end_character":2},"in_reply_to":"9283810f_eb952582","updated":"2022-09-09 09:40:35.000000000","message":"yes, thanks","commit_id":"28d190a9cc28103991a06004de274701c35fbc40"},{"author":{"_account_id":1001975,"name":"Steve Marple","email":"stevemarple@googlemail.com","username":"stevemarple"},"change_message_id":"56b49df9325d14bdd3e42a92931563c3c0a8a483","unresolved":false,"context_lines":[{"line_number":306,"context_line":"\tCOMMAND_REGISTRATION_DONE"},{"line_number":307,"context_line":"};"},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"static const char * const bcm2835_transports[] \u003d { \"jtag\", \"swd\", NULL };"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"static struct jtag_interface bcm2835gpio_interface \u003d {"},{"line_number":312,"context_line":"\t.supported \u003d DEBUG_CAP_TMS_SEQ,"},{"line_number":313,"context_line":"\t.execute_queue \u003d bitbang_execute_queue,"},{"line_number":314,"context_line":"};"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"static bool bcm2835gpio_jtag_mode_possible(void)"},{"line_number":317,"context_line":"{"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"9283810f_eb952582","line":314,"range":{"start_line":309,"start_character":0,"end_line":314,"end_character":2},"in_reply_to":"a14afc31_674b319c","updated":"2022-09-08 20:37:19.000000000","message":"You want them almost at the end of the file? Done.","commit_id":"28d190a9cc28103991a06004de274701c35fbc40"}]}