)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1001975,"name":"Steve Marple","email":"stevemarple@googlemail.com","username":"stevemarple"},"change_message_id":"8b572f15639aadae2c7b09f6ce95d24c8c89c21e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a3f9feb2_1ea6279e","updated":"2022-08-18 09:08:33.000000000","message":"Thanks.","commit_id":"03ccabb987f602a3408592876a9ef7b88d268b4c"}],"src/jtag/drivers/bcm2835gpio.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"47443ae947a18e90c2dc98b79ca026a24a88f49e","unresolved":true,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"static const struct adapter_gpio_config *adapter_gpio_config;"},{"line_number":54,"context_line":"static struct initial_gpio_state {"},{"line_number":55,"context_line":"\tint mode;"},{"line_number":56,"context_line":"\tint output_level;"},{"line_number":57,"context_line":"} initial_gpio_state[ADAPTER_GPIO_IDX_NUM];"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"static bool is_gpio_config_valid(enum adapter_gpio_config_index idx)"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"5dc2d3d6_3eec9b68","line":56,"range":{"start_line":55,"start_character":1,"end_line":56,"end_character":18},"updated":"2022-08-17 16:29:31.000000000","message":"These values are the result of reading from a \u0027volatile uint32_t *\u0027 then shift and mask.\nShould them be \u0027unsigned int\u0027?\n\nActually we keep only one bit for level and three for mode, so we \u0027could\u0027 use two unsigned char. But this is an array of struct and each struct would be aligned to 8 bytes, so no memory gain using unsigned char vs unsigned int.","commit_id":"03ccabb987f602a3408592876a9ef7b88d268b4c"},{"author":{"_account_id":1001975,"name":"Steve Marple","email":"stevemarple@googlemail.com","username":"stevemarple"},"change_message_id":"8b572f15639aadae2c7b09f6ce95d24c8c89c21e","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"static const struct adapter_gpio_config *adapter_gpio_config;"},{"line_number":54,"context_line":"static struct initial_gpio_state {"},{"line_number":55,"context_line":"\tint mode;"},{"line_number":56,"context_line":"\tint output_level;"},{"line_number":57,"context_line":"} initial_gpio_state[ADAPTER_GPIO_IDX_NUM];"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"static bool is_gpio_config_valid(enum adapter_gpio_config_index idx)"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"8493250b_0db5ccaa","line":56,"range":{"start_line":55,"start_character":1,"end_line":56,"end_character":18},"in_reply_to":"5dc2d3d6_3eec9b68","updated":"2022-08-18 09:08:33.000000000","message":"They should to be unsigned int.","commit_id":"03ccabb987f602a3408592876a9ef7b88d268b4c"}]}