)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"dd351a15560b97dad20d1b1ebbff5f90525b1211","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"45b85fa7_484e592c","updated":"2022-08-20 16:54:40.000000000","message":"Thanks for the patch.\nIn your board, can you use the flash with quad-spi interface?","commit_id":"21508457e03054ca34eaa2a79e7823d9f7f5e225"},{"author":{"_account_id":1002024,"name":"Fawaz","display_name":"fawaz","email":"fawaz@tirmizi.dev","username":"fawaz"},"change_message_id":"7c29b3b4fc0e439350065dee155daf696baf4bec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ce6b2965_26928bc5","updated":"2022-08-30 20:54:24.000000000","message":"Fixed mistake pointed out in initial review","commit_id":"546dd35d789cd9034539fb2cbb742052d92bc76e"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"91b9419c599780789235ee53187e95c6b914ccdb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3159bc5e_c6d8e1aa","updated":"2022-09-01 20:10:29.000000000","message":"Thanks, looks ok to me.","commit_id":"b7125884b830ededc60598790394f0fc0b6633bf"},{"author":{"_account_id":1001036,"name":"Andreas Bolsch","email":"hyphen0break@gmail.com","username":"abmero"},"change_message_id":"ef36be4b8146bcebdf4247d55382b23f410aee40","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"50b79fb5_9cd5577d","updated":"2022-09-02 08:23:29.000000000","message":"The command 0xeb does exist, however, it is almost unusable as the command itself is transmitted in 1-line mode, only address and data in 4-line mode. These \"mixed\" mode commands are AFAIK not supported in any flash driver. So, to prevent confusion I\u0027d prefer to set qread to 0x00 (i.e. invalid).\n\nFurthermore I\u0027d suggest to add LQ020, LQ010, LQ512, LQ025 as well. They\u0027re quite similar (except for the QL025 due to non-existent chip erase command).","commit_id":"b7125884b830ededc60598790394f0fc0b6633bf"},{"author":{"_account_id":1001036,"name":"Andreas Bolsch","email":"hyphen0break@gmail.com","username":"abmero"},"change_message_id":"1b82936b6b19f323780920d038637389691ae2b1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"835acabf_2f54469e","in_reply_to":"0840be31_5588df31","updated":"2023-01-15 15:49:38.000000000","message":"LQ020 etc. are certainly not urgent, but I\u0027d prefer to handle almost identical devices in one swoop rather to have one patch after another. But I don\u0027t mind not to include the other devices here if this seems appropriate.\n\nWell, as DPI or QPI modes must always be selected explicitly retaining 0xeb is not strictly a problem. But the unaware user might think: hey, there is this command, so I might use it and then ... boom. That\u0027s why I said \"confusing\".","commit_id":"b7125884b830ededc60598790394f0fc0b6633bf"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"11bb45ec03b42fe5911a9a8d02a85acca924026f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7eec3ea6_c0019527","in_reply_to":"50b79fb5_9cd5577d","updated":"2022-09-02 12:58:34.000000000","message":"Thanks, Andreas.\nI think that fixing LQ020, LQ010, LQ512, LQ025 is out of the scope of this patch.\nWould it be ok to fix all, including this LQ040 in a separate patch?\nFawaz, would you be available to send such separate patch on top of this one?","commit_id":"b7125884b830ededc60598790394f0fc0b6633bf"},{"author":{"_account_id":1002024,"name":"Fawaz","display_name":"fawaz","email":"fawaz@tirmizi.dev","username":"fawaz"},"change_message_id":"dd9aa7ccf3bdc24d39c5ed26e070521f4fcd0408","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0840be31_5588df31","in_reply_to":"7eec3ea6_c0019527","updated":"2022-09-02 15:45:24.000000000","message":"Yeah, that\u0027s not a problem. But, could there be any issues if the command was not invalidated? I haven\u0027t run into anything so far, but if something could go wrong I think it\u0027s best to fix LQ040 in this patch.","commit_id":"b7125884b830ededc60598790394f0fc0b6633bf"},{"author":{"_account_id":1002024,"name":"Fawaz","display_name":"fawaz","email":"fawaz@tirmizi.dev","username":"fawaz"},"change_message_id":"a07a7969afab0ec59121484c7bbea9dd33f023e1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"d3ef1003_12686e40","updated":"2022-09-14 00:02:09.000000000","message":"Changed sectorsize to 4KiB","commit_id":"c321b5090967e8ddd9ac37c46ff49809fe83c31d"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"fc749a391616445dd536c4845e2f34e373422f16","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"c279a5d5_31fed71e","updated":"2022-09-14 08:16:49.000000000","message":"Just aligned the last column","commit_id":"0d6bebbd98a7c9cfdc3ff3b05a3027793bf224c8"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"ca2e6075f8fb26cfb99c9a6157ca0a2cc03c3899","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"102aa105_0e294da9","updated":"2022-09-14 19:51:42.000000000","message":"thanks","commit_id":"0d6bebbd98a7c9cfdc3ff3b05a3027793bf224c8"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"ff33146f47fa3f21fc350c6075afc352ae666a38","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"747ab2b5_44221ad9","updated":"2022-09-17 20:54:05.000000000","message":"I personally prefer version 6, with the fields vertically aligned","commit_id":"9d0bdd00217420a1dbf8805cbeff81766e8a6941"},{"author":{"_account_id":1002024,"name":"Fawaz","display_name":"fawaz","email":"fawaz@tirmizi.dev","username":"fawaz"},"change_message_id":"57bb378a77047ae756d4fb1ba0e7d761b19b54e7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"ca6a22eb_3f4283bd","in_reply_to":"747ab2b5_44221ad9","updated":"2022-10-04 21:51:32.000000000","message":"Should be reverted now.","commit_id":"9d0bdd00217420a1dbf8805cbeff81766e8a6941"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"fdd4c6e57ec560caca01a8ab78f5b6fb7f3d1602","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"1a03d166_7e68fbb9","updated":"2023-01-15 14:50:41.000000000","message":"Andreas,\nI\u0027m merging this but there is a pending question from Fawaz\n\"could there be any issues if the command was not invalidated?\"\nAny reply?","commit_id":"5c9e2c0101592ae1622bdec82bd9dc254c87ccd7"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"a848dc54ec0964879c5691afcdaae1abb043f130","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"30d654c7_17a89c09","updated":"2022-10-08 15:29:26.000000000","message":"thanks!","commit_id":"5c9e2c0101592ae1622bdec82bd9dc254c87ccd7"},{"author":{"_account_id":1001036,"name":"Andreas Bolsch","email":"hyphen0break@gmail.com","username":"abmero"},"change_message_id":"1b82936b6b19f323780920d038637389691ae2b1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"34b74519_6f78d181","in_reply_to":"1a03d166_7e68fbb9","updated":"2023-01-15 15:49:38.000000000","message":"Well, depends on the driver used: If a flash driver allows switch to QPI mode depending on the presence of the qread command ... The qread field was added for the stmqspi driver which does only support SPI, DPI and QPI modes (no mixed modes), but I don\u0027t think any other flash drivers except cmspi makes use of this field currently. The only problem is that somebody might complain that \"advertized\" functionality does not work.","commit_id":"5c9e2c0101592ae1622bdec82bd9dc254c87ccd7"}],"src/flash/nor/spi.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"dd351a15560b97dad20d1b1ebbff5f90525b1211","unresolved":true,"context_lines":[{"line_number":120,"context_line":"\tFLASH_ID(\"issi is25wp256d\",     0x13, 0xec, 0x12, 0xdc, 0xc7, 0x0019709d, 0x100, 0x10000, 0x2000000),"},{"line_number":121,"context_line":"\tFLASH_ID(\"issi is25lp512m\",     0x13, 0xec, 0x12, 0xdc, 0xc7, 0x001a609d, 0x100, 0x10000, 0x4000000),"},{"line_number":122,"context_line":"\tFLASH_ID(\"issi is25wp512m\",     0x13, 0xec, 0x12, 0xdc, 0xc7, 0x001a709d, 0x100, 0x10000, 0x4000000),"},{"line_number":123,"context_line":"\tFLASH_ID(\"issi is25lq040b\",     0x03, 0x2b, 0x02, 0xd8, 0xc7, 0x0013409d, 0x100, 0x10000, 0x400000),"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"\t/* FRAM, no erase commands, no write page or sectors */"},{"line_number":126,"context_line":"\tFRAM_ID(\"fu mb85rs16n\",         0x03, 0,    0x02, 0x00010104, 0x800),"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"f3969e3f_69c05cbd","line":123,"updated":"2022-08-20 16:54:40.000000000","message":"Looks like the flashes in this list are (almost) sorted by: manufacturer, then size. In this case this flash should _probably_ go after \"issi is25lp032\".\n\nThen, where did you got the command 0x2b? I cannot find it in the datasheet.\nComparing with is25wp128d in this list, the command 0xeb in the list is in the datasheet and is named FRQIO (FAST READ QUAD I/O OPERATION).\nThe datasheet of is25lq040b reports the same command with same name. Should we have 0xeb here too?","commit_id":"21508457e03054ca34eaa2a79e7823d9f7f5e225"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"ad7a61c7dc1b476008f8280c2c7ff8cfc8c4c793","unresolved":true,"context_lines":[{"line_number":120,"context_line":"\tFLASH_ID(\"issi is25wp256d\",     0x13, 0xec, 0x12, 0xdc, 0xc7, 0x0019709d, 0x100, 0x10000, 0x2000000),"},{"line_number":121,"context_line":"\tFLASH_ID(\"issi is25lp512m\",     0x13, 0xec, 0x12, 0xdc, 0xc7, 0x001a609d, 0x100, 0x10000, 0x4000000),"},{"line_number":122,"context_line":"\tFLASH_ID(\"issi is25wp512m\",     0x13, 0xec, 0x12, 0xdc, 0xc7, 0x001a709d, 0x100, 0x10000, 0x4000000),"},{"line_number":123,"context_line":"\tFLASH_ID(\"issi is25lq040b\",     0x03, 0x2b, 0x02, 0xd8, 0xc7, 0x0013409d, 0x100, 0x10000, 0x400000),"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"\t/* FRAM, no erase commands, no write page or sectors */"},{"line_number":126,"context_line":"\tFRAM_ID(\"fu mb85rs16n\",         0x03, 0,    0x02, 0x00010104, 0x800),"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"ab3bda0e_32cf0880","line":123,"in_reply_to":"5c3d0f87_da0d6076","updated":"2022-08-31 08:35:30.000000000","message":"Thanks for the fix.\nI still prefer having this line added after \"issi is25lp032\".\nWhile waiting for some other maintainer to check this patch, would you mind changing it?","commit_id":"21508457e03054ca34eaa2a79e7823d9f7f5e225"},{"author":{"_account_id":1002024,"name":"Fawaz","display_name":"fawaz","email":"fawaz@tirmizi.dev","username":"fawaz"},"change_message_id":"326b8b17359a92415066c353ef0ce639583b678c","unresolved":false,"context_lines":[{"line_number":120,"context_line":"\tFLASH_ID(\"issi is25wp256d\",     0x13, 0xec, 0x12, 0xdc, 0xc7, 0x0019709d, 0x100, 0x10000, 0x2000000),"},{"line_number":121,"context_line":"\tFLASH_ID(\"issi is25lp512m\",     0x13, 0xec, 0x12, 0xdc, 0xc7, 0x001a609d, 0x100, 0x10000, 0x4000000),"},{"line_number":122,"context_line":"\tFLASH_ID(\"issi is25wp512m\",     0x13, 0xec, 0x12, 0xdc, 0xc7, 0x001a709d, 0x100, 0x10000, 0x4000000),"},{"line_number":123,"context_line":"\tFLASH_ID(\"issi is25lq040b\",     0x03, 0x2b, 0x02, 0xd8, 0xc7, 0x0013409d, 0x100, 0x10000, 0x400000),"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"\t/* FRAM, no erase commands, no write page or sectors */"},{"line_number":126,"context_line":"\tFRAM_ID(\"fu mb85rs16n\",         0x03, 0,    0x02, 0x00010104, 0x800),"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"99de33f1_65d74eb2","line":123,"in_reply_to":"ab3bda0e_32cf0880","updated":"2022-09-01 17:49:09.000000000","message":"Fixed, forgot to take care of that.","commit_id":"21508457e03054ca34eaa2a79e7823d9f7f5e225"},{"author":{"_account_id":1002024,"name":"Fawaz","display_name":"fawaz","email":"fawaz@tirmizi.dev","username":"fawaz"},"change_message_id":"7c29b3b4fc0e439350065dee155daf696baf4bec","unresolved":false,"context_lines":[{"line_number":120,"context_line":"\tFLASH_ID(\"issi is25wp256d\",     0x13, 0xec, 0x12, 0xdc, 0xc7, 0x0019709d, 0x100, 0x10000, 0x2000000),"},{"line_number":121,"context_line":"\tFLASH_ID(\"issi is25lp512m\",     0x13, 0xec, 0x12, 0xdc, 0xc7, 0x001a609d, 0x100, 0x10000, 0x4000000),"},{"line_number":122,"context_line":"\tFLASH_ID(\"issi is25wp512m\",     0x13, 0xec, 0x12, 0xdc, 0xc7, 0x001a709d, 0x100, 0x10000, 0x4000000),"},{"line_number":123,"context_line":"\tFLASH_ID(\"issi is25lq040b\",     0x03, 0x2b, 0x02, 0xd8, 0xc7, 0x0013409d, 0x100, 0x10000, 0x400000),"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"\t/* FRAM, no erase commands, no write page or sectors */"},{"line_number":126,"context_line":"\tFRAM_ID(\"fu mb85rs16n\",         0x03, 0,    0x02, 0x00010104, 0x800),"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"5c3d0f87_da0d6076","line":123,"in_reply_to":"f3969e3f_69c05cbd","updated":"2022-08-30 20:54:24.000000000","message":"You\u0027re right, I don\u0027t know where that came from; I fixed and tested it and everything still seems to work.","commit_id":"21508457e03054ca34eaa2a79e7823d9f7f5e225"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"40d5d544d64eeb7296a7abb5f26ac82f4de45aed","unresolved":true,"context_lines":[{"line_number":113,"context_line":"\tFLASH_ID(\"gd gd25q256c\",        0x13, 0x00, 0x12, 0xdc, 0xc7, 0x001940c8, 0x100, 0x10000, 0x2000000),"},{"line_number":114,"context_line":"\tFLASH_ID(\"gd gd25q512mc\",       0x13, 0x00, 0x12, 0xdc, 0xc7, 0x002040c8, 0x100, 0x10000, 0x4000000),"},{"line_number":115,"context_line":"\tFLASH_ID(\"issi is25lp032\",      0x03, 0x00, 0x02, 0xd8, 0xc7, 0x0016609d, 0x100, 0x10000, 0x400000),"},{"line_number":116,"context_line":"\tFLASH_ID(\"issi is25lq040b\",     0x03, 0xeb, 0x02, 0xd8, 0xc7, 0x0013409d, 0x100, 0x10000, 0x400000),"},{"line_number":117,"context_line":"\tFLASH_ID(\"issi is25lp064\",      0x03, 0x00, 0x02, 0xd8, 0xc7, 0x0017609d, 0x100, 0x10000, 0x800000),"},{"line_number":118,"context_line":"\tFLASH_ID(\"issi is25lp128d\",     0x03, 0xeb, 0x02, 0xd8, 0xc7, 0x0018609d, 0x100, 0x10000, 0x1000000),"},{"line_number":119,"context_line":"\tFLASH_ID(\"issi is25wp128d\",     0x03, 0xeb, 0x02, 0xd8, 0xc7, 0x0018709d, 0x100, 0x10000, 0x1000000),"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"d09b0c48_ba7271ba","line":116,"range":{"start_line":116,"start_character":91,"end_line":116,"end_character":99},"updated":"2022-09-02 16:36:45.000000000","message":"The size should be in bytes (0x80000 \u003d 512kBytes), not bits!\nTherefore the line should go before is25lp032 (4MByte)\n\nAs the flash is rather small, sector erase might be better than 64k-block erase\n(see e.g. gd25q40). I see similarly suboptimal configuration of other small devices too (e.g. st m25p05 has only two erase blocks), so there is no strict rules.","commit_id":"b7125884b830ededc60598790394f0fc0b6633bf"},{"author":{"_account_id":1002024,"name":"Fawaz","display_name":"fawaz","email":"fawaz@tirmizi.dev","username":"fawaz"},"change_message_id":"1f69d3a1607a4f6c2ccaeeb13c4c90181f23ff5e","unresolved":false,"context_lines":[{"line_number":113,"context_line":"\tFLASH_ID(\"gd gd25q256c\",        0x13, 0x00, 0x12, 0xdc, 0xc7, 0x001940c8, 0x100, 0x10000, 0x2000000),"},{"line_number":114,"context_line":"\tFLASH_ID(\"gd gd25q512mc\",       0x13, 0x00, 0x12, 0xdc, 0xc7, 0x002040c8, 0x100, 0x10000, 0x4000000),"},{"line_number":115,"context_line":"\tFLASH_ID(\"issi is25lp032\",      0x03, 0x00, 0x02, 0xd8, 0xc7, 0x0016609d, 0x100, 0x10000, 0x400000),"},{"line_number":116,"context_line":"\tFLASH_ID(\"issi is25lq040b\",     0x03, 0xeb, 0x02, 0xd8, 0xc7, 0x0013409d, 0x100, 0x10000, 0x400000),"},{"line_number":117,"context_line":"\tFLASH_ID(\"issi is25lp064\",      0x03, 0x00, 0x02, 0xd8, 0xc7, 0x0017609d, 0x100, 0x10000, 0x800000),"},{"line_number":118,"context_line":"\tFLASH_ID(\"issi is25lp128d\",     0x03, 0xeb, 0x02, 0xd8, 0xc7, 0x0018609d, 0x100, 0x10000, 0x1000000),"},{"line_number":119,"context_line":"\tFLASH_ID(\"issi is25wp128d\",     0x03, 0xeb, 0x02, 0xd8, 0xc7, 0x0018709d, 0x100, 0x10000, 0x1000000),"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"b24b3a8a_24d341d0","line":116,"range":{"start_line":116,"start_character":91,"end_line":116,"end_character":99},"in_reply_to":"9af16111_5d649931","updated":"2022-09-14 18:09:56.000000000","message":"Done","commit_id":"b7125884b830ededc60598790394f0fc0b6633bf"},{"author":{"_account_id":1002024,"name":"Fawaz","display_name":"fawaz","email":"fawaz@tirmizi.dev","username":"fawaz"},"change_message_id":"209ba2c454c13baec0d089952fc3ca558ace4ddd","unresolved":true,"context_lines":[{"line_number":113,"context_line":"\tFLASH_ID(\"gd gd25q256c\",        0x13, 0x00, 0x12, 0xdc, 0xc7, 0x001940c8, 0x100, 0x10000, 0x2000000),"},{"line_number":114,"context_line":"\tFLASH_ID(\"gd gd25q512mc\",       0x13, 0x00, 0x12, 0xdc, 0xc7, 0x002040c8, 0x100, 0x10000, 0x4000000),"},{"line_number":115,"context_line":"\tFLASH_ID(\"issi is25lp032\",      0x03, 0x00, 0x02, 0xd8, 0xc7, 0x0016609d, 0x100, 0x10000, 0x400000),"},{"line_number":116,"context_line":"\tFLASH_ID(\"issi is25lq040b\",     0x03, 0xeb, 0x02, 0xd8, 0xc7, 0x0013409d, 0x100, 0x10000, 0x400000),"},{"line_number":117,"context_line":"\tFLASH_ID(\"issi is25lp064\",      0x03, 0x00, 0x02, 0xd8, 0xc7, 0x0017609d, 0x100, 0x10000, 0x800000),"},{"line_number":118,"context_line":"\tFLASH_ID(\"issi is25lp128d\",     0x03, 0xeb, 0x02, 0xd8, 0xc7, 0x0018609d, 0x100, 0x10000, 0x1000000),"},{"line_number":119,"context_line":"\tFLASH_ID(\"issi is25wp128d\",     0x03, 0xeb, 0x02, 0xd8, 0xc7, 0x0018709d, 0x100, 0x10000, 0x1000000),"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"9af16111_5d649931","line":116,"range":{"start_line":116,"start_character":91,"end_line":116,"end_character":99},"in_reply_to":"d09b0c48_ba7271ba","updated":"2022-09-07 18:37:53.000000000","message":"My bad on the flash size, I\u0027ll fix it. And as for the erase command, I\u0027ll defer to your judgement and switch to sector erase.","commit_id":"b7125884b830ededc60598790394f0fc0b6633bf"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"cbf32e951dae766ccff99db92489a18d1f58445b","unresolved":true,"context_lines":[{"line_number":112,"context_line":"\tFLASH_ID(\"gd gd25q128c\",        0x03, 0xeb, 0x02, 0xd8, 0xc7, 0x001840c8, 0x100, 0x10000, 0x1000000),"},{"line_number":113,"context_line":"\tFLASH_ID(\"gd gd25q256c\",        0x13, 0x00, 0x12, 0xdc, 0xc7, 0x001940c8, 0x100, 0x10000, 0x2000000),"},{"line_number":114,"context_line":"\tFLASH_ID(\"gd gd25q512mc\",       0x13, 0x00, 0x12, 0xdc, 0xc7, 0x002040c8, 0x100, 0x10000, 0x4000000),"},{"line_number":115,"context_line":"\tFLASH_ID(\"issi is25lq040b\",     0x03, 0xeb, 0x02, 0x20, 0xc7, 0x0013409d, 0x100, 0x10000, 0x80000),"},{"line_number":116,"context_line":"\tFLASH_ID(\"issi is25lp032\",      0x03, 0x00, 0x02, 0xd8, 0xc7, 0x0016609d, 0x100, 0x10000, 0x400000),"},{"line_number":117,"context_line":"\tFLASH_ID(\"issi is25lp064\",      0x03, 0x00, 0x02, 0xd8, 0xc7, 0x0017609d, 0x100, 0x10000, 0x800000),"},{"line_number":118,"context_line":"\tFLASH_ID(\"issi is25lp128d\",     0x03, 0xeb, 0x02, 0xd8, 0xc7, 0x0018609d, 0x100, 0x10000, 0x1000000),"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"b9bc6e6f_cdbe1ad6","line":115,"updated":"2022-09-07 21:01:03.000000000","message":"using sector erase command 0x20 requires changing sectorsize to 4k?","commit_id":"c872f21c3f77eb071a128b95bf57cb831ca89f36"},{"author":{"_account_id":1002024,"name":"Fawaz","display_name":"fawaz","email":"fawaz@tirmizi.dev","username":"fawaz"},"change_message_id":"a07a7969afab0ec59121484c7bbea9dd33f023e1","unresolved":false,"context_lines":[{"line_number":112,"context_line":"\tFLASH_ID(\"gd gd25q128c\",        0x03, 0xeb, 0x02, 0xd8, 0xc7, 0x001840c8, 0x100, 0x10000, 0x1000000),"},{"line_number":113,"context_line":"\tFLASH_ID(\"gd gd25q256c\",        0x13, 0x00, 0x12, 0xdc, 0xc7, 0x001940c8, 0x100, 0x10000, 0x2000000),"},{"line_number":114,"context_line":"\tFLASH_ID(\"gd gd25q512mc\",       0x13, 0x00, 0x12, 0xdc, 0xc7, 0x002040c8, 0x100, 0x10000, 0x4000000),"},{"line_number":115,"context_line":"\tFLASH_ID(\"issi is25lq040b\",     0x03, 0xeb, 0x02, 0x20, 0xc7, 0x0013409d, 0x100, 0x10000, 0x80000),"},{"line_number":116,"context_line":"\tFLASH_ID(\"issi is25lp032\",      0x03, 0x00, 0x02, 0xd8, 0xc7, 0x0016609d, 0x100, 0x10000, 0x400000),"},{"line_number":117,"context_line":"\tFLASH_ID(\"issi is25lp064\",      0x03, 0x00, 0x02, 0xd8, 0xc7, 0x0017609d, 0x100, 0x10000, 0x800000),"},{"line_number":118,"context_line":"\tFLASH_ID(\"issi is25lp128d\",     0x03, 0xeb, 0x02, 0xd8, 0xc7, 0x0018609d, 0x100, 0x10000, 0x1000000),"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"2efab517_6eb0820e","line":115,"in_reply_to":"b9bc6e6f_cdbe1ad6","updated":"2022-09-14 00:02:09.000000000","message":"Done","commit_id":"c872f21c3f77eb071a128b95bf57cb831ca89f36"}]}