)]}'
{"id":"openocd~master~I0382a622bc7c4108a335fd741816577e79240397","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2022-08-21 22:03:55.000000000","reason":"Antonio Borneo replied on the change"},"1001982":{"account":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"last_update":"2022-08-21 04:51:49.000000000","reason":"Ian Thompson replied on the change"},"1001964":{"account":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"last_update":"2022-08-21 22:04:07.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I0382a622bc7c4108a335fd741816577e79240397","subject":"target/xtensa: fix clang analyzer warnings and gcc12 build errors","status":"MERGED","created":"2022-08-20 20:33:34.000000000","updated":"2022-08-21 22:04:07.000000000","submitted":"2022-08-21 22:04:07.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7137","meta_rev_id":"12d9dd8719b9a03a26a3070b0cbb4f6cc3ba76d5","_number":7137,"owner":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-08-21 22:04:07.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"value":0,"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-08-21 22:04:07.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-08-21 22:04:07.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-08-20 20:40:58.000000000","updated_by":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"reviewer":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"state":"REVIEWER"},{"updated":"2022-08-20 20:40:58.000000000","updated_by":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"},{"updated":"2022-08-20 20:57:51.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"1550eda36b99cc491233cc548916209cbe228364","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"real_author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"date":"2022-08-20 20:33:34.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c9b3dc0f423b29e49be6639b1b0f4fd95c6cd1ab","author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"real_author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"date":"2022-08-20 20:40:58.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"6f3ec092b1b564fd669f309794152e9b0a516176","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-08-20 20:57:51.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/15778/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/16569/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"1539ccf9c955538fb3d1d6349b6cebdc8041d663","author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"real_author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"date":"2022-08-21 04:51:49.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"9396f7eb22c26f951ad835901f1e284c467fff5d","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-08-21 22:03:55.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"12d9dd8719b9a03a26a3070b0cbb4f6cc3ba76d5","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-08-21 22:04:07.000000000","message":"Change has been successfully cherry-picked as f77c919cf4dd25d3540bdef7d0bf60f5b84d5dd6","accounts_in_message":[],"_revision_number":2}],"current_revision":"f77c919cf4dd25d3540bdef7d0bf60f5b84d5dd6","revisions":{"a02c7d4d1c3717f383a01ad1126511ba45359101":{"kind":"REWORK","_number":1,"created":"2022-08-20 20:33:34.000000000","uploader":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"ref":"refs/changes/37/7137/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/37/7137/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/37/7137/1 \u0026\u0026 git checkout -b change-7137 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/37/7137/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/37/7137/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/37/7137/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/37/7137/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/37/7137/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"44e21b41df593d3349c07c2de5e088ea82a37042","subject":"Generic Xtensa target config files"}],"author":{"name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","date":"2022-08-20 20:22:47.000000000","tz":180},"committer":{"name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","date":"2022-08-20 20:22:47.000000000","tz":180},"subject":"target/xtensa: fix clang analyzer warnings and gcc12 build errors","message":"target/xtensa: fix clang analyzer warnings and gcc12 build errors\n\nFix Unused code\tDead assignment at line 657\nFix Memory error Double free at line 2851\nFix Memory error Memory leak at line 2530\nFix error: \u0027a3\u0027 may be used uninitialized at line 758\nFix error: \u0027%04x\u0027 directive writing between 4 and 8 bytes\ninto a region of size 5 at line 2471\n\nSigned-off-by: Erhan Kurubas \u003cerhan.kurubas@espressif.com\u003e\nChange-Id: I0382a622bc7c4108a335fd741816577e79240397\n"}},"f77c919cf4dd25d3540bdef7d0bf60f5b84d5dd6":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2022-08-21 22:04:07.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/37/7137/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/37/7137/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/37/7137/2 \u0026\u0026 git checkout -b change-7137 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/37/7137/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/37/7137/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/37/7137/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/37/7137/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/37/7137/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"44e21b41df593d3349c07c2de5e088ea82a37042","subject":"Generic Xtensa target config files"}],"author":{"name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","date":"2022-08-20 20:22:47.000000000","tz":180},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-08-21 22:04:07.000000000","tz":0},"subject":"target/xtensa: fix clang analyzer warnings and gcc12 build errors","message":"target/xtensa: fix clang analyzer warnings and gcc12 build errors\n\nFix Unused code\tDead assignment at line 657\nFix Memory error Double free at line 2851\nFix Memory error Memory leak at line 2530\nFix error: \u0027a3\u0027 may be used uninitialized at line 758\nFix error: \u0027%04x\u0027 directive writing between 4 and 8 bytes\ninto a region of size 5 at line 2471\n\nSigned-off-by: Erhan Kurubas \u003cerhan.kurubas@espressif.com\u003e\nChange-Id: I0382a622bc7c4108a335fd741816577e79240397\nReviewed-on: https://review.openocd.org/c/openocd/+/7137\nTested-by: jenkins\nReviewed-by: Ian Thompson \u003cianst@cadence.com\u003e\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}
