)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"3fb11740caab71dd5af70e876402522bc7505760","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"00ebf69a_5a9dc41a","updated":"2022-08-21 19:17:45.000000000","message":"Erhan, thanks for working on this.","commit_id":"417a1b46e5846236fa94d9d75150fb2ce7706bf8"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"6ee761d62b98987bf5a0f839a814609da5305fbf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c15b1235_2eb64eaa","updated":"2022-08-21 21:00:39.000000000","message":"Thanks!","commit_id":"363907d7deb6ced529834f7fd2aa3a6f263d000b"}],"src/flash/nor/kinetis.c":[{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"3fb11740caab71dd5af70e876402522bc7505760","unresolved":true,"context_lines":[{"line_number":948,"context_line":"\tunsigned num_blocks;"},{"line_number":949,"context_line":"\tstruct kinetis_flash_bank *k_bank;"},{"line_number":950,"context_line":"\tstruct flash_bank *bank;"},{"line_number":951,"context_line":"\tchar base_name[69], name[80], num[4];"},{"line_number":952,"context_line":"\tchar *class, *p;"},{"line_number":953,"context_line":""},{"line_number":954,"context_line":"\tnum_blocks \u003d k_chip-\u003enum_pflash_blocks + k_chip-\u003enum_nvm_blocks;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"e4eca4ee_e5ec7693","line":951,"range":{"start_line":951,"start_character":35,"end_line":951,"end_character":36},"updated":"2022-08-21 19:17:45.000000000","message":"I think the easiest fix is to make num long enough (10 or 11?) to satisfy scan-build","commit_id":"417a1b46e5846236fa94d9d75150fb2ce7706bf8"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"571b3a6fd0fd2f2a2b640e7e3ebc9a171e90f3d5","unresolved":false,"context_lines":[{"line_number":948,"context_line":"\tunsigned num_blocks;"},{"line_number":949,"context_line":"\tstruct kinetis_flash_bank *k_bank;"},{"line_number":950,"context_line":"\tstruct flash_bank *bank;"},{"line_number":951,"context_line":"\tchar base_name[69], name[80], num[4];"},{"line_number":952,"context_line":"\tchar *class, *p;"},{"line_number":953,"context_line":""},{"line_number":954,"context_line":"\tnum_blocks \u003d k_chip-\u003enum_pflash_blocks + k_chip-\u003enum_nvm_blocks;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"41b12b97_2151b09e","line":951,"range":{"start_line":951,"start_character":35,"end_line":951,"end_character":36},"in_reply_to":"e4eca4ee_e5ec7693","updated":"2022-08-21 19:39:01.000000000","message":"11 is OK. Then because of line 1010 name needs to be increased by 7, too.","commit_id":"417a1b46e5846236fa94d9d75150fb2ce7706bf8"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"3fb11740caab71dd5af70e876402522bc7505760","unresolved":true,"context_lines":[{"line_number":991,"context_line":"\t\tif (bank_idx \u003c k_chip-\u003enum_pflash_blocks) {"},{"line_number":992,"context_line":"\t\t\tclass \u003d \"pflash\";"},{"line_number":993,"context_line":"\t\t\tif (k_chip-\u003enum_pflash_blocks \u003e 1)"},{"line_number":994,"context_line":"\t\t\t\tsnprintf(num, sizeof(num), \"%u\", bank_idx \u0026 999);"},{"line_number":995,"context_line":"\t\t} else {"},{"line_number":996,"context_line":"\t\t\tclass \u003d \"flexnvm\";"},{"line_number":997,"context_line":"\t\t\tif (k_chip-\u003enum_nvm_blocks \u003e 1)"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"ae30fc48_e01db3b5","line":994,"range":{"start_line":994,"start_character":45,"end_line":994,"end_character":51},"updated":"2022-08-21 19:17:45.000000000","message":"It will not work as Alan explained in mail.\nBTW Bank number goes over 9 only exceptionally, I cannot imagine more than 99 flash banks. The warning is a false alarm in reality.","commit_id":"417a1b46e5846236fa94d9d75150fb2ce7706bf8"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"571b3a6fd0fd2f2a2b640e7e3ebc9a171e90f3d5","unresolved":false,"context_lines":[{"line_number":991,"context_line":"\t\tif (bank_idx \u003c k_chip-\u003enum_pflash_blocks) {"},{"line_number":992,"context_line":"\t\t\tclass \u003d \"pflash\";"},{"line_number":993,"context_line":"\t\t\tif (k_chip-\u003enum_pflash_blocks \u003e 1)"},{"line_number":994,"context_line":"\t\t\t\tsnprintf(num, sizeof(num), \"%u\", bank_idx \u0026 999);"},{"line_number":995,"context_line":"\t\t} else {"},{"line_number":996,"context_line":"\t\t\tclass \u003d \"flexnvm\";"},{"line_number":997,"context_line":"\t\t\tif (k_chip-\u003enum_nvm_blocks \u003e 1)"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"f498d861_52514ec8","line":994,"range":{"start_line":994,"start_character":45,"end_line":994,"end_character":51},"in_reply_to":"ae30fc48_e01db3b5","updated":"2022-08-21 19:39:01.000000000","message":"Yes. My bad. Thanks to Alan and you for the super fast review.","commit_id":"417a1b46e5846236fa94d9d75150fb2ce7706bf8"}]}