)]}'
{"id":"openocd~master~I6da16506baa7af718947562505dd49606d124171","project":"openocd","branch":"master","topic":"checkpatch","hashtags":[],"change_id":"I6da16506baa7af718947562505dd49606d124171","subject":"openocd: fix SPDX tag format for files .c","status":"MERGED","created":"2022-09-01 20:29:45.000000000","updated":"2022-09-18 08:22:01.000000000","submitted":"2022-09-18 08:22:01.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7153-checkpatch","meta_rev_id":"638bbee87df1ecc85ff5972cf96f6df2268f2e94","_number":7153,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-09-18 08:22:01.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-09-18 08:22:01.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-09-02 06:40:15.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"40f0302537221fcfb4233ed35fdc5fcd39ca4eeb","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-09-01 20:29:45.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"4c76fbf749f83e98f328200b5321e99051f11eb5","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-09-01 20:36:25.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"126ea092f277edca9b8a7e037cca1208bbf50ec6","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-09-02 06:40:15.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/15841/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/16632/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"813c4f8077db332cf1cadaaac4636b6ab4756022","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-09-13 23:11:50.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"da01faeb9741101fc62fb7a13fcd903d20da837d","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-09-14 13:26:05.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/15927/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/16717/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"904a6384a513a6ef00e2fcc5e4f8a02024684757","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-09-14 14:54:12.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"638bbee87df1ecc85ff5972cf96f6df2268f2e94","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-09-18 08:22:01.000000000","message":"Change has been successfully cherry-picked as 382148e4dd437978997d668f6ec715ddcec1c46e","accounts_in_message":[],"_revision_number":3}],"current_revision":"382148e4dd437978997d668f6ec715ddcec1c46e","revisions":{"18ad0eb1547266001feef16ce0473e342d90b161":{"kind":"REWORK","_number":1,"created":"2022-09-01 20:29:45.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/53/7153/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/53/7153/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/53/7153/1 \u0026\u0026 git checkout -b change-7153 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/53/7153/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/53/7153/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/53/7153/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/53/7153/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/53/7153/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"c792e3576d18ce4e0bb12225da12470ce73b716c","subject":"HACKING: add chapter on checkpatch"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-08-30 15:01:12.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-09-01 20:23:10.000000000","tz":120},"subject":"openocd: fix SPDX tag format for files .c","message":"openocd: fix SPDX tag format for files .c\n\nWith the old checkpatch we cannot use the correct format for the\nSPDX tags in the file .c, in fact the C99 comments are not allowed\nand we had to use the block comment.\n\nWith the new checkpatch, let\u0027s switch to the correct SPDX format.\n\nChange created automatically through the command:\n\tsed -i \\\n\t\u0027s,^/\\* *\\(SPDX-License-Identifier: .*[^ ]\\) *\\*/$,// \\1,\u0027 \\\n\t$(find src/ contrib/ -name \\*.c)\n\nChange-Id: I6da16506baa7af718947562505dd49606d124171\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"382148e4dd437978997d668f6ec715ddcec1c46e":{"kind":"REWORK","_number":3,"created":"2022-09-18 08:22:01.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/53/7153/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/53/7153/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/53/7153/3 \u0026\u0026 git checkout -b change-7153 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/53/7153/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/53/7153/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/53/7153/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/53/7153/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/53/7153/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"5be78fafa9b7c9354956fa72c69dbb82338f6e4a","subject":"HACKING: add chapter on checkpatch"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-08-30 15:01:12.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-09-18 08:22:01.000000000","tz":0},"subject":"openocd: fix SPDX tag format for files .c","message":"openocd: fix SPDX tag format for files .c\n\nWith the old checkpatch we cannot use the correct format for the\nSPDX tags in the file .c, in fact the C99 comments are not allowed\nand we had to use the block comment.\n\nWith the new checkpatch, let\u0027s switch to the correct SPDX format.\n\nChange created automatically through the command:\n\tsed -i \\\n\t\u0027s,^/\\* *\\(SPDX-License-Identifier: .*[^ ]\\) *\\*/$,// \\1,\u0027 \\\n\t$(find src/ contrib/ -name \\*.c)\n\nChange-Id: I6da16506baa7af718947562505dd49606d124171\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/7153\nTested-by: jenkins\n"}},"76aace529bbc4d724c4124ffb97a6c2df1d6ac96":{"kind":"REWORK","_number":2,"created":"2022-09-13 23:11:50.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/53/7153/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/53/7153/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/53/7153/2 \u0026\u0026 git checkout -b change-7153 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/53/7153/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/53/7153/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/53/7153/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/53/7153/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/53/7153/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"c021f6dbff950dbae279457c3f9a738a00c1c0ca","subject":"HACKING: add chapter on checkpatch"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-08-30 15:01:12.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-09-13 23:06:16.000000000","tz":120},"subject":"openocd: fix SPDX tag format for files .c","message":"openocd: fix SPDX tag format for files .c\n\nWith the old checkpatch we cannot use the correct format for the\nSPDX tags in the file .c, in fact the C99 comments are not allowed\nand we had to use the block comment.\n\nWith the new checkpatch, let\u0027s switch to the correct SPDX format.\n\nChange created automatically through the command:\n\tsed -i \\\n\t\u0027s,^/\\* *\\(SPDX-License-Identifier: .*[^ ]\\) *\\*/$,// \\1,\u0027 \\\n\t$(find src/ contrib/ -name \\*.c)\n\nChange-Id: I6da16506baa7af718947562505dd49606d124171\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}