)]}'
{"id":"openocd~master~I75793fce82a5297d74af72e620c4e63cd5b15f90","project":"openocd","branch":"master","hashtags":[],"change_id":"I75793fce82a5297d74af72e620c4e63cd5b15f90","subject":".gitignore: remove cross-compile *-libtool","status":"MERGED","created":"2022-09-04 09:56:06.000000000","updated":"2022-09-13 22:07:21.000000000","submitted":"2022-09-13 22:07:21.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7161","meta_rev_id":"f472a83f5d594612906fee8fe8dde05d9b145776","_number":7161,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-09-13 22:07:21.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-09-13 22:07:21.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-09-04 10:29:45.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"c9dbbec89e3094850e20fd0e3b0d9c2874b719ed","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-09-04 09:56:06.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"8953f571408a3bde3fc427e6ede65312c7d4cda9","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-09-04 10:29:45.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/15851/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/16642/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"0477c3538aa21171f9e9ba6734c2c6f3aa1a55e3","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-09-04 10:34:43.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"f472a83f5d594612906fee8fe8dde05d9b145776","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-09-13 22:07:21.000000000","message":"Change has been successfully cherry-picked as 7dff68f65d93db45954be08967b54251ac9861f8","accounts_in_message":[],"_revision_number":2}],"current_revision":"7dff68f65d93db45954be08967b54251ac9861f8","revisions":{"7dff68f65d93db45954be08967b54251ac9861f8":{"kind":"REWORK","_number":2,"created":"2022-09-13 22:07:21.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/61/7161/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/61/7161/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/61/7161/2 \u0026\u0026 git checkout -b change-7161 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/61/7161/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/61/7161/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/61/7161/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/61/7161/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/61/7161/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"36597636f2a0e9fbf7b44f2c02fb85632d4dc063","subject":"contrib: add GPL license tag on files that miss it"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-09-04 09:38:07.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-09-13 22:07:21.000000000","tz":0},"subject":".gitignore: remove cross-compile *-libtool","message":".gitignore: remove cross-compile *-libtool\n\nThis reverts commit dac90163a287 (\".gitignore: add cross-compile\n*-libtool\") [1] merged in May 2022.\n\nThe old build system of OpenEmbedded used to rebuild and rename\nplenty of tools to discriminate between host\u0027s and target\u0027s tools.\nThis creates, among others, the odd file \"$CROSS_COMPILE-libtool\"\nthat was addressed by the patch [1].\nOpenEmbedded has dropped this odd behavior with patch [2], present\nin OpenEmbedded 4.0 \"kirkstone\" tagged on April 2022.\n\nIn current situation:\n- old OpenEmbedded use OpenOCD v0.11.0 or older, so will not use\n  the patch [1];\n- new OpenEmbedded has [2] applied, so will never take benefit\n  from the patch [1].\n\nAs consequence, patch [1] is completely useless and keeping it in\nOpenOCD can even be misleading.\n\nRevert patch [1].\n\nChange-Id: I75793fce82a5297d74af72e620c4e63cd5b15f90\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nFixes: https://review.openocd.org/6960 [1]\nFixes: dac90163a287 (\".gitignore: add cross-compile *-libtool\")\nLink: https://git.openembedded.org/openembedded-core/commit/?id\u003d4b308773eca7 [2]\nReviewed-on: https://review.openocd.org/c/openocd/+/7161\nTested-by: jenkins\n"}},"5559bf7c05640e4497439963a72dec38008a4dd5":{"kind":"REWORK","_number":1,"created":"2022-09-04 09:56:06.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/61/7161/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/61/7161/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/61/7161/1 \u0026\u0026 git checkout -b change-7161 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/61/7161/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/61/7161/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/61/7161/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/61/7161/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/61/7161/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"7fcbac1bdf5848fb5f80545126ca61473dc59721","subject":"server: add function to get openocd shutdown status"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-09-04 09:38:07.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-09-04 09:38:07.000000000","tz":120},"subject":".gitignore: remove cross-compile *-libtool","message":".gitignore: remove cross-compile *-libtool\n\nThis reverts commit dac90163a287 (\".gitignore: add cross-compile\n*-libtool\") [1] merged in May 2022.\n\nThe old build system of OpenEmbedded used to rebuild and rename\nplenty of tools to discriminate between host\u0027s and target\u0027s tools.\nThis creates, among others, the odd file \"$CROSS_COMPILE-libtool\"\nthat was addressed by the patch [1].\nOpenEmbedded has dropped this odd behavior with patch [2], present\nin OpenEmbedded 4.0 \"kirkstone\" tagged on April 2022.\n\nIn current situation:\n- old OpenEmbedded use OpenOCD v0.11.0 or older, so will not use\n  the patch [1];\n- new OpenEmbedded has [2] applied, so will never take benefit\n  from the patch [1].\n\nAs consequence, patch [1] is completely useless and keeping it in\nOpenOCD can even be misleading.\n\nRevert patch [1].\n\nChange-Id: I75793fce82a5297d74af72e620c4e63cd5b15f90\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nFixes: https://review.openocd.org/6960 [1]\nFixes: dac90163a287 (\".gitignore: add cross-compile *-libtool\")\nLink: https://git.openembedded.org/openembedded-core/commit/?id\u003d4b308773eca7 [2]\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}