)]}'
{"id":"openocd~master~Idf208e3fda4b3f8df789553cf03ebf5f20d811bb","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1001667":{"account":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"last_update":"2022-09-07 06:18:25.000000000","reason":"Jan Matyas replied on the change"},"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2022-09-13 22:12:29.000000000","reason":"Change was submitted"},"1001242":{"account":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"last_update":"2022-09-07 16:44:26.000000000","reason":"Tim Newsome replied on the change"}},"hashtags":[],"change_id":"Idf208e3fda4b3f8df789553cf03ebf5f20d811bb","subject":"riscv: don\u0027t export local symbols","status":"MERGED","created":"2022-09-06 08:40:38.000000000","updated":"2022-09-13 22:12:29.000000000","submitted":"2022-09-13 22:12:29.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":5,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7170","meta_rev_id":"8c05f636004b8c210f3e338edb29083492ec59d0","_number":7170,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-09-13 22:12:29.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-09-13 22:12:29.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-09-13 22:12:29.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-09-13 22:12:29.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-09-06 08:43:38.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"state":"REVIEWER"},{"updated":"2022-09-06 08:43:38.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"state":"REVIEWER"},{"updated":"2022-09-06 12:34:31.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"879ec7e9b3343f1cf09a0605766d5340e920178b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-09-06 08:40:38.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"96e486ab994b0df5e5e1b992ac13957f2f17f4e3","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-09-06 08:43:38.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"9f60a4848697080b91ba2a251838a33aa84e09d5","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-09-06 12:34:31.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/15863/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/16653/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"4a74bea7b7cd7a3ed959cc9e04b84fc80b6f4520","author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"real_author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"date":"2022-09-06 17:13:02.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"6a0b266ad7762873d11e767a9e232eabb861e798","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2022-09-07 06:18:25.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"868dba1ba107dedef0ec85b228c8a64e2c3599d2","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-09-07 13:44:33.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"b50e0c5f2b86dbb6687443cc1b6d79ee75bf27eb","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-09-07 13:45:24.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"5068ffd8635a6ed990b2ad877dc65dc3ab99e67e","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2022-09-07 13:58:13.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"c4b24d94d0eb1a861a17164df96e856d85ac803a","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-09-07 14:18:24.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/15874/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/16665/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"9a7fa1158dd7906fe73e4d0789085e262d1c4933","author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"real_author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"date":"2022-09-07 16:44:26.000000000","message":"Patch Set 2: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"8c05f636004b8c210f3e338edb29083492ec59d0","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-09-13 22:12:29.000000000","message":"Change has been successfully cherry-picked as 933cbd9156e878ca90d58f0a12e9e14060c11ca7","accounts_in_message":[],"_revision_number":3}],"current_revision":"933cbd9156e878ca90d58f0a12e9e14060c11ca7","revisions":{"933cbd9156e878ca90d58f0a12e9e14060c11ca7":{"kind":"REWORK","_number":3,"created":"2022-09-13 22:12:29.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/70/7170/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/70/7170/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/70/7170/3 \u0026\u0026 git checkout -b change-7170 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/70/7170/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/70/7170/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/70/7170/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/70/7170/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/70/7170/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d112a1282e8a13b0a85d73e127620e651186e663","subject":"flash/nor/npcx: make local symbols static"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-09-05 22:20:41.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-09-13 22:12:29.000000000","tz":0},"subject":"riscv: don\u0027t export local symbols","message":"riscv: don\u0027t export local symbols\n\nSymbols that are not used outside the file should not be exported\nand should be declared as static.\nMove the existing comments to the static declarations.\n\nChange-Id: Idf208e3fda4b3f8df789553cf03ebf5f20d811bb\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/7170\nReviewed-by: Jan Matyas \u003cmatyas@codasip.com\u003e\nReviewed-by: Tim Newsome \u003ctim@sifive.com\u003e\nTested-by: jenkins\n"}},"4a7012e4d5ab5fa3bb85d949ad61a88874e73ab8":{"kind":"REWORK","_number":2,"created":"2022-09-07 13:44:33.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/70/7170/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/70/7170/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/70/7170/2 \u0026\u0026 git checkout -b change-7170 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/70/7170/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/70/7170/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/70/7170/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/70/7170/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/70/7170/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f8664aeab01e943fd0bdd0c5b31526a05d7a03f3","subject":"flash/nor/npcx: make local symbols static"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-09-05 22:20:41.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-09-07 13:42:20.000000000","tz":120},"subject":"riscv: don\u0027t export local symbols","message":"riscv: don\u0027t export local symbols\n\nSymbols that are not used outside the file should not be exported\nand should be declared as static.\nMove the existing comments to the static declarations.\n\nChange-Id: Idf208e3fda4b3f8df789553cf03ebf5f20d811bb\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"e105ba58e10b9768cc759638f51464b72ebbefb3":{"kind":"REWORK","_number":1,"created":"2022-09-06 08:40:38.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/70/7170/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/70/7170/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/70/7170/1 \u0026\u0026 git checkout -b change-7170 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/70/7170/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/70/7170/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/70/7170/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/70/7170/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/70/7170/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f8664aeab01e943fd0bdd0c5b31526a05d7a03f3","subject":"flash/nor/npcx: make local symbols static"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-09-05 22:20:41.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-09-06 08:08:45.000000000","tz":120},"subject":"riscv: don\u0027t export local symbols","message":"riscv: don\u0027t export local symbols\n\nSymbols that are not used outside the file should not be exported\nand should be declared as static.\n\nChange-Id: Idf208e3fda4b3f8df789553cf03ebf5f20d811bb\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}