)]}'
{"id":"openocd~master~I8151aa28694817001046165a15475d64896f985e","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2023-02-01 08:53:53.000000000","reason":"Antonio Borneo replied on the change"},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2022-09-06 14:59:08.000000000","reason":"Tomas Vanek replied on the change"}},"hashtags":[],"change_id":"I8151aa28694817001046165a15475d64896f985e","subject":"openocd: fix for polling during \"expr\" computation","status":"MERGED","created":"2022-09-06 12:58:33.000000000","updated":"2023-02-01 22:36:36.000000000","submitted":"2022-09-13 22:14:28.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":5,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7174","meta_rev_id":"acc7c2fd47ef12edb976442b007a57ce0fd9153c","_number":7174,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-09-13 22:14:28.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-09-13 22:14:28.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":1001992,"name":"Peter Collingbourne","email":"pcc@google.com","username":"pcc"}],"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-09-06 12:58:33.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"},{"updated":"2022-09-06 14:40:08.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-02-01 04:33:45.000000000","updated_by":{"_account_id":1001992,"name":"Peter Collingbourne","email":"pcc@google.com","username":"pcc"},"reviewer":{"_account_id":1001992,"name":"Peter Collingbourne","email":"pcc@google.com","username":"pcc"},"state":"CC"}],"messages":[{"id":"732af646463de0b2c61bd33eae24d3b8359bb642","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-09-06 12:58:33.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"79f57141bd35c64593522647ab222b7d6f90255f","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-09-06 14:40:08.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/15867/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/16658/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"cc138b0110a4835b38c51f28a2ac06d6efb69e80","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-09-06 14:59:08.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"4dc766a6bbd8cdcc3cbee3b288ca47560462c04d","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-09-13 22:14:28.000000000","message":"Change has been successfully cherry-picked as 320043c054dc0c9f274d462014bd7aafff86fe02","accounts_in_message":[],"_revision_number":2},{"id":"edf40a32d1b4a37d0b8cceb7e0fbb39692ae381c","author":{"_account_id":1001992,"name":"Peter Collingbourne","email":"pcc@google.com","username":"pcc"},"real_author":{"_account_id":1001992,"name":"Peter Collingbourne","email":"pcc@google.com","username":"pcc"},"date":"2023-02-01 04:33:45.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"96de49b25294d86aa09ec069469e66e736008dc4","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-02-01 08:53:53.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"670b16883319ca4a3071ad293d99b8d7d2964eed","author":{"_account_id":1001992,"name":"Peter Collingbourne","email":"pcc@google.com","username":"pcc"},"real_author":{"_account_id":1001992,"name":"Peter Collingbourne","email":"pcc@google.com","username":"pcc"},"date":"2023-02-01 19:10:34.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"acc7c2fd47ef12edb976442b007a57ce0fd9153c","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-02-01 22:36:36.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2}],"current_revision":"320043c054dc0c9f274d462014bd7aafff86fe02","revisions":{"c38eb32f44ebcf83bf7cb726a241c148f2fcdf70":{"kind":"REWORK","_number":1,"created":"2022-09-06 12:58:33.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/74/7174/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/74/7174/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/74/7174/1 \u0026\u0026 git checkout -b change-7174 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/74/7174/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/74/7174/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/74/7174/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/74/7174/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/74/7174/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"7fcbac1bdf5848fb5f80545126ca61473dc59721","subject":"server: add function to get openocd shutdown status"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-09-06 12:44:57.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-09-06 12:55:39.000000000","tz":120},"subject":"openocd: fix for polling during \"expr\" computation","message":"openocd: fix for polling during \"expr\" computation\n\nCommit c7eaaf620488 (\"openocd: prepare for jimtcl 0.81 \u0027expr\u0027\nsyntax change\") replaces the jimtcl command \"expr\" with an openocd\nversion that detects the TCL syntax change and prints a warning.\nThe openocd \"expr\" command will be dropped after v0.12.0,\n\nOne side effect is that openocd invokes polling the target after\nevery openocd command, causing scripts that use several \"expr\"\ncommands to run much slower; see [1].\n\nThe proper fix would require openocd to invoke polling only at the\ntime period deadline, instead of at each command. Such fix is too\nrisky to be applied now, due to short time before v0.12.0-rc1.\n\nAs a temporarily workaround, let openocd to detect the \"expr\"\ncommand and skip the polling.\nThis will be dropped together with the openocd \"expr\" command.\n\nChange-Id: I8151aa28694817001046165a15475d64896f985e\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nFixes: https://sourceforge.net/p/openocd/tickets/362/ [1]\nFixes: c7eaaf620488 (\"openocd: prepare for jimtcl 0.81 \u0027expr\u0027 syntax change\")\n"}},"320043c054dc0c9f274d462014bd7aafff86fe02":{"kind":"REWORK","_number":2,"created":"2022-09-13 22:14:28.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/74/7174/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/74/7174/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/74/7174/2 \u0026\u0026 git checkout -b change-7174 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/74/7174/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/74/7174/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/74/7174/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/74/7174/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/74/7174/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"5d6be673c36b00eb962cbb441dd557d3cc8eb03c","subject":"target: don\u0027t export local symbols"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-09-06 12:44:57.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-09-13 22:14:28.000000000","tz":0},"subject":"openocd: fix for polling during \"expr\" computation","message":"openocd: fix for polling during \"expr\" computation\n\nCommit c7eaaf620488 (\"openocd: prepare for jimtcl 0.81 \u0027expr\u0027\nsyntax change\") replaces the jimtcl command \"expr\" with an openocd\nversion that detects the TCL syntax change and prints a warning.\nThe openocd \"expr\" command will be dropped after v0.12.0,\n\nOne side effect is that openocd invokes polling the target after\nevery openocd command, causing scripts that use several \"expr\"\ncommands to run much slower; see [1].\n\nThe proper fix would require openocd to invoke polling only at the\ntime period deadline, instead of at each command. Such fix is too\nrisky to be applied now, due to short time before v0.12.0-rc1.\n\nAs a temporarily workaround, let openocd to detect the \"expr\"\ncommand and skip the polling.\nThis will be dropped together with the openocd \"expr\" command.\n\nChange-Id: I8151aa28694817001046165a15475d64896f985e\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nFixes: https://sourceforge.net/p/openocd/tickets/362/ [1]\nFixes: c7eaaf620488 (\"openocd: prepare for jimtcl 0.81 \u0027expr\u0027 syntax change\")\nReviewed-on: https://review.openocd.org/c/openocd/+/7174\nTested-by: jenkins\nReviewed-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}