)]}'
{"id":"openocd~master~I68c1b1a1be268a830247fc489f210877c32d7d23","project":"openocd","branch":"master","hashtags":[],"change_id":"I68c1b1a1be268a830247fc489f210877c32d7d23","subject":"configure.ac: drop unneeded dependency check","status":"MERGED","created":"2022-09-06 16:06:14.000000000","updated":"2022-09-13 22:15:12.000000000","submitted":"2022-09-13 22:15:12.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7175","meta_rev_id":"2bb66bd7fd1f0b39e6b141da8261ba3eaf7d3e12","_number":7175,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-09-13 22:15:12.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-09-13 22:15:12.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-09-06 16:38:50.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"c8062cb0d6397fcf76402ee9f2503ad896a4fea7","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-09-06 16:06:14.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"76c86cf492b66612f9e1e79aa47fb67fd38c2900","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-09-06 16:14:27.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"2fb8d81fd8df08412d1443ee0fbe1fd8d6a9618f","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-09-06 16:38:50.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/15868/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/16659/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"09d924969a6a39c01c4011078cea809554599788","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-09-13 22:15:06.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"2bb66bd7fd1f0b39e6b141da8261ba3eaf7d3e12","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-09-13 22:15:12.000000000","message":"Change has been successfully cherry-picked as e5c103a8d31bddfbda2fd2583c1fcdcc0c818a94","accounts_in_message":[],"_revision_number":2}],"current_revision":"e5c103a8d31bddfbda2fd2583c1fcdcc0c818a94","revisions":{"e5c103a8d31bddfbda2fd2583c1fcdcc0c818a94":{"kind":"REWORK","_number":2,"created":"2022-09-13 22:15:12.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/75/7175/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/75/7175/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/75/7175/2 \u0026\u0026 git checkout -b change-7175 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/75/7175/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/75/7175/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/75/7175/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/75/7175/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/75/7175/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"320043c054dc0c9f274d462014bd7aafff86fe02","subject":"openocd: fix for polling during \"expr\" computation"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-09-06 15:55:44.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-09-13 22:15:12.000000000","tz":0},"subject":"configure.ac: drop unneeded dependency check","message":"configure.ac: drop unneeded dependency check\n\nThe script configure.ac checks for the presence of system include\nfiles required to build OpenOCD.\n\nIt incorrectly check for:\n\tdirent.h\n\tpthread.h\n\tifaddrs.h\n\tnet/if.h\nthat are never included by OpenOCD source code, plus the generated\nmacros:\n\tHAVE_DIRENT_H\n\tHAVE_PTHREAD_H\n\tHAVE_IFADDRS_H\n\tHAVE_NET_IF_H\nare never used in OpenOCD source code.\n\nIt also checks for the system function:\n\tvasprintf()\nthat is never called by OpenOCD source code, plus the generated\nmacro:\n\tHAVE_VASPRINTF\nis never used in OpenOCD source code.\n\nDrop the checks for the unused system include files and the unused\nsystem function.\n\nChange-Id: I68c1b1a1be268a830247fc489f210877c32d7d23\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/7175\nTested-by: jenkins\n"}},"dad80d7b2eddb0c9e79017bc04bf90b2c07d3868":{"kind":"REWORK","_number":1,"created":"2022-09-06 16:06:14.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/75/7175/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/75/7175/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/75/7175/1 \u0026\u0026 git checkout -b change-7175 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/75/7175/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/75/7175/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/75/7175/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/75/7175/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/75/7175/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"7fcbac1bdf5848fb5f80545126ca61473dc59721","subject":"server: add function to get openocd shutdown status"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-09-06 15:55:44.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-09-06 15:55:44.000000000","tz":120},"subject":"configure.ac: drop unneeded dependency check","message":"configure.ac: drop unneeded dependency check\n\nThe script configure.ac checks for the presence of system include\nfiles required to build OpenOCD.\n\nIt incorrectly check for:\n\tdirent.h\n\tpthread.h\n\tifaddrs.h\n\tnet/if.h\nthat are never included by OpenOCD source code, plus the generated\nmacros:\n\tHAVE_DIRENT_H\n\tHAVE_PTHREAD_H\n\tHAVE_IFADDRS_H\n\tHAVE_NET_IF_H\nare never used in OpenOCD source code.\n\nIt also checks for the system function:\n\tvasprintf()\nthat is never called by OpenOCD source code, plus the generated\nmacro:\n\tHAVE_VASPRINTF\nis never used in OpenOCD source code.\n\nDrop the checks for the unused system include files and the unused\nsystem function.\n\nChange-Id: I68c1b1a1be268a830247fc489f210877c32d7d23\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}