)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1001494,"name":"sborshch","username":"sborshch"},"change_message_id":"faee29e8aa50e85e08503ceefcd5962f010ebf9b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ab3c7d3e_9b442f00","updated":"2022-09-09 10:31:18.000000000","message":"I think syscon should not be pointer to uint8_t because it is not pointing to uint8_t. And as you make explicit type conversion after any expression with syscon envolved it should be of uintptr_t type, because it holds address to make pointer. ","commit_id":"5afe6c5d5f4224b2205087294f46d6716dfa271d"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"aba648063ec3daa6465efaec8333cf7339d7e788","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b2395075_09b90f9c","updated":"2022-09-08 15:12:43.000000000","message":"Only compile-time tested. I don\u0027t have access to such HW setup\nNobody really updated this driver since the very first commit of OpenOCD, but not a big deal to keep it for the time being.\n","commit_id":"5afe6c5d5f4224b2205087294f46d6716dfa271d"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"7bf594617ab08b3b06b8e1370211d1b1d523ccbb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2785c716_899d0873","in_reply_to":"ab3c7d3e_9b442f00","updated":"2022-09-09 13:16:47.000000000","message":"You are right! I\u0027m sending a v2.\nThanks for the review.","commit_id":"5afe6c5d5f4224b2205087294f46d6716dfa271d"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"92df45b973453fceb3f5726163f05a6a77da4a9b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"dc05fb4b_c2f44964","updated":"2022-09-09 14:38:09.000000000","message":"I cannot use\nuintptr_t syscon;\nbecause uintptr_t is an integer type, not a pointer, so I would get errors in:\nsyscon \u003d mmap(...);\nif (syscon \u003d\u003d MAP_FAILED) {\nmunmap(syscon, ...);\n\nI take your suggest of using uintptr_t for pointer arithmetic, but I keep void* for the pointer itself.","commit_id":"dc4bb85de17cba8ecb3945a6b3477406f7810810"}]}