)]}'
{"id":"openocd~master~Idd78a7156bdf99df2624043e924b8e54a0588ace","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1001494":{"account":{"_account_id":1001494,"name":"sborshch","username":"sborshch"},"last_update":"2022-09-13 22:16:07.000000000","reason":"Change was submitted"},"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2022-09-13 22:16:07.000000000","reason":"Change was submitted"},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2022-09-13 10:11:37.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"Idd78a7156bdf99df2624043e924b8e54a0588ace","subject":"src/jtag/drivers/ep93xx: fix GCC 12 warning","status":"MERGED","created":"2022-09-08 14:24:10.000000000","updated":"2022-09-13 22:16:07.000000000","submitted":"2022-09-13 22:16:07.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7180","meta_rev_id":"4cb1c7b0ae843e21a18c69a3d40096ac1597c39a","_number":7180,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1001494,"name":"sborshch","username":"sborshch"},{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-09-13 22:16:07.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"value":0,"_account_id":1001494,"name":"sborshch","username":"sborshch"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-09-13 22:16:07.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-09-13 22:16:07.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"_account_id":1001494,"name":"sborshch","username":"sborshch"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-09-08 14:46:19.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-09-08 15:12:43.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"},{"updated":"2022-09-09 10:31:18.000000000","updated_by":{"_account_id":1001494,"name":"sborshch","username":"sborshch"},"reviewer":{"_account_id":1001494,"name":"sborshch","username":"sborshch"},"state":"REVIEWER"}],"messages":[{"id":"7b7024bb408e550c8b4d29f3b653c9e9e18b6394","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-09-08 14:24:10.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"5644c7d4071b2fb95116a191abec32c68fdc7eb2","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-09-08 14:46:19.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/15882/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/16673/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"aba648063ec3daa6465efaec8333cf7339d7e788","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-09-08 15:12:43.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"faee29e8aa50e85e08503ceefcd5962f010ebf9b","author":{"_account_id":1001494,"name":"sborshch","username":"sborshch"},"real_author":{"_account_id":1001494,"name":"sborshch","username":"sborshch"},"date":"2022-09-09 10:31:18.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"7bf594617ab08b3b06b8e1370211d1b1d523ccbb","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-09-09 13:16:47.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"bdbf494c249c175d7c15193c3f709b039ca86575","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-09-09 13:56:32.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"19630b41594257388d925a86acde3ecfbe8d9ba1","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-09-09 14:24:18.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/15895/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/16686/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"92df45b973453fceb3f5726163f05a6a77da4a9b","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-09-09 14:38:09.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"7daa02216357fd133dbcf9eb0677fe2f09e6b46b","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-09-13 10:11:37.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"4cb1c7b0ae843e21a18c69a3d40096ac1597c39a","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-09-13 22:16:07.000000000","message":"Change has been successfully cherry-picked as b8594026e4bf1aa910944c0b72dd5f1def181f13","accounts_in_message":[],"_revision_number":3}],"current_revision":"b8594026e4bf1aa910944c0b72dd5f1def181f13","revisions":{"dc4bb85de17cba8ecb3945a6b3477406f7810810":{"kind":"REWORK","_number":2,"created":"2022-09-09 13:56:32.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/80/7180/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/80/7180/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/80/7180/2 \u0026\u0026 git checkout -b change-7180 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/80/7180/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/80/7180/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/80/7180/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/80/7180/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/80/7180/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"de99836cf639b63dc357a34c13825669af841f17","subject":"target/xtensa: virtualize XDM registers"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-09-08 12:37:55.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-09-09 13:55:00.000000000","tz":120},"subject":"src/jtag/drivers/ep93xx: fix GCC 12 warning","message":"src/jtag/drivers/ep93xx: fix GCC 12 warning\n\nNew GCC reports 5 warning:\n\nsrc/jtag/drivers/ep93xx.c: In function \u0027set_gonk_mode\u0027:\nsrc/jtag/drivers/ep93xx.c:123:47: warning: pointer of type \u0027void *\u0027 used in arithmetic [-Wpointer-arith]\n  123 |         devicecfg \u003d *((volatile int *)(syscon + 0x80));\n      |                                               ^\nsrc/jtag/drivers/ep93xx.c:124:35: warning: pointer of type \u0027void *\u0027 used in arithmetic [-Wpointer-arith]\n  124 |         *((volatile int *)(syscon + 0xc0)) \u003d 0xaa;\n      |                                   ^\nsrc/jtag/drivers/ep93xx.c:125:35: warning: pointer of type \u0027void *\u0027 used in arithmetic [-Wpointer-arith]\n  125 |         *((volatile int *)(syscon + 0x80)) \u003d devicecfg | 0x08000000;\n      |                                   ^\nsrc/jtag/drivers/ep93xx.c: In function \u0027ep93xx_init\u0027:\nsrc/jtag/drivers/ep93xx.c:182:46: warning: pointer of type \u0027void *\u0027 used in arithmetic [-Wpointer-arith]\n  182 |         gpio_data_register \u003d gpio_controller + 0x08;\n      |                                              ^\nsrc/jtag/drivers/ep93xx.c:183:56: warning: pointer of type \u0027void *\u0027 used in arithmetic [-Wpointer-arith]\n  183 |         gpio_data_direction_register \u003d gpio_controller + 0x18;\n      |                                                        ^\n\nChange pointer type to allow pointer arithmetic.\n\nChange-Id: Idd78a7156bdf99df2624043e924b8e54a0588ace\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"b8594026e4bf1aa910944c0b72dd5f1def181f13":{"kind":"REWORK","_number":3,"created":"2022-09-13 22:16:07.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/80/7180/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/80/7180/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/80/7180/3 \u0026\u0026 git checkout -b change-7180 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/80/7180/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/80/7180/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/80/7180/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/80/7180/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/80/7180/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"e5c103a8d31bddfbda2fd2583c1fcdcc0c818a94","subject":"configure.ac: drop unneeded dependency check"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-09-08 12:37:55.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-09-13 22:16:07.000000000","tz":0},"subject":"src/jtag/drivers/ep93xx: fix GCC 12 warning","message":"src/jtag/drivers/ep93xx: fix GCC 12 warning\n\nNew GCC reports 5 warning:\n\nsrc/jtag/drivers/ep93xx.c: In function \u0027set_gonk_mode\u0027:\nsrc/jtag/drivers/ep93xx.c:123:47: warning: pointer of type \u0027void *\u0027 used in arithmetic [-Wpointer-arith]\n  123 |         devicecfg \u003d *((volatile int *)(syscon + 0x80));\n      |                                               ^\nsrc/jtag/drivers/ep93xx.c:124:35: warning: pointer of type \u0027void *\u0027 used in arithmetic [-Wpointer-arith]\n  124 |         *((volatile int *)(syscon + 0xc0)) \u003d 0xaa;\n      |                                   ^\nsrc/jtag/drivers/ep93xx.c:125:35: warning: pointer of type \u0027void *\u0027 used in arithmetic [-Wpointer-arith]\n  125 |         *((volatile int *)(syscon + 0x80)) \u003d devicecfg | 0x08000000;\n      |                                   ^\nsrc/jtag/drivers/ep93xx.c: In function \u0027ep93xx_init\u0027:\nsrc/jtag/drivers/ep93xx.c:182:46: warning: pointer of type \u0027void *\u0027 used in arithmetic [-Wpointer-arith]\n  182 |         gpio_data_register \u003d gpio_controller + 0x08;\n      |                                              ^\nsrc/jtag/drivers/ep93xx.c:183:56: warning: pointer of type \u0027void *\u0027 used in arithmetic [-Wpointer-arith]\n  183 |         gpio_data_direction_register \u003d gpio_controller + 0x18;\n      |                                                        ^\n\nChange pointer type to allow pointer arithmetic.\n\nChange-Id: Idd78a7156bdf99df2624043e924b8e54a0588ace\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/7180\nTested-by: jenkins\nReviewed-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"5afe6c5d5f4224b2205087294f46d6716dfa271d":{"kind":"REWORK","_number":1,"created":"2022-09-08 14:24:10.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/80/7180/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/80/7180/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/80/7180/1 \u0026\u0026 git checkout -b change-7180 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/80/7180/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/80/7180/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/80/7180/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/80/7180/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/80/7180/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"de99836cf639b63dc357a34c13825669af841f17","subject":"target/xtensa: virtualize XDM registers"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-09-08 12:37:55.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-09-08 12:37:55.000000000","tz":120},"subject":"src/jtag/drivers/ep93xx: fix GCC 12 warning","message":"src/jtag/drivers/ep93xx: fix GCC 12 warning\n\nNew GCC reports 5 warning:\n\nsrc/jtag/drivers/ep93xx.c: In function \u0027set_gonk_mode\u0027:\nsrc/jtag/drivers/ep93xx.c:123:47: warning: pointer of type \u0027void *\u0027 used in arithmetic [-Wpointer-arith]\n  123 |         devicecfg \u003d *((volatile int *)(syscon + 0x80));\n      |                                               ^\nsrc/jtag/drivers/ep93xx.c:124:35: warning: pointer of type \u0027void *\u0027 used in arithmetic [-Wpointer-arith]\n  124 |         *((volatile int *)(syscon + 0xc0)) \u003d 0xaa;\n      |                                   ^\nsrc/jtag/drivers/ep93xx.c:125:35: warning: pointer of type \u0027void *\u0027 used in arithmetic [-Wpointer-arith]\n  125 |         *((volatile int *)(syscon + 0x80)) \u003d devicecfg | 0x08000000;\n      |                                   ^\nsrc/jtag/drivers/ep93xx.c: In function \u0027ep93xx_init\u0027:\nsrc/jtag/drivers/ep93xx.c:182:46: warning: pointer of type \u0027void *\u0027 used in arithmetic [-Wpointer-arith]\n  182 |         gpio_data_register \u003d gpio_controller + 0x08;\n      |                                              ^\nsrc/jtag/drivers/ep93xx.c:183:56: warning: pointer of type \u0027void *\u0027 used in arithmetic [-Wpointer-arith]\n  183 |         gpio_data_direction_register \u003d gpio_controller + 0x18;\n      |                                                        ^\n\nChange pointer type to allow pointer arithmetic.\n\nChange-Id: Idd78a7156bdf99df2624043e924b8e54a0588ace\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}