)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"051f858f6705732b2885159d4cf9e6310a962275","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"70d1c75d_858573a2","updated":"2022-09-21 06:50:42.000000000","message":"Rebased on to of\n7213: target/adi_v5_swd: fix SWD multidrop | https://review.openocd.org/c/openocd/+/7213\nto make testing possible and to re-check changes by the new checkpatch script.","commit_id":"d77f6335646c32d2806473db7535b8d5b406f71b"}],"src/flash/nor/rp2040.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"00d67c851ef26d2857ff2c93c202f50171beeb33","unresolved":true,"context_lines":[{"line_number":317,"context_line":"\tif (err2 !\u003d ERROR_OK)"},{"line_number":318,"context_line":"\t\tLOG_ERROR(\"SSEL inactive failed\");"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"\treturn err;"},{"line_number":321,"context_line":"}"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"static int rp2040_flash_probe(struct flash_bank *bank)"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"40090b8e_d29bc84d","line":320,"updated":"2022-09-12 07:40:03.000000000","message":"Would it make sense changing this to ... ?\n return (err !\u003d ERROR_OK) ? err : err2;","commit_id":"8cd63036afe110a62bc482b8e45d375c2159cbe0"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"1808da0f2658d9b5e58fbb5f6a5bc3075052f53b","unresolved":true,"context_lines":[{"line_number":317,"context_line":"\tif (err2 !\u003d ERROR_OK)"},{"line_number":318,"context_line":"\t\tLOG_ERROR(\"SSEL inactive failed\");"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"\treturn err;"},{"line_number":321,"context_line":"}"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"static int rp2040_flash_probe(struct flash_bank *bank)"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"e17ab4ac_5f3e490d","line":320,"in_reply_to":"40090b8e_d29bc84d","updated":"2022-09-12 08:01:35.000000000","message":"The flash ID is read correctly regardless of the result from select deactivation.\nIMO it would be pity not to use it.\nSelect gets reconfigured in the following rp2040_finalize_stack_free() (introduced in #7186) so I guess an occasional rp2040_ssel_active() error could not affect further operation.","commit_id":"8cd63036afe110a62bc482b8e45d375c2159cbe0"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"ff9443884e676a2f382aff6a1c96535adf49d772","unresolved":false,"context_lines":[{"line_number":317,"context_line":"\tif (err2 !\u003d ERROR_OK)"},{"line_number":318,"context_line":"\t\tLOG_ERROR(\"SSEL inactive failed\");"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"\treturn err;"},{"line_number":321,"context_line":"}"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"static int rp2040_flash_probe(struct flash_bank *bank)"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"400a4717_03a359d4","line":320,"in_reply_to":"e17ab4ac_5f3e490d","updated":"2022-09-12 08:08:48.000000000","message":"ok, thanks!","commit_id":"8cd63036afe110a62bc482b8e45d375c2159cbe0"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"e2396f3606c4b591092af514a741ab6994c025e0","unresolved":true,"context_lines":[{"line_number":315,"context_line":""},{"line_number":316,"context_line":"\tint err2 \u003d rp2040_ssel_active(target, false);"},{"line_number":317,"context_line":"\tif (err2 !\u003d ERROR_OK)"},{"line_number":318,"context_line":"\t\tLOG_ERROR(\"SSEL inactive failed\");"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"\treturn err;"},{"line_number":321,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"e7335a6f_31f7f353","line":318,"updated":"2022-09-21 15:57:19.000000000","message":"in case of error, or\nreturn err2;\nor\nerr \u003d err2;","commit_id":"db6f23402e1fe4c652e9998e5e7357fbf258d76c"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"8b41c923392c59454a6d3bb27024b1042c10ec9a","unresolved":true,"context_lines":[{"line_number":315,"context_line":""},{"line_number":316,"context_line":"\tint err2 \u003d rp2040_ssel_active(target, false);"},{"line_number":317,"context_line":"\tif (err2 !\u003d ERROR_OK)"},{"line_number":318,"context_line":"\t\tLOG_ERROR(\"SSEL inactive failed\");"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"\treturn err;"},{"line_number":321,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"0a83f77d_01e49ca6","line":318,"in_reply_to":"d3b69376_67180567","updated":"2022-09-23 22:34:10.000000000","message":"no way, I\u0027m getting old and tired!","commit_id":"db6f23402e1fe4c652e9998e5e7357fbf258d76c"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"4423958a6787f8e81346bec671def57785b4876c","unresolved":true,"context_lines":[{"line_number":315,"context_line":""},{"line_number":316,"context_line":"\tint err2 \u003d rp2040_ssel_active(target, false);"},{"line_number":317,"context_line":"\tif (err2 !\u003d ERROR_OK)"},{"line_number":318,"context_line":"\t\tLOG_ERROR(\"SSEL inactive failed\");"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"\treturn err;"},{"line_number":321,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"d3b69376_67180567","line":318,"in_reply_to":"e7335a6f_31f7f353","updated":"2022-09-21 17:37:59.000000000","message":"You already asked, see comment above to line #320.","commit_id":"db6f23402e1fe4c652e9998e5e7357fbf258d76c"}]}