)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"43055f73e3b7fcd43e86448ebdf2fc0ba9e33b30","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"70534082_7efff17b","updated":"2022-09-16 00:27:34.000000000","message":"Fixed 1 of 2 xtensa clang static analysis warnings.  Validated on both little- and big-endian generic Xtensa targets.  \n\nHoping to get the other one fixed soon, although I will probably limit the scope of the fix in case Antonio wants it included in 0.12, so will address other big-endian improvements separately.","commit_id":"36cf6b0a2c47797aa59625eb91317c3ed36776f8"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"c3fc0d36903490ab75216b761954667223aa1df5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"02a69f10_47787dc1","updated":"2022-09-16 16:26:29.000000000","message":"Thanks for catching the error I introduced, Antonio.  Resolved both bug and clang warning this time!","commit_id":"36cf6b0a2c47797aa59625eb91317c3ed36776f8"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"a41e9f7d5b731fabbdd6e5a110a327a13a3c5f45","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"194cb8e5_8a54053c","updated":"2022-09-17 20:59:32.000000000","message":"thanks","commit_id":"089725ee30f3b316a623fa00d46d677adcc24a32"}],"src/target/xtensa/xtensa.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"c98629dbefdad848d4fbe8196826a38011096c58","unresolved":true,"context_lines":[{"line_number":503,"context_line":"\t\tuint8_t ops_padded[max_oplen];"},{"line_number":504,"context_line":"\t\tmemcpy(ops_padded, ops, oplen);"},{"line_number":505,"context_line":"\t\tmemset(ops_padded + oplen, 0, max_oplen - oplen);"},{"line_number":506,"context_line":"\t\tuint8_t oplenw \u003d DIV_ROUND_UP(oplen, 4);"},{"line_number":507,"context_line":"\t\tfor (int32_t i \u003d oplenw - 1; i \u003e 0; i--)"},{"line_number":508,"context_line":"\t\t\txtensa_queue_dbg_reg_write(xtensa,"},{"line_number":509,"context_line":"\t\t\t\tXDMREG_DIR0 + i,"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"429b0948_24294240","line":506,"updated":"2022-09-16 08:27:00.000000000","message":"it\u0027s a host\u0027s value, not a target\u0027s one; no reason to be \u0027uint8_t\u0027:\n unsigned int oplenw \u003d DIV_ROUND_UP(oplen, sizeof(uint32_t));","commit_id":"36cf6b0a2c47797aa59625eb91317c3ed36776f8"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"c3fc0d36903490ab75216b761954667223aa1df5","unresolved":false,"context_lines":[{"line_number":503,"context_line":"\t\tuint8_t ops_padded[max_oplen];"},{"line_number":504,"context_line":"\t\tmemcpy(ops_padded, ops, oplen);"},{"line_number":505,"context_line":"\t\tmemset(ops_padded + oplen, 0, max_oplen - oplen);"},{"line_number":506,"context_line":"\t\tuint8_t oplenw \u003d DIV_ROUND_UP(oplen, 4);"},{"line_number":507,"context_line":"\t\tfor (int32_t i \u003d oplenw - 1; i \u003e 0; i--)"},{"line_number":508,"context_line":"\t\t\txtensa_queue_dbg_reg_write(xtensa,"},{"line_number":509,"context_line":"\t\t\t\tXDMREG_DIR0 + i,"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"46ddeb02_83f7c323","line":506,"in_reply_to":"429b0948_24294240","updated":"2022-09-16 16:26:29.000000000","message":"Done","commit_id":"36cf6b0a2c47797aa59625eb91317c3ed36776f8"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"c98629dbefdad848d4fbe8196826a38011096c58","unresolved":true,"context_lines":[{"line_number":507,"context_line":"\t\tfor (int32_t i \u003d oplenw - 1; i \u003e 0; i--)"},{"line_number":508,"context_line":"\t\t\txtensa_queue_dbg_reg_write(xtensa,"},{"line_number":509,"context_line":"\t\t\t\tXDMREG_DIR0 + i,"},{"line_number":510,"context_line":"\t\t\t\ttarget_buffer_get_u32(xtensa-\u003etarget, \u0026ops_padded[i]));"},{"line_number":511,"context_line":"\t\t/* Write DIR0EXEC last */"},{"line_number":512,"context_line":"\t\txtensa_queue_dbg_reg_write(xtensa,"},{"line_number":513,"context_line":"\t\t\tXDMREG_DIR0EXEC,"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"694c469f_3e4edc29","line":510,"updated":"2022-09-16 08:27:00.000000000","message":"Maybe \u0027\u0026ops_padded[sizeof(uint32_t)*i]\u0027 ?","commit_id":"36cf6b0a2c47797aa59625eb91317c3ed36776f8"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"c3fc0d36903490ab75216b761954667223aa1df5","unresolved":false,"context_lines":[{"line_number":507,"context_line":"\t\tfor (int32_t i \u003d oplenw - 1; i \u003e 0; i--)"},{"line_number":508,"context_line":"\t\t\txtensa_queue_dbg_reg_write(xtensa,"},{"line_number":509,"context_line":"\t\t\t\tXDMREG_DIR0 + i,"},{"line_number":510,"context_line":"\t\t\t\ttarget_buffer_get_u32(xtensa-\u003etarget, \u0026ops_padded[i]));"},{"line_number":511,"context_line":"\t\t/* Write DIR0EXEC last */"},{"line_number":512,"context_line":"\t\txtensa_queue_dbg_reg_write(xtensa,"},{"line_number":513,"context_line":"\t\t\tXDMREG_DIR0EXEC,"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"1b97fc29_78df2b1c","line":510,"in_reply_to":"694c469f_3e4edc29","updated":"2022-09-16 16:26:29.000000000","message":"Ah, good catch!  I apparently only tested with oplen \u003c\u003d 4 (most xtensa instructions are 2 or 3 bytes).  Thanks, Antonio.","commit_id":"36cf6b0a2c47797aa59625eb91317c3ed36776f8"}]}