)]}'
{"src/target/dsp563xx.c":[{"author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"change_message_id":"30d201ccb62c9a4eff5f9fc95d730b417c878447","unresolved":true,"context_lines":[{"line_number":2141,"context_line":"\t}"},{"line_number":2142,"context_line":""},{"line_number":2143,"context_line":"\tconst size_t buffer_size \u003d count * sizeof(uint32_t);"},{"line_number":2144,"context_line":"\tbuffer \u003d malloc(buffer_size);"},{"line_number":2145,"context_line":""},{"line_number":2146,"context_line":"\tif (read_mem \u003d\u003d 1) {"},{"line_number":2147,"context_line":"\t\terr \u003d dsp563xx_read_memory(target, mem_type, address, sizeof(uint32_t),"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"20dc860a_9495452c","line":2144,"updated":"2022-09-19 14:51:44.000000000","message":"A simpler and probably more future-proof fix would be to replace sizeof(uint32_t) with its de-facto only possible value: 4","commit_id":"94116ad3c7ca3245b34908d2b828ad8e616f3d48"},{"author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"change_message_id":"56d1be7596352605aca244b50813a2e62c17feb3","unresolved":false,"context_lines":[{"line_number":2141,"context_line":"\t}"},{"line_number":2142,"context_line":""},{"line_number":2143,"context_line":"\tconst size_t buffer_size \u003d count * sizeof(uint32_t);"},{"line_number":2144,"context_line":"\tbuffer \u003d malloc(buffer_size);"},{"line_number":2145,"context_line":""},{"line_number":2146,"context_line":"\tif (read_mem \u003d\u003d 1) {"},{"line_number":2147,"context_line":"\t\terr \u003d dsp563xx_read_memory(target, mem_type, address, sizeof(uint32_t),"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"4aa85cf6_ec13b59a","line":2144,"in_reply_to":"094dea03_2e5a434d","updated":"2022-09-20 08:52:40.000000000","message":"I don\u0027t personally see the value in hiding numerical values behind macros, when they are tightly coupled to the mechanism in the code they are used in. But I tend to lose those arguments, so...","commit_id":"94116ad3c7ca3245b34908d2b828ad8e616f3d48"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"4698e9b91c1b1bcc176e7c835040ac0a2d0418ee","unresolved":true,"context_lines":[{"line_number":2141,"context_line":"\t}"},{"line_number":2142,"context_line":""},{"line_number":2143,"context_line":"\tconst size_t buffer_size \u003d count * sizeof(uint32_t);"},{"line_number":2144,"context_line":"\tbuffer \u003d malloc(buffer_size);"},{"line_number":2145,"context_line":""},{"line_number":2146,"context_line":"\tif (read_mem \u003d\u003d 1) {"},{"line_number":2147,"context_line":"\t\terr \u003d dsp563xx_read_memory(target, mem_type, address, sizeof(uint32_t),"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"094dea03_2e5a434d","line":2144,"in_reply_to":"20dc860a_9495452c","updated":"2022-09-19 15:40:52.000000000","message":"You are right about sizeof(), but this magic number \"4\" can be source of confusion.\nIn stdint.h we already have\n # define UINT32_WIDTH 32\n\nmaybe we should add somewhere in src/helper/\n # define UINT32_SIZE 4\n\nand all the other sizes, and use them extensively in OpenOCD. But this would be after v0.12.0\nFor this one I will use the magic number 4 and suppress the warning.","commit_id":"94116ad3c7ca3245b34908d2b828ad8e616f3d48"},{"author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"change_message_id":"30d201ccb62c9a4eff5f9fc95d730b417c878447","unresolved":true,"context_lines":[{"line_number":2154,"context_line":""},{"line_number":2155,"context_line":"\t\tfor (i \u003d 0; i \u003c count; i++) {"},{"line_number":2156,"context_line":"\t\t\ttarget_buffer_set_u32(target, b, pattern);"},{"line_number":2157,"context_line":"\t\t\tb +\u003d 4;"},{"line_number":2158,"context_line":"\t\t}"},{"line_number":2159,"context_line":""},{"line_number":2160,"context_line":"\t\terr \u003d dsp563xx_write_memory(target,"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"9c364f16_e99b2428","line":2157,"updated":"2022-09-19 14:51:44.000000000","message":"...or at least be consistent.","commit_id":"94116ad3c7ca3245b34908d2b828ad8e616f3d48"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"4698e9b91c1b1bcc176e7c835040ac0a2d0418ee","unresolved":false,"context_lines":[{"line_number":2154,"context_line":""},{"line_number":2155,"context_line":"\t\tfor (i \u003d 0; i \u003c count; i++) {"},{"line_number":2156,"context_line":"\t\t\ttarget_buffer_set_u32(target, b, pattern);"},{"line_number":2157,"context_line":"\t\t\tb +\u003d 4;"},{"line_number":2158,"context_line":"\t\t}"},{"line_number":2159,"context_line":""},{"line_number":2160,"context_line":"\t\terr \u003d dsp563xx_write_memory(target,"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"2410e095_bd91d0b9","line":2157,"in_reply_to":"9c364f16_e99b2428","updated":"2022-09-19 15:40:52.000000000","message":"Ack","commit_id":"94116ad3c7ca3245b34908d2b828ad8e616f3d48"},{"author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"change_message_id":"30d201ccb62c9a4eff5f9fc95d730b417c878447","unresolved":true,"context_lines":[{"line_number":2160,"context_line":"\t\terr \u003d dsp563xx_write_memory(target,"},{"line_number":2161,"context_line":"\t\t\t\tmem_type,"},{"line_number":2162,"context_line":"\t\t\t\taddress,"},{"line_number":2163,"context_line":"\t\t\t\tsizeof(uint32_t),"},{"line_number":2164,"context_line":"\t\t\t\tcount,"},{"line_number":2165,"context_line":"\t\t\t\tbuffer);"},{"line_number":2166,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"e5da972a_580ddd26","line":2163,"updated":"2022-09-19 14:51:44.000000000","message":"I\u0027m pretty sure dsp563xx_write_memory, as other memory access functions in OpenOCD, define the size arguments to be in octets, not chars. So sizeof(uint32_t) isn\u0027t even technically correct here.","commit_id":"94116ad3c7ca3245b34908d2b828ad8e616f3d48"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"4698e9b91c1b1bcc176e7c835040ac0a2d0418ee","unresolved":false,"context_lines":[{"line_number":2160,"context_line":"\t\terr \u003d dsp563xx_write_memory(target,"},{"line_number":2161,"context_line":"\t\t\t\tmem_type,"},{"line_number":2162,"context_line":"\t\t\t\taddress,"},{"line_number":2163,"context_line":"\t\t\t\tsizeof(uint32_t),"},{"line_number":2164,"context_line":"\t\t\t\tcount,"},{"line_number":2165,"context_line":"\t\t\t\tbuffer);"},{"line_number":2166,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"39710753_d82b8fc8","line":2163,"in_reply_to":"e5da972a_580ddd26","updated":"2022-09-19 15:40:52.000000000","message":"Yes, again UINT32_SIZE would be good to use here.","commit_id":"94116ad3c7ca3245b34908d2b828ad8e616f3d48"}]}