)]}'
{"id":"openocd~master~I5bb1ece177774eefdc5d9cd049338f8f2be87cd7","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2022-09-23 21:22:09.000000000","reason":"Change was submitted"},"1000005":{"account":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"last_update":"2022-09-20 08:52:40.000000000","reason":"Andreas Fritiofson replied on the change"}},"hashtags":[],"change_id":"I5bb1ece177774eefdc5d9cd049338f8f2be87cd7","subject":"target/dsp563xx: fix scan-build warning","status":"MERGED","created":"2022-09-19 13:49:53.000000000","updated":"2022-09-23 21:22:09.000000000","submitted":"2022-09-23 21:22:09.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":7,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7203","meta_rev_id":"33535540621327329f8b32c68521bee8059a1973","_number":7203,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-09-23 21:22:09.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-09-23 21:22:09.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-09-19 14:29:04.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-09-19 14:51:44.000000000","updated_by":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"reviewer":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"state":"CC"},{"updated":"2022-09-20 08:52:40.000000000","updated_by":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"reviewer":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"state":"REVIEWER"}],"messages":[{"id":"5d81945723d860d24b173534961f2bc6d7b3964c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-09-19 13:49:53.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"75c7e419d23c8d8203b67c96a5106aa8ff0317ff","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-09-19 14:29:04.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/15952/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/16743/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"30d201ccb62c9a4eff5f9fc95d730b417c878447","author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"real_author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"date":"2022-09-19 14:51:44.000000000","message":"Patch Set 1:\n\n(3 comments)","accounts_in_message":[],"_revision_number":1},{"id":"4698e9b91c1b1bcc176e7c835040ac0a2d0418ee","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-09-19 15:40:52.000000000","message":"Patch Set 1: Code-Review-1\n\n(3 comments)","accounts_in_message":[],"_revision_number":1},{"id":"f3db1c155a70933986a040ed184084ea58818305","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-09-19 20:26:21.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"105fb2a8f1d21eb96416fcfa54abef290cbcb79d","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-09-19 20:47:14.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/15962/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/16753/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"56d1be7596352605aca244b50813a2e62c17feb3","author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"real_author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"date":"2022-09-20 08:52:40.000000000","message":"Patch Set 2: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"33535540621327329f8b32c68521bee8059a1973","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-09-23 21:22:09.000000000","message":"Change has been successfully cherry-picked as 8683526af7a9ca23115d26deb5b4835cd6be05d8","accounts_in_message":[],"_revision_number":3}],"current_revision":"8683526af7a9ca23115d26deb5b4835cd6be05d8","revisions":{"94116ad3c7ca3245b34908d2b828ad8e616f3d48":{"kind":"REWORK","_number":1,"created":"2022-09-19 13:49:53.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/03/7203/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/03/7203/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/03/7203/1 \u0026\u0026 git checkout -b change-7203 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/03/7203/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/03/7203/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/03/7203/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/03/7203/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/03/7203/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2deffdd449c549ecd5dfa023069ce413f24cbf10","subject":"jtag/adapter: fix doxygen warning"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-09-19 09:36:06.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-09-19 13:48:05.000000000","tz":120},"subject":"target/dsp563xx: fix scan-build warning","message":"target/dsp563xx: fix scan-build warning\n\nScan-build triggers a warning:\n\tUnix API: Allocator sizeof operand mismatch\n\tdsp563xx.c:2143 Result of \u0027calloc\u0027 is converted to a pointer\n\t\tof type \u0027uint8_t\u0027, which is incompatible with sizeof\n\t\t operand type \u0027uint32_t\u0027\n\nIt\u0027s a false positive because calloc() is properly used in this\ncase, as the uint8_t array is used in blocks of 4 elements to read\nor write uint32_t values.\n\nEither\n\tcalloc(sizeof(uint32_t), count);\nand\n\tmalloc(count * sizeof(uint32_t));\nkeep triggering the same warning.\n\nDrop the warning by moving the computation of the size in a\nseparate statement and by using malloc().\n\nChange-Id: I5bb1ece177774eefdc5d9cd049338f8f2be87cd7\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"f54addb34100de311f0225c7705e427208834b0c":{"kind":"REWORK","_number":2,"created":"2022-09-19 20:26:21.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/03/7203/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/03/7203/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/03/7203/2 \u0026\u0026 git checkout -b change-7203 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/03/7203/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/03/7203/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/03/7203/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/03/7203/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/03/7203/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2deffdd449c549ecd5dfa023069ce413f24cbf10","subject":"jtag/adapter: fix doxygen warning"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-09-19 09:36:06.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-09-19 20:23:36.000000000","tz":120},"subject":"target/dsp563xx: fix scan-build warning","message":"target/dsp563xx: fix scan-build warning\n\nScan-build triggers a warning:\n\tUnix API: Allocator sizeof operand mismatch\n\tdsp563xx.c:2143 Result of \u0027calloc\u0027 is converted to a pointer\n\t\tof type \u0027uint8_t\u0027, which is incompatible with sizeof\n\t\t operand type \u0027uint32_t\u0027\n\nIt\u0027s a false positive because calloc() is properly used in this\ncase, as the uint8_t array is used in blocks of 4 elements to read\nor write uint32_t values.\n\nEither\n\tcalloc(sizeof(uint32_t), count);\nand\n\tmalloc(count * sizeof(uint32_t));\nkeep triggering the same warning.\n\nDrop the warning by using the constant \u00274\u0027 as size of uint32_t, as\nalready used few lines below.\n\nChange-Id: I5bb1ece177774eefdc5d9cd049338f8f2be87cd7\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"8683526af7a9ca23115d26deb5b4835cd6be05d8":{"kind":"REWORK","_number":3,"created":"2022-09-23 21:22:09.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/03/7203/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/03/7203/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/03/7203/3 \u0026\u0026 git checkout -b change-7203 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/03/7203/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/03/7203/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/03/7203/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/03/7203/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/03/7203/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"cde944fd8b9cd5eb67617aa3b68dc13eb49b1d10","subject":"jtag/adapter: fix doxygen warning"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-09-19 09:36:06.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-09-23 21:22:09.000000000","tz":0},"subject":"target/dsp563xx: fix scan-build warning","message":"target/dsp563xx: fix scan-build warning\n\nScan-build triggers a warning:\n\tUnix API: Allocator sizeof operand mismatch\n\tdsp563xx.c:2143 Result of \u0027calloc\u0027 is converted to a pointer\n\t\tof type \u0027uint8_t\u0027, which is incompatible with sizeof\n\t\t operand type \u0027uint32_t\u0027\n\nIt\u0027s a false positive because calloc() is properly used in this\ncase, as the uint8_t array is used in blocks of 4 elements to read\nor write uint32_t values.\n\nEither\n\tcalloc(sizeof(uint32_t), count);\nand\n\tmalloc(count * sizeof(uint32_t));\nkeep triggering the same warning.\n\nDrop the warning by using the constant \u00274\u0027 as size of uint32_t, as\nalready used few lines below.\n\nChange-Id: I5bb1ece177774eefdc5d9cd049338f8f2be87cd7\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/7203\nTested-by: jenkins\nReviewed-by: Andreas Fritiofson \u003candreas.fritiofson@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}