)]}'
{"id":"openocd~master~Ia9032a0229aa243138f95f4e13f765726a4ceae9","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1001667":{"account":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"last_update":"2022-09-20 05:33:02.000000000","reason":"Jan Matyas replied on the change"},"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2022-09-23 21:22:31.000000000","reason":"Change was submitted"},"1001242":{"account":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"last_update":"2022-09-19 16:27:29.000000000","reason":"Tim Newsome replied on the change"}},"hashtags":[],"change_id":"Ia9032a0229aa243138f95f4e13f765726a4ceae9","subject":"target/riscv-013: fix unchecked return code","status":"MERGED","created":"2022-09-19 13:51:13.000000000","updated":"2022-09-23 21:22:31.000000000","submitted":"2022-09-23 21:22:31.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7205","meta_rev_id":"933ff2782aa9340f2bd16a6ad594e643c2799d92","_number":7205,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-09-23 21:22:31.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-09-23 21:22:31.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-09-23 21:22:31.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-09-19 13:51:13.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"state":"REVIEWER"},{"updated":"2022-09-19 13:51:13.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"state":"REVIEWER"},{"updated":"2022-09-19 17:36:30.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"b5a3b12656b9f171594029f57ed636b028e66cb5","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-09-19 13:51:13.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"464f4fcc3c01390ea84cb59fd85bb763c5265f07","author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"real_author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"date":"2022-09-19 16:27:29.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"b7612784690090e418c6fd059b5e3a50590fc19e","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-09-19 17:36:30.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/15956/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/16747/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"e7721675bf8460d1fd2e510795781f7a891e6ac2","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2022-09-20 05:33:02.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"933ff2782aa9340f2bd16a6ad594e643c2799d92","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-09-23 21:22:31.000000000","message":"Change has been successfully cherry-picked as 8db6dff333c2803d339086c7d5694eac4da11d0a","accounts_in_message":[],"_revision_number":2}],"current_revision":"8db6dff333c2803d339086c7d5694eac4da11d0a","revisions":{"b621fc35b4a95a9f3286f9cb5514dbd3e6b07890":{"kind":"REWORK","_number":1,"created":"2022-09-19 13:51:13.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/05/7205/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/05/7205/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/05/7205/1 \u0026\u0026 git checkout -b change-7205 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/05/7205/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/05/7205/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/05/7205/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/05/7205/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/05/7205/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ec2b158fc781a24a5888f309639560ef4000fd16","subject":"target/armv4_5: fix scan-build error"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-09-19 12:37:24.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-09-19 13:48:05.000000000","tz":120},"subject":"target/riscv-013: fix unchecked return code","message":"target/riscv-013: fix unchecked return code\n\nScan-build complains about variable \u0027sbcs_orig\u0027 that can be used\nnot initialized.\n\tLogic error: Assigned value is garbage or undefined\n\triscv-013.c:4468 Assigned value is garbage or undefined\nThis is caused by not checking the return value of the call\n\triscv-013.c:4466 dmi_read(target, \u0026sbcs_orig, DM_SBCS);\nIn fact when dmi_read() returns error, the variable \u0027sbcs_orig\u0027 is\nnot assigned.\n\nCheck the returned value.\n\nChange-Id: Ia9032a0229aa243138f95f4e13f765726a4ceae9\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"8db6dff333c2803d339086c7d5694eac4da11d0a":{"kind":"REWORK","_number":2,"created":"2022-09-23 21:22:31.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/05/7205/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/05/7205/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/05/7205/2 \u0026\u0026 git checkout -b change-7205 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/05/7205/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/05/7205/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/05/7205/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/05/7205/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/05/7205/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"8683526af7a9ca23115d26deb5b4835cd6be05d8","subject":"target/dsp563xx: fix scan-build warning"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-09-19 12:37:24.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-09-23 21:22:31.000000000","tz":0},"subject":"target/riscv-013: fix unchecked return code","message":"target/riscv-013: fix unchecked return code\n\nScan-build complains about variable \u0027sbcs_orig\u0027 that can be used\nnot initialized.\n\tLogic error: Assigned value is garbage or undefined\n\triscv-013.c:4468 Assigned value is garbage or undefined\nThis is caused by not checking the return value of the call\n\triscv-013.c:4466 dmi_read(target, \u0026sbcs_orig, DM_SBCS);\nIn fact when dmi_read() returns error, the variable \u0027sbcs_orig\u0027 is\nnot assigned.\n\nCheck the returned value.\n\nChange-Id: Ia9032a0229aa243138f95f4e13f765726a4ceae9\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/7205\nReviewed-by: Tim Newsome \u003ctim@sifive.com\u003e\nReviewed-by: Jan Matyas \u003cmatyas@codasip.com\u003e\nTested-by: jenkins\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}