)]}'
{"id":"openocd~master~I548f8175530b9a2aa4c1788549d6467bf9824584","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1001667":{"account":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"last_update":"2022-09-20 05:36:55.000000000","reason":"Jan Matyas replied on the change"},"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2022-09-23 21:22:42.000000000","reason":"Change was submitted"},"1001242":{"account":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"last_update":"2022-09-19 16:26:31.000000000","reason":"Tim Newsome replied on the change"}},"hashtags":[],"change_id":"I548f8175530b9a2aa4c1788549d6467bf9824584","subject":"target/riscv-013: fix unused initialization","status":"MERGED","created":"2022-09-19 13:51:13.000000000","updated":"2022-09-23 21:22:42.000000000","submitted":"2022-09-23 21:22:42.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7206","meta_rev_id":"05031c74f821bda3565f9eb26ad1b7078d2ad98c","_number":7206,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-09-23 21:22:42.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-09-23 21:22:42.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-09-23 21:22:42.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-09-19 13:51:13.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"state":"REVIEWER"},{"updated":"2022-09-19 13:51:13.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"state":"REVIEWER"},{"updated":"2022-09-19 17:54:38.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"90866e2c6a10151d6535439447128ff15a6b8b4a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-09-19 13:51:13.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"7a8b477f0432c8392590750c881e4a28caaf3427","author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"real_author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"date":"2022-09-19 16:26:31.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"22a1d9718d02fea9e659086efe628e0b2514b530","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-09-19 17:54:38.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/15957/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/16748/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"26431d55ce7c2bd2d370718ea94ca2b93b8f772a","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2022-09-20 05:36:55.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"05031c74f821bda3565f9eb26ad1b7078d2ad98c","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-09-23 21:22:42.000000000","message":"Change has been successfully cherry-picked as aa57890554cb4f8b4ccf35a69598238a12a79069","accounts_in_message":[],"_revision_number":2}],"current_revision":"aa57890554cb4f8b4ccf35a69598238a12a79069","revisions":{"cdcb593287a90a6b3d6ffbe91368cf2fcf7e86a2":{"kind":"REWORK","_number":1,"created":"2022-09-19 13:51:13.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/06/7206/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/06/7206/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/06/7206/1 \u0026\u0026 git checkout -b change-7206 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/06/7206/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/06/7206/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/06/7206/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/06/7206/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/06/7206/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b621fc35b4a95a9f3286f9cb5514dbd3e6b07890","subject":"target/riscv-013: fix unchecked return code"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-09-19 12:50:26.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-09-19 13:48:05.000000000","tz":120},"subject":"target/riscv-013: fix unused initialization","message":"target/riscv-013: fix unused initialization\n\nScan-build reports:\n\tUnused code: Dead initialization\n\triscv-013.c:2362 Value stored to \u0027control\u0027 during its\n\t\tinitialization is never read\n\nRemove the initialization of variable \u0027control\u0027.\n\nChange-Id: I548f8175530b9a2aa4c1788549d6467bf9824584\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"aa57890554cb4f8b4ccf35a69598238a12a79069":{"kind":"REWORK","_number":2,"created":"2022-09-23 21:22:42.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/06/7206/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/06/7206/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/06/7206/2 \u0026\u0026 git checkout -b change-7206 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/06/7206/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/06/7206/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/06/7206/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/06/7206/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/06/7206/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"8db6dff333c2803d339086c7d5694eac4da11d0a","subject":"target/riscv-013: fix unchecked return code"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-09-19 12:50:26.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-09-23 21:22:42.000000000","tz":0},"subject":"target/riscv-013: fix unused initialization","message":"target/riscv-013: fix unused initialization\n\nScan-build reports:\n\tUnused code: Dead initialization\n\triscv-013.c:2362 Value stored to \u0027control\u0027 during its\n\t\tinitialization is never read\n\nRemove the initialization of variable \u0027control\u0027.\n\nChange-Id: I548f8175530b9a2aa4c1788549d6467bf9824584\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/7206\nReviewed-by: Tim Newsome \u003ctim@sifive.com\u003e\nReviewed-by: Jan Matyas \u003cmatyas@codasip.com\u003e\nTested-by: jenkins\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}
