)]}'
{"id":"openocd~master~Ifad29f4c46d4a2d0a2f5a5c4104d768cc3db2794","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1001667":{"account":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"last_update":"2022-09-20 05:45:37.000000000","reason":"Jan Matyas replied on the change"},"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2022-09-23 21:24:41.000000000","reason":"Change was submitted"},"1001242":{"account":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"last_update":"2022-09-19 16:32:14.000000000","reason":"Tim Newsome replied on the change"}},"hashtags":[],"change_id":"Ifad29f4c46d4a2d0a2f5a5c4104d768cc3db2794","subject":"target/riscv: fix dead assignment","status":"MERGED","created":"2022-09-19 13:51:13.000000000","updated":"2022-09-23 21:24:41.000000000","submitted":"2022-09-23 21:24:41.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7208","meta_rev_id":"72d85855f00bf176251d19c6b252590a692cdf7f","_number":7208,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-09-23 21:24:41.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-09-23 21:24:41.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-09-23 21:24:41.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-09-19 13:51:13.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"state":"REVIEWER"},{"updated":"2022-09-19 13:51:13.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"state":"REVIEWER"},{"updated":"2022-09-19 18:50:48.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"dc82666ccfef2db96a0e27eb6330814153561cb0","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-09-19 13:51:13.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"edb348de274ba43697df57a01405293853614191","author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"real_author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"date":"2022-09-19 16:32:14.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"c6f3636403e9f9f744082a70cdb53790b31bd145","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-09-19 18:50:48.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/15959/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/16750/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"4963349488be4755169f0461e0885f65b2ce228c","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2022-09-20 05:45:37.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"72d85855f00bf176251d19c6b252590a692cdf7f","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-09-23 21:24:41.000000000","message":"Change has been successfully cherry-picked as aff48a6a31019af17959a7da33909d1cea6de61a","accounts_in_message":[],"_revision_number":2}],"current_revision":"aff48a6a31019af17959a7da33909d1cea6de61a","revisions":{"ed6edb277397d451e18e228d7a5924b0d587b794":{"kind":"REWORK","_number":1,"created":"2022-09-19 13:51:13.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/08/7208/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/08/7208/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/08/7208/1 \u0026\u0026 git checkout -b change-7208 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/08/7208/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/08/7208/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/08/7208/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/08/7208/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/08/7208/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"eb4498f1d8ef8a071490b157d95535d41b93c971","subject":"target/riscv: fix unused initialization"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-09-19 13:02:36.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-09-19 13:48:05.000000000","tz":120},"subject":"target/riscv: fix dead assignment","message":"target/riscv: fix dead assignment\n\nScan-build reports:\n\tUnused code: Dead nested assignment\n\triscv.c:459 Although the value stored to \u0027ir_user4_raw\u0027 is\n\t\tused in the enclosing expression, the value is\n\t\tnever actually read from \u0027ir_user4_raw\u0027\n\nThis is caused by the value reassigned in \u0027ir_user4_raw\u0027:\n\triscv.c:459 ir_user4[3] \u003d (uint8_t)(ir_user4_raw \u003e\u003e\u003d 8);\nbut never used.\n\nDrop the DIY conversion in favor of h_u32_to_le() that does not\nreassign the input value.\n\nChange-Id: Ifad29f4c46d4a2d0a2f5a5c4104d768cc3db2794\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"aff48a6a31019af17959a7da33909d1cea6de61a":{"kind":"REWORK","_number":2,"created":"2022-09-23 21:24:41.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/08/7208/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/08/7208/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/08/7208/2 \u0026\u0026 git checkout -b change-7208 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/08/7208/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/08/7208/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/08/7208/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/08/7208/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/08/7208/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ea9089944e509ba301f5a2ca14b30eb5d7a90f44","subject":"target/riscv: fix unused initialization"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-09-19 13:02:36.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-09-23 21:24:41.000000000","tz":0},"subject":"target/riscv: fix dead assignment","message":"target/riscv: fix dead assignment\n\nScan-build reports:\n\tUnused code: Dead nested assignment\n\triscv.c:459 Although the value stored to \u0027ir_user4_raw\u0027 is\n\t\tused in the enclosing expression, the value is\n\t\tnever actually read from \u0027ir_user4_raw\u0027\n\nThis is caused by the value reassigned in \u0027ir_user4_raw\u0027:\n\triscv.c:459 ir_user4[3] \u003d (uint8_t)(ir_user4_raw \u003e\u003e\u003d 8);\nbut never used.\n\nDrop the DIY conversion in favor of h_u32_to_le() that does not\nreassign the input value.\n\nChange-Id: Ifad29f4c46d4a2d0a2f5a5c4104d768cc3db2794\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/7208\nReviewed-by: Tim Newsome \u003ctim@sifive.com\u003e\nReviewed-by: Jan Matyas \u003cmatyas@codasip.com\u003e\nTested-by: jenkins\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}